GNU bug report logs - #11995
vc-compilation-mode name and implementation

Previous Next

Package: emacs;

Reported by: Dan Nicolaescu <dann <at> gnu.org>

Date: Thu, 19 Jul 2012 19:45:02 UTC

Severity: minor

Tags: moreinfo

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11995 in the body.
You can then email your comments to 11995 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#11995; Package emacs. (Thu, 19 Jul 2012 19:45:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dan Nicolaescu <dann <at> gnu.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 19 Jul 2012 19:45:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: vc-compilation-mode name and implementation
Date: Thu, 19 Jul 2012 15:38:23 -0400
The newly added vc-compilation-mode function does not have the best
name, -mode functions stand for modes, this is not one.

Currently the preferred way to define modes is to use `defined-derived-mode'...

Also the implementation seems to be a bit more complicated than needed:
there

Defining a vc-default-compilation-mode function should simplify the
implementation.  vc-make-backend-sym is something that very few things
need to call.

I'm leaving on vacation, so I won't be able to do much about this for a while.










Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11995; Package emacs. (Wed, 20 Jan 2021 04:21:02 GMT) Full text and rfc822 format available.

Message #8 received at 11995 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 11995 <at> debbugs.gnu.org
Subject: Re: bug#11995: vc-compilation-mode name and implementation
Date: Wed, 20 Jan 2021 05:20:37 +0100
Dan Nicolaescu <dann <at> gnu.org> writes:

> The newly added vc-compilation-mode function does not have the best
> name, -mode functions stand for modes, this is not one.

(I'm going through old bug reports that unfortunately got no response at
the time.)

It is perhaps not an ideal name, but it's probably too late to change
now, though.

> Currently the preferred way to define modes is to use
> `defined-derived-mode'...
>
> Also the implementation seems to be a bit more complicated than needed:
> there
>
> Defining a vc-default-compilation-mode function should simplify the
> implementation.  vc-make-backend-sym is something that very few things
> need to call.

I think it looks like something was left out of this message?  I'm not
sure what this is referring to.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2021 04:21:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11995; Package emacs. (Mon, 22 Feb 2021 15:19:02 GMT) Full text and rfc822 format available.

Message #13 received at 11995 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 11995 <at> debbugs.gnu.org
Subject: Re: bug#11995: vc-compilation-mode name and implementation
Date: Mon, 22 Feb 2021 16:17:53 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> Defining a vc-default-compilation-mode function should simplify the
>> implementation.  vc-make-backend-sym is something that very few things
>> need to call.
>
> I think it looks like something was left out of this message?  I'm not
> sure what this is referring to.

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug closed, send any further explanations to 11995 <at> debbugs.gnu.org and Dan Nicolaescu <dann <at> gnu.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 22 Feb 2021 15:19:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 23 Mar 2021 11:25:16 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 6 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.