Received: (at 1206-done) by debbugs.gnu.org; 15 Feb 2025 15:34:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 15 10:34:36 2025 Received: from localhost ([127.0.0.1]:57404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjKBf-0004dk-OF for submit <at> debbugs.gnu.org; Sat, 15 Feb 2025 10:34:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40646) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tjKBd-0004dT-Ef for 1206-done <at> debbugs.gnu.org; Sat, 15 Feb 2025 10:34:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tjKBW-0007f8-CF; Sat, 15 Feb 2025 10:34:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lkmW8AQkMS6R5OQy8mvvUdaJlVLpCFWtOlZtGvUYF7A=; b=P2pXBtDexBl+rCPb+WfY cvI6xHpmt3kwKD1Elnk/y/ZqB9FDG0iUdP3asNxA2IjhXizHkQRRiJH+3XnJXvG/bFlTyMwxe+13L S9eRS1boqvFMEjQx2oQjvTq7BzuCazrGFEgN1JZ09OKf0JbNSMX5c8NFHiM+YjHtVFv+OQXMGeGO+ h+t7zd3VXxlq1ogLLeqZWniWrM/ngEmxbPu9XmAhXJ0eTwJ3Z13X50NyKNfaVyBQE6ZrR9g2rHfNh XF+7HWAN5yHRdeIDmqRBvBdF/K3XNL0K90e6YOuGbw3/6oG/jEKLrJ2SfkitCwBpSCAzOU21KoJ8U 3MGLy+IeZeaJAQ==; Date: Sat, 15 Feb 2025 17:34:18 +0200 Message-Id: <8634gfdxxh.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mauro Aranda <maurooaranda@HIDDEN> In-Reply-To: <75152115-2732-4d58-8324-799cf1364f53@HIDDEN> (message from Mauro Aranda on Sat, 15 Feb 2025 10:33:59 -0300) Subject: Re: bug#1206: double slash // in read-shell-command completion References: <75152115-2732-4d58-8324-799cf1364f53@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 1206-done Cc: 1206-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sat, 15 Feb 2025 10:33:59 -0300 > From: Mauro Aranda <maurooaranda@HIDDEN> > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: Glenn Morris <rgm@HIDDEN> > >> Cc: 1206 <at> debbugs.gnu.org > >> Date: Tue, 01 Mar 2011 23:14:15 -0500 > >> > >> > >> Do you still see this? I don't think I do. > > > > No, but it still isn't right: it inserts an extra slash. That is, I > > get something like "d:/gnu/emacs-foo//lisp". The extra slash in this > > situation is really not nice... > > > > This happens both with Emacs 23.3 RC1 and with the development trunk. > > This is an old bug report you filed, that I used to be able to reproduce > years ago when I was looking for old bugs to fix. > > Thing is, I'm not able to reproduce it anymore. I did this: > > In a directory that looks like this: > . > ├── emacs > │ ├── emacs-27 > │ │ ├── lisp > │ ├── emacs-28 > │ │ ├── lisp > │ ├── emacs-29 > │ │ ├── lisp > > emacs -Q > M-! > ls ~/emacs/emacs-2/lisp > Move point to the slash before "lisp". > TAB > > Emacs shows: > 3 possible completions: > emacs-27/ > emacs-28/ > emacs-29/ > > Select one and now the minibuffer shows: > ~/emacs/emacs-27/lisp > > > Emacs 28 shows the behavior you reported. Then Emacs 29 showed: "No > match", which is wrong. But then, after the following commit, I can't > reproduce it anymore: Yes, this is now fixed in Emacs 30 (Emacs 29.4 is still wrong, albeit in a different way). So I'm closing this bug, thanks. Good riddance!
Eli Zaretskii <eliz@HIDDEN>
:Eli Zaretskii <eliz@HIDDEN>
:Received: (at 1206) by debbugs.gnu.org; 15 Feb 2025 13:34:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 15 08:34:12 2025 Received: from localhost ([127.0.0.1]:53990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjIJA-0006Pd-4Z for submit <at> debbugs.gnu.org; Sat, 15 Feb 2025 08:34:12 -0500 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]:57802) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maurooaranda@HIDDEN>) id 1tjIJ8-0006PK-Aa for 1206 <at> debbugs.gnu.org; Sat, 15 Feb 2025 08:34:11 -0500 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-2aa17010cbcso2249311fac.3 for <1206 <at> debbugs.gnu.org>; Sat, 15 Feb 2025 05:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739626444; x=1740231244; darn=debbugs.gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=OMXYuScToEMmSQBiZ+QphubCorC8C/A6LAk3VdIHXY4=; b=XqRIsVzN9zOkKA8/YDIlgr5TNkt+3TYD//P4sSeYjuDv7+QR/eV+VRfnT7dBPWifHX pMHblvVlIhSibB/EXywJ8dx3mCFgdgXdZzIl384S1sZjkwWfCE4rSq0akc0GvLULZPnR BBciBXUdrPDFcGgIQctV4UlZ1JHgG3tJA29CtiC7oRmIULRKBmo3Bdfd3Q9CabuKQCsC gmqTkU8uo5M6hFU+lWG+Cbs53kBnAX12WAUbLAR8/ghYpPcPyB6zzulZcj1a2+GPmBdw WMFRlqH/PRREAIMq5JQLaaS85oIdlbnQuDnUJB9tPvAfU9kxi9M6agTnVhJEm8ktj9yo RmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739626444; x=1740231244; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OMXYuScToEMmSQBiZ+QphubCorC8C/A6LAk3VdIHXY4=; b=r7NLsJFvdGCOmOqVIL41xNJuIO8bNtPOHSXs9LoVy0shH5liVQwJpsY8w8bz6Trbsy VZg125DhW2q9imzTsRc5eEolw3FlF1CBSaaJvI3JXN26c+83xGrL6tLHR4Lsy/aTuSme EFAPZ0UNXcVppHlwlFVbIwbTAjjM5uSGENDMxQHzi38GxLgVXHpVpZyFidI6RRlo23Mi XIfhF+GQbUUOvygnYJFBArV4rYHVcs60KuULN9yhHdzX1/ptMafEDXkaxT+UvJ7yJiGg rovMgAcB5rUKu0ikBddyxbWNMZVvboklhKw1kciXdDTnxHhhpDDCLl9Pkvykv63rtl/y 2m2Q== X-Forwarded-Encrypted: i=1; AJvYcCVesYRsCxnLKQJf4PWJ6DCBBM6FQT3+pEOibyGLU93pFeRRyP2VUOnnxXJPEcm30lLg70lr <at> debbugs.gnu.org X-Gm-Message-State: AOJu0YxIn0HuTks4ywTewlTnsDNY+P9LNaByWI9FOLdOOBtcSpI68Qwu cy+scHxNWeaCnVBFvaeFxukoNLBMOKK2jSfcQNBQy37qEimcprJDsVBWcg== X-Gm-Gg: ASbGncv4xWm9f6D0K7ddNWd+GbLO3Uf9IhKguN8DdME7x3UvZakKDoKaXcCC9E1Q+Fb DcQQPvTWDHjxk7rAX8gAGF6FiuKFG5TwRm+A+f2Qp0ZTDI8NT/PneDQJtNA2IavMq84E58/kMog PBMwFQbGqUiMY+xpF8/KM6NNHMmYnwq1LOW0BpSXFSPkPbUH+G7BKZFUWU2a3dYnlrI4fgal6NB 6m8C6d0G1fMJMQeB5Moj2MlDOH09dRL6VzCS8sJ4+Qfv/+ePbP2jkMIPAilhXsyqwDyeLQq0PmN wdMMpJxfcgFm0WcrBmwDmQ== X-Google-Smtp-Source: AGHT+IEmDPL97k/WazT3ijG4HbMzWPxrtb+5tFbreaxQZv9ZpkZ2TWsJ0fv2oRwpA8nlNPQB9yg5Zg== X-Received: by 2002:a05:6870:aa85:b0:2bc:69a9:2ef4 with SMTP id 586e51a60fabf-2bc99d82992mr1486198fac.25.1739626443897; Sat, 15 Feb 2025 05:34:03 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-727002581d3sm1928623a34.49.2025.02.15.05.34.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Feb 2025 05:34:02 -0800 (PST) Message-ID: <75152115-2732-4d58-8324-799cf1364f53@HIDDEN> Date: Sat, 15 Feb 2025 10:33:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Eli Zaretskii <eliz@HIDDEN>, 1206 <at> debbugs.gnu.org From: Mauro Aranda <maurooaranda@HIDDEN> Subject: Re: bug#1206: double slash // in read-shell-command completion Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 1206 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Hi Eli, Eli Zaretskii <eliz@HIDDEN> writes: >> From: Glenn Morris <rgm@HIDDEN> >> Cc: 1206 <at> debbugs.gnu.org >> Date: Tue, 01 Mar 2011 23:14:15 -0500 >> >> >> Do you still see this? I don't think I do. > > No, but it still isn't right: it inserts an extra slash. That is, I > get something like "d:/gnu/emacs-foo//lisp". The extra slash in this > situation is really not nice... > > This happens both with Emacs 23.3 RC1 and with the development trunk. This is an old bug report you filed, that I used to be able to reproduce years ago when I was looking for old bugs to fix. Thing is, I'm not able to reproduce it anymore. I did this: In a directory that looks like this: . ├── emacs │ ├── emacs-27 │ │ ├── lisp │ ├── emacs-28 │ │ ├── lisp │ ├── emacs-29 │ │ ├── lisp emacs -Q M-! ls ~/emacs/emacs-2/lisp Move point to the slash before "lisp". TAB Emacs shows: 3 possible completions: emacs-27/ emacs-28/ emacs-29/ Select one and now the minibuffer shows: ~/emacs/emacs-27/lisp Emacs 28 shows the behavior you reported. Then Emacs 29 showed: "No match", which is wrong. But then, after the following commit, I can't reproduce it anymore: commit ff3f17ca3cdd9e82355942f577e7807acc76ddcd Author: Dmitry Gutov <dmitry@HIDDEN> Date: Thu May 9 05:30:32 2024 +0300 choose-completion: Retain the suffix after completion boundary * lisp/minibuffer.el (completion-base-suffix): Remove as not optimal after all (bug#48356). (completion--replace): Use insert-before-markers-and-inherit. (minibuffer-completion-help): Don't set completion-base-affixes, implement the same logic more optimally by local search and querying for field boundaries. Also fix the problem with completion table, predicate and extra-props being looked up in the wrong buffer. (minibuffer-next-completion, minibuffer-choose-completion): Don't bind completion-use-base-affixes anymore. * lisp/simple.el (completion-base-affixes) (completion-use-base-affixes): Remove. (completion-list-insert-choice-function): Don't pass them through anymore.
bug-gnu-emacs@HIDDEN
:bug#1206
; Package emacs
.
Full text available.Glenn Morris <rgm@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Glenn Morris <rgm@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Received: (at 1206) by debbugs.gnu.org; 2 Mar 2011 17:59:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 02 12:59:32 2011 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1PuqKh-00072r-Re for submit <at> debbugs.gnu.org; Wed, 02 Mar 2011 12:59:31 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <eliz@HIDDEN>) id 1PuqKf-00072f-CC for 1206 <at> debbugs.gnu.org; Wed, 02 Mar 2011 12:59:30 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LHF00700Z80DK00@HIDDEN> for 1206 <at> debbugs.gnu.org; Wed, 02 Mar 2011 19:59:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.183.216]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHF007HNZAYDS00@HIDDEN>; Wed, 02 Mar 2011 19:59:23 +0200 (IST) Date: Wed, 02 Mar 2011 19:57:20 +0200 From: Eli Zaretskii <eliz@HIDDEN> Subject: Re: 23.0.60; read-shell-command completion problem In-reply-to: <tkbp1uma5k.fsf@HIDDEN> X-012-Sender: halo1@HIDDEN To: Glenn Morris <rgm@HIDDEN> Message-id: <83ipw1xv5r.fsf@HIDDEN> References: <877hub5is0.fsf@HIDDEN> <83skcqa2uf.fsf@HIDDEN> <tkbp1uma5k.fsf@HIDDEN> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 1206 Cc: 1206 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii <eliz@HIDDEN> List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Glenn Morris <rgm@HIDDEN> > Cc: 1206 <at> debbugs.gnu.org > Date: Tue, 01 Mar 2011 23:14:15 -0500 > > > Do you still see this? I don't think I do. No, but it still isn't right: it inserts an extra slash. That is, I get something like "d:/gnu/emacs-foo//lisp". The extra slash in this situation is really not nice... This happens both with Emacs 23.3 RC1 and with the development trunk.
owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN
:bug#1206
; Package emacs
.
Full text available.Received: (at 1206) by debbugs.gnu.org; 2 Mar 2011 04:14:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 01 23:14:23 2011 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1PudSA-00044a-Ql for submit <at> debbugs.gnu.org; Tue, 01 Mar 2011 23:14:23 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <rgm@HIDDEN>) id 1PudS9-00044O-16 for 1206 <at> debbugs.gnu.org; Tue, 01 Mar 2011 23:14:21 -0500 Received: from localhost ([127.0.0.1]:46444) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@HIDDEN>) id 1PudS3-0002cl-Qc; Tue, 01 Mar 2011 23:14:15 -0500 From: Glenn Morris <rgm@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: 23.0.60; read-shell-command completion problem References: <877hub5is0.fsf@HIDDEN> <83skcqa2uf.fsf@HIDDEN> X-Spook: Iran nitrate arrangements fundamentalist Attorney General X-Ran: !~tsSu<JC6"G&nek,iv\zc|HG)8%F=8qtE98SK+pQyI(ryNNH1ttEy4"dNz|zxdm;nHZ&< X-Hue: blue X-Attribution: GM Date: Tue, 01 Mar 2011 23:14:15 -0500 In-Reply-To: <83skcqa2uf.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 07 Nov 2009 15:20:24 +0200") Message-ID: <tkbp1uma5k.fsf@HIDDEN> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 1206 Cc: 1206 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -6.3 (------) Do you still see this? I don't think I do.
owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN
:bug#1206
; Package emacs
.
Full text available.Received: (at 1206) by emacsbugs.donarmstrong.com; 7 Nov 2009 13:22:35 +0000 From eliz@HIDDEN Sat Nov 7 05:22:35 2009 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout21.012.net.il (mtaout21.012.net.il [80.179.55.169]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA7DMXT8008439 for <1206@HIDDEN>; Sat, 7 Nov 2009 05:22:34 -0800 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0KSQ00400PS0ZZ00@HIDDEN> for 1206@HIDDEN; Sat, 07 Nov 2009 15:22:27 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KSQ001F1QHEL090@HIDDEN>; Sat, 07 Nov 2009 15:22:27 +0200 (IST) Date: Sat, 07 Nov 2009 15:20:24 +0200 From: Eli Zaretskii <eliz@HIDDEN> Subject: Re: 23.0.60; read-shell-command completion problem In-reply-to: <877hub5is0.fsf@HIDDEN> X-012-Sender: halo1@HIDDEN To: Chong Yidong <cyd@HIDDEN> Cc: 1206 <at> debbugs.gnu.org Reply-to: Eli Zaretskii <eliz@HIDDEN> Message-id: <83skcqa2uf.fsf@HIDDEN> References: <877hub5is0.fsf@HIDDEN> > From: Chong Yidong <cyd@HIDDEN> > Cc: 1206@HIDDEN > Date: Sat, 31 Oct 2009 17:57:03 -0400 > > Hi Eli, > > Could you test the patch I posted at > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1206 Sorry for the long delay. I tested the patch now on MS-Windows, and I still see two slashes, exactly like in the original report. The problem seems to be that minibuffer-completing-file-name is nil when the modified code is run.
Eli Zaretskii <eliz@HIDDEN>
:Emacs Bugs <bug-gnu-emacs@HIDDEN>
.
Full text available.bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>
:bug#1206
; Package emacs
.
Full text available.Received: (at 1206) by emacsbugs.donarmstrong.com; 31 Oct 2009 21:57:10 +0000 From cyd@HIDDEN Sat Oct 31 14:57:10 2009 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.3 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po27.its.yale.edu (pantheon-po27.its.yale.edu [130.132.50.122]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9VLv8kO006593 for <1206@HIDDEN>; Sat, 31 Oct 2009 14:57:10 -0700 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po27.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9VLv3wd003667 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 31 Oct 2009 17:57:03 -0400 Received: by furry (Postfix, from userid 1000) id 6E124C070; Sat, 31 Oct 2009 17:57:03 -0400 (EDT) From: Chong Yidong <cyd@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Cc: 1206 <at> debbugs.gnu.org Subject: Re: 23.0.60; read-shell-command completion problem Date: Sat, 31 Oct 2009 17:57:03 -0400 Message-ID: <877hub5is0.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) Hi Eli, Could you test the patch I posted at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1206 Thanks!
Chong Yidong <cyd@HIDDEN>
:Emacs Bugs <bug-gnu-emacs@HIDDEN>
.
Full text available.bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>
:bug#1206
; Package emacs
.
Full text available.Received: (at 1206) by emacsbugs.donarmstrong.com; 15 Aug 2009 23:56:16 +0000 From cyd@HIDDEN Sat Aug 15 16:56:16 2009 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.6 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7FNuFVJ011818 for <1206@HIDDEN>; Sat, 15 Aug 2009 16:56:16 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 0449057E21C; Sat, 15 Aug 2009 19:57:14 -0400 (EDT) From: Chong Yidong <cyd@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Cc: 1206 <at> debbugs.gnu.org Subject: Re: 23.0.60; read-shell-command completion problem Date: Sat, 15 Aug 2009 19:57:13 -0400 Message-ID: <874os8ljfq.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > emacs -Q > M-! > ls d:/gnu/emacs/lisp > > Move point so that the cursor is on the slash between "emacs" and > "lisp", and type TAB. At this point, the *Completions* buffer pops up > > Click <mouse-2> on a completion to select it. > In this buffer, type RET to select the completion near point. > > Possible completions are: > emacs-21.4/ emacs-22-branch/ emacs-22.x/ > emacs-23.pre-unicode/ emacs-bidi/ emacs-rtf/ > emacs/ > > Clicking on "emacs-22-branch/" produces this in the minibuffer: > > emacs-22-branch//lisp Could you test the following patch (admittedly a bit of a hack)? *** trunk/lisp/simple.el.~1.1003.~ 2009-08-13 10:30:54.000000000 -0400 --- trunk/lisp/simple.el 2009-08-15 19:53:04.000000000 -0400 *************** *** 5843,5849 **** --- 5843,5857 ---- (if base-size (delete-region (+ base-size (field-beginning)) (point)) (choose-completion-delete-max-match choice)) + + ;; Insert the choice. When reading a file name and the choice + ;; is a directory, avoid having an extra "/" (Bug#1206). (insert choice) + (and minibuffer-completing-file-name + (looking-at "/") + (= (aref choice (1- (length choice))) ?/) + (delete-char 1)) + (remove-text-properties (- (point) (length choice)) (point) '(mouse-face nil)) ;; Update point in the window that BUFFER is showing in.
Chong Yidong <cyd@HIDDEN>
:Emacs Bugs <bug-gnu-emacs@HIDDEN>
.
Full text available.bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>
:bug#1206
; Package emacs
.
Full text available.Received: (at unknown) by unknown; unknown X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,FOURLA, RCVD_IN_DNSWL_MED,RCVD_IN_NIX1 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 19 Oct 2008 15:24:28 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9JFOO8t013272 for <submit@HIDDEN>; Sun, 19 Oct 2008 08:24:25 -0700 Received: from mail.gnu.org ([199.232.76.166]:53160 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from <eliz@HIDDEN>) id 1Kra6E-0001Qx-P8 for emacs-pretest-bug@HIDDEN; Sun, 19 Oct 2008 11:21:46 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from <eliz@HIDDEN>) id 1Kra8k-0004Jr-UJ for emacs-pretest-bug@HIDDEN; Sun, 19 Oct 2008 11:24:23 -0400 Received: from mtaout5.012.net.il ([84.95.2.13]:14110) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from <eliz@HIDDEN>) id 1Kra8k-0004Jh-H6 for emacs-pretest-bug@HIDDEN; Sun, 19 Oct 2008 11:24:22 -0400 Received: from HOME-C4E4A596F7 ([77.126.98.197]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K8Z00K88S6ZQDS1@i_mtaout5.012.net.il> for emacs-pretest-bug@HIDDEN; Sun, 19 Oct 2008 17:25:48 +0200 (IST) Date: Sun, 19 Oct 2008 17:24:24 +0200 From: Eli Zaretskii <eliz@HIDDEN> Subject: 23.0.60; read-shell-command completion problem X-012-Sender: halo1@HIDDEN To: emacs-pretest-bug@HIDDEN Message-id: <uskqsk3pz.fsf@HIDDEN> X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@HIDDEN mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: emacs -Q M-! ls d:/gnu/emacs/lisp Move point so that the cursor is on the slash between "emacs" and "lisp", and type TAB. At this point, the *Completions* buffer pops up with the following possibilities: Click <mouse-2> on a completion to select it. In this buffer, type RET to select the completion near point. Possible completions are: emacs-21.4/ emacs-22-branch/ emacs-22.x/ emacs-23.pre-unicode/ emacs-bidi/ emacs-rtf/ emacs/ (Depending on your system, you will see something different.) Clicking on "emacs-22-branch/" produces this in the minibuffer: emacs-22-branch//lisp But I expected it to replace only the "emacs" part (because this is what it evidently produced the possible completions for), so that I will see "ls d:/gnu/emacs-22-branch/lisp". This was on MS-Windows, but I see the same behavior on GNU/Linux: picking up a completion replaces the whole input, up to the position of point. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file d:/gnu/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-19 on HOME-C4E4A596F7 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU value of $XMODIFIERS: nil locale-coding-system: cp1255 default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: s e c o n d SPC C - x SPC a n d SPC w a n t e d SPC t o SPC b a i l SPC o u t . SPC SPC I S-SPC e x p e c t e d SPC t o SPC s e e SPC " Q u i t " , SPC n o t SPC a SPC f a t a l SPC <M-backspace> <M-backspace> a n SPC e r r o r . ) M-q <C-home> C-SPC <down> C-SPC <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> M-w C-x b <return> C-x 1 C-x <return> c u n d e c <tab> <return> C-x C-g <help-echo> <help-echo> C-x b * C o m <tab> <return> C-x b <return> M-! l s SPC d : / g n u / e m a c s / l i s p <left> <left> <left> <left> <left> <tab> <help-echo> <help-echo> <help-echo> <down-mouse-1> <mouse-2> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> <left> C-SPC C-e M-w <help-echo> <help-echo> <help-echo> C-g C-x b <up> <up> <return> <up> <up> <up> <up> C-a C-SPC <down> <down> <down> <down> <down> <down> <down> M-w <help-echo> C-x b <return> M-x <up> <return> Recent messages: Quit [2 times] universal-coding-system-argument: Wrong type argument: commandp, nil Mark set [4 times] Auto-saving...done Mark set [3 times] Saved text from "To: emacs-pretest-bug@HIDDEN Subject: 2" universal-coding-system-argument: Wrong type argument: commandp, nil Quit Mark set
Eli Zaretskii <eliz@HIDDEN>
:Emacs Bugs <bug-gnu-emacs@HIDDEN>
.
Full text available.bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>
:bug#1206
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.