X-Loop: help-debbugs@HIDDEN Subject: bug#12501: Automake generated makefiles can be less verbose when building with silent rules Resent-From: Hib Eris <hib@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-automake@HIDDEN Resent-Date: Mon, 24 Sep 2012 07:38:02 +0000 Resent-Message-ID: <handler.12501.B.134847225830364 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 12501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 12501 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-automake@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.134847225830364 (code B ref -1); Mon, 24 Sep 2012 07:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Sep 2012 07:37:38 +0000 Received: from localhost ([127.0.0.1]:52066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1TG3EX-0007th-T6 for submit <at> debbugs.gnu.org; Mon, 24 Sep 2012 03:37:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60843) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <hib@HIDDEN>) id 1TG3EV-0007tZ-4J for submit <at> debbugs.gnu.org; Mon, 24 Sep 2012 03:37:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <hib@HIDDEN>) id 1TG3Cf-000173-7X for submit <at> debbugs.gnu.org; Mon, 24 Sep 2012 03:35:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hib@HIDDEN>) id 1TG3Cf-00016z-4E for submit <at> debbugs.gnu.org; Mon, 24 Sep 2012 03:35:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hib@HIDDEN>) id 1TG3CZ-00083R-LK for bug-automake@HIDDEN; Mon, 24 Sep 2012 03:35:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <hib@HIDDEN>) id 1TG3CV-00015a-TZ for bug-automake@HIDDEN; Mon, 24 Sep 2012 03:35:35 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:56292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hib@HIDDEN>) id 1TG3CV-00015R-Oh for bug-automake@HIDDEN; Mon, 24 Sep 2012 03:35:31 -0400 Received: by obcva7 with SMTP id va7so1852469obc.0 for <bug-automake@HIDDEN>; Mon, 24 Sep 2012 00:35:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :x-gm-message-state; bh=Wm5NMTnZ8Tze7FynFG5C2vmVRG8TCD8n9S58JztmfOY=; b=El/8KSToqCM1Wl7FQrN03OgWTILWJjeH1QRz0tNdC2uS7ZTWNETT7VCVHGFI3xZMYb ZeR0PtRCJ3bbHHAhHALPLnaPOh5ZEldjSOcIP9r0IKQ4oh8iBJTWBk+r3DXQDOX/4pgC x1n/xw9E4PsXtED4Dq7JqadtMt2LftsYjtbcacQ817oywQodtGCzTaRHp+E9RMAO3zLR g/C4PYHJvjNxp0IHhFe0NVe40CeII6P1hA/zm0Xb6eEGQHD/0aZVHOHve2fYQr2X3te1 nYXHtI6chf4dspUvQvakrek7OmwiQycK3b4XskkDvbjxos5fVh/gHRIVMrlyjxmBzWEZ 3cdw== Received: by 10.60.13.104 with SMTP id g8mr8982624oec.82.1348472130198; Mon, 24 Sep 2012 00:35:30 -0700 (PDT) Received: from mail-oa0-f41.google.com (mail-oa0-f41.google.com [209.85.219.41]) by mx.google.com with ESMTPS id k3sm15388052obw.4.2012.09.24.00.35.27 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Sep 2012 00:35:28 -0700 (PDT) Received: by oagk14 with SMTP id k14so2445911oag.0 for <bug-automake@HIDDEN>; Mon, 24 Sep 2012 00:35:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.30.229 with SMTP id v5mr8979760oeh.130.1348472126893; Mon, 24 Sep 2012 00:35:26 -0700 (PDT) Received: by 10.60.172.196 with HTTP; Mon, 24 Sep 2012 00:35:26 -0700 (PDT) Date: Mon, 24 Sep 2012 09:35:26 +0200 Message-ID: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> From: Hib Eris <hib@HIDDEN> Content-Type: multipart/mixed; boundary=e89a8fb206cc1ced5b04ca6da2a0 X-Gm-Message-State: ALoCoQk1y3dO8J+/Lz49gDEPU3j/8gFYoUw+C9TcIp9DYNsWryP9yHY6R78Xyk5gNHp9Xqt3cN1i X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -6.9 (------) --e89a8fb206cc1ced5b04ca6da2a0 Content-Type: text/plain; charset=ISO-8859-1 Hi all, I think Automake generated makefiles can be a little less verbose when building with silent rules. Please consider attached patch. Thanks, Hib Eris --e89a8fb206cc1ced5b04ca6da2a0 Content-Type: application/octet-stream; name="0001-Do-not-echo-targets-when-building-with-silent-rules.patch" Content-Disposition: attachment; filename="0001-Do-not-echo-targets-when-building-with-silent-rules.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h7h9gzzs0 RnJvbSBiMWFiMzQzZTNlNWM4M2UzZGE5OWEzNDkyNGFjZjljNjhiZDRlZTcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIaWIgRXJpcyA8aGliQGhpYmVyaXMubmw+CkRhdGU6IE1vbiwg MjQgU2VwIDIwMTIgMDk6Mjk6NTYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBEbyBub3QgZWNobyB0 YXJnZXRzIHdoZW4gYnVpbGRpbmcgd2l0aCBzaWxlbnQgcnVsZXMKCi0tLQogYXV0b21ha2UuaW4g ICAgICAgfCAgICAyICstCiBsaWIvYW0vc3ViZGlycy5hbSB8ICAgIDIgKy0KIDIgZmlsZXMgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2F1dG9t YWtlLmluIGIvYXV0b21ha2UuaW4KaW5kZXggYjE2NTg1NS4uNWIzODNhMCAxMDA2NDQKLS0tIGEv YXV0b21ha2UuaW4KKysrIGIvYXV0b21ha2UuaW4KQEAgLTQ0NzYsNyArNDQ3Niw3IEBAIHN1YiBo YW5kbGVfYWxsICgkKQogCSMgdGhpbmdzIGV4cGxpY2l0bHkuCiAJJG91dHB1dF9hbGwgLj0gKCJh bGw6IEBsb2NhbF9oZWFkZXJzIgogCQkJLiAiXG5cdCIKLQkJCS4gJyQoTUFLRSkgJChBTV9NQUtF RkxBR1MpICcKKwkJCS4gJyQoQU1fVl9hdCkkKE1BS0UpICQoQU1fTUFLRUZMQUdTKSAnCiAJCQku ICh2YXIgKCdTVUJESVJTJykgPyAnYWxsLXJlY3Vyc2l2ZScgOiAnYWxsLWFtJykKIAkJCS4gIlxu XG4iKTsKICAgICAgICAgZGVwZW5kICgnLk1BS0UnLCAnYWxsJyk7CmRpZmYgLS1naXQgYS9saWIv YW0vc3ViZGlycy5hbSBiL2xpYi9hbS9zdWJkaXJzLmFtCmluZGV4IDAwNTQ4M2EuLmI0MzBkMjEg MTAwNjQ0Ci0tLSBhL2xpYi9hbS9zdWJkaXJzLmFtCisrKyBiL2xpYi9hbS9zdWJkaXJzLmFtCkBA IC01Niw3ICs1Niw3IEBAICQoYW1fX3JlY3Vyc2l2ZV90YXJnZXRzKToKIAkgICopIGxpc3Q9JyQo U1VCRElSUyknIDs7IFwKIAllc2FjOyBcCiAJZm9yIHN1YmRpciBpbiAkJGxpc3Q7IGRvIFwKLQkg IGVjaG8gIk1ha2luZyAkJHRhcmdldCBpbiAkJHN1YmRpciI7IFwKKwkgICQoQU1fVl9QKSAmJiBl Y2hvICJNYWtpbmcgJCR0YXJnZXQgaW4gJCRzdWJkaXIiOyBcCiAJICBpZiB0ZXN0ICIkJHN1YmRp ciIgPSAiLiI7IHRoZW4gXAogCSAgICBkb3Rfc2Vlbj15ZXM7IFwKIAkgICAgbG9jYWxfdGFyZ2V0 PSIkJHRhcmdldC1hbSI7IFwKLS0gCjEuNy41LjQKCg== --e89a8fb206cc1ced5b04ca6da2a0--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Hib Eris <hib@HIDDEN> Subject: bug#12501: Acknowledgement (Automake generated makefiles can be less verbose when building with silent rules) Message-ID: <handler.12501.B.134847225830364.ack <at> debbugs.gnu.org> References: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> X-Gnu-PR-Message: ack 12501 X-Gnu-PR-Package: automake Reply-To: 12501 <at> debbugs.gnu.org Date: Mon, 24 Sep 2012 07:38:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-automake@HIDDEN If you wish to submit further information on this problem, please send it to 12501 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 12501: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12501 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#12501: Automake generated makefiles can be less verbose when building with silent rules Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-automake@HIDDEN Resent-Date: Tue, 02 Oct 2012 15:11:01 +0000 Resent-Message-ID: <handler.12501.B12501.134919062028136 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 12501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Hib Eris <hib@HIDDEN> Cc: 12501 <at> debbugs.gnu.org Received: via spool by 12501-submit <at> debbugs.gnu.org id=B12501.134919062028136 (code B ref 12501); Tue, 02 Oct 2012 15:11:01 +0000 Received: (at 12501) by debbugs.gnu.org; 2 Oct 2012 15:10:20 +0000 Received: from localhost ([127.0.0.1]:37879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1TJ472-0007Jj-7w for submit <at> debbugs.gnu.org; Tue, 02 Oct 2012 11:10:20 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:54735) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <stefano.lattarini@HIDDEN>) id 1TJ46y-0007JX-TP; Tue, 02 Oct 2012 11:10:18 -0400 Received: by bkcjc3 with SMTP id jc3so5453162bkc.3 for <multiple recipients>; Tue, 02 Oct 2012 08:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=JJyP6OKeEahAZi2jtoZVFNstFFtizK0Gs+S+C1+KlJE=; b=uQ7mJ2Z/jRaL0ldGX5WYbTVcghJzLztkFkHS+SJ3m9NSIdisWVOslZ5anGEQUv+AfZ kH614fQXHIRvociTBjs+GjT/4667P/fu1cKuyFVRn8iDQmkLoD0CGrVxRVutGQaDhb9M 3pSjL736RhWeent+J503nhoruXhaqRLCdS/oJAo9qoA847XBq9XgGKIhBppZqZa41USD eR4UMHzt/BiAGt0M3rMYfhmUkDzG/n2liWTSKFVZB4Et82eGi7aUX3pnOxj66kCd+8S/ xnQ1NQ6bu6Gd7yuntKIqZR92zWl2fyZiqI3oXKYSb4eIc0VTYDeCTs9KHzkhXEuWohSY Leqg== Received: by 10.204.8.141 with SMTP id h13mr5500037bkh.54.1349190583130; Tue, 02 Oct 2012 08:09:43 -0700 (PDT) Received: from [192.168.178.21] (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id z22sm1542864bkw.2.2012.10.02.08.09.38 (version=SSLv3 cipher=OTHER); Tue, 02 Oct 2012 08:09:41 -0700 (PDT) Message-ID: <506B03B0.1090309@HIDDEN> Date: Tue, 02 Oct 2012 17:09:36 +0200 From: Stefano Lattarini <stefano.lattarini@HIDDEN> MIME-Version: 1.0 References: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> In-Reply-To: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: 0.1 (/) tags 12501 + moreinfo severity 12501 wishlist thanks On 09/24/2012 09:35 AM, Hib Eris wrote: > Hi all, > > I think Automake generated makefiles can be a little less verbose when > building with silent rules. > Please consider attached patch. > > Thanks, > > Hib Eris > > From b1ab343e3e5c83e3da99a34924acf9c68bd4ee72 Mon Sep 17 00:00:00 2001 > From: Hib Eris <hib@HIDDEN> > Date: Mon, 24 Sep 2012 09:29:56 +0200 > Subject: [PATCH] Do not echo targets when building with silent rules > > --- > automake.in | 2 +- > lib/am/subdirs.am | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/automake.in b/automake.in > index b165855..5b383a0 100644 > --- a/automake.in > +++ b/automake.in > @@ -4476,7 +4476,7 @@ sub handle_all ($) > # things explicitly. > $output_all .= ("all: @local_headers" > . "\n\t" > - . '$(MAKE) $(AM_MAKEFLAGS) ' > + . '$(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) ' > . (var ('SUBDIRS') ? 'all-recursive' : 'all-am') > . "\n\n"); > depend ('.MAKE', 'all'); > diff --git a/lib/am/subdirs.am b/lib/am/subdirs.am > index 005483a..b430d21 100644 > --- a/lib/am/subdirs.am > +++ b/lib/am/subdirs.am > @@ -56,7 +56,7 @@ $(am__recursive_targets): > *) list='$(SUBDIRS)' ;; \ > esac; \ > for subdir in $$list; do \ > - echo "Making $$target in $$subdir"; \ > + $(AM_V_P) && echo "Making $$target in $$subdir"; \ > if test "$$subdir" = "."; then \ > dot_seen=yes; \ > local_target="$$target-am"; \ > -- 1.7.5.4 > Hmm... I fear that this change would actually make the makefile output *too* silent, possibly impeding debugging or problem diagnosis in a serious way. But I'm not sure if this is actually the case, or if I'm just being overly wary. Would any other automaker like to chime in with his opinion? Anyway, the best way to make an "informed decision" would be to try out Automake, patched with this diff, on few real-world package (GNU coreutils and GNU autoconf comes to mind), with GNU and non-GNU make implementations alike, and seeing how the make output looks when everything goes smoothly, and then how it looks when there are errors (e.g., errors compiling a file, permission errors modifying or creating a file, and even syntax errors in a subdir Makefile). Would you be willing to give this experiment a try, later posting here the output and impressions you get? This might be overkill for such a minor change however ... Waiting for feedback, Stefano
Received: (at control) by debbugs.gnu.org; 2 Oct 2012 15:10:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 02 11:10:21 2012 Received: from localhost ([127.0.0.1]:37881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1TJ472-0007Jm-QX for submit <at> debbugs.gnu.org; Tue, 02 Oct 2012 11:10:21 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:54735) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <stefano.lattarini@HIDDEN>) id 1TJ46y-0007JX-TP; Tue, 02 Oct 2012 11:10:18 -0400 Received: by bkcjc3 with SMTP id jc3so5453162bkc.3 for <multiple recipients>; Tue, 02 Oct 2012 08:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=JJyP6OKeEahAZi2jtoZVFNstFFtizK0Gs+S+C1+KlJE=; b=uQ7mJ2Z/jRaL0ldGX5WYbTVcghJzLztkFkHS+SJ3m9NSIdisWVOslZ5anGEQUv+AfZ kH614fQXHIRvociTBjs+GjT/4667P/fu1cKuyFVRn8iDQmkLoD0CGrVxRVutGQaDhb9M 3pSjL736RhWeent+J503nhoruXhaqRLCdS/oJAo9qoA847XBq9XgGKIhBppZqZa41USD eR4UMHzt/BiAGt0M3rMYfhmUkDzG/n2liWTSKFVZB4Et82eGi7aUX3pnOxj66kCd+8S/ xnQ1NQ6bu6Gd7yuntKIqZR92zWl2fyZiqI3oXKYSb4eIc0VTYDeCTs9KHzkhXEuWohSY Leqg== Received: by 10.204.8.141 with SMTP id h13mr5500037bkh.54.1349190583130; Tue, 02 Oct 2012 08:09:43 -0700 (PDT) Received: from [192.168.178.21] (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id z22sm1542864bkw.2.2012.10.02.08.09.38 (version=SSLv3 cipher=OTHER); Tue, 02 Oct 2012 08:09:41 -0700 (PDT) Message-ID: <506B03B0.1090309@HIDDEN> Date: Tue, 02 Oct 2012 17:09:36 +0200 From: Stefano Lattarini <stefano.lattarini@HIDDEN> MIME-Version: 1.0 To: Hib Eris <hib@HIDDEN> Subject: Re: bug#12501: Automake generated makefiles can be less verbose when building with silent rules References: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> In-Reply-To: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control Cc: 12501 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: 0.1 (/) tags 12501 + moreinfo severity 12501 wishlist thanks On 09/24/2012 09:35 AM, Hib Eris wrote: > Hi all, > > I think Automake generated makefiles can be a little less verbose when > building with silent rules. > Please consider attached patch. > > Thanks, > > Hib Eris > > From b1ab343e3e5c83e3da99a34924acf9c68bd4ee72 Mon Sep 17 00:00:00 2001 > From: Hib Eris <hib@HIDDEN> > Date: Mon, 24 Sep 2012 09:29:56 +0200 > Subject: [PATCH] Do not echo targets when building with silent rules > > --- > automake.in | 2 +- > lib/am/subdirs.am | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/automake.in b/automake.in > index b165855..5b383a0 100644 > --- a/automake.in > +++ b/automake.in > @@ -4476,7 +4476,7 @@ sub handle_all ($) > # things explicitly. > $output_all .= ("all: @local_headers" > . "\n\t" > - . '$(MAKE) $(AM_MAKEFLAGS) ' > + . '$(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) ' > . (var ('SUBDIRS') ? 'all-recursive' : 'all-am') > . "\n\n"); > depend ('.MAKE', 'all'); > diff --git a/lib/am/subdirs.am b/lib/am/subdirs.am > index 005483a..b430d21 100644 > --- a/lib/am/subdirs.am > +++ b/lib/am/subdirs.am > @@ -56,7 +56,7 @@ $(am__recursive_targets): > *) list='$(SUBDIRS)' ;; \ > esac; \ > for subdir in $$list; do \ > - echo "Making $$target in $$subdir"; \ > + $(AM_V_P) && echo "Making $$target in $$subdir"; \ > if test "$$subdir" = "."; then \ > dot_seen=yes; \ > local_target="$$target-am"; \ > -- 1.7.5.4 > Hmm... I fear that this change would actually make the makefile output *too* silent, possibly impeding debugging or problem diagnosis in a serious way. But I'm not sure if this is actually the case, or if I'm just being overly wary. Would any other automaker like to chime in with his opinion? Anyway, the best way to make an "informed decision" would be to try out Automake, patched with this diff, on few real-world package (GNU coreutils and GNU autoconf comes to mind), with GNU and non-GNU make implementations alike, and seeing how the make output looks when everything goes smoothly, and then how it looks when there are errors (e.g., errors compiling a file, permission errors modifying or creating a file, and even syntax errors in a subdir Makefile). Would you be willing to give this experiment a try, later posting here the output and impressions you get? This might be overkill for such a minor change however ... Waiting for feedback, Stefano
Received: (at control) by debbugs.gnu.org; 2 Oct 2012 15:10:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 02 11:10:21 2012 Received: from localhost ([127.0.0.1]:37881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1TJ472-0007Jm-QX for submit <at> debbugs.gnu.org; Tue, 02 Oct 2012 11:10:21 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:54735) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <stefano.lattarini@HIDDEN>) id 1TJ46y-0007JX-TP; Tue, 02 Oct 2012 11:10:18 -0400 Received: by bkcjc3 with SMTP id jc3so5453162bkc.3 for <multiple recipients>; Tue, 02 Oct 2012 08:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=JJyP6OKeEahAZi2jtoZVFNstFFtizK0Gs+S+C1+KlJE=; b=uQ7mJ2Z/jRaL0ldGX5WYbTVcghJzLztkFkHS+SJ3m9NSIdisWVOslZ5anGEQUv+AfZ kH614fQXHIRvociTBjs+GjT/4667P/fu1cKuyFVRn8iDQmkLoD0CGrVxRVutGQaDhb9M 3pSjL736RhWeent+J503nhoruXhaqRLCdS/oJAo9qoA847XBq9XgGKIhBppZqZa41USD eR4UMHzt/BiAGt0M3rMYfhmUkDzG/n2liWTSKFVZB4Et82eGi7aUX3pnOxj66kCd+8S/ xnQ1NQ6bu6Gd7yuntKIqZR92zWl2fyZiqI3oXKYSb4eIc0VTYDeCTs9KHzkhXEuWohSY Leqg== Received: by 10.204.8.141 with SMTP id h13mr5500037bkh.54.1349190583130; Tue, 02 Oct 2012 08:09:43 -0700 (PDT) Received: from [192.168.178.21] (host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194]) by mx.google.com with ESMTPS id z22sm1542864bkw.2.2012.10.02.08.09.38 (version=SSLv3 cipher=OTHER); Tue, 02 Oct 2012 08:09:41 -0700 (PDT) Message-ID: <506B03B0.1090309@HIDDEN> Date: Tue, 02 Oct 2012 17:09:36 +0200 From: Stefano Lattarini <stefano.lattarini@HIDDEN> MIME-Version: 1.0 To: Hib Eris <hib@HIDDEN> Subject: Re: bug#12501: Automake generated makefiles can be less verbose when building with silent rules References: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> In-Reply-To: <CABuq26hv-ZkhDcEWSeZ9szN839mUHOJ5OPwzdzm15tQOxgHEVA@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control Cc: 12501 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: 0.1 (/) tags 12501 + moreinfo severity 12501 wishlist thanks On 09/24/2012 09:35 AM, Hib Eris wrote: > Hi all, > > I think Automake generated makefiles can be a little less verbose when > building with silent rules. > Please consider attached patch. > > Thanks, > > Hib Eris > > From b1ab343e3e5c83e3da99a34924acf9c68bd4ee72 Mon Sep 17 00:00:00 2001 > From: Hib Eris <hib@HIDDEN> > Date: Mon, 24 Sep 2012 09:29:56 +0200 > Subject: [PATCH] Do not echo targets when building with silent rules > > --- > automake.in | 2 +- > lib/am/subdirs.am | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/automake.in b/automake.in > index b165855..5b383a0 100644 > --- a/automake.in > +++ b/automake.in > @@ -4476,7 +4476,7 @@ sub handle_all ($) > # things explicitly. > $output_all .= ("all: @local_headers" > . "\n\t" > - . '$(MAKE) $(AM_MAKEFLAGS) ' > + . '$(AM_V_at)$(MAKE) $(AM_MAKEFLAGS) ' > . (var ('SUBDIRS') ? 'all-recursive' : 'all-am') > . "\n\n"); > depend ('.MAKE', 'all'); > diff --git a/lib/am/subdirs.am b/lib/am/subdirs.am > index 005483a..b430d21 100644 > --- a/lib/am/subdirs.am > +++ b/lib/am/subdirs.am > @@ -56,7 +56,7 @@ $(am__recursive_targets): > *) list='$(SUBDIRS)' ;; \ > esac; \ > for subdir in $$list; do \ > - echo "Making $$target in $$subdir"; \ > + $(AM_V_P) && echo "Making $$target in $$subdir"; \ > if test "$$subdir" = "."; then \ > dot_seen=yes; \ > local_target="$$target-am"; \ > -- 1.7.5.4 > Hmm... I fear that this change would actually make the makefile output *too* silent, possibly impeding debugging or problem diagnosis in a serious way. But I'm not sure if this is actually the case, or if I'm just being overly wary. Would any other automaker like to chime in with his opinion? Anyway, the best way to make an "informed decision" would be to try out Automake, patched with this diff, on few real-world package (GNU coreutils and GNU autoconf comes to mind), with GNU and non-GNU make implementations alike, and seeing how the make output looks when everything goes smoothly, and then how it looks when there are errors (e.g., errors compiling a file, permission errors modifying or creating a file, and even syntax errors in a subdir Makefile). Would you be willing to give this experiment a try, later posting here the output and impressions you get? This might be overkill for such a minor change however ... Waiting for feedback, Stefano
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.