GNU bug report logs - #12513
Should aclocal warn when picking up system-wide installed macros?

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 25 Sep 2012 07:23:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 25 03:23:23 2012
Received: from localhost ([127.0.0.1]:54290 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TGPUI-0003KD-Ge
	for submit <at> debbugs.gnu.org; Tue, 25 Sep 2012 03:23:23 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39325)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1TGPUG-0003K7-D4
	for submit <at> debbugs.gnu.org; Tue, 25 Sep 2012 03:23:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1TGPSK-0002Tw-N0
	for submit <at> debbugs.gnu.org; Tue, 25 Sep 2012 03:21:22 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_HI, T_DKIM_INVALID,
	URIBL_BLACK autolearn=ham version=3.3.2
Received: from lists.gnu.org ([208.118.235.17]:41074)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1TGPSK-0002Tm-JS
	for submit <at> debbugs.gnu.org; Tue, 25 Sep 2012 03:21:20 -0400
Received: from eggs.gnu.org ([208.118.235.92]:58777)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1TGPSB-0007tZ-2g
	for bug-automake@HIDDEN; Tue, 25 Sep 2012 03:21:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1TGPS6-0002SD-Uu
	for bug-automake@HIDDEN; Tue, 25 Sep 2012 03:21:11 -0400
Received: from mail-bk0-f41.google.com ([209.85.214.41]:37983)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefano.lattarini@HIDDEN>)
	id 1TGPS6-0002S0-JB; Tue, 25 Sep 2012 03:21:06 -0400
Received: by bkcjm1 with SMTP id jm1so33668bkc.0
	for <multiple recipients>; Tue, 25 Sep 2012 00:21:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:mime-version:to:cc:subject:references
	:in-reply-to:content-type:content-transfer-encoding;
	bh=bM1yUNU2AovIwA2dB1PhD3KL2TF/f0xvwlm/XjSyh5s=;
	b=oZt3doPUTUHDRgvutcHgfA1lZ5r2fCqTNQpyfLZ6RSUUwYjRIDJ1i+vBrpoKJqEmsc
	ZAcXi0kl+rG9nNyhweeH6LXldlGiYjHaxB6IkGHi3pIHqdK1Dd1ans3rQb5s3rL9O38W
	C1UPMRIq8VWQWy++a/IgeOIWCVWH0M+okQG8cSdqSt6Ur7LQLyBVZY9cK1WImEhKF7Zn
	OXEOakfmXSvFzrZrNA35CTT8ratDfOYfeJA0R1i84vb0U+QOSnlwp+XLviisiJCmSNC1
	H2OBo5pz1/KAMZSKo8nW2UcyEbgX0FG4sDVaVoDRq5c28UzmlCLHJE4hkTl74bXhlmhJ
	bIMg==
Received: by 10.204.130.152 with SMTP id t24mr50639bks.138.1348557665333;
	Tue, 25 Sep 2012 00:21:05 -0700 (PDT)
Received: from [192.168.178.21]
	(host194-94-dynamic.2-87-r.retail.telecomitalia.it. [87.2.94.194])
	by mx.google.com with ESMTPS id hy11sm2635571bkc.5.2012.09.25.00.21.03
	(version=SSLv3 cipher=OTHER); Tue, 25 Sep 2012 00:21:04 -0700 (PDT)
Message-ID: <50615B55.7060000@HIDDEN>
Date: Tue, 25 Sep 2012 09:20:53 +0200
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
MIME-Version: 1.0
To: Peter Johansson <trojkan@HIDDEN>
Subject: Should aclocal warn when picking up system-wide installed macros?
References: <5060F608.4000908@HIDDEN>
In-Reply-To: <5060F608.4000908@HIDDEN>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.17
X-Spam-Score: -4.4 (----)
X-Debbugs-Envelope-To: submit
Cc: bug-automake@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.4 (----)

Severity: wishlist

On 09/25/2012 02:08 AM, Peter Johansson wrote:
> Hi,
>
Hi Peter.  I'm moving this discussion to bug-automake so that we
won't forget about the issue.

> I just helped a co-developer who experienced a mysterious
> 
> autoreconf: Entering directory `.'
> autoreconf: configure.ac: not using Gettext
> autoreconf: running: aclocal --force
> autoreconf: configure.ac: tracing
> autoreconf: configure.ac: adding subdirectory c++ to autoreconf
> autoreconf: Entering directory `c++'
> autoreconf: configure.ac: not using Libtool
> autoreconf: running: /opt/local/bin/autoconf --force
> configure.ac:43: error: possibly undefined macro: AC_MSG_FAILURE
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> autoreconf: /opt/local/bin/autoconf failed with exit status: 1
> 
> 
> Line 43 in c++/configure.ac contained
> 
> YAT_CHECK_YAT([0.9.1], [], [AC_MSG_FAILURE([no yat found])])
> 
> which is a macro defined in c++/m4/yat.m4. After some investigation I
> realized the problem is that aclocal doesn't find 'yat.m4' and adding
> 
>     ACLOCAL_AMFLAGS = -I m4
> 
> in c++/Makefile.am solved the problem as expected. The annoying thing
> is that I did not see this problem because my aclocal finds yat.m4
> under /usr/local. I'm not sure what I'm asking for here, but it would
> be nice if I could have aclocal complain somehow in this scenario. Is
> it possible to tell aclocal to only pick up local files that it can
> m4_include into aclocal.m4? Only time I really wanna pick up installed
> m4 files is when I issue 'aclocal --install -I m4', or am I misusing
> aclocal?
>
I believe your request makes lot of sense.  We could add a new warning
'-Wglobal-macros' (say) that reports any picked-up m4 file that cannot
be 'm4_include'd into aclocal.m4.  And that warning could become active
by default in Automake 1.14 (assuming there will be a simple way to
disable it from 'autoreconf').  Of course, such a warning should be
disabled whenever the '--install' is used.

Also, having a way to turn that warning (and that warning only) into a
fatal error would allow us to enhance the 'distcheck' target to verify
that no non-distributed third-party m4 file is required to re-bootstrap
the package.

Not sure when I'll have time and will to pursue this though; in the
meantime, as usual, feedback and patches welcome.

And BTW, to save us from potentially wasted effort: can anyone think
of real-word use cases that would be hampered or broken by the proposal
above?

Regards,
  Stefano