GNU bug report logs - #12535
24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: "Drew Adams" <drew.adams@HIDDEN>; Keywords: patch; dated Fri, 28 Sep 2012 21:38:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 29 Apr 2016 13:06:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 29 09:06:04 2016
Received: from localhost ([127.0.0.1]:54085 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aw87Q-0008KH-7A
	for submit <at> debbugs.gnu.org; Fri, 29 Apr 2016 09:06:04 -0400
Received: from hermes.netfonds.no ([80.91.224.195]:54392)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1aw87P-0008KA-8y
 for 12535 <at> debbugs.gnu.org; Fri, 29 Apr 2016 09:06:03 -0400
Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse)
 by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <larsi@HIDDEN>)
 id 1aw874-0007lg-EZ; Fri, 29 Apr 2016 15:06:00 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#12535: 24.2.50;
 [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
 <87eh3ba7s9.fsf@HIDDEN>
 <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
 <877fhuej87.fsf@HIDDEN>
 <ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
 <87bn4t7ih6.fsf@HIDDEN>
 <2493efa4-e079-446c-8926-f7ee14c04ec9@default>
Date: Fri, 29 Apr 2016 15:05:42 +0200
In-Reply-To: <2493efa4-e079-446c-8926-f7ee14c04ec9@default> (Drew Adams's
 message of "Thu, 28 Apr 2016 17:32:49 -0700 (PDT)")
Message-ID: <87eg9oa7kp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

Drew Adams <drew.adams@HIDDEN> writes:

> See my previous comment.  If you don't want to make the
> one-line change required to fix this bug, too bad.

If you can't be bothered to test the code you're submitting, that's also
too bad.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 29 Apr 2016 00:33:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 28 20:33:00 2016
Received: from localhost ([127.0.0.1]:53768 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1avwMe-00017I-2P
	for submit <at> debbugs.gnu.org; Thu, 28 Apr 2016 20:33:00 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:47982)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1avwMd-000175-1q
 for 12535 <at> debbugs.gnu.org; Thu, 28 Apr 2016 20:32:59 -0400
Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])
 by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 u3T0Wqkt012335
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
 Fri, 29 Apr 2016 00:32:52 GMT
Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])
 by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u3T0Wpoa026379
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
 Fri, 29 Apr 2016 00:32:52 GMT
Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10])
 by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3T0WoCs002240;
 Fri, 29 Apr 2016 00:32:51 GMT
MIME-Version: 1.0
Message-ID: <2493efa4-e079-446c-8926-f7ee14c04ec9@default>
Date: Thu, 28 Apr 2016 17:32:49 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: RE: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for
 M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
 <87eh3ba7s9.fsf@HIDDEN>
 <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default> <877fhuej87.fsf@HIDDEN>
 <ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default> <87bn4t7ih6.fsf@HIDDEN>
In-Reply-To: <87bn4t7ih6.fsf@HIDDEN>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9  (901082) [OL
 12.0.6744.5000 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
X-Spam-Score: -3.3 (---)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> >> Can you submit a new patch, preferably tested?
> >
> > Sorry; I really don't have the time now.  But I think that all
> > of the relevant info has been provided, so you should be able
> > to DTRT.  The patch is quite tiny.  And it is unlikely that
> > the `edmacro-parse-keys' has changed much, if at all, since
> > 2014.  Just change \\TAB to \\|TAB in the patch.
>=20
> The patch you sent obviously hadn't been tested, because it was
> syntactically wrong.  I'm not going to apply patches that haven't been
> tested.
>=20
> Please create a new patch and post it here.

See my previous comment.  If you don't want to make the
one-line change required to fix this bug, too bad.

You've been working a lot on bugs today, which is great.
You're tired, and so am I.  And we are no doubt both busy
with other things too.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 28 Apr 2016 17:26:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 28 13:26:17 2016
Received: from localhost ([127.0.0.1]:53487 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1avphh-0008M2-1I
	for submit <at> debbugs.gnu.org; Thu, 28 Apr 2016 13:26:17 -0400
Received: from hermes.netfonds.no ([80.91.224.195]:32828)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1avphf-0008Lu-ME
 for 12535 <at> debbugs.gnu.org; Thu, 28 Apr 2016 13:26:16 -0400
Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse)
 by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <larsi@HIDDEN>)
 id 1avphd-0005Yn-9p; Thu, 28 Apr 2016 19:26:15 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#12535: 24.2.50;
 [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
 <87eh3ba7s9.fsf@HIDDEN>
 <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
 <877fhuej87.fsf@HIDDEN>
 <ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
Date: Thu, 28 Apr 2016 19:26:13 +0200
In-Reply-To: <ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default> (Drew Adams's
 message of "Wed, 24 Feb 2016 07:15:00 -0800 (PST)")
Message-ID: <87bn4t7ih6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

Drew Adams <drew.adams@HIDDEN> writes:

>> >> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
>> >> >          word))))
>> >> >           (setq key (list (intern word))))
>> >> >          ((or (equal word "REM") (string-match "^;;" word))
>> >> > --- 708,714 ----
>> >> >         (substring word (match-beginning 3)
>> >> >             (match-end 3))))
>> >> >           (not (string-match
>> >> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
>> >>
>> >> There's probably a missing | in the patch...
>> >
>> > Yes, good catch.  Should be \\|TAB, not \\TAB.
>> 
>> Can you submit a new patch, preferably tested?
>
> Sorry; I really don't have the time now.  But I think that all
> of the relevant info has been provided, so you should be able
> to DTRT.  The patch is quite tiny.  And it is unlikely that
> the `edmacro-parse-keys' has changed much, if at all, since
> 2014.  Just change \\TAB to \\|TAB in the patch.

The patch you sent obviously hadn't been tested, because it was
syntactically wrong.  I'm not going to apply patches that haven't been
tested.

Please create a new patch and post it here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 24 Feb 2016 15:15:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 24 10:15:09 2016
Received: from localhost ([127.0.0.1]:43984 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aYb9h-0003Qm-Lh
	for submit <at> debbugs.gnu.org; Wed, 24 Feb 2016 10:15:09 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:42529)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <drew.adams@HIDDEN>) id 1aYb9g-0003QY-4G
 for 12535 <at> debbugs.gnu.org; Wed, 24 Feb 2016 10:15:08 -0500
Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])
 by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 u1OFF2D0011393
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
 Wed, 24 Feb 2016 15:15:02 GMT
Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])
 by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u1OFF1Mf029878
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);
 Wed, 24 Feb 2016 15:15:02 GMT
Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])
 by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u1OFF1uJ006165;
 Wed, 24 Feb 2016 15:15:01 GMT
MIME-Version: 1.0
Message-ID: <ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
Date: Wed, 24 Feb 2016 07:15:00 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: RE: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for
 M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
 <87eh3ba7s9.fsf@HIDDEN>
 <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default> <877fhuej87.fsf@HIDDEN>
In-Reply-To: <877fhuej87.fsf@HIDDEN>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9  (901082) [OL
 12.0.6691.5000 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

> >> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
> >> >          word))))
> >> >           (setq key (list (intern word))))
> >> >          ((or (equal word "REM") (string-match "^;;" word))
> >> > --- 708,714 ----
> >> >         (substring word (match-beginning 3)
> >> >             (match-end 3))))
> >> >           (not (string-match
> >> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
> >>
> >> There's probably a missing | in the patch...
> >
> > Yes, good catch.  Should be \\|TAB, not \\TAB.
>=20
> Can you submit a new patch, preferably tested?

Sorry; I really don't have the time now.  But I think that all
of the relevant info has been provided, so you should be able
to DTRT.  The patch is quite tiny.  And it is unlikely that
the `edmacro-parse-keys' has changed much, if at all, since
2014.  Just change \\TAB to \\|TAB in the patch.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 24 Feb 2016 06:05:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 24 01:05:57 2016
Received: from localhost ([127.0.0.1]:42295 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aYSaD-00089L-KN
	for submit <at> debbugs.gnu.org; Wed, 24 Feb 2016 01:05:57 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:56948)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <larsi@HIDDEN>) id 1aYSaC-00089E-Em
 for 12535 <at> debbugs.gnu.org; Wed, 24 Feb 2016 01:05:56 -0500
Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161]
 helo=mouse)
 by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <larsi@HIDDEN>)
 id 1aYSZo-0002d7-MD; Wed, 24 Feb 2016 07:05:33 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>
Subject: Re: bug#12535: 24.2.50;
 [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
 <87eh3ba7s9.fsf@HIDDEN>
 <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
Date: Wed, 24 Feb 2016 17:05:28 +1100
In-Reply-To: <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default> (Drew Adams's
 message of "Sun, 9 Feb 2014 21:02:22 -0800 (PST)")
Message-ID: <877fhuej87.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1aYSZo-0002d7-MD
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@HIDDEN
MailScanner-NULL-Check: 1456898733.61298@LbtEA5lMM/omnPyYugiAjw
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

Drew Adams <drew.adams@HIDDEN> writes:

>> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
>> >          word))))
>> >           (setq key (list (intern word))))
>> >          ((or (equal word "REM") (string-match "^;;" word))
>> > --- 708,714 ----
>> >         (substring word (match-beginning 3)
>> >             (match-end 3))))
>> >           (not (string-match
>> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
>> 
>> There's probably a missing | in the patch...
>
> Yes, good catch.  Should be \\|TAB, not \\TAB.

Can you submit a new patch, preferably tested?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 10 Feb 2014 05:02:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 00:02:29 2014
Received: from localhost ([127.0.0.1]:33540 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1WCj0m-0007r3-RP
	for submit <at> debbugs.gnu.org; Mon, 10 Feb 2014 00:02:29 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:40495)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <drew.adams@HIDDEN>) id 1WCj0l-0007qw-4n
 for 12535 <at> debbugs.gnu.org; Mon, 10 Feb 2014 00:02:27 -0500
Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94])
 by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 s1A52PJl012770
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
 Mon, 10 Feb 2014 05:02:26 GMT
Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231])
 by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s1A52OSp004039
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Mon, 10 Feb 2014 05:02:25 GMT
Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11])
 by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1A52Oqt019799;
 Mon, 10 Feb 2014 05:02:24 GMT
MIME-Version: 1.0
Message-ID: <ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
Date: Sun, 9 Feb 2014 21:02:22 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: RE: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for
 M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
 <87eh3ba7s9.fsf@HIDDEN>
In-Reply-To: <87eh3ba7s9.fsf@HIDDEN>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8  (707110) [OL
 12.0.6680.5000 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: ucsinet22.oracle.com [156.151.31.94]
X-Spam-Score: -2.9 (--)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.9 (--)

> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
> >          word))))
> >           (setq key (list (intern word))))
> >          ((or (equal word "REM") (string-match "^;;" word))
> > --- 708,714 ----
> >         (substring word (match-beginning 3)
> >             (match-end 3))))
> >           (not (string-match
> > !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
>=20
> There's probably a missing | in the patch...

Yes, good catch.  Should be \\|TAB, not \\TAB.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at 12535 <at> debbugs.gnu.org:


Received: (at 12535) by debbugs.gnu.org; 10 Feb 2014 04:54:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 23:54:08 2014
Received: from localhost ([127.0.0.1]:33495 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1WCish-0006Q5-Hy
	for submit <at> debbugs.gnu.org; Sun, 09 Feb 2014 23:54:07 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:56472)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <larsi@HIDDEN>) id 1WCisf-0006Pv-Fj
 for 12535 <at> debbugs.gnu.org; Sun, 09 Feb 2014 23:54:05 -0500
Received: from [204.14.154.233] (helo=building.gnus.org)
 by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <larsi@HIDDEN>)
 id 1WCisR-0006FV-Bx; Mon, 10 Feb 2014 05:53:51 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Drew Adams" <drew.adams@HIDDEN>
Subject: Re: bug#12535: 24.2.50;
 [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
References: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
Date: Sun, 09 Feb 2014 20:52:38 -0800
In-Reply-To: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN> (Drew Adams's
 message of "Fri, 28 Sep 2012 14:37:30 -0700")
Message-ID: <87eh3ba7s9.fsf@HIDDEN>
User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1WCisR-0006FV-Bx
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@HIDDEN
MailScanner-NULL-Check: 1392612831.95989@5E/qE+rqRToR5CIij/O59w
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 12535
Cc: 12535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

"Drew Adams" <drew.adams@HIDDEN> writes:

> (kbd "M-<TAB>") incorrectly returns [M-TAB].  IMHO, it should return
> [134217737], the same thing that (kbd "M-TAB") returns.
>
> IOW, for consistency, TAB should be treated specially here, in the
> same way that NUL, RET, LFD, ESC, SPC, and DEL are treated specially.

Makes sense, I guess, but I'm not familiar with the `kbd' use cases.

[...]

> !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
>          word))))
>           (setq key (list (intern word))))
>          ((or (equal word "REM") (string-match "^;;" word))
> --- 708,714 ----
>         (substring word (match-beginning 3)
>             (match-end 3))))
>           (not (string-match
> !        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"

There's probably a missing | in the patch...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Sep 2012 21:37:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 28 17:37:55 2012
Received: from localhost ([127.0.0.1]:32775 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1THiFv-0003lE-E3
	for submit <at> debbugs.gnu.org; Fri, 28 Sep 2012 17:37:55 -0400
Received: from eggs.gnu.org ([208.118.235.92]:35354)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <drew.adams@HIDDEN>) id 1THiFt-0003l7-8D
	for submit <at> debbugs.gnu.org; Fri, 28 Sep 2012 17:37:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1THiFg-0007CM-PH
	for submit <at> debbugs.gnu.org; Fri, 28 Sep 2012 17:37:41 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2
Received: from lists.gnu.org ([208.118.235.17]:42961)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1THiFg-0007CI-Lw
	for submit <at> debbugs.gnu.org; Fri, 28 Sep 2012 17:37:40 -0400
Received: from eggs.gnu.org ([208.118.235.92]:53222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1THiFf-0000aj-Ok
	for bug-gnu-emacs@HIDDEN; Fri, 28 Sep 2012 17:37:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1THiFe-0007C6-K7
	for bug-gnu-emacs@HIDDEN; Fri, 28 Sep 2012 17:37:39 -0400
Received: from acsinet15.oracle.com ([141.146.126.227]:37369)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1THiFe-0007C2-EA
	for bug-gnu-emacs@HIDDEN; Fri, 28 Sep 2012 17:37:38 -0400
Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94])
	by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with
	ESMTP id q8SLbZLR000554
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <bug-gnu-emacs@HIDDEN>; Fri, 28 Sep 2012 21:37:36 GMT
Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158])
	by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	q8SLbYVx011949
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <bug-gnu-emacs@HIDDEN>; Fri, 28 Sep 2012 21:37:35 GMT
Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58])
	by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id
	q8SLbYPL028688
	for <bug-gnu-emacs@HIDDEN>; Fri, 28 Sep 2012 16:37:34 -0500
Received: from dradamslap1 (/10.159.184.33)
	by default (Oracle Beehive Gateway v4.0)
	with ESMTP ; Fri, 28 Sep 2012 14:37:34 -0700
From: "Drew Adams" <drew.adams@HIDDEN>
To: <bug-gnu-emacs@HIDDEN>
Subject: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
Date: Fri, 28 Sep 2012 14:37:30 -0700
Message-ID: <584510D2C7DE47CBAE19B5058B21B51C@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 11
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Thread-Index: Ac2dwXY47w34iWZXR+OaF+upKt0G7Q==
X-Source-IP: ucsinet22.oracle.com [156.151.31.94]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.17
X-Spam-Score: -6.1 (------)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.1 (------)

(kbd "M-<TAB>") incorrectly returns [M-TAB].  IMHO, it should return
[134217737], the same thing that (kbd "M-TAB") returns.
 
IOW, for consistency, TAB should be treated specially here, in the
same way that NUL, RET, LFD, ESC, SPC, and DEL are treated specially.
 
Yes, it is true that there is no predefined function key named `NUL'
etc.  But there is also no predefined function key named `TAB'.  The
predefined function key is named `tab', not `TAB'.  `M-<tab>' is not the
same thing as `M-<TAB>', of course.  It is better to help users avoid
such possible confusion by treating `TAB' the same way we treat `NUL' etc.
 

diff -c edmacro.el edmacro-patched.el
*** edmacro.el Fri Sep 28 13:55:18 2012
--- edmacro-patched.el Fri Sep 28 13:56:24 2012
***************
*** 708,714 ****
        (substring word (match-beginning 3)
            (match-end 3))))
          (not (string-match
!        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
         word))))
          (setq key (list (intern word))))
         ((or (equal word "REM") (string-match "^;;" word))
--- 708,714 ----
        (substring word (match-beginning 3)
            (match-end 3))))
          (not (string-match
!        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
         word))))
          (setq key (list (intern word))))
         ((or (equal word "REM") (string-match "^;;" word))
 
Diff finished.  Fri Sep 28 13:56:44 2012
 
 
In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
 of 2012-09-17 on MARVIN
Bzr revision: 110062 cyd@HIDDEN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 





Acknowledgement sent to "Drew Adams" <drew.adams@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#12535; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 29 Apr 2016 13:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.