GNU bug report logs - #12585
diff refine should highlight space changes better (feature request)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Le Wang <l26wang@HIDDEN>; dated Sat, 6 Oct 2012 15:27:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 12585 <at> debbugs.gnu.org:


Received: (at 12585) by debbugs.gnu.org; 8 Oct 2012 14:26:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 08 10:26:37 2012
Received: from localhost ([127.0.0.1]:33647 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TLEI1-0000av-AB
	for submit <at> debbugs.gnu.org; Mon, 08 Oct 2012 10:26:37 -0400
Received: from mail-qa0-f51.google.com ([209.85.216.51]:52504)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <l26wang@HIDDEN>) id 1TLEHz-0000ah-6p
	for 12585 <at> debbugs.gnu.org; Mon, 08 Oct 2012 10:26:36 -0400
Received: by mail-qa0-f51.google.com with SMTP id j40so2459649qab.3
	for <12585 <at> debbugs.gnu.org>; Mon, 08 Oct 2012 07:26:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=+jJsskYBopOJe2W0CdZcjP4XdBWb4LNVxX2arheGhF8=;
	b=Zu483wU2VE3lIZZMyDPjkUv+np/zfSMCQfZrUiNCa1a3TJ6YrjLQi02J3Gk3wZQWIE
	8fXthYZyZyE+IyBqA8ca1HR0ivUE3QEeRxwpR4N6MVVqgnNQwGrt+i0h8Iw7SSL3Je1l
	rS8x/E3bcUWN5hbN5rQIY9CZyBfqoOnFcYaT8ozYDYg7guu/+XZPn1b/QgRat/LvhDDu
	yjygVFAT/PvFqD8jzYJPuVLTlS/BjebTEZ9CdolhfzBURUPPgqbhkNwtx7JUvmwcjlLX
	pn4TViUsgC38IadovInhR4+7YMcxkCJEeRHBUA7rvd2eS2ay/ROX0rr84fuTCpmLc4g3
	fqFQ==
MIME-Version: 1.0
Received: by 10.229.77.224 with SMTP id h32mr2763528qck.59.1349706360744; Mon,
	08 Oct 2012 07:26:00 -0700 (PDT)
Received: by 10.49.50.7 with HTTP; Mon, 8 Oct 2012 07:26:00 -0700 (PDT)
In-Reply-To: <87sj9qr5ba.fsf@HIDDEN>
References: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
	<874nm7e8ul.fsf@HIDDEN>
	<CAM=K+iqBJMf_PUr9v-gEqgTKM=Sh0-E-R-R_Npi+LyuP5VnnLg@HIDDEN>
	<87sj9qr5ba.fsf@HIDDEN>
Date: Mon, 8 Oct 2012 22:26:00 +0800
Message-ID: <CAM=K+ioCBOvKpjDVzqtUQusGpi=NsxArEzpsab2tabs-8+X-PQ@HIDDEN>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
From: Le Wang <l26wang@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 12585
Cc: 12585 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: 0.1 (/)

On Sun, Oct 7, 2012 at 5:37 PM, Juri Linkov <juri@HIDDEN> wrote:
> `C-c C-b' in diff uses `smerge-refine-ignore-whitespace' from smerge.
> Perhaps diff should have a duplicate option `diff-refine-ignore-whitespace'
> with the same functionality but a different name prefix.

I see.  I didn't have a background set in my theme.  Thanks for the pointer.

The setting should be a defcustom in diff group so it's easier to discover.

-- 
Le




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.

Message received at 12585 <at> debbugs.gnu.org:


Received: (at 12585) by debbugs.gnu.org; 7 Oct 2012 14:10:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 07 10:10:25 2012
Received: from localhost ([127.0.0.1]:60120 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TKrYm-0003zG-Qa
	for submit <at> debbugs.gnu.org; Sun, 07 Oct 2012 10:10:25 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20196)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <monnier@HIDDEN>) id 1TKrYl-0003z3-67
	for 12585 <at> debbugs.gnu.org; Sun, 07 Oct 2012 10:10:23 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLQG/2dsb2JhbABEtBGBCIIVAQEEAVYjEAs0EhQYDSSIHAW6CZBEA6MzgViDBQ
X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200827136"
Received: from 69-196-180-6.dsl.teksavvy.com (HELO pastel.home)
	([69.196.180.6])
	by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
	07 Oct 2012 10:09:54 -0400
Received: by pastel.home (Postfix, from userid 20848)
	id AAEFA594D1; Sun,  7 Oct 2012 10:09:54 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Message-ID: <jwvtxu6wezn.fsf-monnier+emacs@HIDDEN>
References: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
	<874nm7e8ul.fsf@HIDDEN>
	<CAM=K+iqBJMf_PUr9v-gEqgTKM=Sh0-E-R-R_Npi+LyuP5VnnLg@HIDDEN>
	<87sj9qr5ba.fsf@HIDDEN>
Date: Sun, 07 Oct 2012 10:09:54 -0400
In-Reply-To: <87sj9qr5ba.fsf@HIDDEN> (Juri Linkov's message of "Sun,
	07 Oct 2012 12:37:29 +0300")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.8 (/)
X-Debbugs-Envelope-To: 12585
Cc: 12585 <at> debbugs.gnu.org, Le Wang <l26wang@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: 0.8 (/)

>>> Inline space changes can be highlighted after setting
>>> `smerge-refine-ignore-whitespace' to nil
>>> (maybe it should be defcustom instead of defvar?)
>> How would I use smerge in this context?  I'm just pressing C-c C-b to
>> refine a diff hunk right now.
> `C-c C-b' in diff uses `smerge-refine-ignore-whitespace' from smerge.
> Perhaps diff should have a duplicate option `diff-refine-ignore-whitespace'
> with the same functionality but a different name prefix.


Or rather, the refinement code should be taken out of smerge into its
own package.


        Stefan




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.

Message received at 12585 <at> debbugs.gnu.org:


Received: (at 12585) by debbugs.gnu.org; 7 Oct 2012 09:42:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 07 05:42:23 2012
Received: from localhost ([127.0.0.1]:59048 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TKnNP-0001vg-0o
	for submit <at> debbugs.gnu.org; Sun, 07 Oct 2012 05:42:23 -0400
Received: from ps18281.dreamhost.com ([69.163.218.105]:60919
	helo=ps18281.dreamhostps.com)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <juri@HIDDEN>) id 1TKnNM-0001vX-Ky
	for 12585 <at> debbugs.gnu.org; Sun, 07 Oct 2012 05:42:21 -0400
Received: from localhost (ps18281.dreamhostps.com [69.163.218.105])
	by ps18281.dreamhostps.com (Postfix) with ESMTP id A4A99451E16B;
	Sun,  7 Oct 2012 02:41:57 -0700 (PDT)
From: Juri Linkov <juri@HIDDEN>
To: Le Wang <l26wang@HIDDEN>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Organization: JURTA
References: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
	<874nm7e8ul.fsf@HIDDEN>
	<CAM=K+iqBJMf_PUr9v-gEqgTKM=Sh0-E-R-R_Npi+LyuP5VnnLg@HIDDEN>
Date: Sun, 07 Oct 2012 12:37:29 +0300
In-Reply-To: <CAM=K+iqBJMf_PUr9v-gEqgTKM=Sh0-E-R-R_Npi+LyuP5VnnLg@HIDDEN>
	(Le Wang's message of "Sun, 7 Oct 2012 10:36:18 +0800")
Message-ID: <87sj9qr5ba.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.8 (/)
X-Debbugs-Envelope-To: 12585
Cc: 12585 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: 0.8 (/)

>> Inline space changes can be highlighted after setting
>> `smerge-refine-ignore-whitespace' to nil
>> (maybe it should be defcustom instead of defvar?)
>
> How would I use smerge in this context?  I'm just pressing C-c C-b to
> refine a diff hunk right now.

`C-c C-b' in diff uses `smerge-refine-ignore-whitespace' from smerge.
Perhaps diff should have a duplicate option `diff-refine-ignore-whitespace'
with the same functionality but a different name prefix.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.

Message received at 12585 <at> debbugs.gnu.org:


Received: (at 12585) by debbugs.gnu.org; 7 Oct 2012 02:36:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 06 22:36:49 2012
Received: from localhost ([127.0.0.1]:58834 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TKgjZ-0008BW-0d
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 22:36:49 -0400
Received: from mail-qc0-f172.google.com ([209.85.216.172]:52701)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <l26wang@HIDDEN>) id 1TKgjT-0008BH-Up
	for 12585 <at> debbugs.gnu.org; Sat, 06 Oct 2012 22:36:46 -0400
Received: by mail-qc0-f172.google.com with SMTP id c10so2385820qca.3
	for <12585 <at> debbugs.gnu.org>; Sat, 06 Oct 2012 19:36:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=v9cFvNDTVeQPevJPTUpIPz4eLuDGj2IY1RqJKk2Gxq8=;
	b=MIpUyrXto8UmkzlQEZwpX3dHwq7lDDcAeFeEEg0uqc4m2mmZr6x75XXZVBzWZ/adoz
	PH9l47qkMeVsYx7OhZkVGlOGINqfq5G9LTpMJLiGacNQuQJG5JyUW9Vj2pg1wtBM6bc2
	OZ1Gf62ygt3xDONSDh9RDL4SE7Thfy2V9XQB1GUL+6oSOxB6OHDOa2343BxKz9lpy/up
	fv8sksq8KxVV4w9tl0a5wr5nERb3iLSxPnNTVwzgvqbnXeP9pT6e6P/ioqdcYVxPl1RX
	Ol5cuF5ELDxVSy73Db54foOeb+YujsDAVCxQSoLrtKCx79qaLec0+vY9XLPP4/CpI3ui
	p6LA==
MIME-Version: 1.0
Received: by 10.224.100.134 with SMTP id y6mr1947225qan.87.1349577378649; Sat,
	06 Oct 2012 19:36:18 -0700 (PDT)
Received: by 10.49.50.7 with HTTP; Sat, 6 Oct 2012 19:36:18 -0700 (PDT)
In-Reply-To: <874nm7e8ul.fsf@HIDDEN>
References: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
	<874nm7e8ul.fsf@HIDDEN>
Date: Sun, 7 Oct 2012 10:36:18 +0800
Message-ID: <CAM=K+iqBJMf_PUr9v-gEqgTKM=Sh0-E-R-R_Npi+LyuP5VnnLg@HIDDEN>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
From: Le Wang <l26wang@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Content-Type: text/plain; charset=ISO-8859-1
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 12585
Cc: 12585 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: 0.1 (/)

On Sun, Oct 7, 2012 at 3:00 AM, Juri Linkov <juri@HIDDEN> wrote:
>> In fact, we should be able to do better than magit
>> and highlight inline space changes as well.
>
> Inline space changes can be highlighted after setting
> `smerge-refine-ignore-whitespace' to nil
> (maybe it should be defcustom instead of defvar?)

How would I use smerge in this context?  I'm just pressing C-c C-b to
refine a diff hunk right now.

-- 
Le




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.

Message received at 12585 <at> debbugs.gnu.org:


Received: (at 12585) by debbugs.gnu.org; 6 Oct 2012 19:02:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 06 15:02:24 2012
Received: from localhost ([127.0.0.1]:58614 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TKZdo-0003p4-5s
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 15:02:24 -0400
Received: from ps18281.dreamhost.com ([69.163.218.105]:37853
	helo=ps18281.dreamhostps.com)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <juri@HIDDEN>) id 1TKZdl-0003ov-Mv
	for 12585 <at> debbugs.gnu.org; Sat, 06 Oct 2012 15:02:22 -0400
Received: from localhost (ps18281.dreamhostps.com [69.163.218.105])
	by ps18281.dreamhostps.com (Postfix) with ESMTP id 57B2C451C1AC;
	Sat,  6 Oct 2012 12:02:02 -0700 (PDT)
From: Juri Linkov <juri@HIDDEN>
To: Le Wang <l26wang@HIDDEN>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Organization: JURTA
References: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
Date: Sat, 06 Oct 2012 22:00:10 +0300
In-Reply-To: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
	(Le Wang's message of "Sat, 6 Oct 2012 23:25:33 +0800")
Message-ID: <874nm7e8ul.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.8 (/)
X-Debbugs-Envelope-To: 12585
Cc: 12585 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: 0.8 (/)

> In fact, we should be able to do better than magit
> and highlight inline space changes as well.

Inline space changes can be highlighted after setting
`smerge-refine-ignore-whitespace' to nil
(maybe it should be defcustom instead of defvar?)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.

Message received at 12585 <at> debbugs.gnu.org:


Received: (at 12585) by debbugs.gnu.org; 6 Oct 2012 16:08:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 06 12:08:20 2012
Received: from localhost ([127.0.0.1]:58377 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TKWvL-0008DB-Ll
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 12:08:19 -0400
Received: from chene.dit.umontreal.ca ([132.204.246.20]:52703)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <monnier@HIDDEN>) id 1TKWvJ-0008D4-4L
	for 12585 <at> debbugs.gnu.org; Sat, 06 Oct 2012 12:08:17 -0400
Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca
	[132.204.27.242])
	by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q96G7xwa026595; 
	Sat, 6 Oct 2012 12:07:59 -0400
Received: by faina.iro.umontreal.ca (Postfix, from userid 20848)
	id B1444B40A1; Sat,  6 Oct 2012 12:07:59 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Le Wang <l26wang@HIDDEN>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Message-ID: <jwvbogfoaah.fsf-monnier+emacs@HIDDEN>
References: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
Date: Sat, 06 Oct 2012 12:07:59 -0400
In-Reply-To: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
	(Le Wang's message of "Sat, 6 Oct 2012 23:25:33 +0800")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: 12585
Cc: 12585 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -1.4 (-)

> When I diff from magit, it highlights spaces at EOL. see: http://puu.sh/1bY8l
> The default diff refinining does not do that.  In fact, we should be
> able to do better than magit and highlight inline space changes as
> well.

AFAIK Emacs-24's diff-mode does that as well, regardless of diff-refine-hunk.


        Stefan




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Oct 2012 15:26:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 06 11:26:02 2012
Received: from localhost ([127.0.0.1]:58341 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TKWGQ-0006Px-3x
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 11:26:02 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45741)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <l26wang@HIDDEN>) id 1TKWGN-0006Ph-E2
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 11:26:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l26wang@HIDDEN>) id 1TKWG0-0004fm-Lk
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 11:25:37 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_HI, T_DKIM_INVALID,
	URIBL_SBL autolearn=unavailable version=3.3.2
Received: from lists.gnu.org ([208.118.235.17]:36537)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l26wang@HIDDEN>) id 1TKWG0-0004fi-Ii
	for submit <at> debbugs.gnu.org; Sat, 06 Oct 2012 11:25:36 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45080)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l26wang@HIDDEN>) id 1TKWFz-0004sF-Ke
	for bug-gnu-emacs@HIDDEN; Sat, 06 Oct 2012 11:25:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <l26wang@HIDDEN>) id 1TKWFy-0004dZ-Hi
	for bug-gnu-emacs@HIDDEN; Sat, 06 Oct 2012 11:25:35 -0400
Received: from mail-qa0-f48.google.com ([209.85.216.48]:50420)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <l26wang@HIDDEN>) id 1TKWFy-0004dJ-Dj
	for bug-gnu-emacs@HIDDEN; Sat, 06 Oct 2012 11:25:34 -0400
Received: by mail-qa0-f48.google.com with SMTP id c11so1285093qad.0
	for <bug-gnu-emacs@HIDDEN>; Sat, 06 Oct 2012 08:25:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:date:message-id:subject:from:to:content-type;
	bh=rqNHcG6w7LX4C8tWulM0ZvtDkoZXvrVvy+yggiPil+E=;
	b=JipaAp9U3O9agllkLeo6abzV4bmx8Er7X5T0sIkMvuT1SP9abKjaFYZGMdSA+aAdLC
	OnyvPNv8UWqWVG/VW8Nh9pN/HBwpNwRuDcRq6nMxPpCMWcxIsb2daiQmFusGx+PJqJbS
	UYJqjS6CNi/FPRG7JFa7Xn7NrW0IJoNzvmlhql+aO6i8Q2UFC86sx/gEO6ICki2RE4TZ
	bHhXlPEUE0Zd2zlZuPB75PhIjSekAkhxLpBvHwIWZNw9cO9yukZzgu1l92yGbeh4MaBF
	3y3ANAHpEAqC8J92+4pyCMbqFZoyod/GmeL9m2dEaqDhlTFTc9gnYio2Gh7cdCLDcZiM
	Kakw==
MIME-Version: 1.0
Received: by 10.49.85.202 with SMTP id j10mr32216519qez.59.1349537133895; Sat,
	06 Oct 2012 08:25:33 -0700 (PDT)
Received: by 10.49.50.7 with HTTP; Sat, 6 Oct 2012 08:25:33 -0700 (PDT)
Date: Sat, 6 Oct 2012 23:25:33 +0800
Message-ID: <CAM=K+irJScB89hHF8fdUFbd4LfW50WsB51OpDrLmMCX2dNo=Vg@HIDDEN>
Subject: diff refine should highlight space changes better (feature request)
From: Le Wang <l26wang@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.17
X-Spam-Score: -1.8 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -1.8 (-)

When I diff from magit, it highlights spaces at EOL. see: http://puu.sh/1bY8l

The default diff refinining does not do that.  In fact, we should be
able to do better than magit and highlight inline space changes as
well.


-- 
Le




Acknowledgement sent to Le Wang <l26wang@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#12585; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.