GNU bug report logs - #12585
diff refine should highlight space changes better (feature request)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12585 in the body.
You can then email your comments to 12585 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Le Wang <l26wang <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: diff refine should highlight space changes better (feature request)
Date: Sat, 6 Oct 2012 23:25:33 +0800

When I diff from magit, it highlights spaces at EOL. see: http://puu.sh/1bY8l

The default diff refinining does not do that.  In fact, we should be
able to do better than magit and highlight inline space changes as
well.


-- 
Le

Message #8 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Le Wang <l26wang <at> gmail.com>
Cc: 12585 <at> debbugs.gnu.org
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Date: Sat, 06 Oct 2012 12:07:59 -0400

> When I diff from magit, it highlights spaces at EOL. see: http://puu.sh/1bY8l
> The default diff refinining does not do that.  In fact, we should be
> able to do better than magit and highlight inline space changes as
> well.

AFAIK Emacs-24's diff-mode does that as well, regardless of diff-refine-hunk.


        Stefan

Message #11 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Le Wang <l26wang <at> gmail.com>
Cc: 12585 <at> debbugs.gnu.org
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Date: Sat, 06 Oct 2012 22:00:10 +0300

> In fact, we should be able to do better than magit
> and highlight inline space changes as well.

Inline space changes can be highlighted after setting
`smerge-refine-ignore-whitespace' to nil
(maybe it should be defcustom instead of defvar?)

Message #14 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Le Wang <l26wang <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12585 <at> debbugs.gnu.org
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Date: Sun, 7 Oct 2012 10:36:18 +0800

On Sun, Oct 7, 2012 at 3:00 AM, Juri Linkov <juri <at> jurta.org> wrote:
>> In fact, we should be able to do better than magit
>> and highlight inline space changes as well.
>
> Inline space changes can be highlighted after setting
> `smerge-refine-ignore-whitespace' to nil
> (maybe it should be defcustom instead of defvar?)

How would I use smerge in this context?  I'm just pressing C-c C-b to
refine a diff hunk right now.

-- 
Le

Message #17 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Le Wang <l26wang <at> gmail.com>
Cc: 12585 <at> debbugs.gnu.org
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Date: Sun, 07 Oct 2012 12:37:29 +0300

>> Inline space changes can be highlighted after setting
>> `smerge-refine-ignore-whitespace' to nil
>> (maybe it should be defcustom instead of defvar?)
>
> How would I use smerge in this context?  I'm just pressing C-c C-b to
> refine a diff hunk right now.

`C-c C-b' in diff uses `smerge-refine-ignore-whitespace' from smerge.
Perhaps diff should have a duplicate option `diff-refine-ignore-whitespace'
with the same functionality but a different name prefix.

Message #20 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12585 <at> debbugs.gnu.org, Le Wang <l26wang <at> gmail.com>
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Date: Sun, 07 Oct 2012 10:09:54 -0400

>>> Inline space changes can be highlighted after setting
>>> `smerge-refine-ignore-whitespace' to nil
>>> (maybe it should be defcustom instead of defvar?)
>> How would I use smerge in this context?  I'm just pressing C-c C-b to
>> refine a diff hunk right now.
> `C-c C-b' in diff uses `smerge-refine-ignore-whitespace' from smerge.
> Perhaps diff should have a duplicate option `diff-refine-ignore-whitespace'
> with the same functionality but a different name prefix.


Or rather, the refinement code should be taken out of smerge into its
own package.


        Stefan

Message #23 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Le Wang <l26wang <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 12585 <at> debbugs.gnu.org
Subject: Re: bug#12585: diff refine should highlight space changes better
	(feature request)
Date: Mon, 8 Oct 2012 22:26:00 +0800

On Sun, Oct 7, 2012 at 5:37 PM, Juri Linkov <juri <at> jurta.org> wrote:
> `C-c C-b' in diff uses `smerge-refine-ignore-whitespace' from smerge.
> Perhaps diff should have a duplicate option `diff-refine-ignore-whitespace'
> with the same functionality but a different name prefix.

I see.  I didn't have a background set in my theme.  Thanks for the pointer.

The setting should be a defcustom in diff group so it's easier to discover.

-- 
Le

Message #26 received at 12585 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Le Wang <l26wang <at> gmail.com>
Cc: Juri Linkov <juri <at> jurta.org>, 12585 <at> debbugs.gnu.org
Subject: Re: bug#12585: diff refine should highlight space changes better
 (feature request)
Date: Wed, 26 Jan 2022 18:55:10 +0100

Le Wang <l26wang <at> gmail.com> writes:

> I see.  I didn't have a background set in my theme.  Thanks for the pointer.
>
> The setting should be a defcustom in diff group so it's easier to discover.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

I've now done this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.