GNU bug report logs - #12857
rcirc.el: make default PART and QUIT reasons customizable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12857 in the body.
You can then email your comments to 12857 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Ralston <wubbulous <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: rcirc.el: make default PART and QUIT reasons customizable
Date: Sat, 10 Nov 2012 13:43:52 -0800

[Message part 1 (text/plain, inline)]

If no other reason is given for parting or quitting with
rcirc-cmd-part or rcirc-cmd-quit, rcirc will use the value of
rcirc-id-string: "rcirc on GNU Emacs <version>". Kinda stuffy.

This patch adds two customizable variables to rcirc:
rcirc-default-part-reason and rcirc-default-quit-reason. The above
commands will use these variables as the default part/quit reason if
they are set. If they are left nil, rcirc will fallback to its current
behaviour, and use the value of rcirc-id-string.


Changelog entry:

2012-11-10  Daniel Ralston  <Wubbulous <at> gmail.com>

    * rcirc.el: Make the default PART and QUIT reasons used by
    rcirc-cmd-part and rcirc-cmd-quit customizable.
    (rcirc-default-part-reason,rcirc-default-quit-reason): New
    customizable vars.

[rcirc-default-reasons.patch (application/octet-stream, attachment)]

Message #8 received at 12857 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz <at> dogan.se>
To: 12857 <at> debbugs.gnu.org
Subject: Re: rcirc.el: make default PART and QUIT reasons customizable
Date: Fri, 23 Nov 2012 18:25:30 +0100

Hi, Daniel

This is a good patch! In my opinion it would be nicer if we use a 
composite customization type for rcirc-default-part-reason and 
rcirc-default-quit-reason, letting the user choose between the default 
(rcirc-id-string) and a custom message.

What do you think about this idea?  Would you be willing to write a new 
patch implementing this instead?

Cheers,
Deniz

Message #11 received at 12857 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Ralston <wubbulous <at> gmail.com>
To: 12857 <at> debbugs.gnu.org
Cc: deniz <at> dogan.se
Subject: Re: Re: rcirc.el: make default PART and QUIT reasons customizable
Date: Thu, 13 Dec 2012 07:05:08 -0800

[Message part 1 (text/plain, inline)]

Hi Deniz,

Sorry for my glacially tardy response.
That's a much cleaner way of doing it. I hadn't really looked into
composite types before, so thanks for the suggestion! I have attached the
new patch file to this message. Let me know what you think, and if you'd
like me to tweak it any further. I'll try to respond more promptly next
time.

    Daniel

Changelog entry:

2012-11-10  Daniel Ralston  <Wubbulous <at> gmail.com>

    * rcirc.el: Make the default PART and QUIT reasons used by
    rcirc-cmd-part and rcirc-cmd-quit customizable.
    (rcirc-default-part-reason,rcirc-default-quit-reason): New
    customizable vars.


Subject: Re: rcirc.el: make default PART and QUIT reasons customizable
> Date: Fri, 23 Nov 2012 18:25:30 +0100
> From: Deniz Dogan <deniz <at> dogan.se>
> To: 12857 <at> debbugs.gnu.org
>
> Hi, Daniel
>
> This is a good patch! In my opinion it would be nicer if we use a
> composite customization type for rcirc-default-part-reason and
> rcirc-default-quit-reason, letting the user choose between the default
> (rcirc-id-string) and a custom message.
>
> What do you think about this idea?  Would you be willing to write a new
> patch implementing this instead?
>
> Cheers,
> Deniz
>
>
>
>

[Message part 2 (text/html, inline)]

[rcirc-default-part-quit-reasons.patch (application/octet-stream, attachment)]

Message #14 received at 12857 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Daniel Ralston <wubbulous <at> gmail.com>
Cc: 12857 <at> debbugs.gnu.org, deniz <at> dogan.se
Subject: Re: bug#12857: Re: rcirc.el: make default PART and QUIT reasons
 customizable
Date: Wed, 24 Feb 2016 17:02:59 +1100

Daniel Ralston <wubbulous <at> gmail.com> writes:

> Sorry for my glacially tardy response.
> That's a much cleaner way of doing it. I hadn't really looked into composite types before, so thanks for the suggestion! I have attached
> the new patch file to this message. Let me know what you think, and if you'd like me to tweak it any further. I'll try to respond more
> promptly next time.
>
> Daniel
>
> Changelog entry:
>
> 2012-11-10 Daniel Ralston <Wubbulous <at> gmail.com>
>
> * rcirc.el: Make the default PART and QUIT reasons used by
> rcirc-cmd-part and rcirc-cmd-quit customizable.
> (rcirc-default-part-reason,rcirc-default-quit-reason): New
> customizable vars.
>
>  Subject: Re: rcirc.el: make default PART and QUIT reasons customizable
>  Date: Fri, 23 Nov 2012 18:25:30 +0100
>  From: Deniz Dogan <deniz <at> dogan.se>
>  To: 12857 <at> debbug=, 12857 <at> debbugs.gnu.org s.gnu.org

That was three years ago.  :-)  Deniz, did you have a look at the respun
patch, and does it look OK?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 12857 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Daniel Ralston <wubbulous <at> gmail.com>
Cc: 12857 <at> debbugs.gnu.org, deniz <at> dogan.se
Subject: Re: bug#12857: Re: rcirc.el: make default PART and QUIT reasons
 customizable
Date: Sat, 01 Jun 2019 20:11:52 -0400

tags 12857 fixed
close 12857 27.1
quit

Daniel Ralston <wubbulous <at> gmail.com> writes:

> That's a much cleaner way of doing it. I hadn't really looked into
> composite types before, so thanks for the suggestion!

>> This is a good patch! In my opinion it would be nicer if we use a
>> composite customization type for rcirc-default-part-reason and
>> rcirc-default-quit-reason, letting the user choose between the default
>> (rcirc-id-string) and a custom message.

I removed the part that puts the default into the customization type,
since the customization machinery already handles default values just
fine.  Pushed to master, with followup NEWS entry.

aa9d57eed1 2019-06-01T20:01:43-04:00 "; Add NEWS entry for previous change"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=aa9d57eed17ee6a8006c9cdd4f8636100482cd71

d3f14ffae4 2019-06-01T20:01:43-04:00 "Make rcirc PART and QUIT reasons customizable (Bug#12857)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d3f14ffae4078688a57acdff30fdd91747386f17

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.