GNU logs - #12946, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: ams@HIDDEN (Alfred M. Szmidt)
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 18:08:01 +0000
Resent-Message-ID: <handler.12946.B.135343484529883 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 12946 <at> debbugs.gnu.org
Reply-To: ams@HIDDEN
Date: Tue, 20 Nov 2012 13:06:03 -0500
Message-Id: <E1TasCx-0003uA-P8@HIDDEN>
From: ams@HIDDEN (Alfred M. Szmidt)
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

It would be useful if log-edit-insert-changelog would add a
`description line' from ChangeLog, that is the first line right before
date/author.  For example doing the following:

1) Opened a random file under VC.
2) Do M-x add-change-log-entry-other-window, and add something like

   2012-11-16  Alfred M. Szmidt  <ams@HIDDEN>

	This is a deccription line.

	* random-file: New file.

3) Save ChangeLog
4) Save random file.
5) M-x vc-dir
6) Mark random file and ChangeLog.
7) M-x vc-next-action
8) In *vc-log*, M-x log-edit-insert-changelog.

Will result in either noting showing up in *vc-log*, or you get,

  * random-file: New file.

What would be useful is that you got the description line inserted
instead, with nothing following it.  This is common practise when
working with various distributed version control systems where the
commit entry only contains a brief description of the change, and the
ChangeLog contains the detailed information.

In GNU Emacs 23.2.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2010-12-11 on brahms, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
configured using `configure  '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
e a d , C-k C-k C-k SPC t h i s SPC i s <M-backspace> 
<M-backspace> w i t h SPC n o t h i n g SPC f o l l 
o w i n g SPC i t . M-q SPC SPC T h i s SPC i s SPC 
c o m m o n SPC p r a c t i s e SPC w h e n SPC w o 
r k i n g SPC w i t h SPC v a r i o u s SPC d i s t 
s <backspace> <M-backspace> d i s t r i b u t e d SPC 
v e r s i o n SPC c o n t r o l SPC s y s t e m s . 
<backspace> SPC w h e r e SPC t h e SPC c o m m i t 
SPC e n t r y SPC o n l y SPC c o n t a i n s SPC a 
SPC b r i e f SPC d e s c r i p t i o n SPC o f SPC 
t h e SPC c h a n g e , SPC a n d SPC t h e SPC C h 
a n g e L o g SPC c o n t a i n s SPC t h e SPC d e 
t a i l e d SPC i n f o r m a t i o n . <escape> q 
C-x h M-w C-x b C-g C-x C-g M-x r e p o t <tab> <backspace> 
<backspace> <backspace> <backspace> <backspace> C-g 
C-g M-x r e p o r t - b <tab> <return>

Recent messages:
Mark set [3 times]
Auto-saving...done
Mark set
Ispell process killed
Computing summary lines...done
(No new mail has arrived)
Computing summary lines...done
0 new messages read
Mark set [5 times]
Quit [2 times]
Quit

Load-path shadows:
~/paredit hides /usr/share/emacs23/site-lisp/paredit-el/paredit
/usr/share/emacs/23.2/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
~/loaddefs hides /usr/share/emacs/23.2/lisp/loaddefs
/usr/share/emacs23/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/23.2/lisp/textmodes/ispell
/usr/share/emacs23/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/23.2/lisp/textmodes/flyspell
/usr/share/emacs23/site-lisp/emms/tq hides /usr/share/emacs/23.2/lisp/emacs-lisp/tq

Features:
(shadow emacsbug rfc822 vc-rcs mailalias net-utils mail-queue sendmail
battery mule-util cal-move dabbrev animate slime-banner slime-asdf
slime-fancy slime-fontifying-fu slime-package-fu slime-references
slime-scratch slime-presentations slime-fuzzy slime-fancy-inspector
slime-c-p-c slime-editing-commands slime-autodoc slime-parse
slime-repl slime apropos hideshow hyperspec thingatpt browse-url cl
cl-19 ispell pp grep compile pcmpl-unix help-mode multi-isearch org-wl
org-w3m org-vm org-rmail org-mhe org-mew org-irc org-jsinfo org-infojs
org-html org-exp org-exp-blocks org-agenda org-info org-gnus
org-bibtex org-bbdb org byte-opt bytecomp byte-compile org-footnote
org-src org-list org-faces org-compat org-macs noutline outline
easy-mmode sgml-mode dired-x dired-aux dired rmailout rmailsum rmail
mail-utils ansi-color em-unix pcomplete em-term term disp-table ehelp
electric em-script em-prompt em-ls em-hist em-pred em-glob em-dirs
em-cmpl em-basic esh-opt em-banner em-alias esh-var esh-io esh-cmd
esh-ext esh-proc esh-arg eldoc esh-groups eshell esh-module esh-mode
esh-util conf-mode newcomment tramp-imap assoc tramp-gw tramp-fish
tramp-smb tramp-cache tramp-ftp tramp-cmds tramp auth-source gnus-util
netrc advice advice-preload shell comint ring password-cache
format-spec tramp-compat trampver view cal-china lunar solar cal-dst
cal-bahai cal-islam cal-hebrew holidays hol-loaddefs appt diary-lib
diary-loaddefs cal-menu easymenu calendar cal-loaddefs time-date
regexp-opt autoload help-fns slime-autoloads emms-auto tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting
tool-bar dnd fontset image fringe lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind system-font-setting
font-render-setting gtk x-toolkit x multi-tty emacs)

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.428 (Entity 5.428)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: ams@HIDDEN
Subject: bug#12946: Acknowledgement (23.2; log-edit-insert-changelog not
 inserting a description line from ChangeLog file)
Message-ID: <handler.12946.B.135343484529883.ack <at> debbugs.gnu.org>
References: <E1TasCx-0003uA-P8@HIDDEN>
X-Gnu-PR-Message: ack 12946
X-Gnu-PR-Package: emacs
Reply-To: 12946 <at> debbugs.gnu.org
Date: Tue, 20 Nov 2012 18:08:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 12946 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
12946: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12946
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: Glenn Morris <rgm@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 18:33:02 +0000
Resent-Message-ID: <handler.12946.B12946.135343632832132 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: ams@HIDDEN
Cc: 12946 <at> debbugs.gnu.org
From: Glenn Morris <rgm@HIDDEN>
References: <E1TasCx-0003uA-P8@HIDDEN>
Date: Tue, 20 Nov 2012 13:30:50 -0500
In-Reply-To: <E1TasCx-0003uA-P8@HIDDEN> (Alfred M. Szmidt's message
	of "Tue, 20 Nov 2012 13:06:03 -0500")
Message-ID: <biehjocejp.fsf@HIDDEN>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

Alfred M. Szmidt wrote:

>    2012-11-16  Alfred M. Szmidt  <ams@HIDDEN>
>
> 	This is a deccription line.
>
> 	* random-file: New file.

If you don't use a blank line between the two, you get

This is a description line.
* random-file: New file.

in the log buffer, which seems fine to me. You can easily kill all but
the first line if you don't want it.

http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

says not to put blank lines between related entries (essentially, IMO).
(Maybe it should be updated for the practise of adding a leading summary.)

>   * random-file: New file.
>
> What would be useful is that you got the description line inserted
> instead, with nothing following it.  This is common practise when
> working with various distributed version control systems where the
> commit entry only contains a brief description of the change, and the
> ChangeLog contains the detailed information.

Really? I got the impression the trend was to generate ChangeLogs from
commit logs.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: ams@HIDDEN (Alfred M. Szmidt)
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 18:55:02 +0000
Resent-Message-ID: <handler.12946.B12946.13534376911724 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Glenn Morris <rgm@HIDDEN>
Cc: 12946 <at> debbugs.gnu.org
Reply-To: ams@HIDDEN
Date: Tue, 20 Nov 2012 13:53:37 -0500
Message-Id: <E1Taswz-0005YY-Gc@HIDDEN>
From: ams@HIDDEN (Alfred M. Szmidt)
In-reply-to: <biehjocejp.fsf@HIDDEN> (message from Glenn Morris on
	Tue, 20 Nov 2012 13:30:50 -0500)
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

   Alfred M. Szmidt wrote:

   >    2012-11-16  Alfred M. Szmidt  <ams@HIDDEN>
   >
   > 	This is a deccription line.
   >
   > 	* random-file: New file.

   If you don't use a blank line between the two, you get

   This is a description line.
   * random-file: New file.

   in the log buffer, which seems fine to me. You can easily kill all
   but the first line if you don't want it.

   http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

   says not to put blank lines between related entries (essentially,
   IMO).  (Maybe it should be updated for the practise of adding a
   leading summary.)

Interesting; this might make me change how I do things.  I've always
done one ChangeLog entry per related entry.  Though, I think it would
be useful if there was some variable at least, that would only put in
the description line.

   >   * random-file: New file.
   >
   > What would be useful is that you got the description line
   > inserted instead, with nothing following it.  This is common
   > practise when working with various distributed version control
   > systems where the commit entry only contains a brief description
   > of the change, and the ChangeLog contains the detailed
   > information.

   Really? I got the impression the trend was to generate ChangeLogs
   from commit logs.

Well, there are two camps, those who keep ChangeLog entries in commit
message, and those who don't.  Those who don't put a short summary in
the commit message.  At least from my limited observations.  E.g. in
Emacs it tends to be short summaries in the commit message.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: Glenn Morris <rgm@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 19:00:02 +0000
Resent-Message-ID: <handler.12946.B12946.13534379602128 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 12946
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: ams@HIDDEN
Cc: 12946 <at> debbugs.gnu.org
Received: via spool by 12946-submit <at> debbugs.gnu.org id=B12946.13534379602128
          (code B ref 12946); Tue, 20 Nov 2012 19:00:02 +0000
Received: (at 12946) by debbugs.gnu.org; 20 Nov 2012 18:59:20 +0000
Received: from localhost ([127.0.0.1]:57299 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Tat2W-0000YH-7B
	for submit <at> debbugs.gnu.org; Tue, 20 Nov 2012 13:59:20 -0500
Received: from fencepost.gnu.org ([208.118.235.10]:49512)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <rgm@HIDDEN>) id 1Tat2V-0000YB-2f
	for 12946 <at> debbugs.gnu.org; Tue, 20 Nov 2012 13:59:19 -0500
Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <rgm@HIDDEN>)
	id 1Tat1L-0006AV-55; Tue, 20 Nov 2012 13:58:07 -0500
From: Glenn Morris <rgm@HIDDEN>
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
	<E1Taswz-0005YY-Gc@HIDDEN>
X-Spook: 9705 Samford Road virus bank AMW Area 51 world domination
X-Ran: *I^-y%b<tC]3"/D>^`5ZMkc0Musluo.hu+6:Es/`Xf_APo?K#A;{agtL~yg5Lv^#wy~qfR
X-Hue: black
X-Attribution: GM
Date: Tue, 20 Nov 2012 13:58:07 -0500
In-Reply-To: <E1Taswz-0005YY-Gc@HIDDEN> (Alfred M. Szmidt's message
	of "Tue, 20 Nov 2012 13:53:37 -0500")
Message-ID: <1wa9ucp0e8.fsf@HIDDEN>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -4.6 (----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.4 (-----)

Alfred M. Szmidt wrote:

> E.g. in Emacs it tends to be short summaries in the commit message.

?
AFAICS, it is the same as the ChangeLog in almost every case.
This is certainly how it is _supposed_ to be, AFAIK.

A random browse of http://lists.gnu.org/archive/html/emacs-diffs/2012-11/
seems to support this.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 20:22:02 +0000
Resent-Message-ID: <handler.12946.B12946.135344287212615 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 12946
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Glenn Morris <rgm@HIDDEN>
Cc: ams@HIDDEN, 12946 <at> debbugs.gnu.org
Received: via spool by 12946-submit <at> debbugs.gnu.org id=B12946.135344287212615
          (code B ref 12946); Tue, 20 Nov 2012 20:22:02 +0000
Received: (at 12946) by debbugs.gnu.org; 20 Nov 2012 20:21:12 +0000
Received: from localhost ([127.0.0.1]:57356 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TauJj-0003HN-J3
	for submit <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:21:12 -0500
Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46621)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <monnier@HIDDEN>) id 1TauJg-0003HC-J7
	for 12946 <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:21:09 -0500
Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca
	[132.204.27.242])
	by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id qAKKJu8I025931;
	Tue, 20 Nov 2012 15:19:56 -0500
Received: by faina.iro.umontreal.ca (Postfix, from userid 20848)
	id 0251BB4278; Tue, 20 Nov 2012 15:19:55 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvvcd02fl4.fsf-monnier+emacs@HIDDEN>
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
Date: Tue, 20 Nov 2012 15:19:55 -0500
In-Reply-To: <biehjocejp.fsf@HIDDEN> (Glenn Morris's message of
	"Tue, 20 Nov 2012 13:30:50 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-NAI-Spam-Flag: NO
X-NAI-Spam-Level: *
X-NAI-Spam-Threshold: 5
X-NAI-Spam-Score: 1.5
X-NAI-Spam-Rules: 3 Rules triggered
	BDY_CHNGLOG_ATT=1, BDY_CHNGLOG_ATT_HTP=0.5, RV4408=0
X-NAI-Spam-Version: 2.2.0.9309 : core <4408> : streams <862353> : uri <1272995>
X-Spam-Score: -1.2 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.0 (--)

>> This is a deccription line.
>> 
>> * random-file: New file.
> If you don't use a blank line between the two, you get

Ah, indeed that's the difference between his use case and what I do
every day.

It would be good to change log-edit-insert-changelog so that it
inserts "everything between the date headers".


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: ams@HIDDEN (Alfred M. Szmidt)
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 20:29:01 +0000
Resent-Message-ID: <handler.12946.B12946.135344329613224 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 12946
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Glenn Morris <rgm@HIDDEN>
Cc: 12946 <at> debbugs.gnu.org
Reply-To: ams@HIDDEN
Received: via spool by 12946-submit <at> debbugs.gnu.org id=B12946.135344329613224
          (code B ref 12946); Tue, 20 Nov 2012 20:29:01 +0000
Received: (at 12946) by debbugs.gnu.org; 20 Nov 2012 20:28:16 +0000
Received: from localhost ([127.0.0.1]:57362 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TauQa-0003RE-6L
	for submit <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:28:16 -0500
Received: from fencepost.gnu.org ([208.118.235.10]:51321)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <ams@HIDDEN>) id 1TauQX-0003R6-Cf
	for 12946 <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:28:14 -0500
Received: from ams by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <ams@HIDDEN>)
	id 1TauPN-00084z-Om; Tue, 20 Nov 2012 15:27:01 -0500
Date: Tue, 20 Nov 2012 15:27:01 -0500
Message-Id: <E1TauPN-00084z-Om@HIDDEN>
From: ams@HIDDEN (Alfred M. Szmidt)
In-reply-to: <1wa9ucp0e8.fsf@HIDDEN> (message from Glenn Morris on
	Tue, 20 Nov 2012 13:58:07 -0500)
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
	<E1Taswz-0005YY-Gc@HIDDEN>
	<1wa9ucp0e8.fsf@HIDDEN>
X-Spam-Score: -4.6 (----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.6 (----)

   > E.g. in Emacs it tends to be short summaries in the commit message.

   ?
   AFAICS, it is the same as the ChangeLog in almost every case.
   This is certainly how it is _supposed_ to be, AFAIK.

   A random browse of http://lists.gnu.org/archive/html/emacs-diffs/2012-11/
   seems to support this.

I stand corrected, it seems that I never looked close enough and only
noticed the subject line.  Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: ams@HIDDEN (Alfred M. Szmidt)
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 20:31:02 +0000
Resent-Message-ID: <handler.12946.B12946.135344344113471 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 12946
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: rgm@HIDDEN, 12946 <at> debbugs.gnu.org
Reply-To: ams@HIDDEN
Received: via spool by 12946-submit <at> debbugs.gnu.org id=B12946.135344344113471
          (code B ref 12946); Tue, 20 Nov 2012 20:31:02 +0000
Received: (at 12946) by debbugs.gnu.org; 20 Nov 2012 20:30:41 +0000
Received: from localhost ([127.0.0.1]:57366 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TauSu-0003VD-KK
	for submit <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:30:41 -0500
Received: from fencepost.gnu.org ([208.118.235.10]:51353)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <ams@HIDDEN>) id 1TauSt-0003V7-H1
	for 12946 <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:30:40 -0500
Received: from ams by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <ams@HIDDEN>)
	id 1TauRk-0000Br-63; Tue, 20 Nov 2012 15:29:28 -0500
Date: Tue, 20 Nov 2012 15:29:28 -0500
Message-Id: <E1TauRk-0000Br-63@HIDDEN>
From: ams@HIDDEN (Alfred M. Szmidt)
In-reply-to: <jwvvcd02fl4.fsf-monnier+emacs@HIDDEN> (message from Stefan
	Monnier on Tue, 20 Nov 2012 15:19:55 -0500)
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
	<jwvvcd02fl4.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -4.6 (----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.6 (----)

   >> This is a deccription line.
   >> 
   >> * random-file: New file.
   > If you don't use a blank line between the two, you get

   Ah, indeed that's the difference between his use case and what I do
   every day.

   It would be good to change log-edit-insert-changelog so that it
   inserts "everything between the date headers".

That would be nice, I could live with the additional data that is
inserted if it worked like that (using some variable to tweak it).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: Glenn Morris <rgm@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 20 Nov 2012 20:48:02 +0000
Resent-Message-ID: <handler.12946.B12946.135344447015010 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 12946
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: ams@HIDDEN, 12946 <at> debbugs.gnu.org
Received: via spool by 12946-submit <at> debbugs.gnu.org id=B12946.135344447015010
          (code B ref 12946); Tue, 20 Nov 2012 20:48:02 +0000
Received: (at 12946) by debbugs.gnu.org; 20 Nov 2012 20:47:50 +0000
Received: from localhost ([127.0.0.1]:57422 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TaujV-0003u2-Ef
	for submit <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:47:50 -0500
Received: from fencepost.gnu.org ([208.118.235.10]:51667)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <rgm@HIDDEN>) id 1TaujR-0003tu-H7
	for 12946 <at> debbugs.gnu.org; Tue, 20 Nov 2012 15:47:48 -0500
Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <rgm@HIDDEN>)
	id 1TauiH-00027j-FD; Tue, 20 Nov 2012 15:46:33 -0500
From: Glenn Morris <rgm@HIDDEN>
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
	<jwvvcd02fl4.fsf-monnier+emacs@HIDDEN>
X-Spook: advisors TWA Leuken-Baden Venezuela FTS2000 kibo ISEC
X-Ran: 1LGS#E&|~p"3nxv4o=|Qvp]eY1sT!f3~\;-Zc";~?QSuSLYigoqxvvb('6]/iw&Xgar/V{
X-Hue: cyan
X-Attribution: GM
Date: Tue, 20 Nov 2012 15:46:33 -0500
In-Reply-To: <jwvvcd02fl4.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
	of "Tue, 20 Nov 2012 15:19:55 -0500")
Message-ID: <8bk3tgatp2.fsf@HIDDEN>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -4.6 (----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.6 (----)

Stefan Monnier wrote:

> It would be good to change log-edit-insert-changelog so that it
> inserts "everything between the date headers".

Compared to the current approach:

  search the ChangeLog entry for paragraphs containing the names of
  the files we're checking in

this will add irrelevant stuff in the common case of "make several
unrelated commits to different files in the same day, with ChangeLog
entries separated by blank lines".

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#12946: 23.2; log-edit-insert-changelog not inserting a description line from ChangeLog file
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 21 Nov 2012 13:51:02 +0000
Resent-Message-ID: <handler.12946.B12946.13535058034452 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 12946
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Glenn Morris <rgm@HIDDEN>
Cc: ams@HIDDEN, 12946 <at> debbugs.gnu.org
Received: via spool by 12946-submit <at> debbugs.gnu.org id=B12946.13535058034452
          (code B ref 12946); Wed, 21 Nov 2012 13:51:02 +0000
Received: (at 12946) by debbugs.gnu.org; 21 Nov 2012 13:50:03 +0000
Received: from localhost ([127.0.0.1]:58369 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TbAgk-00019l-Td
	for submit <at> debbugs.gnu.org; Wed, 21 Nov 2012 08:50:03 -0500
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:23911)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <monnier@HIDDEN>) id 1TbAgi-00019J-W4
	for 12946 <at> debbugs.gnu.org; Wed, 21 Nov 2012 08:50:01 -0500
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FpaQ6/2dsb2JhbABEtBGBCIIVAQEEAVYjEAsOJhIUGA0kiBwFugmQRAOIQppxgViDBw
X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208117031"
Received: from 69-165-164-58.dsl.teksavvy.com (HELO pastel.home)
	([69.165.164.58])
	by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
	21 Nov 2012 08:48:45 -0500
Received: by pastel.home (Postfix, from userid 20848)
	id 1954E597C9; Wed, 21 Nov 2012 08:48:45 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvehjnkqzm.fsf-monnier+emacs@HIDDEN>
References: <E1TasCx-0003uA-P8@HIDDEN>
	<biehjocejp.fsf@HIDDEN>
	<jwvvcd02fl4.fsf-monnier+emacs@HIDDEN>
	<8bk3tgatp2.fsf@HIDDEN>
Date: Wed, 21 Nov 2012 08:48:45 -0500
In-Reply-To: <8bk3tgatp2.fsf@HIDDEN> (Glenn Morris's message of
	"Tue, 20 Nov 2012 15:46:33 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: 0.8 (/)

>> It would be good to change log-edit-insert-changelog so that it
>> inserts "everything between the date headers".
> Compared to the current approach:
>   search the ChangeLog entry for paragraphs containing the names of
>   the files we're checking in
> this will add irrelevant stuff in the common case of "make several
> unrelated commits to different files in the same day, with ChangeLog
> entries separated by blank lines".

Yes, sorry for being unclear.  I meant to only provide the new behavior
based on some config setting (we could either extend
log-edit-changelog-full-paragraphs with more options, or add a new var).


        Stefan

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.