GNU bug report logs - #13581
24.3.50; regression: defadvice does not work, to augment doc string

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13581 in the body.
You can then email your comments to 13581 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; regression: defadvice does not work, to augment doc string
Date: Mon, 28 Jan 2013 14:46:37 -0800 (PST)

emacs -Q
 
(defun frog () (interactive) (message "croak"))
(define-key isearch-mode-map "\C-o" 'frog)
(defadvice isearch-forward (before froggy activate)
  "\\<isearch-mode-map>\\[frog] - hear Froggy croak")
 
C-h f isearch-forward
 
No Froggy to be seen.  Worked in previous Emacs versions, including 24.2.

 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-01-25 on ODIEONE
Bzr revision: 111604 eliz <at> gnu.org-20130125143821-1ykj7ia1qjojjjnp
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 

Message #8 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <13581 <at> debbugs.gnu.org>
Subject: RE: bug#13581: 24.3.50;
	regression: defadvice does not work, to augment doc string
Date: Wed, 30 Jan 2013 08:18:26 -0800

I cannot download a pretest binary and try this in that now.  Could someone else
please try it?  If this is a regression also in the pretest (not just in the
trunk), then I think it should be fixed before the release.  Thx.

> emacs -Q
>  
> (defun frog () (interactive) (message "croak"))
> (define-key isearch-mode-map "\C-o" 'frog)
> (defadvice isearch-forward (before froggy activate)
>   "\\<isearch-mode-map>\\[frog] - hear Froggy croak")
>  
> C-h f isearch-forward
>  
> No Froggy to be seen.  Worked in previous Emacs versions, 
> including 24.2.
> 
>  
> In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
>  of 2013-01-25 on ODIEONE

Message #11 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 13581 <at> debbugs.gnu.org
Subject: Re: bug#13581: 24.3.50; regression: defadvice does not work, to
	augment doc string
Date: Wed, 30 Jan 2013 17:38:37 +0100

> I cannot download a pretest binary and try this in that now.

You can get pretest binaries for MS-Windows from here:
  https://www.dropbox.com/sh/7jr3vbv9tm1zod0/jPuvfrJAe8

The pretest versions are the ones starting with "emacs-24", so
currently the last one is "emacs-24-r111199-20130125-w32-i386.zip"  (5
days old).


-- 
Dani Moncayo

Message #14 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Dani Moncayo'" <dmoncayo <at> gmail.com>
Cc: 13581 <at> debbugs.gnu.org
Subject: RE: bug#13581: 24.3.50;
	regression: defadvice does not work, to augment doc string
Date: Wed, 30 Jan 2013 08:42:27 -0800

> > I cannot download a pretest binary and try this in that now.
> 
> You can get pretest binaries for MS-Windows from here:
>   https://www.dropbox.com/sh/7jr3vbv9tm1zod0/jPuvfrJAe8
> 
> The pretest versions are the ones starting with "emacs-24", so
> currently the last one is "emacs-24-r111199-20130125-w32-i386.zip"  (5
> days old).

Yes, I know.  But thanks, Dani.

As I said, I cannot download now.  I have no access (at my end, not an Emacs Dev
problem).

I'm just asking that someone quickly check whether this regression is a problem
also for the pretest.  If so, I think this needs to be fixed before release.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#13581: 24.3.50;
	regression: defadvice does not work, to augment doc string
Date: Wed, 30 Jan 2013 18:08:22 +0100

"Drew Adams" <drew.adams <at> oracle.com> writes:

> I cannot download a pretest binary and try this in that now.  Could
> someone else
> please try it?  If this is a regression also in the pretest (not just
> in the
> trunk), then I think it should be fixed before the release.  Thx.

Works for me in a built of the emacs-24 branch from today:

,----------------------------------------------------------------------
| [...]
| If this function is called non-interactively, it does not return to
| the calling function until the search is done.
| 
| This function is advised.
| 
| Before-advice `froggy':
| C-o - hear Froggy croak
`----------------------------------------------------------------------


Regards,

Michael.

Message #20 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Michael Heerdegen'" <michael_heerdegen <at> web.de>, <13581 <at> debbugs.gnu.org>
Subject: RE: bug#13581: 24.3.50;
	regression: defadvice does not work, to augment doc string
Date: Wed, 30 Jan 2013 09:10:45 -0800

> Works for me in a built of the emacs-24 branch from today:

Good.  Thanks for testing.

So unless this is platform-specific, which is unlikely, the regression was
introduced post-pretest.

Message #23 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 13581 <at> debbugs.gnu.org
Subject: Re: bug#13581: 24.3.50; regression: defadvice does not work, to
	augment doc string
Date: Wed, 30 Jan 2013 19:00:07 +0100

>> I cannot download a pretest binary and try this in that now.  Could
>> someone else
>> please try it?  If this is a regression also in the pretest (not just
>> in the
>> trunk), then I think it should be fixed before the release.  Thx.
>
> Works for me in a built of the emacs-24 branch from today:
>
> ,----------------------------------------------------------------------
> | [...]
> | If this function is called non-interactively, it does not return to
> | the calling function until the search is done.
> |
> | This function is advised.
> |
> | Before-advice `froggy':
> | C-o - hear Froggy croak
> `----------------------------------------------------------------------

Works also for me on MS-Windows:
  In GNU Emacs 24.2.92.1 (i386-mingw-nt6.1.7601)
   of 2013-01-25 on MS-W8-DANI
  Bzr revision: 111199 eliz <at> gnu.org-20130125144737-gedgongj7wf9j3hv
  Windowing system distributor `Microsoft Corp.', version 6.1.7601


-- 
Dani Moncayo

Message #26 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 13581 <at> debbugs.gnu.org
Subject: Re: bug#13581: 24.3.50;
	regression: defadvice does not work, to augment doc string
Date: Wed, 30 Jan 2013 13:07:24 -0500

Michael Heerdegen wrote:

> Works for me in a built of the emacs-24 branch from today:

As expected, since the recent advice changes are only in trunk.

Message #29 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Dani Moncayo'" <dmoncayo <at> gmail.com>,
	"'Michael Heerdegen'" <michael_heerdegen <at> web.de>
Cc: 13581 <at> debbugs.gnu.org
Subject: RE: bug#13581: 24.3.50;
	regression: defadvice does not work, to augment doc string
Date: Wed, 30 Jan 2013 10:09:36 -0800

> > Works for me in a built of the emacs-24 branch from today:
> 
> Works also for me on MS-Windows:
>   In GNU Emacs 24.2.92.1 (i386-mingw-nt6.1.7601)

Excellent, so it seems to have been introduced in the trunk.

Message #36 received at 13581 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 13581 <at> debbugs.gnu.org
Subject: Re: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc
 strings (C-h f)
Date: Mon, 23 Sep 2019 23:07:18 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> It's obviously the result of advice.el being re-implemented using
> nadvice.el, for backward compatibility. Having a minor regression in
> functionality in this kind of situation is fairly normal.

This was marked as a "wontfix" five+ years ago, and the rough consensus
seems to be that the current look is OK, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.