GNU bug report logs - #1408
23.0.60; git/*vc-dir*: does not register a symbolic link which befor was a directory with one singel file

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Gregor Zattler <telegraph@HIDDEN>; dated Sat, 22 Nov 2008 00:10:04 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
bug reassigned from package `emacs,vc-dir' to `emacs,vc'. Request was from Juanma Barranquero <lekktu@HIDDEN> to control@HIDDEN. Full text available.
Severity set to `wishlist' from `normal' Request was from Dan Nicolaescu <dann@HIDDEN> to control@HIDDEN. Full text available.

Message received at 1408@HIDDEN:


Received: (at 1408) by emacsbugs.donarmstrong.com; 28 Dec 2008 18:31:45 +0000
From dann@HIDDEN Sun Dec 28 10:31:45 2008
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=-8.0 required=4.0 tests=HAS_BUG_NUMBER,
	VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham
	version=3.2.5-bugs.debian.org_2005_01_02
Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBSIVbVo004730;
	Sun, 28 Dec 2008 10:31:38 -0800
Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93])
	by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mBSITWfI015683;
	Sun, 28 Dec 2008 10:29:32 -0800 (PST)
Received: (from dann@localhost)
	by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mBSISePg022740;
	Sun, 28 Dec 2008 10:28:40 -0800 (PST)
Date: Sun, 28 Dec 2008 10:28:40 -0800 (PST)
Message-Id: <200812281828.mBSISePg022740@HIDDEN>
From: Dan Nicolaescu <dann@HIDDEN>
To: Gregor Zattler <telegraph@HIDDEN>
Cc: 1408 <at> debbugs.gnu.org, rfrancoise@HIDDEN
Subject: Re: bug#1408: 23.0.60; git/*vc-dir*: does not register a symbolic link which befor was a directory with one singel file
References: <E1L3fzc-0007NA-N0@HIDDEN>
X-Debbugs-No-Ack: yes
In-Reply-To: <E1L3fzc-0007NA-N0@HIDDEN> (Gregor Zattler's
	message of "Fri, 21 Nov 2008 19:04:59 -0500")
Lines: 67
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-ICS-MailScanner-Information: Please contact the ISP for more information
X-ICS-MailScanner-ID: mBSITWfI015683
X-ICS-MailScanner: Found to be clean
X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5,
	autolearn=disabled, ALL_TRUSTED -1.44)
X-ICS-MailScanner-From: dann@HIDDEN

severity 1408 wishlist
quit


Gregor Zattler <telegraph@HIDDEN> writes:

  > Disclaimer: I'm new to version control, perhaps I do not understand
  > the situation.  These are the steps to reproduce the problem:
  > 
  > $ mkdir vc-emacs-test
  > $ cd vc-emacs-test
  > $ git init
  > Initialized empty Git repository in /tmp/vc-emacs-test/.git/
  > $ mkdir dir directory
  > $ echo test >dir/test
  > $ git add .
  > $ git commit -a -m "one"
  > Created initial commit cdd09ae: one
  >  1 files changed, 1 insertions(+), 0 deletions(-)
  >  create mode 100644 dir/test
  > $ rm -rf dir
  > $ ln -s directory dir
  > $ emacs-snapshot -Q
  > 
  > ^X v d
  > 
  > now in buffer *vc-dir* looks like this:
  > 
  > 
  > VC backend : Git
  > Working dir: /tmp/vc-emacs-test/
  > Branch     : master
  > 
  >                           ./
  >      unregistered         dir
  >                           dir/
  >      removed              dir/test
  > 
  > 
  > move cursor on this line type 'i' to register.  Following error
  > messages are displayed:
  > 
  > on the last line, copied from *Messages*:
  > vc-do-command: Running git update-index --add -- dir...FAILED (status 128)
  > 
  > 
  > In buffer *vc*:
  > 
  > error: 'dir' appears as both a file and as a directory
  > error: dir: cannot add to the index - missing --add option?
  > fatal: Unable to process path dir
  > 
  > 
  > 
  > 
  > I think this is a bug because emacs should handle this case (at least
  > with a sensible message what to do).
  > 
  > Actually this happend in a "real" scenario, I decided to reproduce a
  > minimalistic example. 

VC is not really prepared to deal with arbitrary commands on symlinks,
so it's not surprising that this corner case fails.
Changing a directory into a symlink between to VC operations is not
something that happens very frequently...






Information forwarded to bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>, owner@HIDDEN:
bug#1408; Package emacs,vc-dir. Full text available.
bug reassigned from package `emacs' to `emacs,vc-dir'. Request was from Glenn Morris <rgm@HIDDEN> to control@HIDDEN. Full text available.

Message received at (unknown):


Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA,
	RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02
Received: (at submit) by emacsbugs.donarmstrong.com; 22 Nov 2008 00:05:07 +0000
Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAM050WT022010
	for <submit@HIDDEN>; Fri, 21 Nov 2008 16:05:02 -0800
Received: from mx10.gnu.org ([199.232.76.166]:60078)
	by fencepost.gnu.org with esmtp (Exim 4.67)
	(envelope-from <telegraph@HIDDEN>)
	id 1L3fzT-0000x2-R8
	for emacs-pretest-bug@HIDDEN; Fri, 21 Nov 2008 19:04:48 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60)
	(envelope-from <telegraph@HIDDEN>)
	id 1L3fzc-0007NA-N0
	for emacs-pretest-bug@HIDDEN; Fri, 21 Nov 2008 19:04:59 -0500
Received: from mail.gmx.net ([213.165.64.20]:44446)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <telegraph@HIDDEN>)
	id 1L3fzc-0007N6-0Y
	for emacs-pretest-bug@HIDDEN; Fri, 21 Nov 2008 19:04:56 -0500
Received: (qmail invoked by alias); 22 Nov 2008 00:04:53 -0000
Received: from unknown (EHLO localhost) [77.22.102.44]
  by mail.gmx.net (mp031) with SMTP; 22 Nov 2008 01:04:53 +0100
X-Authenticated: #6219957
X-Provags-ID: V01U2FsdGVkX1+n/E07iISnKKGO5nqqADcqCscM7ND0iYzPzWxo0C
	uzBBxpcFxvR95y
From: Gregor Zattler <telegraph@HIDDEN>
To: emacs-pretest-bug@HIDDEN
CC: rfrancoise@HIDDEN
Subject: 23.0.60; git/*vc-dir*: does not register a symbolic link which befor was a directory with one singel file
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.47
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4)
Message-Id: <E1L3fzc-0007NA-N0@HIDDEN>
Date: Fri, 21 Nov 2008 19:04:59 -0500

Disclaimer: I'm new to version control, perhaps I do not understand
the situation.  These are the steps to reproduce the problem:

$ mkdir vc-emacs-test
$ cd vc-emacs-test
$ git init
Initialized empty Git repository in /tmp/vc-emacs-test/.git/
$ mkdir dir directory
$ echo test >dir/test
$ git add .
$ git commit -a -m "one"
Created initial commit cdd09ae: one
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 dir/test
$ rm -rf dir
$ ln -s directory dir
$ emacs-snapshot -Q

^X v d

now in buffer *vc-dir* looks like this:


VC backend : Git
Working dir: /tmp/vc-emacs-test/
Branch     : master

                          ./
     unregistered         dir
                          dir/
     removed              dir/test


move cursor on this line type 'i' to register.  Following error
messages are displayed:

on the last line, copied from *Messages*:
vc-do-command: Running git update-index --add -- dir...FAILED (status 128)


In buffer *vc*:

error: 'dir' appears as both a file and as a directory
error: dir: cannot add to the index - missing --add option?
fatal: Unable to process path dir




I think this is a bug because emacs should handle this case (at least
with a sensible message what to do).

Actually this happend in a "real" scenario, I decided to reproduce a
minimalistic example. 

Thank you for emacs and version control in emacs,
Gregor

	

In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-18 on del, modified by Debian
 (emacs-snapshot package, version 1:20081113-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: 
  value of $LC_COLLATE: de_DE.utf8
  value of $LC_CTYPE: de_DE.utf8
  value of $LC_MESSAGES: POSIX
  value of $LC_MONETARY: de_DE.utf8
  value of $LC_NUMERIC: de_DE.utf8
  value of $LC_TIME: de_DE.utf8
  value of $LANG: 
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x v d <return> <down> <down> <down> <down> <down> 
<right> <right> <right> <right> <right> i <down-mouse-1> 
<mouse-1> <down-mouse-1> <mouse-movement> <mouse-movement> 
<drag-mouse-1> C-x o C-SPC <escape> > <escape> w C-x 
b <return> C-x 1 m m m <up> <up> i <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> C-x o <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <home> C-SPC <escape> > <escape> w C-x 
o C-x b C-g C-g <up> <up> <up> C-x o <up> <up> <up> 
<down> m <help-echo> <help-echo> <help-echo> <down-mouse-3> 
<down-mouse-3> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <down-mouse-3> <help-echo> 
<help-echo> i i i C-x o i <up> C-x o <up> i <up> C-x 
o <up> u u <up> <up> i <down> C-x o <down> <down> i 
C-x o <up> <up> i M-x r e p <tab> o <tab> r <tab> 
<return>

Recent messages:
vc-do-command: Running git update-index --add -- dir...FAILED (status 128)
Mark set
Press C-c C-c when you are done editing.
Registering (/tmp/vc-emacs-test/dir/test)... 
vc-do-command: Running git update-index --add -- dir/test...FAILED (status 128)
Mark set
Press C-c C-c when you are done editing.
Registering (/tmp/vc-emacs-test/dir)... 
vc-do-command: Running git update-index --add -- dir...FAILED (status 128)
Making completion list... [2 times]




Acknowledgement sent to Gregor Zattler <telegraph@HIDDEN>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs@HIDDEN>. Full text available.
Report forwarded to bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>:
bug#1408; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 31 Oct 2014 17:00:04 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.