GNU bug report logs - #14130
24.3.50; doc/help for advice and advised functions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14130 in the body.
You can then email your comments to 14130 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; doc/help for advice and advised functions
Date: Wed, 3 Apr 2013 08:13:57 -0700

Mostly an enhancement request, I guess, but partly a bug report.
 
1. (elisp) `Advising Functions'
 
Says "Note that enabling a piece of advice and activating advice for a
function are not the same thing."  But it does not say clearly what the
difference is.  It says only this:
 
a. A piece of advice can be "enabled"/"disabled".  It does not explain
what this means.
 
b. Advice takes effect only if both enabled and activated.
 
That's pretty incomplete.  The difference between these two things
(enabling, activating) is presumably important, and it is not made
clear.  It is not enough to tell users not to confuse the two, without
telling them clearly what the difference is.  Start with this question:
What is the purpose of each of them (enabling, activating)?
 
2. The definition of "forward advice", and the *important* fact that you
can advise a function without the function being defined yet, should be
moved from (elisp) `Defining Advice' to (elisp) `Advising Functions'.
It is not a detail concerning just the keyword `activate'.  (Note too
that there is zero use of or reference to "forward advice" in the
manual.)
 
3. If these concepts apply also to the new advice facility written by
Stefan, then please keep this request in mind in that context: document
each of the various states of a piece of advice (enabled but not
activated etc.) etc.  (And where is the doc for that new facility?)
 
 
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-03-28 on ODIEONE
Bzr revision: 112173 monnier <at> iro.umontreal.ca-20130328163306-419khox8aneaoaxv
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 

Message #10 received at 14130-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14130-done <at> debbugs.gnu.org
Subject: Re: bug#14130: 24.3.50; doc/help for advice and advised functions
Date: Sat, 25 Sep 2021 10:15:06 -0700

"Drew Adams" <drew.adams <at> oracle.com> writes:

> Mostly an enhancement request, I guess, but partly a bug report.
>
> 1. (elisp) `Advising Functions'
>
> Says "Note that enabling a piece of advice and activating advice for a
> function are not the same thing."  But it does not say clearly what the
> difference is.  It says only this:
>
> a. A piece of advice can be "enabled"/"disabled".  It does not explain
> what this means.
>
> b. Advice takes effect only if both enabled and activated.
>
> That's pretty incomplete.  The difference between these two things
> (enabling, activating) is presumably important, and it is not made
> clear.  It is not enough to tell users not to confuse the two, without
> telling them clearly what the difference is.  Start with this question:
> What is the purpose of each of them (enabling, activating)?
>
> 2. The definition of "forward advice", and the *important* fact that you
> can advise a function without the function being defined yet, should be
> moved from (elisp) `Defining Advice' to (elisp) `Advising Functions'.
> It is not a detail concerning just the keyword `activate'.  (Note too
> that there is zero use of or reference to "forward advice" in the
> manual.)
>
> 3. If these concepts apply also to the new advice facility written by
> Stefan, then please keep this request in mind in that context: document
> each of the various states of a piece of advice (enabled but not
> activated etc.) etc.  (And where is the doc for that new facility?)

Since the above was reported, this entire section seems to have been
rewritten.  I can't find any of the problematic text reported above in
the new manual.  I'm therefore closing this bug report.

If this conclusion is incorrect and this is still an issue, please reply
to this email (use "Reply to all" in your email client) and we can
reopen the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.