GNU bug report logs - #14257
24.3.50; (elisp) `Modifying Menus' - clarify second example

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: "Drew Adams" <drew.adams@HIDDEN>; dated Wed, 24 Apr 2013 16:27:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 24 Apr 2013 16:26:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 24 12:26:29 2013
Received: from localhost ([127.0.0.1]:41218 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1UV2Wa-0005YB-4W
	for submit <at> debbugs.gnu.org; Wed, 24 Apr 2013 12:26:28 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33294)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <drew.adams@HIDDEN>) id 1UV2WU-0005Y1-PC
	for submit <at> debbugs.gnu.org; Wed, 24 Apr 2013 12:26:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1UV2Ra-0005Sd-Bs
	for submit <at> debbugs.gnu.org; Wed, 24 Apr 2013 12:21:19 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-104.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED,
	RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=disabled
	version=3.3.2
Received: from lists.gnu.org ([208.118.235.17]:57596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1UV2Ra-0005SY-90
	for submit <at> debbugs.gnu.org; Wed, 24 Apr 2013 12:21:18 -0400
Received: from eggs.gnu.org ([208.118.235.92]:44621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1UV2RV-0004bq-7w
	for bug-gnu-emacs@HIDDEN; Wed, 24 Apr 2013 12:21:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1UV2RT-0005R7-VS
	for bug-gnu-emacs@HIDDEN; Wed, 24 Apr 2013 12:21:13 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:40708)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drew.adams@HIDDEN>) id 1UV2RT-0005Qv-QQ
	for bug-gnu-emacs@HIDDEN; Wed, 24 Apr 2013 12:21:11 -0400
Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94])
	by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with
	ESMTP id r3OGL9w1010921
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <bug-gnu-emacs@HIDDEN>; Wed, 24 Apr 2013 16:21:10 GMT
Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86])
	by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	r3OGL9Rb025051
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL)
	for <bug-gnu-emacs@HIDDEN>; Wed, 24 Apr 2013 16:21:09 GMT
Received: from abhmt111.oracle.com (abhmt111.oracle.com [141.146.116.63])
	by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	r3OGL9V8025036
	for <bug-gnu-emacs@HIDDEN>; Wed, 24 Apr 2013 16:21:09 GMT
Received: from dradamslap1 (/130.35.178.8)
	by default (Oracle Beehive Gateway v4.0)
	with ESMTP ; Wed, 24 Apr 2013 09:21:08 -0700
From: "Drew Adams" <drew.adams@HIDDEN>
To: <bug-gnu-emacs@HIDDEN>
Subject: 24.3.50; (elisp) `Modifying Menus' - clarify second example
Date: Wed, 24 Apr 2013 09:21:08 -0700
Message-ID: <E12F73B0EEC24EEB973EAE4F264954F3@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 11
Thread-Index: Ac5BB7nmxRbo/o8FQNeKtpBADUiDoQ==
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
X-Source-IP: ucsinet22.oracle.com [156.151.31.94]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.17
X-Spam-Score: -4.8 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.2 (------)

It might help if some motivation were given for the second example:
 
 (define-key-after
   (lookup-key shell-mode-map [menu-bar signals])
   [work] '("Work" . work-command) 'break)
 
My guess is that that example was added to tell users how to deal with
the error that used to be raised if you used something like this:
 
 (define-key-after minibuffer-local-completion-map
   [menu-bar minibuf foo]
   '(menu-item "Foo" foo) 'quit)
 
Instead of this:
 
 (define-key-after (lookup-key minibuffer-local-completion-map
                               [menu-bar minibuf])
   [foo]
   '(menu-item "Foo" foo) 'quit)
 
That error is no longer raised.  And the doc string has been updated to
no longer say this:
 
 "KEY must contain just one event type--that is to say, it must be a
  string or vector of length 1."
 
If the example still has a purpose (some other purpose), then consider
mentioning it.
 
And it would at least help to mention that the `lookup-key' sexp in the
example returns a keymap, not a key.  Without knowing that, the second
example would not make much sense (hence, some readers will guess it,
but it would still help to mention it).
 
 
 

In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-04-17 on ODIEONE
Bzr revision: 112320 monnier@HIDDEN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 





Acknowledgement sent to "Drew Adams" <drew.adams@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#14257; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 31 Oct 2014 17:00:04 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.