GNU bug report logs - #14398
24.3.50; Customize: `Revert...' and `Apply'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Tue, 14 May 2013 14:23:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 24.3.50

Fixed in version 28.1

Done: Mauro Aranda <maurooaranda <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14398 in the body.
You can then email your comments to 14398 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Tue, 14 May 2013 14:23:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Drew Adams" <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 14 May 2013 14:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; Customize: `Revert...' and `Apply'
Date: Tue, 14 May 2013 07:21:40 -0700
1. The `Revert...' menu items should be controled by either :enable or
:visible.  It makes no sense to show a user an active menu item `Undo
Edits in Customization Buffer' if there have been no edits.  After a
user clicks this, undoing any edits, this menu item should disappear or
be dimmed.  Similarly for other menu items.
 
2. `Apply' is not helpful as is.  The name does not sufficiently
indicate what it does (apply what? to what?).  The help echo is also not
helpful enough: `Apply settings (for current session only)'.  What
settings?  And again, if no settings have been changed (edited) then
this button should not even be available.  Its presence when it is a
no-op just confuses.
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-05-10 on ODIEONE
Bzr revision: 112542 rgm <at> gnu.org-20130510102119-fklj7xlajezey0tr
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Tue, 03 Nov 2020 13:57:01 GMT) Full text and rfc822 format available.

Message #8 received at 14398 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14398 <at> debbugs.gnu.org
Subject: Re: bug#14398: 24.3.50; Customize: `Revert...' and `Apply'
Date: Tue, 3 Nov 2020 10:56:32 -0300
[Message part 1 (text/plain, inline)]
tags 14398 patch
quit

"Drew Adams" <drew.adams <at> oracle.com> writes:

> 1. The `Revert...' menu items should be controled by either :enable or
> :visible.  It makes no sense to show a user an active menu item `Undo
> Edits in Customization Buffer' if there have been no edits.  After a
> user clicks this, undoing any edits, this menu item should disappear or
> be dimmed.  Similarly for other menu items.

Now that widget-choose supports extended menus, this can be done like in
Bug#4787.

> 2. `Apply' is not helpful as is.  The name does not sufficiently
> indicate what it does (apply what? to what?).  The help echo is also not
> helpful enough: `Apply settings (for current session only)'.  What
> settings?

While "Apply" might not be helpful, I think that the help-echo
answers the questions.  And I'd say it is evident that it talks about
the settings the user is seeing in the Custom buffer at that moment.

> And again, if no settings have been changed (edited) then
> this button should not even be available.  Its presence when it is a
> no-op just confuses.

Makes sense to me.  And this can be easily controlled by activating and
deactivating the widgets.

I think that toolbar icons and menu bar items should also be
enabled/disabled according to the state of the options in the Custom
buffer, so I propose a patch that adds logic to do that as well.
[Message part 2 (text/html, inline)]
[0001-Enable-disable-buttons-tool-bar-and-menu-items-in-Cu.patch (text/x-patch, attachment)]

Added tag(s) patch. Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 03 Nov 2020 13:57:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Tue, 03 Nov 2020 14:13:01 GMT) Full text and rfc822 format available.

Message #13 received at 14398 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 14398 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14398: 24.3.50; Customize: `Revert...' and `Apply'
Date: Tue, 03 Nov 2020 15:11:52 +0100
Mauro Aranda <maurooaranda <at> gmail.com> writes:

> I think that toolbar icons and menu bar items should also be
> enabled/disabled according to the state of the options in the Custom
> buffer, so I propose a patch that adds logic to do that as well.

I haven't tried the patch, but this makes sense to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Tue, 03 Nov 2020 15:24:01 GMT) Full text and rfc822 format available.

Message #16 received at 14398 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14398 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14398: 24.3.50; Customize: `Revert...' and `Apply'
Date: Tue, 3 Nov 2020 12:22:50 -0300
[Message part 1 (text/plain, inline)]
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> I think that toolbar icons and menu bar items should also be
>> enabled/disabled according to the state of the options in the Custom
>> buffer, so I propose a patch that adds logic to do that as well.
>
> I haven't tried the patch, but this makes sense to me.

Thanks.  Should I wait for further comments, or is it OK to push and see
if anything comes up? I mean, I have tested the code quite a bit, but
perhaps I should wait for comments about the code itself?
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Tue, 03 Nov 2020 16:50:02 GMT) Full text and rfc822 format available.

Message #19 received at 14398 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 14398 <at> debbugs.gnu.org
Subject: RE: bug#14398: 24.3.50; Customize: `Revert...' and `Apply'
Date: Tue, 3 Nov 2020 08:47:29 -0800 (PST)
Haven't tried it, but the patch looks great.

I especially appreciate the fact that you adding
a missing doc string.  Thx.
___

FWIW -

I'll incorporate those changes into my library
`cus-edit+.el', which adds these three items to
`custom-commands': `Consider Unchanged', `Ignore
Unsaved Changes', and `Set from External Changes'.

The help strings for those 3 are:

"Treat changed preferences as if they were
unchanged, without saving them"

"Add to the `customize-unsaved-ignore' preferences,
whose changes are ignored by `customize-unsaved'"

"Tell Customize that all preferences changed
outside it are now set"

(Tried to interest Emacs in these, to no avail.)





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Thu, 05 Nov 2020 14:42:01 GMT) Full text and rfc822 format available.

Message #22 received at 14398 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 14398 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14398: 24.3.50; Customize: `Revert...' and `Apply'
Date: Thu, 05 Nov 2020 15:40:52 +0100
Mauro Aranda <maurooaranda <at> gmail.com> writes:

> Thanks.  Should I wait for further comments, or is it OK to push and see
> if anything comes up? I mean, I have tested the code quite a bit, but
> perhaps I should wait for comments about the code itself?

The code looked fine to me, so just go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14398; Package emacs. (Thu, 05 Nov 2020 22:03:02 GMT) Full text and rfc822 format available.

Message #25 received at 14398 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14398 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14398: 24.3.50; Customize: `Revert...' and `Apply'
Date: Thu, 5 Nov 2020 19:02:26 -0300
[Message part 1 (text/plain, inline)]
tags 14398 fixed
close 14398 28.1
quit

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> Thanks.  Should I wait for further comments, or is it OK to push and see
>> if anything comes up? I mean, I have tested the code quite a bit, but
>> perhaps I should wait for comments about the code itself?
>
> The code looked fine to me, so just go ahead and push.

Great, thanks.  I've now pushed, and I'm closing this bug report.
[Message part 2 (text/html, inline)]

Added tag(s) fixed. Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 05 Nov 2020 22:03:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 14398 <at> debbugs.gnu.org and "Drew Adams" <drew.adams <at> oracle.com> Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 05 Nov 2020 22:03:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 04 Dec 2020 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 115 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.