GNU logs - #14676, boring messages


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 20 Jun 2013 18:11:01 +0000
Resent-Message-ID: <handler.14676.B.137175181023989 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 14676
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 14676 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Reply-To: michael_heerdegen@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.137175181023989
          (code B ref -1); Thu, 20 Jun 2013 18:11:01 +0000
Received: (at submit) by debbugs.gnu.org; 20 Jun 2013 18:10:10 +0000
Received: from localhost ([127.0.0.1]:59055 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1UpjJB-0006Em-6F
	for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 14:10:09 -0400
Received: from eggs.gnu.org ([208.118.235.92]:37248)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpjJ6-0006EB-SR
 for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 14:10:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpjJ0-0002Sc-Ft
 for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 14:09:59 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
 USER_IN_WHITELIST autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:35273)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpjJ0-0002SY-Cj
 for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 14:09:58 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38969)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpjIz-0001Vq-AA
 for bug-gnu-emacs@HIDDEN; Thu, 20 Jun 2013 14:09:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpjIy-0002S7-8o
 for bug-gnu-emacs@HIDDEN; Thu, 20 Jun 2013 14:09:57 -0400
Received: from mout.web.de ([212.227.15.4]:61359)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpjIy-0002Rw-0A
 for bug-gnu-emacs@HIDDEN; Thu, 20 Jun 2013 14:09:56 -0400
Received: from drachen.dragon ([2.201.137.250]) by smtp.web.de (mrweb004) with
 ESMTPSA (Nemesis) id 0Lir9R-1UJhLL0NTh-00cvtf for
 <bug-gnu-emacs@HIDDEN>; Thu, 20 Jun 2013 20:09:54 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Date: Thu, 20 Jun 2013 20:09:21 +0200
Message-ID: <87k3lo4pta.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K0:xOK43UwMLxj5BEVefF6UjPT75k1jst5kgUwt3ZOVouhhCZ0LNN/
 qZ8n8NfuFr9SoJ3N52BFtty3L7OSNRkYH53C5dNZnHWsdAcpVEHLWqz9UM95pua4XXUpgp5
 D+8NsK2lsyvge3wB6qJ9P7ahlw1A9AhiQzo+zIMVXdSbdqwadDZWcxij4weN0XjMSGcNvaa
 ttcA0N5qypBuEYboqOwyw==
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic]
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)


Hello,

I have `winner-mode' turned on.

From e.g. an image viewer I want to open a dired buffer for the
directory containing the images.  So, from the image viewer, I run

  emacsclient file

and in Emacs, I immediately hit C-^ (which I bound to `dired-jump') in
the popped up window, to get the parent dir.

The problem: the buffer showing the file was not recorded in the winner
history - `winner-undo' can't get it.

Note: this only happens if I hit C-^ immediately after opening the
file.  Else, you trigger `post-command-hook' which DTRT.

Evaluating

  (add-hook 'server-switch-hook 'winner-save-old-configurations)

fixes the problem for me.  Should we do something like that in the
definition of `winner-mode'?


Regards,

Michael.



In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.8.2)
 of 2013-06-18 on dex, modified by Debian
 (emacs-snapshot package, version 2:20130618-1)
Windowing system distributor `The X.Org Foundation', version 11.0.11204000
System Description:	Debian GNU/Linux testing (jessie)

Configured using:
 `configure --build x86_64-linux-gnu --host x86_64-linux-gnu
 --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var --infodir=/usr/share/info --mandir=/usr/share/man
 --with-pop=yes
 --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.3.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3.50/site-lisp:/usr/share/emacs/site-lisp
 --without-compress-info --with-crt-dir=/usr/lib/x86_64-linux-gnu/
 --with-x=yes --with-x-toolkit=gtk3 --with-imagemagick=yes
 CFLAGS='-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2'
 CPPFLAGS='-D_FORTIFY_SOURCE=2' LDFLAGS='-g -Wl,--as-needed
 -znocombreloc''





Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: michael_heerdegen@HIDDEN
Subject: bug#14676: Acknowledgement (24.3.50; winner doesn't immediately
 notice windows created by server)
Message-ID: <handler.14676.B.137175181023989.ack <at> debbugs.gnu.org>
References: <87k3lo4pta.fsf@HIDDEN>
X-Gnu-PR-Message: ack 14676
X-Gnu-PR-Package: emacs
Reply-To: 14676 <at> debbugs.gnu.org
Date: Thu, 20 Jun 2013 18:11:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 14676 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
14676: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D14676
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 20 Jun 2013 20:33:02 +0000
Resent-Message-ID: <handler.14676.B14676.13717603287676 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 14676
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 14676 <at> debbugs.gnu.org
Received: via spool by 14676-submit <at> debbugs.gnu.org id=B14676.13717603287676
          (code B ref 14676); Thu, 20 Jun 2013 20:33:02 +0000
Received: (at 14676) by debbugs.gnu.org; 20 Jun 2013 20:32:08 +0000
Received: from localhost ([127.0.0.1]:59271 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1UplWZ-0001zj-K0
	for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 16:32:08 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:11980)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1UplWX-0001z7-Ce
 for 14676 <at> debbugs.gnu.org; Thu, 20 Jun 2013 16:32:05 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: At8KABK/CFFFpZVy/2dsb2JhbABEuzWCWAQCexdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw
X-IPAS-Result: At8KABK/CFFFpZVy/2dsb2JhbABEuzWCWAQCexdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw
X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16827262"
Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home)
 ([69.165.149.114])
 by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
 20 Jun 2013 16:31:54 -0400
Received: by pastel.home (Postfix, from userid 20848)
 id 0B353630ED; Thu, 20 Jun 2013 16:31:59 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvwqpofrsx.fsf-monnier+emacs@HIDDEN>
References: <87k3lo4pta.fsf@HIDDEN>
Date: Thu, 20 Jun 2013 16:31:58 -0400
In-Reply-To: <87k3lo4pta.fsf@HIDDEN> (Michael Heerdegen's message of "Thu, 20
 Jun 2013 20:09:21 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

>   (add-hook 'server-switch-hook 'winner-save-old-configurations)
> fixes the problem for me.  Should we do something like that in the
> definition of `winner-mode'?

I don't much like this solution.


        Stefan




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 20 Jun 2013 21:01:02 +0000
Resent-Message-ID: <handler.14676.B14676.137176206010893 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 14676
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 14676 <at> debbugs.gnu.org
Received: via spool by 14676-submit <at> debbugs.gnu.org id=B14676.137176206010893
          (code B ref 14676); Thu, 20 Jun 2013 21:01:02 +0000
Received: (at 14676) by debbugs.gnu.org; 20 Jun 2013 21:01:00 +0000
Received: from localhost ([127.0.0.1]:59328 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1UplyU-0002pa-9g
	for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 17:00:58 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:10381)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1UplyP-0002pL-7t
 for 14676 <at> debbugs.gnu.org; Thu, 20 Jun 2013 17:00:54 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw
X-IPAS-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw
X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16829167"
Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home)
 ([69.165.149.114])
 by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
 20 Jun 2013 17:00:42 -0400
Received: by pastel.home (Postfix, from userid 20848)
 id 17586630ED; Thu, 20 Jun 2013 17:00:47 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvfvwcfqhj.fsf-monnier+emacs@HIDDEN>
References: <87k3lo4pta.fsf@HIDDEN> <jwvwqpofrsx.fsf-monnier+emacs@HIDDEN>
Date: Thu, 20 Jun 2013 17:00:47 -0400
In-Reply-To: <jwvwqpofrsx.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Thu, 20 Jun 2013 16:31:58 -0400")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

>> (add-hook 'server-switch-hook 'winner-save-old-configurations)
>> fixes the problem for me.  Should we do something like that in the
>> definition of `winner-mode'?
> I don't much like this solution.

I think the better solution is to move the (run-hooks
'post-command-hook) in server.el.  Currently it's run at the end of
server-visit-files which I think is simply too early.  It should be run
at the end of server-execute instead.  And that should fix your problem
as well since winner-mode hooks itself on post-command-hook.


        Stefan




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 20 Jun 2013 21:55:02 +0000
Resent-Message-ID: <handler.14676.B14676.137176528316585 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 14676
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 14676 <at> debbugs.gnu.org
Received: via spool by 14676-submit <at> debbugs.gnu.org id=B14676.137176528316585
          (code B ref 14676); Thu, 20 Jun 2013 21:55:02 +0000
Received: (at 14676) by debbugs.gnu.org; 20 Jun 2013 21:54:43 +0000
Received: from localhost ([127.0.0.1]:59398 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1UpmoV-0004JQ-Da
	for submit <at> debbugs.gnu.org; Thu, 20 Jun 2013 17:54:43 -0400
Received: from mout.web.de ([212.227.15.4]:60176)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UpmoS-0004JC-Rk
 for 14676 <at> debbugs.gnu.org; Thu, 20 Jun 2013 17:54:41 -0400
Received: from drachen.dragon ([90.186.122.149]) by smtp.web.de (mrweb003)
 with ESMTPSA (Nemesis) id 0MAMkU-1V0Bsj2WiI-00BZbr; Thu, 20 Jun 2013 23:54:32
 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
References: <87k3lo4pta.fsf@HIDDEN> <jwvwqpofrsx.fsf-monnier+emacs@HIDDEN>
 <jwvfvwcfqhj.fsf-monnier+emacs@HIDDEN>
Date: Thu, 20 Jun 2013 23:54:25 +0200
In-Reply-To: <jwvfvwcfqhj.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Thu, 20 Jun 2013 17:00:47 -0400")
Message-ID: <871u7we9da.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K0:+rPWo89J5bvbOr1aj4oNOuggomq7Lw5sLHHb5Ia/dMdsKGb/UmV
 u6bQqDnKcvwr3Ak0f2rpUS9yXR4U8RfDi8d+B0BRGKasIJMzNj+r3S9P9nzLDGsaF6/IRVw
 PCFvPg9UEwQt2iA9dtnHA7MKltEPAQ2qdc4hdBALVrxWugJVGzp7kTXGVpQWIOPDaRpGYJi
 no5EG4onpyLKmEH52uTwQ==
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

Stefan Monnier <monnier@HIDDEN> writes:

> >> (add-hook 'server-switch-hook 'winner-save-old-configurations)
> >> fixes the problem for me.  Should we do something like that in the
> >> definition of `winner-mode'?
> > I don't much like this solution.
>
> I think the better solution is to move the (run-hooks
> 'post-command-hook) in server.el.  Currently it's run at the end of
> server-visit-files which I think is simply too early.  It should be run
> at the end of server-execute instead.  And that should fix your problem
> as well since winner-mode hooks itself on post-command-hook.

That sounds reasonable.  I tested your approach quickly, and it worked.

Michael.




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 21 Jun 2013 14:39:02 +0000
Resent-Message-ID: <handler.14676.B14676.137182553922126 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 14676
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Heerdegen <michael_heerdegen@HIDDEN>
Cc: 14676 <at> debbugs.gnu.org
Received: via spool by 14676-submit <at> debbugs.gnu.org id=B14676.137182553922126
          (code B ref 14676); Fri, 21 Jun 2013 14:39:02 +0000
Received: (at 14676) by debbugs.gnu.org; 21 Jun 2013 14:38:59 +0000
Received: from localhost ([127.0.0.1]:32855 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Uq2UN-0005ko-Ap
	for submit <at> debbugs.gnu.org; Fri, 21 Jun 2013 10:38:59 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:36901)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1Uq2UK-0005ka-7H
 for 14676 <at> debbugs.gnu.org; Fri, 21 Jun 2013 10:38:56 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA59lAoUTgV6DEw
X-IPAS-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA59lAoUTgV6DEw
X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16874010"
Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home)
 ([69.165.149.114])
 by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
 21 Jun 2013 10:38:45 -0400
Received: by pastel.home (Postfix, from userid 20848)
 id 30DC262CFF; Fri, 21 Jun 2013 10:38:50 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwva9mjedi7.fsf-monnier+emacs@HIDDEN>
References: <87k3lo4pta.fsf@HIDDEN> <jwvwqpofrsx.fsf-monnier+emacs@HIDDEN>
 <jwvfvwcfqhj.fsf-monnier+emacs@HIDDEN> <871u7we9da.fsf@HIDDEN>
Date: Fri, 21 Jun 2013 10:38:50 -0400
In-Reply-To: <871u7we9da.fsf@HIDDEN> (Michael Heerdegen's message of "Thu, 20
 Jun 2013 23:54:25 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

> That sounds reasonable.  I tested your approach quickly, and it worked.

Can you show me the patch you tested?


        Stefan




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server
Resent-From: Michael Heerdegen <michael_heerdegen@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 22 Jun 2013 22:45:01 +0000
Resent-Message-ID: <handler.14676.B14676.137194107227021 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 14676
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 14676 <at> debbugs.gnu.org
Received: via spool by 14676-submit <at> debbugs.gnu.org id=B14676.137194107227021
          (code B ref 14676); Sat, 22 Jun 2013 22:45:01 +0000
Received: (at 14676) by debbugs.gnu.org; 22 Jun 2013 22:44:32 +0000
Received: from localhost ([127.0.0.1]:35317 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1UqWXn-00071k-OA
	for submit <at> debbugs.gnu.org; Sat, 22 Jun 2013 18:44:32 -0400
Received: from mout.web.de ([212.227.15.3]:61603)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <michael_heerdegen@HIDDEN>) id 1UqWXj-00071R-SQ
 for 14676 <at> debbugs.gnu.org; Sat, 22 Jun 2013 18:44:29 -0400
Received: from drachen.dragon ([90.186.79.33]) by smtp.web.de (mrweb102) with
 ESMTPSA (Nemesis) id 0Ls91n-1U9WPd2Eut-013xg4;
 Sun, 23 Jun 2013 00:44:19 +0200
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
References: <87k3lo4pta.fsf@HIDDEN> <jwvwqpofrsx.fsf-monnier+emacs@HIDDEN>
 <jwvfvwcfqhj.fsf-monnier+emacs@HIDDEN> <871u7we9da.fsf@HIDDEN>
 <jwva9mjedi7.fsf-monnier+emacs@HIDDEN>
Date: Sun, 23 Jun 2013 00:44:13 +0200
In-Reply-To: <jwva9mjedi7.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Fri, 21 Jun 2013 10:38:50 -0400")
Message-ID: <87ehbtojeq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K0:4TRNg1oovWxPoDppURHw8Un6HPrMqFTLNcuuj+HSEkHB3p22okT
 EIJAJuxqZ/DQtKarM5jFWzeLNtl8RnnJ2ogFApGHKe2OReZ5eIte5lV0Kx3zkua9hTN9+Q+
 2A1YQU2QrPkIbOIsImxM+mhqctVB6nJ1xQe64tHiEsiAOll4N6aVHLInlVx/IXrUnE9+Jkl
 xZRTbcPZKjW0lLikmnpDg==
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

--=-=-=
Content-Type: text/plain

Stefan Monnier <monnier@HIDDEN> writes:

> Can you show me the patch you tested?

I tested this:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=server.patch

*** /home/micha/today/server.el	2013-06-23 00:21:58.737341216 +0200
--- /home/micha/today/server-new.el	2013-06-23 00:27:31.470493560 +0200
***************
*** 1292,1298 ****
                (message "%s" (substitute-command-keys
                               "When done with a buffer, type \\[server-edit]")))))
            (when (and frame (null tty-name))
!             (server-unselect-display frame)))
        ((quit error)
         (when (eq (car err) 'quit)
           (message "Quit emacsclient request"))
--- 1292,1299 ----
                (message "%s" (substitute-command-keys
                               "When done with a buffer, type \\[server-edit]")))))
            (when (and frame (null tty-name))
!             (server-unselect-display frame))
! 	  (run-hooks 'post-command-hook))
        ((quit error)
         (when (eq (car err) 'quit)
           (message "Quit emacsclient request"))
***************
*** 1360,1368 ****
              (unless server-buffer-clients
                (setq server-existing-buffer t)))
            (server-goto-line-column (cdr file))
!           (run-hooks 'server-visit-hook)
! 	  ;; hooks may be specific to current buffer:
! 	  (run-hooks 'post-command-hook))
  	(unless nowait
  	  ;; When the buffer is killed, inform the clients.
  	  (add-hook 'kill-buffer-hook 'server-kill-buffer nil t)
--- 1361,1367 ----
              (unless server-buffer-clients
                (setq server-existing-buffer t)))
            (server-goto-line-column (cdr file))
!           (run-hooks 'server-visit-hook))
  	(unless nowait
  	  ;; When the buffer is killed, inform the clients.
  	  (add-hook 'kill-buffer-hook 'server-kill-buffer nil t)

--=-=-=
Content-Type: text/plain


Note that I don't know anything about server.el, I just did what you
proposed.

Anyway, it fixes the problem - with my setup as well as for -Q.

BTW, I didn't know what was meant with this comment:

| ;; hooks may be specific to current buffer:

so I just removed it.


Michael.

--=-=-=--





Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.