GNU bug report logs - #14816
24.3.50.1; ispell remember position, feature request

Previous Next

Package: emacs;

Reported by: Andreas Röhler <andreas.roehler <at> easy-emacs.de>

Date: Mon, 8 Jul 2013 06:06:01 UTC

Severity: wishlist

Found in version 24.3.50.1

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14816 in the body.
You can then email your comments to 14816 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Mon, 08 Jul 2013 06:06:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andreas Röhler <andreas.roehler <at> easy-emacs.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 08 Jul 2013 06:06:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50.1; ispell remember position, feature request
Date: Mon, 08 Jul 2013 08:06:00 +0200
When ispell process ends, user might want to jump to last position
where checking was done.

See

http://stackoverflow.com/questions/17510249/emacs-ispell-goto-previous-word

Don't see it's possible for now.

Implementation would be trivial.

In ispell.el

defun ispell-process-line

line 3572
(goto-char word-start)

knows position of last ispell.

Store it in a suitable defvared variable, so it's accessible
when ispell ends.

Afterwards a command ispell-goto-last-position might jump there.

Thanks,

Andreas

GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2013-07-06




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Tue, 10 May 2022 14:25:01 GMT) Full text and rfc822 format available.

Message #8 received at 14816 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 14816 <at> debbugs.gnu.org
Subject: Re: bug#14816: 24.3.50.1; ispell remember position, feature request
Date: Tue, 10 May 2022 16:24:44 +0200
Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> When ispell process ends, user might want to jump to last position
> where checking was done.

I've now fixed this in Emacs 29 -- but instead of adding a special
command/user option, I just made it push the location of the final word
to the mark ring, so that `C-x C-x' can skip back to it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 29.1, send any further explanations to 14816 <at> debbugs.gnu.org and Andreas Röhler <andreas.roehler <at> easy-emacs.de> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 10 May 2022 14:26:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Tue, 10 May 2022 17:17:01 GMT) Full text and rfc822 format available.

Message #13 received at 14816 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14816 <at> debbugs.gnu.org, andreas.roehler <at> easy-emacs.de
Subject: Re: bug#14816: 24.3.50.1; ispell remember position, feature request
Date: Tue, 10 May 2022 20:16:01 +0300
> Cc: 14816 <at> debbugs.gnu.org
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Tue, 10 May 2022 16:24:44 +0200
> 
> Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
> 
> > When ispell process ends, user might want to jump to last position
> > where checking was done.
> 
> I've now fixed this in Emacs 29 -- but instead of adding a special
> command/user option, I just made it push the location of the final word
> to the mark ring, so that `C-x C-x' can skip back to it.

This changeset changes the form of the return value of
ispell-process-line, so shouldn't that at least appear in
incompatible changes in NEWS (if not done in some more compatible
way)?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Wed, 11 May 2022 11:48:02 GMT) Full text and rfc822 format available.

Message #16 received at 14816 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14816 <at> debbugs.gnu.org, andreas.roehler <at> easy-emacs.de
Subject: Re: bug#14816: 24.3.50.1; ispell remember position, feature request
Date: Wed, 11 May 2022 13:46:55 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> This changeset changes the form of the return value of
> ispell-process-line, so shouldn't that at least appear in
> incompatible changes in NEWS (if not done in some more compatible
> way)?

It seemed unlikely to me that third party packages would be using
ispell-process-line, so I didn't think either was necessary.  If it
turns out that it is, I was thinking of adding a new optional argument
to the function to alter the return value.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Wed, 11 May 2022 12:05:02 GMT) Full text and rfc822 format available.

Message #19 received at 14816 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14816 <at> debbugs.gnu.org, andreas.roehler <at> easy-emacs.de
Subject: Re: bug#14816: 24.3.50.1; ispell remember position, feature request
Date: Wed, 11 May 2022 15:04:10 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: andreas.roehler <at> easy-emacs.de,  14816 <at> debbugs.gnu.org
> Date: Wed, 11 May 2022 13:46:55 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > This changeset changes the form of the return value of
> > ispell-process-line, so shouldn't that at least appear in
> > incompatible changes in NEWS (if not done in some more compatible
> > way)?
> 
> It seemed unlikely to me that third party packages would be using
> ispell-process-line, so I didn't think either was necessary.  If it
> turns out that it is, I was thinking of adding a new optional argument
> to the function to alter the return value.

Yes, I'm asking why not do that now, proactively?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Thu, 12 May 2022 00:08:01 GMT) Full text and rfc822 format available.

Message #22 received at 14816 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14816 <at> debbugs.gnu.org, andreas.roehler <at> easy-emacs.de
Subject: Re: bug#14816: 24.3.50.1; ispell remember position, feature request
Date: Thu, 12 May 2022 02:07:07 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> It seemed unlikely to me that third party packages would be using
>> ispell-process-line, so I didn't think either was necessary.  If it
>> turns out that it is, I was thinking of adding a new optional argument
>> to the function to alter the return value.
>
> Yes, I'm asking why not do that now, proactively?

Having an optional parameter to a function that has one single usage
didn't seem warranted.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14816; Package emacs. (Thu, 12 May 2022 05:30:02 GMT) Full text and rfc822 format available.

Message #25 received at 14816 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14816 <at> debbugs.gnu.org, andreas.roehler <at> easy-emacs.de
Subject: Re: bug#14816: 24.3.50.1; ispell remember position, feature request
Date: Thu, 12 May 2022 08:29:01 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: andreas.roehler <at> easy-emacs.de,  14816 <at> debbugs.gnu.org
> Date: Thu, 12 May 2022 02:07:07 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> It seemed unlikely to me that third party packages would be using
> >> ispell-process-line, so I didn't think either was necessary.  If it
> >> turns out that it is, I was thinking of adding a new optional argument
> >> to the function to alter the return value.
> >
> > Yes, I'm asking why not do that now, proactively?
> 
> Having an optional parameter to a function that has one single usage
> didn't seem warranted.

It's a public API that could be used out there any number of times.
And the compatible change is very simple.  Sounds like a no-brainer to
me.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 09 Jun 2022 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 293 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.