GNU logs - #15268, boring messages

Message sent to bug-parted@HIDDEN:

Subject: bug#15268: Add Intel Fast Flash(iFFS) partition type support on GPT disk type
Resent-From: Max Lin <mlin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-parted@HIDDEN
Resent-Date: Thu, 05 Sep 2013 04:38:02 +0000
Resent-Message-ID: <handler.15268.B.13783558638319 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 15268 <at> debbugs.gnu.org
Message-ID: <522808ED.2000402@HIDDEN>
Date: Thu, 05 Sep 2013 12:30:37 +0800
From: Max Lin <mlin@HIDDEN>
Organization: SUSE
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------020205060000060000010402"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------020205060000060000010402
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello list,

This patch is intend to add Intel Fast Flash(iFFS) partition type 
support on GPT disk type to parted, the GUID code of this type is 
D3BFE2DE-3DAF-11DF-BA40-E3A556D89593, this partition type is a 
requirements of Intel Rapid Start Technology[1].

This patch also contains a test script, and no complain from "make 
distcheck". Could you please review this patch and give me any 
suggestion? Thanks a lot!!

Best regards,
Max

[1] 
http://software.intel.com/en-us/articles/what-is-intel-rapid-start-technology

--------------020205060000060000010402
Content-Type: text/x-patch;
 name="0001-libparted-add-iFFS-partition-type-support.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="0001-libparted-add-iFFS-partition-type-support.patch"

From df1788f6297ff16335ed25643d9e26343d10018c Mon Sep 17 00:00:00 2001
From: Max Lin <mlin@HIDDEN>
Date: Thu, 22 Aug 2013 11:53:16 +0800
Subject: [PATCH] libparted: Add Intel Fast Flash(iFFS) partition type support
 on gpt disk type

Add Intel Fast Flash(iFFS) flag on gpt disk type, iFFS partition is one
pre-requirements of Intel Rapid Start Technology. The concept of Intel
Rapid Start Technology is, when suspend your computer and the timeout
expires, the firmware just copies the entire contents of RAM to iFFS
partition and turns the computer off, the firmware dumps the contents
back into RAM and resume at next time hit the power button.

* NEWS (Changes in behavior): Mention the feature of iFFS partition.
* libparted/labels/gpt.c: Add this new feature.
* libparted/disk.c: Likewise.
* include/parted/disk.in.h: Add iFFS to _PedPartitionFlag.
* tests/t0260-gpt-iffs.sh: New test against iffs flag.
* tests/Makefile.am: Add it.
---
 NEWS                     |  9 ++++++++
 include/parted/disk.in.h |  3 ++-
 libparted/disk.c         |  2 ++
 libparted/labels/gpt.c   | 59 ++++++++++++++++++++++++++++++++++++++++--------
 tests/Makefile.am        |  1 +
 tests/t0260-gpt-iffs.sh  | 44 ++++++++++++++++++++++++++++++++++++
 6 files changed, 107 insertions(+), 11 deletions(-)
 create mode 100644 tests/t0260-gpt-iffs.sh

diff --git a/NEWS b/NEWS
index 98f7c6e..7dbda21 100644
--- a/NEWS
+++ b/NEWS
@@ -45,6 +45,15 @@ GNU parted NEWS                                    -*- outline -*-
   System partitions) or "msftres" (which sets the "Microsoft Reserved" type
   code).
 
+  Added new "iffs" flag on GPT disks.  This flag corresponds to a GPT type
+  code of D3BFE2DE-3DAF-11DF-BA40-E3A556D89593 ("Intel Fast Flash"). This
+  partition type is a pre-requirements of Intel Rapid Start Technology, it is
+  needs to be a partition that's at least the size of your system's physical
+  RAM, and need given a type GUID of D3BFE2DE-3DAF-11DF-BA40-E3A556D89593.
+  The concept of Intel Rapid Start Technology is, when suspend your computer
+  and the timeout expires, the firmware just copies the entire contents of
+  RAM to iFFS partition and turns the computer off, the firmware dumps the
+  contents back into RAM and resume at next time hit the power button.
 
 * Noteworthy changes in release 3.1 (2012-03-02) [stable]
 
diff --git a/include/parted/disk.in.h b/include/parted/disk.in.h
index aa905c5..76f7c82 100644
--- a/include/parted/disk.in.h
+++ b/include/parted/disk.in.h
@@ -73,7 +73,8 @@ enum _PedPartitionFlag {
         PED_PARTITION_APPLE_TV_RECOVERY=13,
         PED_PARTITION_DIAG=14,
         PED_PARTITION_LEGACY_BOOT=15,
-        PED_PARTITION_MSFT_DATA=16
+        PED_PARTITION_IFFS=16,
+        PED_PARTITION_MSFT_DATA=17
 };
 #define PED_PARTITION_FIRST_FLAG        PED_PARTITION_BOOT
 #define PED_PARTITION_LAST_FLAG         PED_PARTITION_MSFT_DATA
diff --git a/libparted/disk.c b/libparted/disk.c
index d3cd5bb..6f033d8 100644
--- a/libparted/disk.c
+++ b/libparted/disk.c
@@ -2441,6 +2441,8 @@ ped_partition_flag_get_name (PedPartitionFlag flag)
                 return N_("diag");
         case PED_PARTITION_LEGACY_BOOT:
                 return N_("legacy_boot");
+        case PED_PARTITION_IFFS:
+                return N_("iffs");
 
 	default:
 		ped_exception_throw (
diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
index 490de70..021f36e 100644
--- a/libparted/labels/gpt.c
+++ b/libparted/labels/gpt.c
@@ -146,6 +146,10 @@ typedef struct
     ((efi_guid_t) { PED_CPU_TO_LE32 (0x5265636F), PED_CPU_TO_LE16 (0x7665), \
                     PED_CPU_TO_LE16 (0x11AA), 0xaa, 0x11, \
                     { 0x00, 0x30, 0x65, 0x43, 0xEC, 0xAC }})
+#define PARTITION_IFFS_GUID \
+    ((efi_guid_t) { PED_CPU_TO_LE32 (0xD3BFE2DE), PED_CPU_TO_LE16 (0x3DAF), \
+                    PED_CPU_TO_LE16 (0x11DF), 0xBA, 0x40, \
+                    { 0xE3, 0xA5, 0x56, 0xD8, 0x95, 0x93 }})
 
 struct __attribute__ ((packed)) _GuidPartitionTableHeader_t
 {
@@ -288,6 +292,7 @@ typedef struct _GPTPartitionData
   int atvrecv;
   int msftrecv;
   int legacy_boot;
+  int iffs;
 } GPTPartitionData;
 
 static PedDiskType gpt_disk_type;
@@ -796,7 +801,8 @@ _parse_part_entry (PedDisk *disk, GuidPartitionEntry_t *pte)
     = gpt_part_data->msftdata
     = gpt_part_data->msftrecv
     = gpt_part_data->legacy_boot
-    = gpt_part_data->bios_grub = gpt_part_data->atvrecv = 0;
+    = gpt_part_data->bios_grub = gpt_part_data->atvrecv
+    = gpt_part_data->iffs = 0;
 
   if (pte->Attributes.RequiredToFunction & 0x1)
     gpt_part_data->hidden = 1;
@@ -821,6 +827,8 @@ _parse_part_entry (PedDisk *disk, GuidPartitionEntry_t *pte)
     gpt_part_data->msftrecv = 1;
   else if (!guid_cmp (gpt_part_data->type, PARTITION_APPLE_TV_RECOVERY_GUID))
     gpt_part_data->atvrecv = 1;
+  else if (!guid_cmp (gpt_part_data->type, PARTITION_IFFS_GUID))
+    gpt_part_data->iffs = 1;
 
   return part;
 }
@@ -1338,6 +1346,7 @@ gpt_partition_new (const PedDisk *disk,
   gpt_part_data->msftrecv = 0;
   gpt_part_data->atvrecv = 0;
   gpt_part_data->legacy_boot = 0;
+  gpt_part_data->iffs = 0;
   uuid_generate ((unsigned char *) &gpt_part_data->uuid);
   swap_uuid_and_efi_guid ((unsigned char *) (&gpt_part_data->uuid));
   memset (gpt_part_data->name, 0, sizeof gpt_part_data->name);
@@ -1446,6 +1455,11 @@ gpt_partition_set_system (PedPartition *part,
       gpt_part_data->type = PARTITION_APPLE_TV_RECOVERY_GUID;
       return 1;
     }
+  if (gpt_part_data->iffs)
+    {
+      gpt_part_data->type = PARTITION_IFFS_GUID;
+      return 1;
+    }
 
   if (fs_type)
     {
@@ -1587,7 +1601,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->msftres
           = gpt_part_data->msftdata
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_BIOS_GRUB:
       gpt_part_data->bios_grub = state;
@@ -1599,7 +1614,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->msftres
           = gpt_part_data->msftdata
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_RAID:
       gpt_part_data->raid = state;
@@ -1611,7 +1627,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->msftres
           = gpt_part_data->msftdata
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_LVM:
       gpt_part_data->lvm = state;
@@ -1623,7 +1640,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->msftres
           = gpt_part_data->msftdata
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_HPSERVICE:
       gpt_part_data->hp_service = state;
@@ -1635,7 +1653,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->msftres
           = gpt_part_data->msftdata
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_MSFT_RESERVED:
       gpt_part_data->msftres = state;
@@ -1647,7 +1666,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->hp_service
           = gpt_part_data->msftdata
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_MSFT_DATA:
       gpt_part_data->msftres = state;
@@ -1659,7 +1679,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->hp_service
           = gpt_part_data->msftres
           = gpt_part_data->msftrecv
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
         gpt_part_data->msftdata = 1;
       } else {
         gpt_part_data->msftdata = 0;
@@ -1675,7 +1696,8 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->hp_service
           = gpt_part_data->msftdata
           = gpt_part_data->msftres
-          = gpt_part_data->atvrecv = 0;
+          = gpt_part_data->atvrecv
+          = gpt_part_data->iffs = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_APPLE_TV_RECOVERY:
       gpt_part_data->atvrecv = state;
@@ -1687,7 +1709,21 @@ gpt_partition_set_flag (PedPartition *part, PedPartitionFlag flag, int state)
           = gpt_part_data->hp_service
           = gpt_part_data->msftres
           = gpt_part_data->msftdata
-          = gpt_part_data->msftrecv = 0;
+          = gpt_part_data->msftrecv
+          = gpt_part_data->iffs = 0;
+      return gpt_partition_set_system (part, part->fs_type);
+    case PED_PARTITION_IFFS:
+      gpt_part_data->iffs = state;
+      if (state)
+        gpt_part_data->boot
+          = gpt_part_data->raid
+          = gpt_part_data->lvm
+          = gpt_part_data->bios_grub
+          = gpt_part_data->hp_service
+          = gpt_part_data->msftres
+          = gpt_part_data->msftdata
+          = gpt_part_data->msftrecv
+          = gpt_part_data->atvrecv = 0;
       return gpt_partition_set_system (part, part->fs_type);
     case PED_PARTITION_HIDDEN:
       gpt_part_data->hidden = state;
@@ -1735,6 +1771,8 @@ gpt_partition_get_flag (const PedPartition *part, PedPartitionFlag flag)
       return gpt_part_data->hidden;
     case PED_PARTITION_LEGACY_BOOT:
       return gpt_part_data->legacy_boot;
+    case PED_PARTITION_IFFS:
+      return gpt_part_data->iffs;
     case PED_PARTITION_SWAP:
     case PED_PARTITION_LBA:
     case PED_PARTITION_ROOT:
@@ -1761,6 +1799,7 @@ gpt_partition_is_flag_available (const PedPartition *part,
     case PED_PARTITION_APPLE_TV_RECOVERY:
     case PED_PARTITION_HIDDEN:
     case PED_PARTITION_LEGACY_BOOT:
+    case PED_PARTITION_IFFS:
       return 1;
     case PED_PARTITION_SWAP:
     case PED_PARTITION_ROOT:
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 4ec08da..7df742f 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -27,6 +27,7 @@ TESTS = \
   t0212-gpt-many-partitions.sh \
   t0220-gpt-msftres.sh \
   t0250-gpt.sh \
+  t0260-gpt-iffs.sh \
   t0280-gpt-corrupt.sh \
   t0300-dos-on-gpt.sh \
   t0301-overwrite-gpt-pmbr.sh \
diff --git a/tests/t0260-gpt-iffs.sh b/tests/t0260-gpt-iffs.sh
new file mode 100644
index 0000000..cc0a927
--- /dev/null
+++ b/tests/t0260-gpt-iffs.sh
@@ -0,0 +1,44 @@
+#!/bin/sh
+# iFFS parition type support on gpt disk type
+
+# Copyright (C) 2012-2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../parted
+
+dev=loop-file
+ss=$sector_size_
+n_sectors=5000
+
+# Create the smallest file that can accommodate a GPT partition table.
+dd if=/dev/null of=$dev bs=$ss seek=$n_sectors || framework_failure
+
+# Create a GPT partition table
+parted -s $dev mklabel gpt > out 2>&1 || fail=1
+# Expect no output
+compare /dev/null out || fail=1
+
+# Create a single partition without fs-type given
+parted -s $dev mkpart primary 1m 2m > out 2>&1 || fail=1
+# Expect no output
+compare /dev/null out || fail=1
+
+# Set the iffs flag
+parted -s $dev set 1 iffs on || fail=1
+# Ensure that setting the "iffs" flag works
+parted -s $dev u s p > out || fail=1
+grep iffs out || { fail=1; cat out; }
+
+Exit $fail
-- 
1.8.1.4


--------------020205060000060000010402--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Max Lin <mlin@HIDDEN>
Subject: bug#15268: Acknowledgement (Add Intel Fast Flash(iFFS) partition
 type support on GPT disk type)
Message-ID: <handler.15268.B.13783558638319.ack <at> debbugs.gnu.org>
References: <522808ED.2000402@HIDDEN>
X-Gnu-PR-Message: ack 15268
X-Gnu-PR-Package: parted
Reply-To: 15268 <at> debbugs.gnu.org
Date: Thu, 05 Sep 2013 04:38:04 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-parted@HIDDEN

If you wish to submit further information on this problem, please
send it to 15268 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
15268: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15268
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-parted@HIDDEN:

Subject: bug#15268: Add Intel Fast Flash(iFFS) partition type support on GPT disk type
Resent-From: "Brian C. Lane" <bcl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-parted@HIDDEN
Resent-Date: Thu, 05 Sep 2013 23:14:02 +0000
Resent-Message-ID: <handler.15268.B.137842278827776 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 15268 <at> debbugs.gnu.org
Date: Thu, 5 Sep 2013 16:09:51 -0700
From: "Brian C. Lane" <bcl@HIDDEN>
Message-ID: <20130905230951.GC1931@HIDDEN>
References: <522808ED.2000402@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="lhTn81PdljI0Ow1Z"
Content-Disposition: inline
In-Reply-To: <522808ED.2000402@HIDDEN>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--lhTn81PdljI0Ow1Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 05, 2013 at 12:30:37PM +0800, Max Lin wrote:
> Hello list,
>=20
> This patch is intend to add Intel Fast Flash(iFFS) partition type
> support on GPT disk type to parted, the GUID code of this type is
> D3BFE2DE-3DAF-11DF-BA40-E3A556D89593, this partition type is a
> requirements of Intel Rapid Start Technology[1].
>=20
> This patch also contains a test script, and no complain from "make
> distcheck". Could you please review this patch and give me any
> suggestion? Thanks a lot!!

Thanks for the patch, I actually just finished up a version of this
myself what also includes support for the msdos partition type as well.
I need to send a number of patches to the list, including that one.

--=20
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8=
PDT)

--lhTn81PdljI0Ow1Z
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQEVAwUBUikPPxF+jBaO/jp/AQIcFAgAkRLD1d8euhbVqkp42QO1zBawl8CCdgMw
9fcuGEcLuY/glruG88tdBubl8EVecLrCoNP7vxE8Zcb0PN7CpmoMAalLPvkK5H/z
TJQW8jIpEcqtzlxOSVWs11nVW5FKJ3Oj1f3TDaPhdsrt8ZOKyAx2Q5eQd+4gbyzl
mT8bjHl3qpc/vlZ88aY31pnMvi7vjLxT/NIsO2EjerMqmNmulR9iSoNG0PRYy1B8
QPeBVhaHDM81n2kxKE8RDMNq66oOKKSodThphCF6mxlENb3hBH8XUufwFDMFMZTy
1pHOwI3PhVzHBNGzzgj1e9qyun0b305TUFpBKrdVStpoS3J62R0cxw==
=4NbH
-----END PGP SIGNATURE-----

--lhTn81PdljI0Ow1Z--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.