X-Loop: help-debbugs@HIDDEN Subject: bug#15330: defmacro and define-macros still remain in guile's sources Resent-From: Stefan Israelsson Tampe <stefan.itampe@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-guile@HIDDEN Resent-Date: Tue, 10 Sep 2013 21:02:01 +0000 Resent-Message-ID: <handler.15330.B.137884691424354 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 15330 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 15330 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-guile@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.137884691424354 (code B ref -1); Tue, 10 Sep 2013 21:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Sep 2013 21:01:54 +0000 Received: from localhost ([127.0.0.1]:53395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1VJV4L-0006Kj-Ae for submit <at> debbugs.gnu.org; Tue, 10 Sep 2013 17:01:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53055) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <stefan.itampe@HIDDEN>) id 1VJV4I-0006KR-Ub for submit <at> debbugs.gnu.org; Tue, 10 Sep 2013 17:01:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <stefan.itampe@HIDDEN>) id 1VJV45-0002r6-8n for submit <at> debbugs.gnu.org; Tue, 10 Sep 2013 17:01:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <stefan.itampe@HIDDEN>) id 1VJV45-0002r1-5j for submit <at> debbugs.gnu.org; Tue, 10 Sep 2013 17:01:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <stefan.itampe@HIDDEN>) id 1VJV3w-0004J2-N2 for bug-guile@HIDDEN; Tue, 10 Sep 2013 17:01:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <stefan.itampe@HIDDEN>) id 1VJV3g-0002m2-Eg for bug-guile@HIDDEN; Tue, 10 Sep 2013 17:01:28 -0400 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:56970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <stefan.itampe@HIDDEN>) id 1VJV3g-0002lq-0u for bug-guile@HIDDEN; Tue, 10 Sep 2013 17:01:12 -0400 Received: by mail-lb0-f181.google.com with SMTP id u14so6593179lbd.26 for <bug-guile@HIDDEN>; Tue, 10 Sep 2013 14:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding:content-type; bh=7AZW1ztodUuRP5osK1Dbpy9LkvqeOtDboeqlkDh52TY=; b=jAgoof6k5LiKFPB3G/caKhxpkpuWM6ortO7Wh7BW60n+aabYaVJwZprv9/r19dbnCl gQUT6wGPoHa5s8nuLpBQ9bQQPvmAXuuGHkUQHpY8brqXNZx664ImkecXU/KU8FHsVGNn /Kjmc078FNG8RlzWipC1SF7sU9C2Ck6Nv+luo13zoc5b2VOOg2wHYq9USdJitqZP3AEX 3vZiztXYjmafjf3hQkkWfzAcLDz8+1r3EgnSYBkUN2Wc1BK/6sWSRQ1EcNmaxQhLXcwy PQZjDq/u/kahgMCIL0mOKNs1WkW81o21XK907MEuKE/L5N+w6eSUIVyNtWqtCIXieaPu m6eQ== X-Received: by 10.112.167.3 with SMTP id zk3mr12361186lbb.23.1378846870162; Tue, 10 Sep 2013 14:01:10 -0700 (PDT) Received: from warperdoze.localnet (1-1-1-39a.veo.vs.bostream.se. [82.182.254.46]) by mx.google.com with ESMTPSA id pw4sm9542275lbb.9.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Sep 2013 14:01:08 -0700 (PDT) From: Stefan Israelsson Tampe <stefan.itampe@HIDDEN> Date: Tue, 10 Sep 2013 23:01:01 +0200 Message-ID: <3027761.QpFtufJQ6k@warperdoze> User-Agent: KMail/4.9.5 (Linux/3.5.0-30-generic; KDE/4.9.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -4.0 (----) Hi, Prompted with issues caused by the old and-let* behavor due to beeing defined with a defmacro I scaned guiles sources for similar problems that we should clean up (This is a good newbie exercise) The findings that need to be cleared are, DEFINE-MACRO CALL SITES: ======================== module/srfi/srfi-4.scm: (define-macro (define-bytevector-type tag infix size) ...) module/srfi/srfi-69.scm: (define-macro (hashx-invoke hashx-proc ht-var . args) ...) (define-macro (with-hashx-values bindings ht-var . body-forms) ...) module/srfi/srfi-4/gnu.scm: (define-macro (define-bytevector-type tag infix size) ...) (define-macro (define-any->vector . tags) ...) module/system/base/syntax.scm: (define-macro (define-type name . rest) ...) (define-macro (define-record name-form . slots) ...) (define-macro (define-record/keywords name-form . slots) ...) (define-macro (transform-record type-and-common record . clauses) ...) module/system/base/language.scm: (define-macro (define-language name . spec) ...) module/system/base/lalr.upstream.scm: THIS IS A TRICKY ONE; UPSTREAM IS USING DEFINE_MACRO ;; -- Guile (guile (use-modules (ice-9 pretty-print)) (use-modules (srfi srfi-9)) (define pprint pretty-print) (define lalr-keyword? symbol?) (define-macro (BITS-PER-WORD) 30) (define-macro (logical-or x . y) `(logior ,x ,@y)) (define-macro (lalr-error msg obj) `(error ,msg ,obj))) (define-macro (lalr-parser . arguments) ...) module/statprof.scm: (define-macro (accumulate-time stop-time) ...) (define-macro (with-statprof . args) ...) module/oop/goops.scm: (define-macro (class supers . slots) ...) (define-macro (define-generic name) ...) (define-macro (define-extended-generic name val) ...) (define-macro (define-extended-generics names . args) ...) (define-macro (define-standard-accessor-method form . body) ...) module/oop/goops/save.scm: (define-macro (readable exp) ...) (define-macro (write-component object patcher file env) ...) (define-macro (restore class slots . exps) ...) module/oop/goops/accessors.scm: (define-macro (define-class-with-accessors name supers . slots) ...) (define-macro (define-class-with-accessors-keywords name supers . slots) ...) module/texinfo/plain-text.scm: (define-macro (with-indent n . body) ...) (define-macro (with-itemizer itemizer . body) ...) module/ice-9/i18n.scm: (define-macro (define-vector-langinfo-mapping name nl-items) ...) (define-macro (define-simple-langinfo-mapping name item default) ...) (define-macro (define-monetary-langinfo-mapping name local-item intl-item default/local default/intl) ...) module/ice-9/time.scm: (define-macro (time exp) ...) module/ice-9/serialize.scm: (define-macro (serialize . forms) ...) (define-macro (parallelize . forms) ...) module/ice-9/session.scm: (define-macro (help . exp) ...) module/ice-9/deprecated.scm: (define-macro (eval-case . clauses) ...) module/scripts/snarf-check-and-output-texi.scm: (define-macro (when cond . body) `(if ,cond (begin ,@body))) (define-macro (unless cond . body) `(if (not ,cond) (begin ,@body))) module/sxml/ssax/input-parse.scm: (define-macro (define-opt bindings body . body-rest) ...) module/sxml/transform.scm: (define-macro (let*-values bindings . body) ...) TEH FOLLOWING IS UPSTREAM CODE TRICKY WHAT TO DO HERE module/sxml/upstream/SXPath-old.scm:; module/sxml/upstream/SSAX.scm:;(define-macro module/sxml/upstream/SSAX.scm:; module/language/tree-il/primitives.scm:(define-macro ;;; I actually did spend about 10 minutes trying to redo this with ;;; syntax-rules. Patches appreciated. ;;; (define-macro (define-primitive-expander sym . clauses) module/language/ecmascript/base.scm: (define-macro (call/this this f . args) `(with-fluid* *this* ,this (lambda () (,f . ,args)))) (define-macro (lambda/this formals . body) `(lambda ,formals (let ((this (fluid-ref *this*))) . ,body))) (define-macro (define-js-method object name-and-args . body) `(pput ,object ',(car name-and-args) (lambda/this ,(cdr name-and-args) . ,body))) module/language/assembly/disassemble.scm: (define-macro (unless test . body) `(if (not ,test) (begin ,@body))) module/rnrs/bytevectors.scm: (define-macro (endianness sym) ...) DEFMACRO CALL SITES =================== module/ice-9/calling.scm: (defmacro with-excursion-function (vars proc) `(,proc ,(excursion-function-syntax vars))) (defmacro with-getter-and-setter (vars proc) `(,proc ,@ (getter-and-setter-syntax vars))) (defmacro with-getter (vars proc) `(,proc ,(car (getter-and-setter-syntax vars)))) defmacro with-delegating-getter-and-setter (vars get-delegate set-delegate proc) ...) (defmacro with-excursion-getter-and-setter (vars proc) `(,proc ,(excursion-function-syntax vars) ,@ (getter-and-setter-syntax vars))) (defmacro with-configuration-getter-and-setter (vars-etc proc) ...) (defmacro with-delegating-configuration-getter-and-setter (vars-etc delegate-get delegate-set proc) ...) (defmacro let-with-configuration-getter-and-setter (vars-etc proc) ...) module/ice-9/expect.scm: (defmacro expect clauses ...) (defmacro expect-strings clauses ...) /Regards Stefan
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Stefan Israelsson Tampe <stefan.itampe@HIDDEN> Subject: bug#15330: Acknowledgement (defmacro and define-macros still remain in guile's sources) Message-ID: <handler.15330.B.137884691424354.ack <at> debbugs.gnu.org> References: <3027761.QpFtufJQ6k@warperdoze> X-Gnu-PR-Message: ack 15330 X-Gnu-PR-Package: guile Reply-To: 15330 <at> debbugs.gnu.org Date: Tue, 10 Sep 2013 21:02:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-guile@HIDDEN If you wish to submit further information on this problem, please send it to 15330 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 15330: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15330 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 13 Sep 2013 03:50:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 12 23:50:54 2013 Received: from localhost ([127.0.0.1]:60362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1VKKPF-0006V1-Mr for submit <at> debbugs.gnu.org; Thu, 12 Sep 2013 23:50:53 -0400 Received: from world.peace.net ([96.39.62.75]:59499 ident=hope6) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <mhw@HIDDEN>) id 1VKKPC-0006Up-Nd for control <at> debbugs.gnu.org; Thu, 12 Sep 2013 23:50:51 -0400 Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=tines.lan) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from <mhw@HIDDEN>) id 1VKKP5-0008MB-OW; Thu, 12 Sep 2013 23:50:44 -0400 From: Mark H Weaver <mhw@HIDDEN> To: control <at> debbugs.gnu.org Date: Thu, 12 Sep 2013 23:50:32 -0400 Message-ID: <87ob7xl6rb.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 15253 wishlist severity 15359 wishlist severity 15330 minor severity 15223 wishlist thanks [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 15253 wishlist severity 15359 wishlist severity 15330 minor severity 15223 wishlist thanks [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject severity 15253 wishlist severity 15359 wishlist severity 15330 minor severity 15223 wishlist thanks
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.