GNU logs - #15347, boring messages

Message sent to bug-parted@HIDDEN:

Subject: bug#15347: [PATCH 18/19] libparted: Flush parent device on open (#962611)
Resent-From: "Brian C. Lane" <bcl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-parted@HIDDEN
Resent-Date: Wed, 11 Sep 2013 20:15:05 +0000
Resent-Message-ID: <handler.15347.B.137893049316269 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 15347 <at> debbugs.gnu.org
From: "Brian C. Lane" <bcl@HIDDEN>
Date: Wed, 11 Sep 2013 12:25:08 -0700
Message-Id: <1378927509-15215-19-git-send-email-bcl@HIDDEN>
In-Reply-To: <1378927509-15215-1-git-send-email-bcl@HIDDEN>
References: <1378927509-15215-1-git-send-email-bcl@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

From: "Brian C. Lane" <bcl@HIDDEN>

Parted probes for filesystems using geometry offsets into the parent
device, not the partition device itself. This means it may get stale
information if a partition has just been formatted.

On kernels before 2.6 this will also flush all partition devices. On 2.6
and newer kernels it will only flush the parent device.

* libparted/arch/linux.c (linux_open): Always call _flush_cache
---
 libparted/arch/linux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 375be83..492f828 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -1669,9 +1669,7 @@ retry:
                 dev->read_only = 0;
         }
 
-        /* With kernels < 2.6 flush cache for cache coherence issues */
-        if (!_have_kern26())
-                _flush_cache (dev);
+        _flush_cache (dev);
 
         return 1;
 }
-- 
1.8.3.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Brian C. Lane" <bcl@HIDDEN>
Subject: bug#15347: Acknowledgement ([PATCH 18/19] libparted: Flush parent
 device on open (#962611))
Message-ID: <handler.15347.B.137893049316269.ack <at> debbugs.gnu.org>
References: <1378927509-15215-19-git-send-email-bcl@HIDDEN>
X-Gnu-PR-Message: ack 15347
X-Gnu-PR-Package: parted
X-Gnu-PR-Keywords: patch
Reply-To: 15347 <at> debbugs.gnu.org
Date: Wed, 11 Sep 2013 20:15:07 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-parted@HIDDEN

If you wish to submit further information on this problem, please
send it to 15347 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
15347: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15347
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-parted@HIDDEN:

Subject: bug#15347: [PATCH 18/19] libparted: Flush parent device on open (#962611)
Resent-From: Phillip Susi <psusi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-parted@HIDDEN
Resent-Date: Tue, 29 Oct 2013 15:06:02 +0000
Resent-Message-ID: <handler.15347.B15347.13830591219504 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: "Brian C. Lane" <bcl@HIDDEN>
Cc: 15347 <at> debbugs.gnu.org
Message-ID: <526FCEA7.9000902@HIDDEN>
Date: Tue, 29 Oct 2013 11:05:11 -0400
From: Phillip Susi <psusi@HIDDEN>
User-Agent: Mozilla/5.0 (Windows NT 6.1;
 rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
References: <1378927509-15215-1-git-send-email-bcl@HIDDEN>
 <1378927509-15215-19-git-send-email-bcl@HIDDEN>
In-Reply-To: <1378927509-15215-19-git-send-email-bcl@HIDDEN>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I believe I know why this seems to work for you, and how to show that
it doesn't:  If you run mkfs on the partition and it is the only thing
that has an open handle to it, when it exits, the kernel automatically
flushes the partition.  If you have another process with an open fd to
the partition ( sleep 300 < /dev/sda1 & ) then you can run mkfs
immediately followed by parted print, and it should read the stale
data, since the partition is not flushed when mkfs exits, due to the
other open handle.

On 9/11/2013 3:25 PM, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@HIDDEN>
> 
> Parted probes for filesystems using geometry offsets into the
> parent device, not the partition device itself. This means it may
> get stale information if a partition has just been formatted.
> 
> On kernels before 2.6 this will also flush all partition devices.
> On 2.6 and newer kernels it will only flush the parent device.
> 
> * libparted/arch/linux.c (linux_open): Always call _flush_cache 
> --- libparted/arch/linux.c | 4 +--- 1 file changed, 1 insertion(+),
> 3 deletions(-)
> 
> diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index
> 375be83..492f828 100644 --- a/libparted/arch/linux.c +++
> b/libparted/arch/linux.c @@ -1669,9 +1669,7 @@ retry: 
> dev->read_only = 0; }
> 
> -        /* With kernels < 2.6 flush cache for cache coherence
> issues */ -        if (!_have_kern26()) -
> _flush_cache (dev); +        _flush_cache (dev);
> 
> return 1; }
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSb86mAAoJEJrBOlT6nu75XagIAMD1i+OXsK3QvE82DpLOby+7
UaB0SFXkr2Er0Mcwx1oSA4hctMOLfz0BaMPWDiy28LLafyvmY56uwP0K8i7d4jjo
PSN1RqpJUfkUhk6JYj1EalqHBv0/YT4ZjPLSKrVfJEziQPq0/wlQMSrNH3GJ4vc6
LZzTctS4v4LLXb1p0KHFq09RwD16c8xJW/5vzZy60nNnn+4SoIRjF8EU2MSi8nQ9
EJpf3F9JzIJX+x+6LLvyOtG+rgqQoyYS0BFHf5B3AYYwLAnEHDvKhC35uq53JtmX
wPfv374jGH8PSuusNxdC/PiueqUNqaL30yAmyCcg6iwsHhk74DDICk2hgZpCxAY=
=87SO
-----END PGP SIGNATURE-----

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.