X-Loop: help-debbugs@HIDDEN Subject: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems Resent-From: "Brian C. Lane" <bcl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Wed, 11 Sep 2013 20:16:04 +0000 Resent-Message-ID: <handler.15350.B.137893054816470 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 15350 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: 15350 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-parted@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.137893054816470 (code B ref -1); Wed, 11 Sep 2013 20:16:04 +0000 Received: (at submit) by debbugs.gnu.org; 11 Sep 2013 20:15:48 +0000 Received: from localhost ([127.0.0.1]:56494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1VJqpH-0004HZ-MW for submit <at> debbugs.gnu.org; Wed, 11 Sep 2013 16:15:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45827) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <bcl@HIDDEN>) id 1VJqpF-0004HN-OW for submit <at> debbugs.gnu.org; Wed, 11 Sep 2013 16:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <bcl@HIDDEN>) id 1VJqp5-0001gG-QN for submit <at> debbugs.gnu.org; Wed, 11 Sep 2013 16:15:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <bcl@HIDDEN>) id 1VJqp5-0001gA-Bw for submit <at> debbugs.gnu.org; Wed, 11 Sep 2013 16:15:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <bcl@HIDDEN>) id 1VJqp0-0002rm-Fh for bug-parted@HIDDEN; Wed, 11 Sep 2013 16:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <bcl@HIDDEN>) id 1VJqow-0001bj-2Z for bug-parted@HIDDEN; Wed, 11 Sep 2013 16:15:30 -0400 Received: from neil.brianlane.com ([24.113.37.65]:44100 helo=lister.brianlane.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <bcl@HIDDEN>) id 1VJqov-0000sS-Pt for bug-parted@HIDDEN; Wed, 11 Sep 2013 16:15:26 -0400 Received: from lister.brianlane.com (localhost [127.0.0.1]) by lister.brianlane.com (8.14.7/8.14.7) with ESMTP id r8BJPLbB015350 for <bug-parted@HIDDEN>; Wed, 11 Sep 2013 12:25:21 -0700 Received: (from bcl@localhost) by lister.brianlane.com (8.14.7/8.14.7/Submit) id r8BJPL65015349 for bug-parted@HIDDEN; Wed, 11 Sep 2013 12:25:21 -0700 From: "Brian C. Lane" <bcl@HIDDEN> Date: Wed, 11 Sep 2013 12:25:09 -0700 Message-Id: <1378927509-15215-20-git-send-email-bcl@HIDDEN> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1378927509-15215-1-git-send-email-bcl@HIDDEN> References: <1378927509-15215-1-git-send-email-bcl@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) From: "Brian C. Lane" <bcl@HIDDEN> gpt-header-munge uses perl to manipulate the gpt header for the test. It only works on 64 bit little-endian systems so restrict it to x86_64 only. * tests/t0210-gpt-resized-partition-entry-array.sh: Skip if not x86_64 * tests/t0211-gpt-rewrite-header.sh: Skip if not x86_64 --- tests/t0210-gpt-resized-partition-entry-array.sh | 5 +++++ tests/t0211-gpt-rewrite-header.sh | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/tests/t0210-gpt-resized-partition-entry-array.sh b/tests/t0210-gpt-resized-partition-entry-array.sh index 8854018..512f342 100755 --- a/tests/t0210-gpt-resized-partition-entry-array.sh +++ b/tests/t0210-gpt-resized-partition-entry-array.sh @@ -19,6 +19,11 @@ . "${srcdir=.}/init.sh"; path_prepend_ ../parted $srcdir require_perl_digest_crc_ +# gpt-header-munge will fail on big-endian systems +if test $(uname -m) != x86_64; then + skip_ 'this test only works on little-endian systems' +fi + ss=$sector_size_ N=2M diff --git a/tests/t0211-gpt-rewrite-header.sh b/tests/t0211-gpt-rewrite-header.sh index 58625a2..a87e753 100644 --- a/tests/t0211-gpt-rewrite-header.sh +++ b/tests/t0211-gpt-rewrite-header.sh @@ -23,6 +23,11 @@ . "${srcdir=.}/init.sh"; path_prepend_ ../parted $srcdir require_perl_digest_crc_ +# gpt-header-munge will fail on big-endian systems +if test $(uname -m) != x86_64; then + skip_ 'this test only works on little-endian systems' +fi + ss=$sector_size_ ns=100 # Initial number of sectors. -- 1.8.3.1
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: "Brian C. Lane" <bcl@HIDDEN> Subject: bug#15350: Acknowledgement ([PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems) Message-ID: <handler.15350.B.137893054816470.ack <at> debbugs.gnu.org> References: <1378927509-15215-20-git-send-email-bcl@HIDDEN> X-Gnu-PR-Message: ack 15350 X-Gnu-PR-Package: parted X-Gnu-PR-Keywords: patch Reply-To: 15350 <at> debbugs.gnu.org Date: Wed, 11 Sep 2013 20:16:05 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-parted@HIDDEN If you wish to submit further information on this problem, please send it to 15350 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 15350: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15350 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems Resent-From: Phillip Susi <psusi@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Fri, 28 Feb 2014 19:16:02 +0000 Resent-Message-ID: <handler.15350.B15350.13936149568157 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 15350 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: "Brian C. Lane" <bcl@HIDDEN>, 15350 <at> debbugs.gnu.org Received: via spool by 15350-submit <at> debbugs.gnu.org id=B15350.13936149568157 (code B ref 15350); Fri, 28 Feb 2014 19:16:02 +0000 Received: (at 15350) by debbugs.gnu.org; 28 Feb 2014 19:15:56 +0000 Received: from localhost ([127.0.0.1]:44948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1WJSuZ-00027V-Nc for submit <at> debbugs.gnu.org; Fri, 28 Feb 2014 14:15:55 -0500 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:34339) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <psusi@HIDDEN>) id 1WJSuX-00027M-GG for 15350 <at> debbugs.gnu.org; Fri, 28 Feb 2014 14:15:53 -0500 X-Authority-Analysis: v=2.0 cv=MODiabll c=1 sm=0 a=/DbS/tiKggfTkRRHPZEB4g==:17 a=JipEcVzqA9wA:10 a=fSNXTqN2JtcA:10 a=S1A5HrydsesA:10 a=Qsx_du5GiBkA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=ntDPxGdvJUcA:10 a=20KFwNOVAAAA:8 a=QfKxxUxMAAAA:8 a=g3etPokkDRXHZvhSJcsA:9 a=wPNLvfGTeEIA:10 a=jEp0ucaQiEUA:10 a=/DbS/tiKggfTkRRHPZEB4g==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.78.168.186 Received: from [67.78.168.186] ([67.78.168.186:50031] helo=[10.1.1.236]) by cdptpa-oedge03.mail.rr.com (envelope-from <psusi@HIDDEN>) (ecelerity 2.2.3.46 r()) with ESMTP id FF/78-23887-760E0135; Fri, 28 Feb 2014 19:15:51 +0000 Message-ID: <5310E068.9020707@HIDDEN> Date: Fri, 28 Feb 2014 14:15:52 -0500 From: Phillip Susi <psusi@HIDDEN> User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <1378927509-15215-1-git-send-email-bcl@HIDDEN> <1378927509-15215-20-git-send-email-bcl@HIDDEN> In-Reply-To: <1378927509-15215-20-git-send-email-bcl@HIDDEN> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 9/11/2013 3:25 PM, Brian C. Lane wrote: > From: "Brian C. Lane" <bcl@HIDDEN> > > gpt-header-munge uses perl to manipulate the gpt header for the > test. It only works on 64 bit little-endian systems so restrict it > to x86_64 only. I was wondering; is this a bug in the script, or a bug in perl? It would be preferable to fix it so it works than to skip it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTEOBoAAoJEI5FoCIzSKrwUXMIAKhxkI6MVUFujfTa0X2r6GUk fHykFPJExwaxNe5OI0YDlaBJznxe8/KdzPB+3Gzoubnze5pgJSgY0ibCsfqsgH4O DOt0zpULEQ3CWwrNf9XiI1wNuzYOYYZ7I33k+4xWe2w/P8jLAOOcM+oFtEp4wkJu O8h4K2qZU9kjtekaSdv0XMa6LU5X8F6Ue2NaCMd3OwMXjmkAZ4QzIuOhbH8PKm0R I6LIOEO32lU9DGpxg+IarRFe80PKAvq/XyzL/2w1oTVxQAtqkeNuELixOPoKCw8g 5sJB6cPPmBqkMp9rE/iGl+TR1GB8iMeg+eaQi26YG2c+oSXHqhIGoMeLS8s93JM= =xQgN -----END PGP SIGNATURE-----
X-Loop: help-debbugs@HIDDEN Subject: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems Resent-From: "Brian C. Lane" <bcl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Fri, 28 Feb 2014 20:12:01 +0000 Resent-Message-ID: <handler.15350.B15350.139361827213898 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 15350 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi <psusi@HIDDEN> Cc: 15350 <at> debbugs.gnu.org Received: via spool by 15350-submit <at> debbugs.gnu.org id=B15350.139361827213898 (code B ref 15350); Fri, 28 Feb 2014 20:12:01 +0000 Received: (at 15350) by debbugs.gnu.org; 28 Feb 2014 20:11:12 +0000 Received: from localhost ([127.0.0.1]:44980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1WJTm3-0003c4-74 for submit <at> debbugs.gnu.org; Fri, 28 Feb 2014 15:11:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34235) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <bcl@HIDDEN>) id 1WJTm0-0003bv-Mu for 15350 <at> debbugs.gnu.org; Fri, 28 Feb 2014 15:11:09 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1SKB7HU029330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Feb 2014 15:11:07 -0500 Received: from lister.brianlane.com (ovpn-113-141.phx2.redhat.com [10.3.113.141]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1SJU2Oq012496 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 28 Feb 2014 14:30:03 -0500 Date: Fri, 28 Feb 2014 11:29:52 -0800 From: "Brian C. Lane" <bcl@HIDDEN> Message-ID: <20140228192952.GH12066@HIDDEN> References: <1378927509-15215-1-git-send-email-bcl@HIDDEN> <1378927509-15215-20-git-send-email-bcl@HIDDEN> <5310E068.9020707@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5310E068.9020707@HIDDEN> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) On Fri, Feb 28, 2014 at 02:15:52PM -0500, Phillip Susi wrote: > On 9/11/2013 3:25 PM, Brian C. Lane wrote: > > From: "Brian C. Lane" <bcl@HIDDEN> > > > > gpt-header-munge uses perl to manipulate the gpt header for the > > test. It only works on 64 bit little-endian systems so restrict it > > to x86_64 only. > > I was wondering; is this a bug in the script, or a bug in perl? It > would be preferable to fix it so it works than to skip it. IIRC it is a problem with using perl to do this, its unpack doesn't handle the order correctly. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
X-Loop: help-debbugs@HIDDEN Subject: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems Resent-From: Phillip Susi <psusi@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Sun, 02 Mar 2014 02:58:02 +0000 Resent-Message-ID: <handler.15350.B15350.139372906529238 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 15350 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: "Brian C. Lane" <bcl@HIDDEN> Cc: 15350 <at> debbugs.gnu.org Received: via spool by 15350-submit <at> debbugs.gnu.org id=B15350.139372906529238 (code B ref 15350); Sun, 02 Mar 2014 02:58:02 +0000 Received: (at 15350) by debbugs.gnu.org; 2 Mar 2014 02:57:45 +0000 Received: from localhost ([127.0.0.1]:47228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1WJwb1-0007bQ-S3 for submit <at> debbugs.gnu.org; Sat, 01 Mar 2014 21:57:44 -0500 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:37649) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <psusi@HIDDEN>) id 1WJwax-0007bH-Mr for 15350 <at> debbugs.gnu.org; Sat, 01 Mar 2014 21:57:40 -0500 X-Authority-Analysis: v=2.0 cv=H69ZMpki c=1 sm=0 a=S/gQ7PeTrZbCJAhh99lbaw==:17 a=cs1xLa0W9aIA:10 a=fSNXTqN2JtcA:10 a=S1A5HrydsesA:10 a=ossw24rp0ecA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=QfKxxUxMAAAA:8 a=8LZwEyKflO1RJpIXHPQA:9 a=wPNLvfGTeEIA:10 a=S/gQ7PeTrZbCJAhh99lbaw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 72.238.67.160 Received: from [72.238.67.160] ([72.238.67.160:58206] helo=[192.168.1.101]) by cdptpa-oedge04.mail.rr.com (envelope-from <psusi@HIDDEN>) (ecelerity 2.2.3.46 r()) with ESMTP id 43/F4-11872-12E92135; Sun, 02 Mar 2014 02:57:37 +0000 Message-ID: <53129E22.9080304@HIDDEN> Date: Sat, 01 Mar 2014 21:57:38 -0500 From: Phillip Susi <psusi@HIDDEN> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <1378927509-15215-1-git-send-email-bcl@HIDDEN> <1378927509-15215-20-git-send-email-bcl@HIDDEN> <5310E068.9020707@HIDDEN> <20140228192952.GH12066@HIDDEN> In-Reply-To: <20140228192952.GH12066@HIDDEN> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 02/28/2014 02:29 PM, Brian C. Lane wrote: >>> gpt-header-munge uses perl to manipulate the gpt header for >>> the test. It only works on 64 bit little-endian systems so >>> restrict it to x86_64 only. >> >> I was wondering; is this a bug in the script, or a bug in perl? >> It would be preferable to fix it so it works than to skip it. > > IIRC it is a problem with using perl to do this, its unpack > doesn't handle the order correctly. So this test already fails for me on current git master ( didn't have that perl module installed before so it was skipped ), apparently because gpt-header-munge puts the backup gpt in the wrong place. Do you happen to remember what the error was you saw on the other systems? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTEp4iAAoJEI5FoCIzSKrwffcH/2fxgV89d67x0QRe6I7ohSai SDNL+b7vnzfP4bHhkIjh8EK1EZQN12v3T5/nC26toMCm3VKYvMx1Tv4KOyEDrPlT kVt7cmndHlx98oQ+4ym2RQZSedzdDQqXuR3YhFusgleExdgYTS3fZ2W3QDnVhQSg Of5L3lGidB39poy5gqwnetwfpPdlpV/aQxiAn3H4TH8rWJIa/0S4FDWeDh/HHSUN IBRnhGhjgutlxk+KmC9cvz1edRt8UpiDfoKy7Mf/B6DrBJ4YRMERrIqdSXbR83+h lR4yBFOIz53uPy5LXoMp9JhsBAV/5ff3IkIkXvm4gLGYfSw0PI/dKYYHDnM76Ic= =ITxh -----END PGP SIGNATURE-----
X-Loop: help-debbugs@HIDDEN Subject: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems Resent-From: "Brian C. Lane" <bcl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Mon, 03 Mar 2014 15:12:02 +0000 Resent-Message-ID: <handler.15350.B15350.139385948518638 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 15350 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi <psusi@HIDDEN> Cc: 15350 <at> debbugs.gnu.org Received: via spool by 15350-submit <at> debbugs.gnu.org id=B15350.139385948518638 (code B ref 15350); Mon, 03 Mar 2014 15:12:02 +0000 Received: (at 15350) by debbugs.gnu.org; 3 Mar 2014 15:11:25 +0000 Received: from localhost ([127.0.0.1]:49243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1WKUWa-0004qW-UU for submit <at> debbugs.gnu.org; Mon, 03 Mar 2014 10:11:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54365) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <bcl@HIDDEN>) id 1WKUWW-0004qI-Vs for 15350 <at> debbugs.gnu.org; Mon, 03 Mar 2014 10:11:22 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s23FBIED005370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Mar 2014 10:11:19 -0500 Received: from lister.brianlane.com (ovpn-113-173.phx2.redhat.com [10.3.113.173]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s23FBGPS031877 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 3 Mar 2014 10:11:18 -0500 Date: Mon, 3 Mar 2014 07:11:16 -0800 From: "Brian C. Lane" <bcl@HIDDEN> Message-ID: <20140303151116.GA2492@HIDDEN> References: <1378927509-15215-1-git-send-email-bcl@HIDDEN> <1378927509-15215-20-git-send-email-bcl@HIDDEN> <5310E068.9020707@HIDDEN> <20140228192952.GH12066@HIDDEN> <53129E22.9080304@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53129E22.9080304@HIDDEN> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) On Sat, Mar 01, 2014 at 09:57:38PM -0500, Phillip Susi wrote: > On 02/28/2014 02:29 PM, Brian C. Lane wrote: > >>> gpt-header-munge uses perl to manipulate the gpt header for > >>> the test. It only works on 64 bit little-endian systems so > >>> restrict it to x86_64 only. > >> > >> I was wondering; is this a bug in the script, or a bug in perl? > >> It would be preferable to fix it so it works than to skip it. > > > > IIRC it is a problem with using perl to do this, its unpack > > doesn't handle the order correctly. > > So this test already fails for me on current git master ( didn't have > that perl module installed before so it was skipped ), apparently > because gpt-header-munge puts the backup gpt in the wrong place. Do > you happen to remember what the error was you saw on the other systems? Sorry I don't. I just remember that it was related to big vs. little endian support. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.