X-Loop: help-debbugs@HIDDEN Subject: bug#15361: git send-email creates one report per patch Resent-From: Glenn Morris <rgm@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: help-debbugs@HIDDEN Resent-Date: Thu, 12 Sep 2013 20:12:01 +0000 Resent-Message-ID: <handler.15361.B.137901669813229 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 15361 X-GNU-PR-Package: debbugs.gnu.org X-GNU-PR-Keywords: To: 15361 <at> debbugs.gnu.org X-Debbugs-Original-To: submit <at> debbugs.gnu.org Received: via spool by submit <at> debbugs.gnu.org id=B.137901669813229 (code B ref -1); Thu, 12 Sep 2013 20:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Sep 2013 20:11:38 +0000 Received: from localhost ([127.0.0.1]:59669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1VKDEn-0003RI-9R for submit <at> debbugs.gnu.org; Thu, 12 Sep 2013 16:11:37 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:55302 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <rgm@HIDDEN>) id 1VKDEl-0003RB-OL for submit <at> debbugs.gnu.org; Thu, 12 Sep 2013 16:11:36 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from <rgm@HIDDEN>) id 1VKDEk-0005XS-SE; Thu, 12 Sep 2013 16:11:34 -0400 From: Glenn Morris <rgm@HIDDEN> Date: Thu, 12 Sep 2013 16:11:34 -0400 Message-ID: <h9r4ctrea1.fsf@HIDDEN> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.9 (-----) Package: debbugs.gnu.org If you send a collection of patches to bug-foo via git send-email, it creates one report per patch. Here's why: How it normally works: You send a new report to the bug-foo mailing list. You get an ack saying "thanks, reply to 123@debbugs with more info". When the mail arrives at the bug-foo mailing list after processing, it has "Bug#123" in the subject, and seems to be addressed "To: 123@debbugs". If someone sends a reply, it either has "Re: Bug#123" in the subject, or it goes to 123@debbugs. In either case, it is trivial for debbugs to work out that the message is a reply to an existing bug rather than a new report. The lovely emails sent by git have no consistent subject and are all addressed to bug-foo. Thus, there is no way to tell they are all related except by tracking the message-id of the original report and looking for a references: header in later emails. I did actually implement that, but it replies on the message-id getting into the bug database index, which is only updated every 5(?) minutes or so. When a bunch of emails arrive all at the same time, as from git, it cannot work. To fix this, need to force message-id into the index immediately after a new report arrives. I don't know how much work that is, or when I'll have time to look at it. Workaround: first create a report ("here's the problem for which I will send a patch"), then send patches to that bug number rather than bug-foo.
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Glenn Morris <rgm@HIDDEN> Subject: bug#15361: Acknowledgement (git send-email creates one report per patch) Message-ID: <handler.15361.B.137901669813229.ack <at> debbugs.gnu.org> References: <h9r4ctrea1.fsf@HIDDEN> X-Gnu-PR-Message: ack 15361 X-Gnu-PR-Package: debbugs.gnu.org Reply-To: 15361 <at> debbugs.gnu.org Date: Thu, 12 Sep 2013 20:12:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): help-debbugs@HIDDEN If you wish to submit further information on this problem, please send it to 15361 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 15361: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15361 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#15361: git send-email creates one report per patch Resent-From: Jim Meyering <jim@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: help-debbugs@HIDDEN Resent-Date: Mon, 23 Sep 2013 14:44:02 +0000 Resent-Message-ID: <handler.15361.B15361.137994738621408 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 15361 X-GNU-PR-Package: debbugs.gnu.org X-GNU-PR-Keywords: To: Glenn Morris <rgm@HIDDEN> Cc: 15361 <at> debbugs.gnu.org Received: via spool by 15361-submit <at> debbugs.gnu.org id=B15361.137994738621408 (code B ref 15361); Mon, 23 Sep 2013 14:44:02 +0000 Received: (at 15361) by debbugs.gnu.org; 23 Sep 2013 14:43:06 +0000 Received: from localhost ([127.0.0.1]:58217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1VO7Lt-0005ZD-FN for submit <at> debbugs.gnu.org; Mon, 23 Sep 2013 10:43:05 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:61533) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <meyering@HIDDEN>) id 1VO7Lp-0005Yf-Mc for 15361 <at> debbugs.gnu.org; Mon, 23 Sep 2013 10:43:02 -0400 Received: by mail-pb0-f41.google.com with SMTP id rp2so3294519pbb.14 for <15361 <at> debbugs.gnu.org>; Mon, 23 Sep 2013 07:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=wseBJE6Xi00p9cyqGv4XbD+/TuaXJ1bVOMFne47cCcA=; b=f9+JqEtm8VOycD5D57FLPq/p8WZr+Cx2ExNuiyb/PeKW70Gx+Rus29PMhCnI4wmqzK TemtxMHt0ArWIlyrgLKnwHA4OYWnA7WfYfIFqJIGjtQ3bb18nH/SuDYB1gITMg/7ZyYA j69ayyiS4dWQYq7q6o5j2+iVWUy2IxKCnSNNm+TKDEwIiOQ6AkvrDx4PAiFvDwTR/R2H mnW0KEPYcr/gm1tiHLAjl4iOmG6TTZQZByZ5viZbXbvkLpLI7PKsWXl2l7svfaPgLzwt pdehzXtRdUBgzqs1I0ODdKLj6sObeN8ZS2BSJ8uPH9JPAeGbYVPFV5lgUKQHOiMWUcpe rhhw== X-Received: by 10.67.23.164 with SMTP id ib4mr25513978pad.42.1379947375230; Mon, 23 Sep 2013 07:42:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Mon, 23 Sep 2013 07:42:35 -0700 (PDT) In-Reply-To: <h9r4ctrea1.fsf@HIDDEN> References: <h9r4ctrea1.fsf@HIDDEN> From: Jim Meyering <jim@HIDDEN> Date: Mon, 23 Sep 2013 07:42:35 -0700 X-Google-Sender-Auth: 9QQnR1A-C11jqTDZWTH-xpRfFhg Message-ID: <CA+8g5KEPTpv+LvEgPT7qdh=Tbk1eGWGqZ3DGM8kKXu5DVVALGg@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) On Thu, Sep 12, 2013 at 1:11 PM, Glenn Morris <rgm@HIDDEN> wrote: > Package: debbugs.gnu.org > > If you send a collection of patches to bug-foo via git send-email, > it creates one report per patch. Here's why: ... Hi Glenn, Doesn't git send-email's --in-reply-to option solve this problem? --in-reply-to=<identifier> Make the first mail (or all the mails with --no-thread) appear as a reply to the given Message-Id, which avoids breaking threads to provide a new patch series. The second and subsequent emails will be sent as replies according to the --[no]-chain-reply-to setting. So for example when --thread and --no-chain-reply-to are specified, the second and subsequent patches will be replies to the first one like in the illustration below where [PATCH v2 0/3] is in reply to [PATCH 0/2]: [PATCH 0/2] Here is what I did... [PATCH 1/2] Clean up and tests [PATCH 2/2] Implementation [PATCH v2 0/3] Here is a reroll [PATCH v2 1/3] Clean up [PATCH v2 2/3] New tests [PATCH v2 3/3] Implementation
X-Loop: help-debbugs@HIDDEN Subject: bug#15361: git send-email creates one report per patch Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: help-debbugs@HIDDEN Resent-Date: Mon, 02 Jun 2014 17:50:01 +0000 Resent-Message-ID: <handler.15361.B15361.140173138332391 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 15361 X-GNU-PR-Package: debbugs.gnu.org X-GNU-PR-Keywords: To: Glenn Morris <rgm@HIDDEN> Cc: 15361 <at> debbugs.gnu.org Received: via spool by 15361-submit <at> debbugs.gnu.org id=B15361.140173138332391 (code B ref 15361); Mon, 02 Jun 2014 17:50:01 +0000 Received: (at 15361) by debbugs.gnu.org; 2 Jun 2014 17:49:43 +0000 Received: from localhost ([127.0.0.1]:41199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1WrWMg-0008QM-Os for submit <at> debbugs.gnu.org; Mon, 02 Jun 2014 13:49:43 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:48115) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from <monnier@HIDDEN>) id 1WrWMd-0008QD-PI for 15361 <at> debbugs.gnu.org; Mon, 02 Jun 2014 13:49:40 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id B72512413F; Mon, 2 Jun 2014 13:49:38 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 05F451E5B7C; Mon, 2 Jun 2014 13:49:14 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id CE6E3B40F6; Mon, 2 Jun 2014 13:49:14 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> Message-ID: <jwvwqczcinz.fsf-monnier+bug#15361@HIDDEN> References: <h9r4ctrea1.fsf@HIDDEN> Date: Mon, 02 Jun 2014 13:49:14 -0400 In-Reply-To: <h9r4ctrea1.fsf@HIDDEN> (Glenn Morris's message of "Thu, 12 Sep 2013 16:11:34 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.38, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_REPONSE 0.33, MC_TRANSFR 0.11, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@HIDDEN X-Spam-Status: No X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.0 (---) > I did actually implement that, but it replies on the message-id getting > into the bug database index, which is only updated every 5(?) minutes or > so. When a bunch of emails arrive all at the same time, as from git, it > cannot work. > To fix this, need to force message-id into the index immediately after a > new report arrives. I don't know how much work that is, or when I'll > have time to look at it. Doing it more promptly won't be always sufficient: the message may arrive in a different order. So in order to make it work reliably, we should do something more devious, such as: - postpone processing of messages with an "in-repy-to" that's not found in the message-id database. - when we receive a message with an "in-reply-to" that's not found in the message-id database, allocate a new bug-nb for it and add that message-id to the database. Then when a message arrives, don't only look for its in-reply-to in the database but also its message-id! And then figure out a way to handle the "deeper" threading case where we first receive the grand-child, then the grand parent, and only third the in-between. Postponing, seems like a "cheap" way to solve 99% of the problem. Stefan
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.