GNU logs - #15793, boring messages

Message sent to bug-libtool@HIDDEN:

Subject: bug#15793: Bug: linking shared libraries on Cygwin results in undefined references to __stack_chck_guard for code compiled with -fstack-protector
Resent-From: Richard PALO <richard.palo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Sat, 02 Nov 2013 23:16:01 +0000
Resent-Message-ID: <handler.15793.B.13834341328270 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 15793 <at> debbugs.gnu.org
Cc: libtool-patches@HIDDEN
From: Richard PALO <richard.palo@HIDDEN>
Date: Sat, 02 Nov 2013 23:45:29 +0100
Lines: 30
Message-ID: <l53v9v$gjn$1@HIDDEN>
References: <AANLkTimBUMzojnf9RAqAowJGGG_B8c8o-R5Aq9bjWvYs@HIDDEN>
 <20100601222415.23d4ea46@YAAKOV04>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
User-Agent: Mozilla/5.0 (X11; SunOS i86pc;
 rv:24.0) Gecko/20100101 Thunderbird/24.0.1
In-Reply-To: <20100601222415.23d4ea46@YAAKOV04>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Le 02/06/10 05:24, Yaakov (Cygwin/X) a �crit :
> On Sat, 15 May 2010 09:07:49 +0200
> Bart Van Assche <bvanassche@HIDDEN> wrote:
>> This behavior has been observed with libtool version 2.2.6.
>
> Bug confirmed.  When code is compiled with -fstack-protector{,-all},
> GCC "emits extra code to check for buffer overflows, such as stack
> smashing attacks".  This extra code uses symbols from libssp, and
> therefore (at least) Cygwin's GCC specs contain:
>
> *link_ssp:
> %{fstack-protector|fstack-protector-all:-lssp_nonshared -lssp}
>
> Therefore, when libtool fails to pass -fstack-protector{,-all} at link
> stage, the link fails.
>
> Patch attached.  (Yes, I have a copyright assignment on file.)
>
>
> Yaakov
> Cygwin/X
>

I've done some limited testing of this patch on a SunOS distro with 
pkgsrc, and it certainly helps a number of cases since it is gcc that 
generates the necessary '-lssp_nonshared -lssp' libs for linking (at 
least in absence of '-nostdlib').

Please include in the upcoming version.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Richard PALO <richard.palo@HIDDEN>
Subject: bug#15793: Acknowledgement (Bug: linking shared libraries on
 Cygwin results in undefined references to __stack_chck_guard for code
 compiled with -fstack-protector)
Message-ID: <handler.15793.B.13834341328270.ack <at> debbugs.gnu.org>
References: <l53v9v$gjn$1@HIDDEN>
X-Gnu-PR-Message: ack 15793
X-Gnu-PR-Package: libtool
Reply-To: 15793 <at> debbugs.gnu.org
Date: Sat, 02 Nov 2013 23:16:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-libtool@HIDDEN

If you wish to submit further information on this problem, please
send it to 15793 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
15793: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15793
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-libtool@HIDDEN:

Subject: bug#15793: Bug: linking shared libraries on Cygwin results in undefined references to __stack_chck_guard for code compiled with -fstack-protector
Resent-From: Richard PALO <richard@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Thu, 24 Sep 2015 16:47:01 +0000
Resent-Message-ID: <handler.15793.B.144311316422544 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: libtool-patches@HIDDEN
Cc: 15793 <at> debbugs.gnu.org
Message-ID: <5603F78D.4060202@HIDDEN>
Date: Thu, 24 Sep 2015 15:15:57 +0200
From: Richard PALO <richard@HIDDEN>
User-Agent: Mozilla/5.0 (X11; SunOS i86pc;
 rv:) Gecko/20100101 Thunderbird/24.8.1
MIME-Version: 1.0
Newsgroups: gmane.comp.gnu.libtool.patches,gmane.comp.gnu.libtool.bugs
References: <AANLkTimBUMzojnf9RAqAowJGGG_B8c8o-R5Aq9bjWvYs@HIDDEN>	<20100601222415.23d4ea46@YAAKOV04>
 <l53v9v$gjn$1@HIDDEN>
In-Reply-To: <l53v9v$gjn$1@HIDDEN>
Content-Type: multipart/mixed; boundary="------------010200060800090705000308"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------010200060800090705000308
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Le 02/11/13 23:45, Richard PALO a =C3=A9crit :
> Le 02/06/10 05:24, Yaakov (Cygwin/X) a =C3=A9crit :
>> On Sat, 15 May 2010 09:07:49 +0200
>> Bart Van Assche <bvanassche@HIDDEN> wrote:
>>> This behavior has been observed with libtool version 2.2.6.
>>
>> Bug confirmed.  When code is compiled with -fstack-protector{,-all},
>> GCC "emits extra code to check for buffer overflows, such as stack
>> smashing attacks".  This extra code uses symbols from libssp, and
>> therefore (at least) Cygwin's GCC specs contain:
>>
>> *link_ssp:
>> %{fstack-protector|fstack-protector-all:-lssp_nonshared -lssp}
>>
>> Therefore, when libtool fails to pass -fstack-protector{,-all} at link
>> stage, the link fails.
>>
>> Patch attached.  (Yes, I have a copyright assignment on file.)
>>
>>
>> Yaakov
>> Cygwin/X
>>
>=20
> I've done some limited testing of this patch on a SunOS distro with=20
> pkgsrc, and it certainly helps a number of cases since it is gcc that=20
> generates the necessary '-lssp_nonshared -lssp' libs for linking (at=20
> least in absence of '-nostdlib').
>=20
> Please include in the upcoming version.
>=20
>=20
>=20
>=20

I'd like to propose a slight modification this which, in addition, seems =
to get over the
issue (at least on solaris) of c++ shared libraries linking '-nostdlib'. =
=20

This could easily be adapted for other hosts using g++. Note, it is harml=
ess if '-dumpspecs'
or no spec with fstack-protector* is available.

It appears there was no warm welcome in tossing the '-nostdlib' setup for=
 g++ shared libraries=20
for solaris, so this seems to be a reasonable workaround.

--=20
Richard PALO


--------------010200060800090705000308
Content-Type: text/x-patch;
 name="0001-workaround-for-nostdlib-with-fstack-protector-on-sol.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="0001-workaround-for-nostdlib-with-fstack-protector-on-sol.pa";
 filename*1="tch"

From 5dfcf84c8243441f30a3c852791b8d46bc4d2c53 Mon Sep 17 00:00:00 2001
From: Richard PALO <richard@HIDDEN>
Date: Thu, 24 Sep 2015 13:23:56 +0200
Subject: [PATCH] workaround for -nostdlib with -fstack-protector on solaris

---
 build-aux/ltmain.in | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index 0c40da0..7a6356b 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -5364,8 +5364,7 @@ func_mode_link ()
       # -stdlib=*            select c++ std lib with clang
       -64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \
       -t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
-      -O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
-      -specs=*)
+      -O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-stdlib=*|-specs=*)
         func_quote_for_eval "$arg"
 	arg=$func_quote_for_eval_result
         func_append compile_command " $arg"
@@ -5374,6 +5373,25 @@ func_mode_link ()
         continue
         ;;
 
+      -fstack-protector*)
+        func_quote_for_eval "$arg"
+        arg=$func_quote_for_eval_result
+        func_append compile_command " $arg"
+        func_append finalize_command " $arg"
+        func_append compiler_flags " $arg"
+
+        # Explicitly add solaris ssp libs to postdeps to counter
+        # linking with g++ -nostdlib when supplied -fstack-protector*
+        test CXX = "$tagname" && {
+          case $host_os in
+          solaris*)
+            func_append postdeps " `$compile_command -dumpspecs 2>/dev/null | $SED -n '/fstack-protector/{s/^.*://;s/}$//;p;}'`"
+            ;;
+          esac
+        }
+        continue
+        ;;
+
       -Z*)
         if test os2 = "`expr $host : '.*\(os2\)'`"; then
           # OS/2 uses -Zxxx to specify OS/2-specific options
-- 
2.5.2


--------------010200060800090705000308--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.