GNU logs - #15875, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#15875: 24.3.50; diff-mode counts first column when determining tab width
Resent-From: Nathan Trapuzzano <nbtrap@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 Nov 2013 13:36:02 +0000
Resent-Message-ID: <handler.15875.B.13842633202727 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 15875 <at> debbugs.gnu.org
From: Nathan Trapuzzano <nbtrap@HIDDEN>
Date: Tue, 12 Nov 2013 08:34:12 -0500
Message-ID: <87d2m5eobv.fsf@HIDDEN>
User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

In diff-mode, When determining how many columns wide a given tab
character should be, the calculation should happen as thought the second
column were the first.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Nathan Trapuzzano <nbtrap@HIDDEN>
Subject: bug#15875: Acknowledgement (24.3.50; diff-mode counts first
 column when determining tab width)
Message-ID: <handler.15875.B.13842633202727.ack <at> debbugs.gnu.org>
References: <87d2m5eobv.fsf@HIDDEN>
X-Gnu-PR-Message: ack 15875
X-Gnu-PR-Package: emacs
Reply-To: 15875 <at> debbugs.gnu.org
Date: Tue, 12 Nov 2013 13:36:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 15875 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
15875: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15875
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#15875: 24.3.50; diff-mode counts first column when determining tab width
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 Nov 2013 15:50:02 +0000
Resent-Message-ID: <handler.15875.B15875.138427137517028 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Nathan Trapuzzano <nbtrap@HIDDEN>
Cc: 15875 <at> debbugs.gnu.org
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvob5pd3uj.fsf-monnier+emacsbugs@HIDDEN>
References: <87d2m5eobv.fsf@HIDDEN>
Date: Tue, 12 Nov 2013 10:49:25 -0500
In-Reply-To: <87d2m5eobv.fsf@HIDDEN> (Nathan Trapuzzano's message of "Tue, 
 12 Nov 2013 08:34:12 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

severity 15875 wishlist
thanks

> In diff-mode, When determining how many columns wide a given tab
> character should be, the calculation should happen as thought the second
> column were the first.

Indeed.  Maybe we could get something like that by adding a `tab-offset'
so that TAB chars insert a strechable space to the next
(+ (* tab-width N) tab-offset) instead of just the next (* tab-width N).

Then we can make diff-mode set this tab-offset based on whether we're
looking at a unified or plain or context diff (or a Git-style
multi-diffs, i.e. unified but with more than 2 versions, where each
additional version adds a column of +/-).

Note that diff-mode also handles diffs that have a mix of context-style
and unified-style hunks, but such a tab-offset feature wouldn't be able
to handle it correctly.  Not a big issue, tho.

        Stefan

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 12 Nov 2013 15:49:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 12 10:49:36 2013
Received: from localhost ([127.0.0.1]:48957 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1VgGDf-0004Qb-Kc
	for submit <at> debbugs.gnu.org; Tue, 12 Nov 2013 10:49:35 -0500
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:42997)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>)
 id 1VgGDb-0004QH-T1; Tue, 12 Nov 2013 10:49:32 -0500
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCqr1/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV
X-IPAS-Result: Av8EABK/CFFMCqr1/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV
X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37681564"
Received: from 76-10-170-245.dsl.teksavvy.com (HELO pastel.home)
 ([76.10.170.245])
 by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
 12 Nov 2013 10:49:25 -0500
Received: by pastel.home (Postfix, from userid 20848)
 id 8E528630BF; Tue, 12 Nov 2013 10:49:25 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Nathan Trapuzzano <nbtrap@HIDDEN>
Subject: Re: bug#15875: 24.3.50;
 diff-mode counts first column when determining tab width
Message-ID: <jwvob5pd3uj.fsf-monnier+emacsbugs@HIDDEN>
References: <87d2m5eobv.fsf@HIDDEN>
Date: Tue, 12 Nov 2013 10:49:25 -0500
In-Reply-To: <87d2m5eobv.fsf@HIDDEN> (Nathan Trapuzzano's message of "Tue, 
 12 Nov 2013 08:34:12 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: control
Cc: 15875 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

severity 15875 wishlist
thanks

> In diff-mode, When determining how many columns wide a given tab
> character should be, the calculation should happen as thought the second
> column were the first.

Indeed.  Maybe we could get something like that by adding a `tab-offset'
so that TAB chars insert a strechable space to the next
(+ (* tab-width N) tab-offset) instead of just the next (* tab-width N).

Then we can make diff-mode set this tab-offset based on whether we're
looking at a unified or plain or context diff (or a Git-style
multi-diffs, i.e. unified but with more than 2 versions, where each
additional version adds a column of +/-).

Note that diff-mode also handles diffs that have a mix of context-style
and unified-style hunks, but such a tab-offset feature wouldn't be able
to handle it correctly.  Not a big issue, tho.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#15875: 24.3.50; diff-mode counts first column when determining tab width
Resent-From: Nathan Trapuzzano <nbtrap@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 Nov 2013 15:53:02 +0000
Resent-Message-ID: <handler.15875.B15875.138427154317322 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 15875
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 15875 <at> debbugs.gnu.org
Received: via spool by 15875-submit <at> debbugs.gnu.org id=B15875.138427154317322
          (code B ref 15875); Tue, 12 Nov 2013 15:53:02 +0000
Received: (at 15875) by debbugs.gnu.org; 12 Nov 2013 15:52:23 +0000
Received: from localhost ([127.0.0.1]:48963 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1VgGGM-0004VK-B4
	for submit <at> debbugs.gnu.org; Tue, 12 Nov 2013 10:52:22 -0500
Received: from alt-proxy25.mail.unifiedlayer.com ([66.147.249.8]:34864)
 by debbugs.gnu.org with smtp (Exim 4.80)
 (envelope-from <nbtrap@HIDDEN>) id 1VgGGJ-0004VB-Ez
 for 15875 <at> debbugs.gnu.org; Tue, 12 Nov 2013 10:52:20 -0500
Received: (qmail 29602 invoked by uid 0); 12 Nov 2013 15:52:18 -0000
Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193)
 by oproxy4.mail.unifiedlayer.com with SMTP; 12 Nov 2013 15:52:18 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com;
 s=default; 
 h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From;
 bh=4MorENlEIQ3qmMfn62YrAb6OWi345wcgYpm9UcGIzBc=; 
 b=TO64vCqHFZmj0BXf3Fv3LR9kUiU1DK0LXC2oU5F2+nlENKSaTZX7PseKoNnDNq0QwOd0kHCYEoRO/ZZcIXI7KUQiVCs/v+qGVEkg5XckPPnsnOsO18HoWC6kUTCROVAf;
Received: from [50.90.253.209] (port=54604 helo=Nathan-GNU)
 by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128)
 (Exim 4.80) (envelope-from <nbtrap@HIDDEN>)
 id 1VgGGH-0006CR-En; Tue, 12 Nov 2013 08:52:17 -0700
From: Nathan Trapuzzano <nbtrap@HIDDEN>
References: <87d2m5eobv.fsf@HIDDEN>
 <jwvob5pd3uj.fsf-monnier+emacsbugs@HIDDEN>
Date: Tue, 12 Nov 2013 10:52:15 -0500
In-Reply-To: <jwvob5pd3uj.fsf-monnier+emacsbugs@HIDDEN> (Stefan Monnier's
 message of "Tue, 12 Nov 2013 10:49:25 -0500")
Message-ID: <874n7hr51s.fsf@HIDDEN>
User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com}
 {sentby:smtp auth 50.90.253.209 authed with nbtrap@HIDDEN}
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

Stefan Monnier <monnier@HIDDEN> writes:

> Note that diff-mode also handles diffs that have a mix of context-style
> and unified-style hunks, but such a tab-offset feature wouldn't be able
> to handle it correctly.  Not a big issue, tho.

What if the tab width were a text property instead of a buffer variable?
(Or perhaps it coulbe be both, with the latter overriding the former.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#15875: 24.3.50; diff-mode counts first column when determining tab width
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 Nov 2013 16:33:03 +0000
Resent-Message-ID: <handler.15875.B15875.138427396025261 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 15875
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Nathan Trapuzzano <nbtrap@HIDDEN>
Cc: 15875 <at> debbugs.gnu.org
Received: via spool by 15875-submit <at> debbugs.gnu.org id=B15875.138427396025261
          (code B ref 15875); Tue, 12 Nov 2013 16:33:03 +0000
Received: (at 15875) by debbugs.gnu.org; 12 Nov 2013 16:32:40 +0000
Received: from localhost ([127.0.0.1]:48998 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1VgGtL-0006ZM-VG
	for submit <at> debbugs.gnu.org; Tue, 12 Nov 2013 11:32:40 -0500
Received: from ironport2-out.teksavvy.com ([206.248.154.182]:64026)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1VgGtJ-0006Z2-Pk
 for 15875 <at> debbugs.gnu.org; Tue, 12 Nov 2013 11:32:38 -0500
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCqr1/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgaxH5AOkQoDiGGcGYFegxU
X-IPAS-Result: Av8EABK/CFFMCqr1/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgaxH5AOkQoDiGGcGYFegxU
X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37686509"
Received: from 76-10-170-245.dsl.teksavvy.com (HELO pastel.home)
 ([76.10.170.245])
 by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
 12 Nov 2013 11:32:31 -0500
Received: by pastel.home (Postfix, from userid 20848)
 id B16AF630BF; Tue, 12 Nov 2013 11:32:31 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwviovxd1jy.fsf-monnier+emacsbugs@HIDDEN>
References: <87d2m5eobv.fsf@HIDDEN>
 <jwvob5pd3uj.fsf-monnier+emacsbugs@HIDDEN>
 <874n7hr51s.fsf@HIDDEN>
Date: Tue, 12 Nov 2013 11:32:31 -0500
In-Reply-To: <874n7hr51s.fsf@HIDDEN> (Nathan Trapuzzano's message of "Tue, 
 12 Nov 2013 10:52:15 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

>> Note that diff-mode also handles diffs that have a mix of context-style
>> and unified-style hunks, but such a tab-offset feature wouldn't be able
>> to handle it correctly.  Not a big issue, tho.
> What if the tab width were a text property instead of a buffer variable?

Seems overkill.  The `space' display property already provides pretty
much that (among other things).


        Stefan

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.