GNU logs - #15960, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#15960: 24.3.50; Provide a good way to tell when in `mouse-drag-track' (regression)
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 23 Nov 2013 19:41:02 +0000
Resent-Message-ID: <handler.15960.B.138523562820159 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 15960 <at> debbugs.gnu.org
MIME-Version: 1.0
Message-ID: <ed8eb56a-e02f-435b-9679-82c3853e0fd4@default>
Date: Sat, 23 Nov 2013 11:39:43 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

I have code (library modeline-posn.el) that lets users optionally show
the active region size (highlighted) in the minibuffer, in place of the
buffer size.

My code did this, to test whether the region was active or the user
wants to allow an empty region to be highlighted:

(and transient-mark-mode  mark-active
       (or modelinepos-empty-region-flag
           (/=3D (region-beginning) (region-end))))

With `modelinepos-empty-region-flag' non-nil, this made it easy for a
user to see when the active region is empty.  (The mode-line size
indication is highlighted with face `region'.)

Emacs 24 changed things, so that this mode-line highlighting now
appeared immediately when you press `mouse-1', and did not wait until
you actually drag the mouse or release `mouse-1'.

This broke the user experience for this feature, because now each time
s?he clicked `mouse-1', without any dragging, a zero-size-region
indication showed in the mode line for as long as `mouse-1' was held
down during the click.  IOW, an annoying flash.

Obviously that is no good, so I updated my code to try to test whether
we are inside `mouse-drag-track'.  I found no clean and sure way to do
this, so I currently test `echo-keystrokes', which `mouse-drag-track'
binds to 0.  This seems to work fine, but it is obviously indirect and
fragile.

The bug report is to request some clearer, cleaner, and surer way to
tell whether we are in `mouse-drag-track'.

This is the code I use now for the test:

(defun modelinepos-empty-region-p ()
  "Return non-nil if region is active and empty.
But do not return non-nil if this is true but you are selecting with
the mouse.  This is to prevent highlighting in the mode line whenever
you press `mouse-1' without dragging at least one character."

  ;; Fragile hack: Starting with Emacs 24, the region is considered
  ;; empty as soon as you press `mouse-1' (`down-mouse-1').  That causes
  ;; modeline highlighting each time you just click `mouse-1', i.e.,
  ;; without dragging it.
  ;;
  ;; The hack is to check whether `echo-keystrokes' is 0.
  ;; `mouse-drag-track' binds `echo-keystrokes' to 0, and that seems to
  ;; be the only way to tell whether we are in `mouse-drag-track'.
  ;; If the Emacs code for that changes then this might break.
  (and transient-mark-mode  mark-active
       (or (if (> emacs-major-version 23)
               (and (not (eq 0 echo-keystrokes))
                    modelinepos-empty-region-flag)
             modelinepos-empty-region-flag)
           (/=3D (region-beginning) (region-end)))))

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-11-12 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG=
=3D1'

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Drew Adams <drew.adams@HIDDEN>
Subject: bug#15960: Acknowledgement (24.3.50; Provide a good way to tell
 when in `mouse-drag-track' (regression))
Message-ID: <handler.15960.B.138523562820159.ack <at> debbugs.gnu.org>
References: <ed8eb56a-e02f-435b-9679-82c3853e0fd4@default>
X-Gnu-PR-Message: ack 15960
X-Gnu-PR-Package: emacs
Reply-To: 15960 <at> debbugs.gnu.org
Date: Sat, 23 Nov 2013 19:41:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 15960 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
15960: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15960
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#15960: 24.3.50; Provide a good way to tell when in `mouse-drag-track' (regression)
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 23 Nov 2013 22:05:01 +0000
Resent-Message-ID: <handler.15960.B15960.13852442781284 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Drew Adams <drew.adams@HIDDEN>
Cc: 15960 <at> debbugs.gnu.org
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwva9gudbcn.fsf-monnier+emacsbugs@HIDDEN>
References: <ed8eb56a-e02f-435b-9679-82c3853e0fd4@default>
Date: Sat, 23 Nov 2013 17:04:29 -0500
In-Reply-To: <ed8eb56a-e02f-435b-9679-82c3853e0fd4@default> (Drew Adams's
 message of "Sat, 23 Nov 2013 11:39:43 -0800 (PST)")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Emacs 24 changed things, so that this mode-line highlighting now
> appeared immediately when you press `mouse-1', and did not wait until
> you actually drag the mouse or release `mouse-1'.

Might simply be a bug.  I suggest you focus on tracking why this is.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#15960: 24.3.50; Provide a good way to tell when in `mouse-drag-track' (regression)
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 23 Nov 2013 23:22:02 +0000
Resent-Message-ID: <handler.15960.B15960.13852489118518 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Stefan Monnier <monnier@HIDDEN>
Cc: 15960 <at> debbugs.gnu.org
MIME-Version: 1.0
Message-ID: <25e6e155-4da6-4d8c-bf2a-12f7e7f80c4c@default>
Date: Sat, 23 Nov 2013 15:21:35 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
References: <ed8eb56a-e02f-435b-9679-82c3853e0fd4@default>
 <jwva9gudbcn.fsf-monnier+emacsbugs@HIDDEN>
In-Reply-To: <jwva9gudbcn.fsf-monnier+emacsbugs@HIDDEN>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> > Emacs 24 changed things, so that this mode-line highlighting now
> > appeared immediately when you press `mouse-1', and did not wait
> > until you actually drag the mouse or release `mouse-1'.
>=20
> Might simply be a bug.  I suggest you focus on tracking why this is.

It might.  I have no objection to it being seen as a bug, and fixed.

But the behavior of the highlighting appearing now before you release
mouse-1 is a definite improvement.  I would not wish to see that lost
because of the "fix".  This just should not happen unless at least one
char is selected.

In any case, Chong Yidong (I think) changed the code considerably for
Emacs 24.  It will take someone more knowledgable than I to figure it
out, let alone figure out just what was intended vs what might have
been accidental.

Providing a good, clean way to tell whether `mouse-drag-track' is in
progress (e.g. `mouse-tracking-p') would solve the problem I am
reporting.  I would guess that it might also be useful more generally.

But if you don't see it that way and don't want to fix this, I'll
continue to rely on (eq 0 echo-keystrokes) as the test for this.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#15960: 24.3.50; Provide a good way to tell when in `mouse-drag-track' (regression)
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 24 Nov 2013 00:43:02 +0000
Resent-Message-ID: <handler.15960.B15960.138525378016216 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 15960
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Drew Adams <drew.adams@HIDDEN>
Cc: 15960 <at> debbugs.gnu.org
Received: via spool by 15960-submit <at> debbugs.gnu.org id=B15960.138525378016216
          (code B ref 15960); Sun, 24 Nov 2013 00:43:02 +0000
Received: (at 15960) by debbugs.gnu.org; 24 Nov 2013 00:43:00 +0000
Received: from localhost ([127.0.0.1]:40848 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1VkNmu-0004DU-GS
	for submit <at> debbugs.gnu.org; Sat, 23 Nov 2013 19:43:00 -0500
Received: from ironport2-out.teksavvy.com ([206.248.154.181]:50878)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1VkNms-0004DH-1h
 for 15960 <at> debbugs.gnu.org; Sat, 23 Nov 2013 19:42:58 -0500
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+K4R/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV
X-IPAS-Result: Av8EABK/CFHO+K4R/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV
X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40253587"
Received: from 206-248-174-17.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net)
 ([206.248.174.17])
 by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA;
 23 Nov 2013 19:42:51 -0500
Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848)
 id B8312AE129; Sat, 23 Nov 2013 19:42:50 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwv4n72d41w.fsf-monnier+emacsbugs@HIDDEN>
References: <ed8eb56a-e02f-435b-9679-82c3853e0fd4@default>
 <jwva9gudbcn.fsf-monnier+emacsbugs@HIDDEN>
 <25e6e155-4da6-4d8c-bf2a-12f7e7f80c4c@default>
Date: Sat, 23 Nov 2013 19:42:50 -0500
In-Reply-To: <25e6e155-4da6-4d8c-bf2a-12f7e7f80c4c@default> (Drew Adams's
 message of "Sat, 23 Nov 2013 15:21:35 -0800 (PST)")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

> But the behavior of the highlighting appearing now before you release
> mouse-1 is a definite improvement.  I would not wish to see that lost
> because of the "fix".  This just should not happen unless at least one
> char is selected.

Sounds right.  That's why I think it's just a bug/misfeature.

> Providing a good, clean way to tell whether `mouse-drag-track' is in
> progress (e.g. `mouse-tracking-p') would solve the problem I am
> reporting.

It would just give you a way to work around the problem.  I'd much
rather fix it instead.


        Stefan

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.