GNU bug report logs - #16117
24.3; emacsclient -q enhancement request please also suppress

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16117 in the body.
You can then email your comments to 16117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: gregrwm <backuppc-users <at> whitleymott.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; emacsclient -q enhancement request please also suppress
Date: Wed, 11 Dec 2013 20:47:25 -0600

[Message part 1 (text/plain, inline)]

please have emacsclient -qa suppress the following 2 lines:
emacsclient: can't find socket; have you started the server?
To start the server in Emacs, type "M-x server-start".

In GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu)
 of 2013-10-03 on rose.fo4.net
Configured using:
 `configure '--without-x''

Important settings:
  value of $LC_COLLATE: en_DK.UTF-8
  value of $LC_TIME: en_DK.UTF-8
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  shell-dirtrack-mode: t
  evil-mode: t
  evil-local-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
: r e p o r t - e m a c s - b u g RET

Recent messages:
("emacs" ".emacs")
Loading term/xterm...done
For information about GNU Emacs and the GNU system, type C-h C-a.
delete-backward-char: Text is read-only [2 times]

Load-path shadows:
~/.emacs.d/evil/lib/ert hides
/usr/local/share/emacs/24.3/lisp/emacs-lisp/ert

Features:
(shadow sort mail-extr emacsbug message format-spec rfc822 mml easymenu
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils
shell pcomplete comint regexp-opt ansi-color evil evil-integration
warnings evil-maps evil-commands ffap url-parse auth-source eieio
byte-opt bytecomp byte-compile cconv gnus-util time-date mm-util
mail-prsvr password-cache url-vars evil-types evil-search evil-ex
evil-macros evil-repeat evil-states evil-core advice advice-preload
evil-common windmove rect evil-digraphs evil-vars ring undo-tree derived
easy-mmode help-fns cl-macs gv diff cl cl-lib edmacro kmacro server
ediff-hook vc-hooks lisp-float-type tabulated-list newcomment lisp-mode
register page menu-bar rfn-eshadow timer jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
make-network-process multi-tty emacs)

[Message part 2 (text/html, inline)]

Message #8 received at 16117 <at> debbugs.gnu.org (full text, mbox):

From: Scott Turner <srt19170 <at> gmail.com>
To: 16117 <at> debbugs.gnu.org
Subject: Patch for Emacsclient Unwanted Warning
Date: Fri, 13 Dec 2013 10:46:12 -0500

[Message part 1 (text/plain, inline)]

In emacsclient, if an existing Emacs server cannot be found and an
alternate editor is specified, the alternate editor is started.  Along the
way, emacsclient generates a warning that the server cannot be found.

On Windows, this warning is a pop-up dialog box that must be dismissed by
the user.  This is an unwanted interruption, and irrelevant, since the user
has already indicated by using the --alternated-editor option how to handle
this situation.

The patch below suppresses this warning when the user has specified both
the --quiet option and the --alternate-editor option.  The reasoning is
that --quiet mutes all messages on success, and that because the
--alternate-editor has been specified, this message is not reporting an
error.  It seems like a reasonable compromise that will allow users to see
this warning if they like (by not using --quiet) and allow users to avoid
it if they like (by using --quiet).

*** emacsclient.c    Tue Jan  1 15:37:17 2013
--- emacsclient-nomsg.c    Fri Dec 13 10:05:30 2013
***************
*** 1002,1015 ****
    /* Open up an AF_INET socket.  */
    if ((s = socket (AF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0)
      {
!       sock_err_message ("socket");
        return INVALID_SOCKET;
      }

    /* Set up the socket.  */
    if (connect (s, (struct sockaddr *) &server, sizeof server) < 0)
      {
!       sock_err_message ("connect");
        return INVALID_SOCKET;
      }

--- 1002,1027 ----
    /* Open up an AF_INET socket.  */
    if ((s = socket (AF_INET, SOCK_STREAM, IPPROTO_TCP)) < 0)
      {
!       /*
!        * If we have an alternate editor specified, then a socket error
!        * isn't really an "error" (because we'll end up invoking the
!        * alternate editor) so if asked we'll be quiet about this error
!        * message.
!        *
!        */
!       if (!quiet || !alternate_editor) {
!     sock_err_message ("socket");
!       };
        return INVALID_SOCKET;
      }

    /* Set up the socket.  */
    if (connect (s, (struct sockaddr *) &server, sizeof server) < 0)
      {
!       /* See comment above for rationale about showing/not showing err */
!       if (!quiet || !alternate_editor) {
!     sock_err_message ("connect");
!       };
        return INVALID_SOCKET;
      }

[Message part 2 (text/html, inline)]

Message #11 received at 16117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Scott Turner <srt19170 <at> gmail.com>
Cc: 16117 <at> debbugs.gnu.org
Subject: Re: bug#16117: Patch for Emacsclient Unwanted Warning
Date: Wed, 26 Jun 2019 17:02:01 +0200

Scott Turner <srt19170 <at> gmail.com> writes:

> In emacsclient, if an existing Emacs server cannot be found and an
> alternate editor is specified, the alternate editor is started.  Along
> the way, emacsclient generates a warning that the server cannot be
> found.
>
> On Windows, this warning is a pop-up dialog box that must be dismissed
> by the user.  This is an unwanted interruption, and irrelevant, since
> the user has already indicated by using the --alternated-editor option
> how to handle this situation.
>
> The patch below suppresses this warning when the user has specified
> both the --quiet option and the --alternate-editor option.  The
> reasoning is that --quiet mutes all messages on success, and that
> because the --alternate-editor has been specified, this message is not
> reporting an error.  It seems like a reasonable compromise that will
> allow users to see this warning if they like (by not using --quiet)
> and allow users to avoid it if they like (by using --quiet).

I think your patch makes sense, and the problem is still present in
Emacs, five years after your report.

---
$ emacsclient --quiet --alternate-editor /usr/bin/vi /tmp/a
emacsclient: can't find socket; have you started the server?
To start the server in Emacs, type "M-x server-start".
---

Does anybody else have an objection to not outputting that error message
if both --quiet and --alternate-editor is used?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 16117 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 16117 <at> debbugs.gnu.org, Scott Turner <srt19170 <at> gmail.com>
Subject: Re: bug#16117: Patch for Emacsclient Unwanted Warning
Date: Wed, 12 Aug 2020 15:23:15 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Scott Turner <srt19170 <at> gmail.com> writes:
>
>> In emacsclient, if an existing Emacs server cannot be found and an
>> alternate editor is specified, the alternate editor is started.  Along
>> the way, emacsclient generates a warning that the server cannot be
>> found.
>>
>> On Windows, this warning is a pop-up dialog box that must be dismissed
>> by the user.  This is an unwanted interruption, and irrelevant, since
>> the user has already indicated by using the --alternated-editor option
>> how to handle this situation.
>>
>> The patch below suppresses this warning when the user has specified
>> both the --quiet option and the --alternate-editor option.  The
>> reasoning is that --quiet mutes all messages on success, and that
>> because the --alternate-editor has been specified, this message is not
>> reporting an error.  It seems like a reasonable compromise that will
>> allow users to see this warning if they like (by not using --quiet)
>> and allow users to avoid it if they like (by using --quiet).
>
> I think your patch makes sense, and the problem is still present in
> Emacs, five years after your report.
>
> ---
> $ emacsclient --quiet --alternate-editor /usr/bin/vi /tmp/a
> emacsclient: can't find socket; have you started the server?
> To start the server in Emacs, type "M-x server-start".
> ---
>
> Does anybody else have an objection to not outputting that error message
> if both --quiet and --alternate-editor is used?

I agree, it makes sense to not show the error message in this case.

Best regards,
Stefan Kangas

Message #19 received at 16117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 16117 <at> debbugs.gnu.org, Scott Turner <srt19170 <at> gmail.com>
Subject: Re: bug#16117: Patch for Emacsclient Unwanted Warning
Date: Thu, 13 Aug 2020 10:30:13 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> I agree, it makes sense to not show the error message in this case.

OK, I've now pushed a fix similar to the suggested patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.