GNU bug report logs - #16545
24.3.50; Patch to coalesce calls to linum-update-current

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16545 in the body.
You can then email your comments to 16545 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chow Loong Jin <hyperair <at> debian.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Patch to coalesce calls to linum-update-current
Date: Sat, 25 Jan 2014 15:57:40 +0800

[Message part 1 (text/plain, inline)]

When navigating using C-n/C-p with a high key repeat rate, causing
linum-schedule to be called many times in quick succession,
linum-update-current gets called as many times in linum-schedule,
eventhough one call per round should be enough to renumber the lines.

This patch adds a linum-delay-seconds option defaulting to 10ms to delay
the call to linum-update-current, thus coalescing all calls to
linum-update-current until Emacs settles for 10ms.

--
Kind regards,
Loong Jin

[0001-Add-customization-option-to-delay-linum-updates.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 16545 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Chow Loong Jin <hyperair <at> debian.org>
Cc: 16545 <at> debbugs.gnu.org
Subject: Re: bug#16545: 24.3.50;
 Patch to coalesce calls to linum-update-current
Date: Sat, 25 Jan 2014 20:18:57 -0500

Thanks for the patch.
The usual answer to anything involving linum.el is to try nlinum.el from
GNU ELPA instead (it's hoped this will replace linum.el one day).
Does nlinum.el have the same issue?

Message #11 received at 16545 <at> debbugs.gnu.org (full text, mbox):

From: Chow Loong Jin <hyperair <at> debian.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16545 <at> debbugs.gnu.org
Subject: Re: bug#16545: 24.3.50; Patch to coalesce calls to
 linum-update-current
Date: Mon, 27 Jan 2014 12:40:38 +0800

[Message part 1 (text/plain, inline)]

On Sat, Jan 25, 2014 at 08:18:57PM -0500, Glenn Morris wrote:
> 
> Thanks for the patch.
> The usual answer to anything involving linum.el is to try nlinum.el from
> GNU ELPA instead (it's hoped this will replace linum.el one day).
> Does nlinum.el have the same issue?

Not sure, I was only able to reproduce the issue when using linum-relative.el,
as that made the linum updates slower, and I've since upgraded my machine.

Looking at the source of nlinum.el, though, it doesn't delay the updates like
linum.el does, so updates to the line numbering is unlikely to lag. Instead, it
just makes the entire Emacs instance lag.


P.S. I hope nlinum.el in its current state does not replace linum.el -- neither
global-nlinum-mode nor nlinum-relative seem to exist for this just yet.

-- 
Kind regards,
Loong Jin

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 16545 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Chow Loong Jin <hyperair <at> debian.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 16545 <at> debbugs.gnu.org
Subject: Re: bug#16545: 24.3.50;
 Patch to coalesce calls to linum-update-current
Date: Mon, 27 Jan 2014 09:29:57 -0500

> P.S. I hope nlinum.el in its current state does not replace
> linum.el -- neither global-nlinum-mode nor nlinum-relative seem to
> exist for this just yet.

nlinum.el in the `elpa' branch does include global-nlinum-mode (it was
trivial to define).

But indeed there's no nlinum-relative.  Not sure how best to implement it.


        Stefan

Message #17 received at 16545 <at> debbugs.gnu.org (full text, mbox):

From: Chow Loong Jin <hyperair <at> debian.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Glenn Morris <rgm <at> gnu.org>, 16545 <at> debbugs.gnu.org
Subject: Re: bug#16545: 24.3.50; Patch to coalesce calls to
 linum-update-current
Date: Tue, 28 Jan 2014 11:13:27 +0800

[Message part 1 (text/plain, inline)]

On Mon, Jan 27, 2014 at 09:29:57AM -0500, Stefan Monnier wrote:
> > P.S. I hope nlinum.el in its current state does not replace
> > linum.el -- neither global-nlinum-mode nor nlinum-relative seem to
> > exist for this just yet.
> 
> nlinum.el in the `elpa' branch does include global-nlinum-mode (it was
> trivial to define).

Odd, I didn't see it yesterday when I installed it. Looks like it's there after
I reinstalled it today.

-- 
Kind regards,
Loong Jin

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 16545 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Chow Loong Jin <hyperair <at> debian.org>
Cc: 16545 <at> debbugs.gnu.org
Subject: Re: bug#16545: 24.3.50;
 Patch to coalesce calls to linum-update-current
Date: Wed, 26 Jun 2019 16:49:18 +0200

Chow Loong Jin <hyperair <at> debian.org> writes:

> When navigating using C-n/C-p with a high key repeat rate, causing
> linum-schedule to be called many times in quick succession,
> linum-update-current gets called as many times in linum-schedule,
> eventhough one call per round should be enough to renumber the lines.
>
> This patch adds a linum-delay-seconds option defaulting to 10ms to delay
> the call to linum-update-current, thus coalescing all calls to
> linum-update-current until Emacs settles for 10ms.

This was five years ago, and in the meantime, Emacs has gotten native
line number support, so I don't think this is applicable any more, and
I'm closing this bug report.  If I've misunderstood, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.