GNU bug report logs - #16902
24.3.50; why vc-revert keeps its diff-buffer around?

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Fri, 28 Feb 2014 05:09:01 UTC

Severity: wishlist

Found in version 24.3.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16902 in the body.
You can then email your comments to 16902 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#16902; Package emacs. (Fri, 28 Feb 2014 05:09:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo Liu <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 28 Feb 2014 05:09:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; why vc-revert keeps its diff-buffer around?
Date: Fri, 28 Feb 2014 13:08:13 +0800

I often get a dozen vc-diff<N> buffers and was curious what caused this.
So vc-revert is the culprit. It seems better to also kill the
diff-buffer. Objections?

Leo
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16902; Package emacs. (Fri, 28 Feb 2014 07:18:01 GMT) Full text and rfc822 format available.

Message #8 received at 16902 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 16902 <at> debbugs.gnu.org
Subject: Re: bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
Date: Fri, 28 Feb 2014 02:17:23 -0500

Leo Liu wrote:

> I often get a dozen vc-diff<N> buffers and was curious what caused this.
> So vc-revert is the culprit. It seems better to also kill the
> diff-buffer. Objections?

Well I assume the people who added the feature whereby a new diff buffer
is created each time would object, because they want to keep the diff
buffer around. Eg in case they change their minds after reverting.
See eg http://debbugs.gnu.org/8927 .

Maybe (setq vc-revert-show-diff nil) will work for you?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16902; Package emacs. (Fri, 28 Feb 2014 12:16:01 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
Date: Fri, 28 Feb 2014 20:15:12 +0800

On 2014-02-28 15:17 +0800, Glenn Morris wrote:
> Well I assume the people who added the feature whereby a new diff buffer
> is created each time would object, because they want to keep the diff
> buffer around. Eg in case they change their minds after reverting.
> See eg http://debbugs.gnu.org/8927 .

I have read the whole thread and it seems keeping the revert diff buffer
was unintended change. The complaint was not to override contents in the
old *vc-diff*.

I think it is better to kill that revert diff buffer.

> Maybe (setq vc-revert-show-diff nil) will work for you?

Leo
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16902; Package emacs. (Fri, 28 Feb 2014 19:54:02 GMT) Full text and rfc822 format available.

Message #14 received at 16902 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 16902 <at> debbugs.gnu.org
Subject: Re: bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
Date: Fri, 28 Feb 2014 14:53:06 -0500

How about extending the option vc-revert-show-diff to allow a new value,
`kill', which means to kill the diff buffer afterwards?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16902; Package emacs. (Fri, 28 Feb 2014 21:05:02 GMT) Full text and rfc822 format available.

Message #17 received at 16902 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16902 <at> debbugs.gnu.org
Subject: Re: bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
Date: Sat, 01 Mar 2014 05:04:01 +0800

On 2014-03-01 03:53 +0800, Glenn Morris wrote:
> How about extending the option vc-revert-show-diff to allow a new value,
> `kill', which means to kill the diff buffer afterwards?

Sounds like a good idea.

Leo
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16902; Package emacs. (Sat, 04 Sep 2021 09:13:01 GMT) Full text and rfc822 format available.

Message #20 received at 16902 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16902 <at> debbugs.gnu.org, Leo Liu <sdl.web <at> gmail.com>
Subject: Re: bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
Date: Sat, 04 Sep 2021 11:12:37 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> How about extending the option vc-revert-show-diff to allow a new value,
> `kill', which means to kill the diff buffer afterwards?

Now done in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 28.1, send any further explanations to 16902 <at> debbugs.gnu.org and Leo Liu <sdl.web <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 04 Sep 2021 09:13:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 02 Oct 2021 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 200 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.