GNU logs - #16972, boring messages

Message sent to bug-libtool@HIDDEN:

Subject: bug#16972: Incorrect check for library target directory when relinking
Resent-From: Thilo Schulz <thilo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Sat, 08 Mar 2014 22:41:01 +0000
Resent-Message-ID: <handler.16972.B.139431843218413 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 16972 <at> debbugs.gnu.org
From: Thilo Schulz <thilo@HIDDEN>
Date: Sat, 8 Mar 2014 23:21:12 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201403082321.12793.thilo@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

I'm really baffled by this message:

> /home/thilo/code/libtool-2.4.2/libtool --mode=install install net.la 
/home/thilo/code/usr/lib/sercom/sercomctl/
> libtool: install: error: cannot install `net.la' to a directory not ending 
in /home/thilo/code/usr/lib/sercom/sercomctl/

I'm installing to exactly that directory and it's complaining! Looks like this 
check is wrong, starting from line 3399 in libtool:

# Don't allow the user to place us outside of our expected
# location b/c this prevents finding dependent libraries that
# are installed to the same prefix.
# At present, this check doesn't affect windows .dll's that
# are installed into $libdir/../bin (currently, that works fine)
# but it's something to keep an eye on.
test "$inst_prefix_dir" = "$destdir" && \
func_fatal_error "error: cannot install \`$file' to a directory not ending in 
$libdir"

so basically, if $inst_prefix_dir and $destdir are equal, it throws an error? 
Are you sure it shouldn't be || instead of &&?

-- 
Beste regards,
Thilo Schulz

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Thilo Schulz <thilo@HIDDEN>
Subject: bug#16972: Acknowledgement (Incorrect check for library target
 directory when relinking)
Message-ID: <handler.16972.B.139431843218413.ack <at> debbugs.gnu.org>
References: <201403082321.12793.thilo@HIDDEN>
X-Gnu-PR-Message: ack 16972
X-Gnu-PR-Package: libtool
Reply-To: 16972 <at> debbugs.gnu.org
Date: Sat, 08 Mar 2014 22:41:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-libtool@HIDDEN

If you wish to submit further information on this problem, please
send it to 16972 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
16972: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16972
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-libtool@HIDDEN:

Subject: bug#16972: [PATCH] Fix for this bug
References: <201403082321.12793.thilo@HIDDEN>
In-Reply-To: <201403082321.12793.thilo@HIDDEN>
Resent-From: Thilo Schulz <thilo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Tue, 11 Mar 2014 01:04:01 +0000
Resent-Message-ID: <handler.16972.B16972.13944998098233 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 16972 <at> debbugs.gnu.org
From: Thilo Schulz <thilo@HIDDEN>
Date: Tue, 11 Mar 2014 02:03:21 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201403110203.21766.thilo@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--- libtool.orig        2014-03-11 00:59:52.821999549 +0000
+++ libtool     2014-03-11 01:00:21.197220463 +0000
@@ -3402,7 +3402,7 @@
          # At present, this check doesn't affect windows .dll's that
          # are installed into $libdir/../bin (currently, that works fine)
          # but it's something to keep an eye on.
-         test "$inst_prefix_dir" = "$destdir" && \
+         test "$inst_prefix_dir" = "$destdir" || \
            func_fatal_error "error: cannot install \`$file' to a directory not 
ending in $libdir"
 
          if test -n "$inst_prefix_dir"; then

-- 
Best regards,
Thilo Schulz

Message sent to bug-libtool@HIDDEN:

Subject: bug#16972: [PATCH] Fix for this bug
Resent-From: Peter Rosin <peda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Tue, 11 Mar 2014 07:38:02 +0000
Resent-Message-ID: <handler.16972.B16972.139452347620339 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Thilo Schulz <thilo@HIDDEN>, 16972 <at> debbugs.gnu.org
Message-ID: <531EBD4B.1000303@HIDDEN>
Date: Tue, 11 Mar 2014 08:37:47 +0100
From: Peter Rosin <peda@HIDDEN>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
References: <201403082321.12793.thilo@HIDDEN>
 <201403110203.21766.thilo@HIDDEN>
In-Reply-To: <201403110203.21766.thilo@HIDDEN>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2014-03-11 02:03, Thilo Schulz wrote:
> --- libtool.orig        2014-03-11 00:59:52.821999549 +0000
> +++ libtool     2014-03-11 01:00:21.197220463 +0000
> @@ -3402,7 +3402,7 @@
>           # At present, this check doesn't affect windows .dll's that
>           # are installed into $libdir/../bin (currently, that works fine)
>           # but it's something to keep an eye on.
> -         test "$inst_prefix_dir" = "$destdir" && \
> +         test "$inst_prefix_dir" = "$destdir" || \
>             func_fatal_error "error: cannot install \`$file' to a directory not 
> ending in $libdir"
>  
>           if test -n "$inst_prefix_dir"; then
> 

Hi Thilo,

I seriously doubt that this change is correct. The code has been the way
it is since it was added 10+ years ago (commit d2c4f8f8fc). Well, the test
was written as

	if test "$inst_prefix_dir" = "$destdir"; then
	  $echo ...
	  exit
	fi

way back when, but that's equivalent to the current code.

Cheers,
Peter

Message sent to bug-libtool@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#16972: [PATCH] Relink check in --install mode broken
Resent-From: Thilo Schulz <thilo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Tue, 11 Mar 2014 14:42:02 +0000
Resent-Message-ID: <handler.16972.B16972.13945489068298 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 16972
X-GNU-PR-Package: libtool
X-GNU-PR-Keywords: 
To: Peter Rosin <peda@HIDDEN>
Cc: 16972 <at> debbugs.gnu.org
Received: via spool by 16972-submit <at> debbugs.gnu.org id=B16972.13945489068298
          (code B ref 16972); Tue, 11 Mar 2014 14:42:02 +0000
Received: (at 16972) by debbugs.gnu.org; 11 Mar 2014 14:41:46 +0000
Received: from localhost ([127.0.0.1]:33456 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1WNNsI-00029l-3T
	for submit <at> debbugs.gnu.org; Tue, 11 Mar 2014 10:41:46 -0400
Received: from tjps.eu ([176.9.53.212]:56935)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <thilo@HIDDEN>) id 1WNNsE-00029b-Hk
 for 16972 <at> debbugs.gnu.org; Tue, 11 Mar 2014 10:41:43 -0400
Received: from helmuth.localnet (p4FF15F90.dip0.t-ipconnect.de [79.241.95.144])
 by tjps.eu (Postfix) with ESMTPSA id 326CA5701247;
 Tue, 11 Mar 2014 14:41:41 +0000 (UTC)
From: Thilo Schulz <thilo@HIDDEN>
Date: Tue, 11 Mar 2014 15:41:40 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <201403082321.12793.thilo@HIDDEN>
 <201403110203.21766.thilo@HIDDEN> <531EBD4B.1000303@HIDDEN>
In-Reply-To: <531EBD4B.1000303@HIDDEN>
MIME-Version: 1.0
Message-Id: <201403111541.40577.thilo@HIDDEN>
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi,

> Hi Thilo,
>=20
> I seriously doubt that this change is correct. The code has been the way
> it is since it was added 10+ years ago (commit d2c4f8f8fc). Well, the test
> was written as
>=20
> 	if test "$inst_prefix_dir" =3D "$destdir"; then
> 	  $echo ...
> 	  exit
> 	fi
>=20
> way back when, but that's equivalent to the current code.

You're right. I had a more thorough look at the script as opposed to the=20
cursory glance before, and I now understand what's actually happening.

With the sed command:

          inst_prefix_dir=3D`$ECHO "$destdir" | $SED -e "s%$libdir\$%%"`

it searches for the trailing path, and replaces it with nothing. If that=20
trailing path is identical, inst_prefix_dir will be unequal to the original=
=20
destdir, so equality actually _is_ the error condition.

It didn't work in my case though, because in --link mode, the -rpath argume=
nt=20
had a trailing / and libtool removes the trailing slash from the installati=
on=20
directory argument in --install mode.

So here is a second patch that only fixes this failure of the check. Maybe =
you=20
want to strip libdir of trailing slashes in --link mode already, but that's=
=20
the libtool maintainer's choice.

=2D-- libtool.orig        2014-03-11 15:27:51.541596775 +0100
+++ libtool     2014-03-11 15:27:30.417597689 +0100
@@ -3393,8 +3393,11 @@
        dir+=3D"$objdir"
=20
        if test -n "$relink_command"; then
+         # $destdir has trailing slashes stripped, so must strip slashes f=
rom=20
$libdir as well
+         func_stripname '' '/' "$libdir"
+
          # Determine the prefix the user has applied to our future dir.
=2D         inst_prefix_dir=3D`$ECHO "$destdir" | $SED -e "s%$libdir\$%%"`
+         inst_prefix_dir=3D`$ECHO "$destdir" | $SED -e=20
"s%$func_stripname_result\$%%"`
=20
          # Don't allow the user to place us outside of our expected
          # location b/c this prevents finding dependent libraries that


=2D-=20
Beste Gr=FC=DFe,
Thilo Schulz

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.