GNU bug report logs - #17193
24.4.50; `menu-bar-make-toggle': allow :keys

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sat, 5 Apr 2014 15:35:02 UTC

Severity: wishlist

Tags: fixed

Merged with 6542, 17954

Found in versions 24.0.50, 24.4.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17193 in the body.
You can then email your comments to 17193 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#17193; Package emacs. (Sat, 05 Apr 2014 15:35:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 05 Apr 2014 15:35:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; `menu-bar-make-toggle': allow :keys
Date: Sat, 5 Apr 2014 08:34:16 -0700 (PDT)

Enhancement request:

`menu-bar-make-toggle' is a macro that expands to `(menu-item ...)'.
This is a request to allow it to accept, and take into account,
additional `menu-item' features, such as `:keys'.  Currently, it seems
there is no way to pass :keys to `menu-bar-make-toggle' so that the keys
will appear in (i.e., next to) the menu item.


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-03-30 on ODIEONE
Bzr revision: 116912 rgm <at> gnu.org-20140331004905-epgjyxkpa4nv54bm
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17193; Package emacs. (Sat, 05 Apr 2014 15:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 17193 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 17193 <at> debbugs.gnu.org
Subject: RE: bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys
Date: Sat, 5 Apr 2014 08:49:37 -0700 (PDT)

I should have made clear in the Subject line, as well as in the
message body, that the request is not just about :keys but includes
support for (i.e., taking account of) :enable, :visible, and so on.

IOW, the macro should allow `menu-item' features such as these
keywords to be passed on to `menu-item', so that they take effect.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17193; Package emacs. (Sat, 05 Apr 2014 15:59:02 GMT) Full text and rfc822 format available.

Message #11 received at 17193 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 17193 <at> debbugs.gnu.org
Subject: RE: bug#17193: 24.4.50; `menu-bar-make-toggle': allow :keys
Date: Sat, 5 Apr 2014 08:58:22 -0700 (PDT)

> I should have made clear in the Subject line, as well as in the
> message body, that the request is not just about :keys but includes
> support for (i.e., taking account of) :enable, :visible, and so on.
> 
> IOW, the macro should allow `menu-item' features such as these
> keywords to be passed on to `menu-item', so that they take effect.

This is apparently already what `menu-bar-make-mm-toggle' does,
for example.

[But the doc string for `menu-bar-make-mm-toggle' is not very
clear about this.  It simply calls this PROPS, saying "PROPS are
additional properties."  It really should make clear what is
involved: these are things passed to `menu-item'.  "Properties"
by itself means nothing in the context of that doc string.
Something really needs to point to `menu-item', which is fully
documented.]
Forcibly Merged 17193 17954. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 06 Jul 2014 18:14:01 GMT) Full text and rfc822 format available.
Merged 6542 17193 17954. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 06 Jul 2014 18:15:03 GMT) Full text and rfc822 format available.
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 19 Sep 2020 16:25:03 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 6542 <at> debbugs.gnu.org and "Drew Adams" <drew.adams <at> oracle.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 19 Sep 2020 16:25:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Oct 2020 11:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 187 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.