GNU bug report logs - #17797
24.3; Include ert-buffer.el in Emacs

Previous Next

Package: emacs;

Reported by: Thorsten Jolitz <tjolitz <at> gmail.com>

Date: Tue, 17 Jun 2014 15:02:01 UTC

Severity: wishlist

Tags: wontfix

Found in version 24.3

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17797 in the body.
You can then email your comments to 17797 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#17797; Package emacs. (Tue, 17 Jun 2014 15:02:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Thorsten Jolitz <tjolitz <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 17 Jun 2014 15:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Jolitz <tjolitz <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; Include ert-buffer.el in Emacs
Date: Tue, 17 Jun 2014 15:32:38 +0200
The library 'ert-buffer.el', which does not seem to have a repository
nor to be included in any package repo, but can easily be found via a
web-search, offers some fundamental extensions to ERT functionality in
Emacs core and should thus be included in core.

In summary, it allows to create ert-Buf objects either from string or
from an existing buffer and run tests comparing:

 - point
 - mark
 - content
 - return-value

Since the buffer is such a core concept of Emacs, comparing buffers
seems like a core task in testing. Library ert-buffer.el implements all
the necessary functionality, so that creating this kind of tests is
really fast, even when (sometimes big and complex) real-world
files/buffers are used for testing.

The functionality of ert-buffer.el might potentially be re-implemented
many times when ERT tests that compare buffers are written. Its choice
of criteria for comparing buffers seems pragmatic, keepings things
simple, and thus making it easy to write buffer-tests.

-- 
cheers,
Thorsten





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17797; Package emacs. (Thu, 19 Jun 2014 20:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 17797 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Thorsten Jolitz <tjolitz <at> gmail.com>
Cc: 17797 <at> debbugs.gnu.org
Subject: Re: bug#17797: 24.3; Include ert-buffer.el in Emacs
Date: Thu, 19 Jun 2014 16:46:41 -0400
> The library 'ert-buffer.el', which does not seem to have a repository
> nor to be included in any package repo, but can easily be found via a
> web-search, offers some fundamental extensions to ERT functionality in
> Emacs core and should thus be included in core.

I don't have a strong opinion either way because I don't know this area
well enough to judge how useful this can be.  So whoever thinks this is
a good or a bad idea, please chime in,


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17797; Package emacs. (Fri, 23 Oct 2020 03:01:01 GMT) Full text and rfc822 format available.

Message #11 received at 17797 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 17797 <at> debbugs.gnu.org, Thorsten Jolitz <tjolitz <at> gmail.com>
Subject: Re: bug#17797: 24.3; Include ert-buffer.el in Emacs
Date: Thu, 22 Oct 2020 20:00:26 -0700
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> The library 'ert-buffer.el', which does not seem to have a repository
>> nor to be included in any package repo, but can easily be found via a
>> web-search, offers some fundamental extensions to ERT functionality in
>> Emacs core and should thus be included in core.
>
> I don't have a strong opinion either way because I don't know this area
> well enough to judge how useful this can be.  So whoever thinks this is
> a good or a bad idea, please chime in,

This seems to be:

https://docutils.sourceforge.io/tools/editors/emacs/tests/ert-buffer.el

I'm not sure that this is useful for general use.  It has some
interesting ideas, but I'm not a big fan of the forms you seem to end up
with:

;;   (should (ert-equal-buffer '(insert "foo")
;;                             ; Insertion of "foo"...
;;   			       (concat ert-Buf-point-char ert-Buf-mark-char)
;;                             ; ...into an empty buffer with point and mark...
;;   			       (concat ert-Buf-mark-char "foo"
;;   				       ert-Buf-point-char)))
;;                             ; ...should result in a buffer containing "foo"
;;                             ; with point and mark moved appropriately.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#17797; Package emacs. (Sun, 06 Dec 2020 09:20:02 GMT) Full text and rfc822 format available.

Message #14 received at 17797 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 17797 <at> debbugs.gnu.org, Thorsten Jolitz <tjolitz <at> gmail.com>
Subject: Re: bug#17797: 24.3; Include ert-buffer.el in Emacs
Date: Sun, 6 Dec 2020 03:19:51 -0600
tags 17797 wontfix
close 17797
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>>> The library 'ert-buffer.el', which does not seem to have a repository
>>> nor to be included in any package repo, but can easily be found via a
>>> web-search, offers some fundamental extensions to ERT functionality in
>>> Emacs core and should thus be included in core.
>>
>> I don't have a strong opinion either way because I don't know this area
>> well enough to judge how useful this can be.  So whoever thinks this is
>> a good or a bad idea, please chime in,
>
> This seems to be:
>
> https://docutils.sourceforge.io/tools/editors/emacs/tests/ert-buffer.el
>
> I'm not sure that this is useful for general use.  It has some
> interesting ideas, but I'm not a big fan of the forms you seem to end up
> with:
>
> ;;   (should (ert-equal-buffer '(insert "foo")
> ;;                             ; Insertion of "foo"...
> ;;   			       (concat ert-Buf-point-char ert-Buf-mark-char)
> ;;                             ; ...into an empty buffer with point and mark...
> ;;   			       (concat ert-Buf-mark-char "foo"
> ;;   				       ert-Buf-point-char)))
> ;;                             ; ...should result in a buffer containing "foo"
> ;;                             ; with point and mark moved appropriately.

No further comments within 6 weeks, so I'm closing this as wontfix.




Added tag(s) wontfix. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 06 Dec 2020 09:20:02 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 17797 <at> debbugs.gnu.org and Thorsten Jolitz <tjolitz <at> gmail.com> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 06 Dec 2020 09:20:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 03 Jan 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 85 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.