GNU bug report logs - #18079
Remove redundant spaces in `mode-line-buffer-identification' for `calc-mode'

Previous Next

Package: emacs;

Reported by: Oleh <ohwoeowho <at> gmail.com>

Date: Tue, 22 Jul 2014 13:10:03 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18079 in the body.
You can then email your comments to 18079 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#18079; Package emacs. (Tue, 22 Jul 2014 13:10:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Oleh <ohwoeowho <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 22 Jul 2014 13:10:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleh <ohwoeowho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Remove redundant spaces in `mode-line-buffer-identification' for
 `calc-mode'
Date: Tue, 22 Jul 2014 15:09:26 +0200
[Message part 1 (text/plain, inline)]
Hi,

For some reason there are 14 extra spaces added to
`mode-line-buffer-identification' for `calc-mode'.
Which makes it look weird compared to other buffers, such as *scratch*.
This is especially apparent with a custom mode-line, e.g. powerline package.
I attach a patch.

regards,
Oleh
[0001-lisp-calc-calc.el-calc-set-mode-line-remove-redundan.patch (text/x-patch, attachment)]

Added tag(s) patch. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 03 Aug 2019 20:00:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18079; Package emacs. (Sat, 03 Aug 2019 20:04:01 GMT) Full text and rfc822 format available.

Message #10 received at 18079 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Oleh <ohwoeowho <at> gmail.com>
Cc: 18079 <at> debbugs.gnu.org
Subject: Re: bug#18079: Remove redundant spaces in
 `mode-line-buffer-identification' for `calc-mode'
Date: Sat, 03 Aug 2019 22:03:00 +0200
Oleh <ohwoeowho <at> gmail.com> writes:

> For some reason there are 14 extra spaces added to
> `mode-line-buffer-identification' for `calc-mode'.
> Which makes it look weird compared to other buffers, such as *scratch*.
> This is especially apparent with a custom mode-line, e.g. powerline package.
> I attach a patch.

[...]

> -	    (format "Calc%s%s: %d %s %-14s"
> +	    (format "Calc%s%s: %d %s %s"

That is indeed pretty odd.  Perhaps they wanted to have it equally wide
no matter what settings that are enabled?

Anyway, I think it's a positive change to make this more regular, so
I've applied your patch to Emacs 27.

If there's calc users that somehow found that space useful, then
reverting the commit would be fine, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 03 Aug 2019 20:04:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 18079 <at> debbugs.gnu.org and Oleh <ohwoeowho <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 03 Aug 2019 20:04:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Sep 2019 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 233 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.