GNU bug report logs - #18090
24.4.50; `delete-selection-helper' logic changed for non-mouse region?

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Drew Adams <drew.adams@HIDDEN>; dated Wed, 23 Jul 2014 18:04:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 18090 <at> debbugs.gnu.org:


Received: (at 18090) by debbugs.gnu.org; 19 Sep 2018 17:51:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 19 13:51:50 2018
Received: from localhost ([127.0.0.1]:45933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1g2gdi-0000Ql-E4
	for submit <at> debbugs.gnu.org; Wed, 19 Sep 2018 13:51:50 -0400
Received: from userp2130.oracle.com ([156.151.31.86]:41978)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1g2gdg-0000QQ-Ev
 for 18090 <at> debbugs.gnu.org; Wed, 19 Sep 2018 13:51:49 -0400
Received: from pps.filterd (userp2130.oracle.com [127.0.0.1])
 by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8JHn5iQ184191
 for <18090 <at> debbugs.gnu.org>; Wed, 19 Sep 2018 17:51:42 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=mime-version :
 message-id : date : from : sender : to : subject : references :
 in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02;
 bh=a80TnV3ve+26b2ee19/QGFpBpA10entT3l657nAmo3E=;
 b=icrVP+RwFWypUQEsYE8CUNT1gxPkdI3prD6fC+/w5IhD2m6zQH9QfhgTbCMmvVgWSrom
 MEmmsKDqYi3kInBxZhXVTNJHq3BO4WQx365QwGCdUVRCrZg0b0BP7bMWwOuKCWoCqIdA
 VslB/zyOoVTEDTB3uL8tNoOp1g/hJCMhMuq8OyensbddEf5Aqpr7MPqrAi+o76lbDy39
 0UUbCZpLPNTi7700ogHhGj1+YtNAf6gRuKCrxYmrwZG3feY356Zmbua8GpwkKDTvwpsE
 NwUJ5V1Emj0mkCGBdwk9ySkBpEdxMubCCM9xLEIfdYEQ1gntlQS39X7WCFdnd50rSX7m JA== 
Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])
 by userp2130.oracle.com with ESMTP id 2mgsgtvn5k-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
 for <18090 <at> debbugs.gnu.org>; Wed, 19 Sep 2018 17:51:42 +0000
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])
 by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w8JHpftV023634
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
 for <18090 <at> debbugs.gnu.org>; Wed, 19 Sep 2018 17:51:41 GMT
Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18])
 by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8JHpekC010011
 for <18090 <at> debbugs.gnu.org>; Wed, 19 Sep 2018 17:51:41 GMT
MIME-Version: 1.0
Message-ID: <9859e098-daf7-4b67-a8a6-c53d01a18f93@default>
Date: Wed, 19 Sep 2018 10:51:39 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
To: 18090 <at> debbugs.gnu.org
Subject: RE: bug#18090: 24.4.50; `delete-selection-helper' logic changed for
 non-mouse region?
References: <95e066b9-792c-4b38-8f4b-fd225578ed45@default>
 <eafa1e61-31df-4002-8e1a-289c6dcf5244@default>
In-Reply-To: <eafa1e61-31df-4002-8e1a-289c6dcf5244@default>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1  (1003210) [OL
 16.0.4735.0 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9021
 signatures=668707
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13
 malwarescore=0
 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=478
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.0.1-1807170000 definitions=main-1809190172
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 18090
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

ping

> Sent: Tuesday, April 3, 2018 2:06 PM
> ping
> Could someone else please take a look at this?
> Thx.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#18090; Package emacs. Full text available.

Message received at 18090 <at> debbugs.gnu.org:


Received: (at 18090) by debbugs.gnu.org; 3 Apr 2018 21:11:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 03 17:11:23 2018
Received: from localhost ([127.0.0.1]:37391 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1f3TD8-0008Vp-Tr
	for submit <at> debbugs.gnu.org; Tue, 03 Apr 2018 17:11:23 -0400
Received: from userp2120.oracle.com ([156.151.31.85]:50806)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1f3TD6-0008Vd-SY
 for 18090 <at> debbugs.gnu.org; Tue, 03 Apr 2018 17:11:21 -0400
Received: from pps.filterd (userp2120.oracle.com [127.0.0.1])
 by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w33L4vXG108941
 for <18090 <at> debbugs.gnu.org>; Tue, 3 Apr 2018 21:11:15 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=mime-version :
 message-id : date : from : sender : to : subject : references :
 in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26;
 bh=8majV3j7mQeQWBCYSRrAf1WQANSKCdo105BCv8TEGKQ=;
 b=Kbi+WjdWO412nfR9CCDKdKNMww+2b2U+A9+iBDwx82Lh40SRDjaX0PytoPFj+AXvb47g
 a/d/4kpue4pM4ZWDjk7MCFedyHAhbuMs+BJI/qdbOc1YC+ILrwq+yoITKFIUcUoXV3Rp
 isecwk0SceCiaHVO7aZQcwerPqwdCvT9IKC6eI8LxhzTvO7P+3CeKvJLsbV3W9gmvJzx
 BSiZA+xr+bqleR3IjXNSud/GzCUEYmBGnVzlbNHnpCQgJxduOojxhwkfGq1IYz2P487P
 YIpPjj/5OjoJOh7su7F3hv5HwJ7NMvyQXepucobXr79N21lnZfPKF7zlUPe3PTEvof9l Og== 
Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])
 by userp2120.oracle.com with ESMTP id 2h4h78r0yy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
 for <18090 <at> debbugs.gnu.org>; Tue, 03 Apr 2018 21:11:15 +0000
Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])
 by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w33L6Dj6003680
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
 for <18090 <at> debbugs.gnu.org>; Tue, 3 Apr 2018 21:06:14 GMT
Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11])
 by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w33L6DgW008570
 for <18090 <at> debbugs.gnu.org>; Tue, 3 Apr 2018 21:06:13 GMT
MIME-Version: 1.0
Message-ID: <eafa1e61-31df-4002-8e1a-289c6dcf5244@default>
Date: Tue, 3 Apr 2018 14:06:11 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
To: 18090 <at> debbugs.gnu.org
Subject: RE: bug#18090: 24.4.50; `delete-selection-helper' logic changed for
 non-mouse region?
References: <95e066b9-792c-4b38-8f4b-fd225578ed45@default>
In-Reply-To: <95e066b9-792c-4b38-8f4b-fd225578ed45@default>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1  (1003210) [OL
 16.0.4666.0 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8852
 signatures=668697
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13
 malwarescore=0
 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=992
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.0.1-1711220000 definitions=main-1804030211
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 18090
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

ping

Could someone else please take a look at this?
Thx.

> Sent: Wednesday, July 23, 2014 11:03 AM


> Prior to Emacs 23, the delsel.el code that handles a yank had this code:
>=20
> ;; Before a yank command, make sure we don't yank the
> ;; head of the kill-ring that really comes from the
> ;; currently active region we are going to delete.
> ;; That would make yank a no-op.
> (when (and (string=3D (buffer-substring-no-properties (point) (mark))
>                     (car kill-ring)))
>   (current-kill 1))
>=20
> That code dates from the creation of delsel.el.  In Emacs 23, these
> two sexps were appended to the `and' conditions, which completely
> changes the meaning/behavior (though the comment was not modified):
>=20
>  (fboundp 'mouse-region-match)
>  (mouse-region-match)
>=20
> This changed the behavior so that the yanking point is now rotated only
> when the mouse was used to set the region.  This makes no sense to me,
> but perhaps I am missing something.  Does this make sense to you?
> If it does make sense, then at least the comment should be updated to
> reflect the current behavior.
>=20
>=20
> ---
>=20
> BTW, I also think it would be better to use `while' instead of `when'
> in the code:
>=20
> (let ((tail  kill-ring))
>   (while (and tail  (string=3D (buffer-substring-no-properties (point)
> (mark))
>                              (car tail))
>               (fboundp 'mouse-region-match) ; ????
>               (mouse-region-match)) ; ????
>     (current-kill 1)
>     (setq tail  (cdr tail))))
>=20
>=20
> In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
>  of 2014-06-28 on ODIEONE
> Bzr revision: 117431 rgm@HIDDEN
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
>  `configure --prefix=3D/c/Devel/emacs/snapshot/trunk
>  --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3'
>  LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1
>  -Ic:/Devel/emacs/include''
>=20
>=20
>=20




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#18090; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Jul 2014 18:03:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 23 14:03:25 2014
Received: from localhost ([127.0.0.1]:35851 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1XA0sr-0004AW-Ah
	for submit <at> debbugs.gnu.org; Wed, 23 Jul 2014 14:03:25 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48594)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <drew.adams@HIDDEN>) id 1XA0sl-0004A1-6A
 for submit <at> debbugs.gnu.org; Wed, 23 Jul 2014 14:03:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1XA0sV-000883-H1
 for submit <at> debbugs.gnu.org; Wed, 23 Jul 2014 14:03:09 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:49325)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1XA0sV-00087z-DV
 for submit <at> debbugs.gnu.org; Wed, 23 Jul 2014 14:02:59 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50268)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1XA0sM-0006IJ-2x
 for bug-gnu-emacs@HIDDEN; Wed, 23 Jul 2014 14:02:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1XA0sC-00086T-Pm
 for bug-gnu-emacs@HIDDEN; Wed, 23 Jul 2014 14:02:50 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:43356)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <drew.adams@HIDDEN>) id 1XA0sC-00086O-Ii
 for bug-gnu-emacs@HIDDEN; Wed, 23 Jul 2014 14:02:40 -0400
Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237])
 by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 s6NI2cXW006796
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
 for <bug-gnu-emacs@HIDDEN>; Wed, 23 Jul 2014 18:02:39 GMT
Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231])
 by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NI2cGs029692
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
 for <bug-gnu-emacs@HIDDEN>; Wed, 23 Jul 2014 18:02:38 GMT
Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22])
 by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NI2cEw004032
 for <bug-gnu-emacs@HIDDEN>; Wed, 23 Jul 2014 18:02:38 GMT
MIME-Version: 1.0
Message-ID: <95e066b9-792c-4b38-8f4b-fd225578ed45@default>
Date: Wed, 23 Jul 2014 11:02:37 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 24.4.50; `delete-selection-helper' logic changed for non-mouse region?
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8  (707110) [OL
 12.0.6691.5000 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: acsinet21.oracle.com [141.146.126.237]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

Prior to Emacs 23, the delsel.el code that handles a yank had this code:

;; Before a yank command, make sure we don't yank the
;; head of the kill-ring that really comes from the
;; currently active region we are going to delete.
;; That would make yank a no-op.
(when (and (string=3D (buffer-substring-no-properties (point) (mark))
                    (car kill-ring)))
  (current-kill 1))

That code dates from the creation of delsel.el.  In Emacs 23, these
two sexps were appended to the `and' conditions, which completely
changes the meaning/behavior (though the comment was not modified):

 (fboundp 'mouse-region-match)
 (mouse-region-match)

This changed the behavior so that the yanking point is now rotated only
when the mouse was used to set the region.  This makes no sense to me,
but perhaps I am missing something.  Does this make sense to you?
If it does make sense, then at least the comment should be updated to
reflect the current behavior.


---

BTW, I also think it would be better to use `while' instead of `when'
in the code:

(let ((tail  kill-ring))
  (while (and tail  (string=3D (buffer-substring-no-properties (point) (mar=
k))
                             (car tail))
              (fboundp 'mouse-region-match) ; ????
              (mouse-region-match)) ; ????
    (current-kill 1)
    (setq tail  (cdr tail))))


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@HIDDEN
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=3D/c/Devel/emacs/snapshot/trunk
 --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3'
 LDFLAGS=3D-Lc:/Devel/emacs/lib 'CPPFLAGS=3D-DGC_MCHECK=3D1
 -Ic:/Devel/emacs/include''




Acknowledgement sent to Drew Adams <drew.adams@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#18090; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 19 Sep 2018 18:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.