GNU bug report logs - #18111
24.3; makefile-gmake-mode: Doesn't fontify `subst' calls properly

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 25 Jul 2014 22:37:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 25 18:37:29 2014
Received: from localhost ([127.0.0.1]:38180 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1XAo7E-00042A-EQ
	for submit <at> debbugs.gnu.org; Fri, 25 Jul 2014 18:37:29 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48602)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <naesten@HIDDEN>) id 1XAo7B-00041r-Lu
 for submit <at> debbugs.gnu.org; Fri, 25 Jul 2014 18:37:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <naesten@HIDDEN>) id 1XAo75-0007Uo-Gn
 for submit <at> debbugs.gnu.org; Fri, 25 Jul 2014 18:37:20 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
 T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:55693)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <naesten@HIDDEN>) id 1XAo75-0007Uk-DM
 for submit <at> debbugs.gnu.org; Fri, 25 Jul 2014 18:37:19 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50318)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <naesten@HIDDEN>) id 1XAo74-0006qO-CF
 for bug-gnu-emacs@HIDDEN; Fri, 25 Jul 2014 18:37:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <naesten@HIDDEN>) id 1XAo73-0007UO-3i
 for bug-gnu-emacs@HIDDEN; Fri, 25 Jul 2014 18:37:18 -0400
Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:46291)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <naesten@HIDDEN>) id 1XAo72-0007U5-VI
 for bug-gnu-emacs@HIDDEN; Fri, 25 Jul 2014 18:37:17 -0400
Received: by mail-qg0-f46.google.com with SMTP id z60so5815335qgd.5
 for <bug-gnu-emacs@HIDDEN>; Fri, 25 Jul 2014 15:37:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=from:to:subject:date:message-id:mime-version:content-type;
 bh=r4no0OC3He4uo+DaQLgmqCCoc7a4xuVQmzfy8ETX/Rs=;
 b=MarEqEZH6dBbyCc+XpfQLhLCKzYmi2sefsK93oBX1wfqnd1XaAEY3EKu0ME9BRlEwW
 UESjVxLIW2APORa+0/igijZA/VWPNi3LFv++ugpK+xdLPxgMb4ycXyORZXExJDZUstRg
 6K8LQIpWEqyIXxtPR1Sdzs3/3gm0yJ5Wm2MDv7fwNHGSvOw6NiiJuAjPpaw6gvjdOUrD
 JRNim5tMLpVQFPASlkZC+UnUoV8ckyvmudJN/G6xb0eGeJt7q00qOH4RXtDMLp49TuY2
 nxCSIVEde0+LpfXYeLUFSUitUATmJY9+ouPTmjzP60anq/lzdEZh/ow8KlsHRFOBi6fu
 q3Zw==
X-Received: by 10.140.39.164 with SMTP id v33mr16842025qgv.39.1406327835422;
 Fri, 25 Jul 2014 15:37:15 -0700 (PDT)
Received: from hydrogen (naesten-pt.tunnel.tserv4.nyc4.ipv6.he.net.
 [2001:470:1f06:57::2])
 by mx.google.com with ESMTPSA id y70sm12526498qgd.3.2014.07.25.15.37.13
 for <bug-gnu-emacs@HIDDEN>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Fri, 25 Jul 2014 15:37:14 -0700 (PDT)
Received: from naesten by hydrogen with local (Exim 4.82)
 (envelope-from <naesten@HIDDEN>) id 1XAo6w-0002jE-C9
 for bug-gnu-emacs@HIDDEN; Fri, 25 Jul 2014 18:37:10 -0400
From: Samuel Bronson <naesten@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 24.3; makefile-gmake-mode: Doesn't fontify `subst' calls properly
Date: Fri, 25 Jul 2014 18:37:09 -0400
Message-ID: <87wqb15alm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)


This problem has been bugging me for quite some time: `makefile-mode',
and now `makefile-gmake-mode', don't handle a construction used in,
for example, the following passage quoted from git's Makefile:

--8<---------------cut here---------------start------------->8---
# Shell quote (do not use $(call) to accommodate ancient setups);

SHA1_HEADER_SQ = $(subst ','\'',$(SHA1_HEADER))
ETC_GITCONFIG_SQ = $(subst ','\'',$(ETC_GITCONFIG))
ETC_GITATTRIBUTES_SQ = $(subst ','\'',$(ETC_GITATTRIBUTES))

DESTDIR_SQ = $(subst ','\'',$(DESTDIR))
bindir_SQ = $(subst ','\'',$(bindir))
bindir_relative_SQ = $(subst ','\'',$(bindir_relative))
mandir_relative_SQ = $(subst ','\'',$(mandir_relative))
infodir_relative_SQ = $(subst ','\'',$(infodir_relative))
localedir_SQ = $(subst ','\'',$(localedir))
gitexecdir_SQ = $(subst ','\'',$(gitexecdir))
template_dir_SQ = $(subst ','\'',$(template_dir))
htmldir_relative_SQ = $(subst ','\'',$(htmldir_relative))
prefix_SQ = $(subst ','\'',$(prefix))
gitwebdir_SQ = $(subst ','\'',$(gitwebdir))

SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))
PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
PYTHON_PATH_SQ = $(subst ','\'',$(PYTHON_PATH))
TCLTK_PATH_SQ = $(subst ','\'',$(TCLTK_PATH))
DIFF_SQ = $(subst ','\'',$(DIFF))
PERLLIB_EXTRA_SQ = $(subst ','\'',$(PERLLIB_EXTRA))
--8<---------------cut here---------------end--------------->8---

Actually, the problem doesn't seem to be at all specific to subst; it
appears to apply to any function call.

Function calls are delimited only by balanced parens()/braces{}; there
is no special treatment of single or double quotes.  In fact, Make does
not appear to have *any* particular handling for either single or double
quotes; the only reason to even fontify them at all is that *shells* do.
(I wonder why the manual never actually seems to mention this fact?)

--
In GNU Emacs 24.3.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2014-06-06 on babin, modified by Debian
Windowing system distributor `Colin Harrison', version 11.0.60900031
System Description:	Debian GNU/Linux testing (jessie)

Configured using:
 `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var/lib' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3/site-lisp:/usr/share/emacs/site-lisp'
 '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes'
 '--with-x-toolkit=lucid' '--with-toolkit-scroll-bars' '--without-gconf'
 '--without-gsettings' 'build_alias=i486-linux-gnu' 'CFLAGS=-g -O2
 -fstack-protector --param=ssp-buffer-size=4 -Wformat
 -Werror=format-security -Wall' 'LDFLAGS=-Wl,-z,relro'
 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: GNUmakefile

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  xterm-mouse-mode: t
  show-paren-mode: t
  recentf-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t


-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!