GNU bug report logs - #18120
cua-rect.el issue on help

Previous Next

Package: emacs;

Reported by: Pierre-Yves <py <at> luyten.fr>

Date: Mon, 28 Jul 2014 00:21:02 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18120 in the body.
You can then email your comments to 18120 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#18120; Package emacs. (Mon, 28 Jul 2014 00:21:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre-Yves <py <at> luyten.fr>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 28 Jul 2014 00:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre-Yves <py <at> luyten.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: cua-rect.el issue on help
Date: Sun, 27 Jul 2014 23:54:32 +0200
[Message part 1 (text/plain, inline)]
cua-rectangle feature does offer to type ? for help. It will display several available key sequence. Since modifier is not known, a function computes the string from the prefix variable.
It is basically a switch, which works for ‘hyper or ‘super or ‘alt or ‘meta , but it does not work for ‘control.

This is feasible to use ‘control as the modifier. 
   (setq cua--rectangle-modifier-key ‘control)


This one liner patch fixes the help in such case.
The cua-rect-help.patch is the result of `diff -c` command.
The 0001- prefixed patch is git, but I believe this is not the proper format.

[cua-rect-help.patch (application/octet-stream, attachment)]
[0001-cua-rect-help-check-for-control-value.patch (application/octet-stream, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18120; Package emacs. (Sat, 03 Aug 2019 19:49:01 GMT) Full text and rfc822 format available.

Message #8 received at 18120 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Pierre-Yves <py <at> luyten.fr>
Cc: 18120 <at> debbugs.gnu.org
Subject: Re: bug#18120: cua-rect.el issue on help
Date: Sat, 03 Aug 2019 21:48:04 +0200
Pierre-Yves <py <at> luyten.fr> writes:

> cua-rectangle feature does offer to type ? for help. It will display
> several available key sequence. Since modifier is not known, a
> function computes the string from the prefix variable.
> It is basically a switch, which works for ‘hyper or ‘super or ‘alt or
> ‘meta , but it does not work for ‘control.
>
> This is feasible to use ‘control as the modifier. 
>    (setq cua--rectangle-modifier-key ‘control)

[...]

>   		 ((eq cua--rectangle-modifier-key 'super) " s-")
>   		 ((eq cua--rectangle-modifier-key 'alt) " A-")
> +                  ((eq cua--rectangle-modifier-key 'control) " C-")
>   		 (t " M-"))))

(I'm going through old bug reports that unfortunately have not received
any responses yet.)

I don't use cua mode myself, but this looks like it's "obviously" the
right thing, so I've applied the patch to Emacs 27.

If a cua user determines that it's not quite the right thing to do,
please feel free to revert the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) patch. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 03 Aug 2019 19:49:02 GMT) Full text and rfc822 format available.

Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 03 Aug 2019 19:49:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 18120 <at> debbugs.gnu.org and Pierre-Yves <py <at> luyten.fr> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 03 Aug 2019 19:49:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Sep 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 238 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.