GNU bug report logs - #18163
elisp: highlighting of unexpected indentation should use separate face from highlight of error functions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18163 in the body.
You can then email your comments to 18163 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode': spurious
 `font-lock-warning-face'
Date: Thu, 31 Jul 2014 21:23:47 -0700 (PDT)

Recipe from emacs -Q: Type this into an Emacs-Lisp mode buffer:

(defun foo ()
  (condition-case nil
      (let ((toto (lambda (cand)
		     (foo)) bar)))
    (quit (tutu))))

The text "bar)))" is highlighted erroneously, with face
`font-lock-warning-face'.  It should not be highlighted at all.

If you add more right-parens, or any other text, at the end of the same
line as the warning-highlighted text, it too has that red face.  It
does not seem to matter what text you add.  You can remove all of the
warning-face text except the `b' (or any other char in place of `b'),
and it is still highlighted.  You can remove the SPC before the `b'
and it remains highlighted.  If you remove the whitespace before
"(foo..." on the same line, the highlighting remains.

If you remove the newline before the "(foo..." line then the
highlighting goes away.

The first build where I see this regression is this one:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-04-25 on ODIEONE
Repository revision: 117024 monnier <at> iro.umontreal.ca-20140425192226-frpjpmgs0r8ad9wc
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

The last build I have where there is not this regression is this one:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-04-21 on ODIEONE
Repository revision: 117005 dancol <at> dancol.org-20140421180019-po4wdeg7gqvvlh5d
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

This is the build I'm sending this report from:

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm <at> gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

Message #12 received at 18163-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 18163-done <at> debbugs.gnu.org
Subject: Re: bug#18163: 24.4.50;
 REGRESSION, font-lock in `emacs-lisp-mode': spurious
 `font-lock-warning-face'
Date: Wed, 06 Aug 2014 13:15:04 -0400

tags 18163 notabug
thanks

> The text "bar)))" is highlighted erroneously, with face
> `font-lock-warning-face'.

It's no error.  There's even a help-text explaining why it's highlighted
this way (if you hover your mouse above the highlighted text).


        Stefan

Message #15 received at 18163-done <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 18163-done <at> debbugs.gnu.org
Subject: RE: bug#18163: 24.4.50; REGRESSION, font-lock in `emacs-lisp-mode':
 spurious `font-lock-warning-face'
Date: Wed, 6 Aug 2014 11:04:39 -0700 (PDT)

> It's no error.  There's even a help-text explaining why it's highlighted
> this way (if you hover your mouse above the highlighted text).

I see.  Yes, I can see that that can be helpful.

It's unfortunate that the same face is used for this kind of warning
and for things like `error' and `user-error', which are not something
to be warned about.  It is handy to highlight those too (specially),
but they should not use a "warning" face, if that face is really
starting to be used to warn.

IOW using `font-lock-warning-face' to warn uncovers an (effectively
new) bug: its use for non-warnings is inappropriate.  It could
arguably have been considered appropriate (though poorly named) as
long as none of the uses involved warning.  There is no longer any
such justification.

Message #18 received at 18163 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: 18163 <at> debbugs.gnu.org
Cc: monnier <at> iro.umontreal.ca, drew.adams <at> oracle.com
Subject: Re: bug#18163: 24.4.50;
 REGRESSION, font-lock in `emacs-lisp-mode': spurious
 `font-lock-warning-face'
Date: Thu, 07 Aug 2014 11:47:48 +0800

On 2014-08-06 13:15 -0400, Stefan Monnier wrote:
> It's no error.  There's even a help-text explaining why it's highlighted
> this way (if you hover your mouse above the highlighted text).

Maybe the face can be tweaked to improve usability, for example,
underwave/line it.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.