GNU bug report logs - #18378
wrong fontification of Java code

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18378 in the body.
You can then email your comments to 18378 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: wrong fontification of Java code
Date: Mon, 1 Sep 2014 11:48:14 +0200

[Message part 1 (text/plain, inline)]

class X
{
    public void x ()
    {
        for (int this_is_not_a_function_name : getX ()) {
        }
    }
}

In current trunk (compiled five minutes ago) 'this_is_not_a_function_name'
above is fontified as a function name. This seems to depend on whether I
have '()' after 'getX' or not.

Paul

[Message part 2 (text/html, inline)]

Message #8 received at 18378 <at> debbugs.gnu.org (full text, mbox):

From: Jordon Biondo <jordonbiondo <at> gmail.com>
To: 18378 <at> debbugs.gnu.org
Subject: [Patch] wrong fontification of Java code
Date: Mon, 1 Sep 2014 15:20:30 -0400

I have a potential solution for this bug, as it has impacted me as well.

Not sure what the best solution would be but I have included a patch that does solve the problem. From what I can tell there are no tests for java fortification but I have not seen any issues arising in my own java projects. The issue was that in java, a “:” can mark the end of a declaration in a foreach, not just a “;” or “,”.


=== modified file 'lisp/ChangeLog'
*** lisp/ChangeLog	2014-09-01 15:03:45 +0000
--- lisp/ChangeLog	2014-09-01 19:11:46 +0000
***************
*** 1,3 ****
--- 1,8 ----
+ 2014-09-01  Jordon Biondo  <jordonbiondo <at> gmail.com>
+ 
+ 	* progmodes/cc-fonts.el (c-font-lock-declarators): Special
+ 	case for declarations inside Java foreach loops (Bug#18378)
+ 
  2014-09-01  Eli Zaretskii  <eliz <at> gnu.org>
  
  	* ls-lisp.el (ls-lisp-use-string-collate)

=== modified file 'lisp/progmodes/cc-fonts.el'
*** lisp/progmodes/cc-fonts.el	2014-08-24 20:50:11 +0000
--- lisp/progmodes/cc-fonts.el	2014-09-01 19:11:59 +0000
*************** casts and declarations are fontified.  U
*** 1116,1123 ****
  	    ;; initializing brace lists.
  	    (let (found)
  	      (while
! 		  (and (setq found (c-syntactic-re-search-forward
! 			     "[;,]\\|\\s)\\|\\'\\|\\(=\\|\\s(\\)" limit t t))
  		       (eq (char-before) ?\[)
  		       (c-go-up-list-forward))
  		     (setq brackets-after-id t))
--- 1116,1128 ----
  	    ;; initializing brace lists.
  	    (let (found)
  	      (while
!                   (and (setq found (c-syntactic-re-search-forward
!                                     (concat "[;,]\\|\\s)\\|\\'\\|\\(=\\|"
!                                             (if (c-major-mode-is 'java-mode)
!                                                 ":\\|"
!                                               "")
!                                             "\\s(\\)")
!                                     limit t t))
  		       (eq (char-before) ?\[)
  		       (c-go-up-list-forward))
  		     (setq brackets-after-id t))

Message #13 received at 18378 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Alan Mackenzie <acm <at> muc.de>
Cc: Jordon Biondo <jordonbiondo <at> gmail.com>, 18378 <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18378: [Patch] wrong fontification of Java code
Date: Mon, 20 Jan 2020 22:16:46 +0100

Hi Alan,

Could you please help review the below patch for cc-fonts.el?

Thanks in advance.

Best regards,
Stefan Kangas

Paul Pogonyshev <pogonyshev <at> gmail.com> writes:

> class X
> {
>     public void x ()
>     {
>         for (int this_is_not_a_function_name : getX ()) {
>         }
>     }
> }
>
> In current trunk (compiled five minutes ago)
> 'this_is_not_a_function_name' above is fontified as a function
> name. This seems to depend on whether I have '()' after 'getX' or
> not.
>
> Paul

Jordon Biondo <jordonbiondo <at> gmail.com> writes:

> I have a potential solution for this bug, as it has impacted me as well.
>
> Not sure what the best solution would be but I have included a patch that does
> solve the problem. From what I can tell there are no tests for java
> fortification but I have not seen any issues arising in my own java
> projects. The issue was that in java, a “:” can mark the end of a declaration in
> a foreach, not just a “;” or “,”.
>
> === modified file 'lisp/ChangeLog'
> *** lisp/ChangeLog	2014-09-01 15:03:45 +0000
> --- lisp/ChangeLog	2014-09-01 19:11:46 +0000
> ***************
> *** 1,3 ****
> --- 1,8 ----
> + 2014-09-01  Jordon Biondo  <jordonbiondo <at> gmail.com>
> + 
> + 	* progmodes/cc-fonts.el (c-font-lock-declarators): Special
> + 	case for declarations inside Java foreach loops (Bug#18378)
> + 
>   2014-09-01  Eli Zaretskii  <eliz <at> gnu.org>
>   
>   	* ls-lisp.el (ls-lisp-use-string-collate)
>
> === modified file 'lisp/progmodes/cc-fonts.el'
> *** lisp/progmodes/cc-fonts.el	2014-08-24 20:50:11 +0000
> --- lisp/progmodes/cc-fonts.el	2014-09-01 19:11:59 +0000
> *************** casts and declarations are fontified.  U
> *** 1116,1123 ****
>   	    ;; initializing brace lists.
>   	    (let (found)
>   	      (while
> ! 		  (and (setq found (c-syntactic-re-search-forward
> ! 			     "[;,]\\|\\s)\\|\\'\\|\\(=\\|\\s(\\)" limit t t))
>   		       (eq (char-before) ?\[)
>   		       (c-go-up-list-forward))
>   		     (setq brackets-after-id t))
> --- 1116,1128 ----
>   	    ;; initializing brace lists.
>   	    (let (found)
>   	      (while
> !                   (and (setq found (c-syntactic-re-search-forward
> !                                     (concat "[;,]\\|\\s)\\|\\'\\|\\(=\\|"
> !                                             (if (c-major-mode-is 'java-mode)
> !                                                 ":\\|"
> !                                               "")
> !                                             "\\s(\\)")
> !                                     limit t t))
>   		       (eq (char-before) ?\[)
>   		       (c-go-up-list-forward))
>   		     (setq brackets-after-id t))

Message #16 received at 18378 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Jordon Biondo <jordonbiondo <at> gmail.com>, 18378 <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18378: [Patch] wrong fontification of Java code
Date: Wed, 22 Jan 2020 20:59:06 +0000

Hello, Stefan.

On Mon, Jan 20, 2020 at 22:16:46 +0100, Stefan Kangas wrote:
> Hi Alan,

> Could you please help review the below patch for cc-fonts.el?

I missed this bug report back in 2014.  The code has moved around so
much since then that Jordon's patch no longer applies.  But a simple
patch with the same idea appears to fix this bug:



diff -r 3d883b66c245 cc-engine.el
--- a/cc-engine.el	Tue Jan 07 19:24:00 2020 +0000
+++ b/cc-engine.el	Wed Jan 22 20:49:53 2020 +0000
@@ -9025,7 +9025,7 @@
 			   (if (looking-at c-:-op-cont-regexp)
 			       (progn (goto-char (match-end 0)) t)
 			     (not
-			      (and (c-major-mode-is 'c++-mode)
+			      (and (c-major-mode-is '(c++-mode java-mode))
 				   (save-excursion
 				     (and
 				      (c-go-up-list-backward)

This patch should apply cleanly to the emacs-27 branch, and most
probably to master, too.


> Thanks in advance.

> Best regards,
> Stefan Kangas

-- 
Alan Mackenzie (Nuremberg, Germany).


> Paul Pogonyshev <pogonyshev <at> gmail.com> writes:

> > class X
> > {
> >     public void x ()
> >     {
> >         for (int this_is_not_a_function_name : getX ()) {
> >         }
> >     }
> > }
> >
> > In current trunk (compiled five minutes ago)
> > 'this_is_not_a_function_name' above is fontified as a function
> > name. This seems to depend on whether I have '()' after 'getX' or
> > not.
> >
> > Paul

> Jordon Biondo <jordonbiondo <at> gmail.com> writes:

> > I have a potential solution for this bug, as it has impacted me as well.
> >
> > Not sure what the best solution would be but I have included a patch that does
> > solve the problem. From what I can tell there are no tests for java
> > fortification but I have not seen any issues arising in my own java
> > projects. The issue was that in java, a “:” can mark the end of a declaration in
> > a foreach, not just a “;” or “,”.
> >
> > === modified file 'lisp/ChangeLog'
> > *** lisp/ChangeLog	2014-09-01 15:03:45 +0000
> > --- lisp/ChangeLog	2014-09-01 19:11:46 +0000
> > ***************
> > *** 1,3 ****
> > --- 1,8 ----
> > + 2014-09-01  Jordon Biondo  <jordonbiondo <at> gmail.com>
> > + 
> > + 	* progmodes/cc-fonts.el (c-font-lock-declarators): Special
> > + 	case for declarations inside Java foreach loops (Bug#18378)
> > + 
> >   2014-09-01  Eli Zaretskii  <eliz <at> gnu.org>
> >   
> >   	* ls-lisp.el (ls-lisp-use-string-collate)
> >
> > === modified file 'lisp/progmodes/cc-fonts.el'
> > *** lisp/progmodes/cc-fonts.el	2014-08-24 20:50:11 +0000
> > --- lisp/progmodes/cc-fonts.el	2014-09-01 19:11:59 +0000
> > *************** casts and declarations are fontified.  U
> > *** 1116,1123 ****
> >   	    ;; initializing brace lists.
> >   	    (let (found)
> >   	      (while
> > ! 		  (and (setq found (c-syntactic-re-search-forward
> > ! 			     "[;,]\\|\\s)\\|\\'\\|\\(=\\|\\s(\\)" limit t t))
> >   		       (eq (char-before) ?\[)
> >   		       (c-go-up-list-forward))
> >   		     (setq brackets-after-id t))
> > --- 1116,1128 ----
> >   	    ;; initializing brace lists.
> >   	    (let (found)
> >   	      (while
> > !                   (and (setq found (c-syntactic-re-search-forward
> > !                                     (concat "[;,]\\|\\s)\\|\\'\\|\\(=\\|"
> > !                                             (if (c-major-mode-is 'java-mode)
> > !                                                 ":\\|"
> > !                                               "")
> > !                                             "\\s(\\)")
> > !                                     limit t t))
> >   		       (eq (char-before) ?\[)
> >   		       (c-go-up-list-forward))
> >   		     (setq brackets-after-id t))

Message #19 received at 18378 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Alan Mackenzie <acm <at> muc.de>
Cc: Jordon Biondo <jordonbiondo <at> gmail.com>, 18378 <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18378: [Patch] wrong fontification of Java code
Date: Thu, 23 Jan 2020 15:13:05 +0100

Hi Alan,

Alan Mackenzie <acm <at> muc.de> writes:

> I missed this bug report back in 2014.  The code has moved around so
> much since then that Jordon's patch no longer applies.  But a simple
> patch with the same idea appears to fix this bug:

Thanks for taking a look.

With your fix, applied on the master branch, in the example given:

    class X
    {
        public void x ()
        {
            for (int this_is_not_a_function_name : getX ()) {
            }
        }
    }

The "int" no longer has font-lock-type-face.  Should it?

Best regards,
Stefan Kangas

Message #22 received at 18378 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Jordon Biondo <jordonbiondo <at> gmail.com>, 18378 <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18378: [Patch] wrong fontification of Java code
Date: Thu, 23 Jan 2020 18:09:47 +0000

Hello, Stefan.

On Thu, Jan 23, 2020 at 15:13:05 +0100, Stefan Kangas wrote:
> Hi Alan,

> Alan Mackenzie <acm <at> muc.de> writes:

> > I missed this bug report back in 2014.  The code has moved around so
> > much since then that Jordon's patch no longer applies.  But a simple
> > patch with the same idea appears to fix this bug:

> Thanks for taking a look.

> With your fix, applied on the master branch, in the example given:

>     class X
>     {
>         public void x ()
>         {
>             for (int this_is_not_a_function_name : getX ()) {
>             }
>         }
>     }

> The "int" no longer has font-lock-type-face.  Should it?

That's funny.  It has font-lock-type-face for me, in all of emacs-27,
master and standalone CC Mode (in master).  font-lock-type-face is indeed
correct, here.

Are you sure you were ....  (I don't think I need to fill in the dots for
you.  ;-)

> Best regards,
> Stefan Kangas

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #25 received at 18378 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Jordon Biondo <jordonbiondo <at> gmail.com>, 18378 <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18378: [Patch] wrong fontification of Java code
Date: Tue, 11 Feb 2020 20:06:38 +0000

Hello again, Stefan.

Ping?

-- 
Alan Mackenzie (Nuremberg, Germany).


On Thu, Jan 23, 2020 at 18:09:47 +0000, Alan Mackenzie wrote:
> Hello, Stefan.

> On Thu, Jan 23, 2020 at 15:13:05 +0100, Stefan Kangas wrote:
> > Hi Alan,

> > Alan Mackenzie <acm <at> muc.de> writes:

> > > I missed this bug report back in 2014.  The code has moved around so
> > > much since then that Jordon's patch no longer applies.  But a simple
> > > patch with the same idea appears to fix this bug:

> > Thanks for taking a look.

> > With your fix, applied on the master branch, in the example given:

> >     class X
> >     {
> >         public void x ()
> >         {
> >             for (int this_is_not_a_function_name : getX ()) {
> >             }
> >         }
> >     }

> > The "int" no longer has font-lock-type-face.  Should it?

> That's funny.  It has font-lock-type-face for me, in all of emacs-27,
> master and standalone CC Mode (in master).  font-lock-type-face is indeed
> correct, here.

> Are you sure you were ....  (I don't think I need to fill in the dots for
> you.  ;-)

> > Best regards,
> > Stefan Kangas

> -- 
> Alan Mackenzie (Nuremberg, Germany).

Message #30 received at 18378-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Jordon Biondo <jordonbiondo <at> gmail.com>, 18378-done <at> debbugs.gnu.org,
 Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: Re: bug#18378: [Patch] wrong fontification of Java code
Date: Sun, 23 Feb 2020 12:50:37 +0000

Hello, all.

I've committed a fix to this bug to the emacs-27 branch at savannah.
I'm closing the bug with this post.

-- 
Alan Mackenzie (Nuremberg, Germany).


On Mon, Jan 20, 2020 at 22:16:46 +0100, Stefan Kangas wrote:
> Hi Alan,

> Could you please help review the below patch for cc-fonts.el?

> Thanks in advance.

> Best regards,
> Stefan Kangas

> Paul Pogonyshev <pogonyshev <at> gmail.com> writes:

> > class X
> > {
> >     public void x ()
> >     {
> >         for (int this_is_not_a_function_name : getX ()) {
> >         }
> >     }
> > }

> > In current trunk (compiled five minutes ago)
> > 'this_is_not_a_function_name' above is fontified as a function
> > name. This seems to depend on whether I have '()' after 'getX' or
> > not.

> > Paul

> Jordon Biondo <jordonbiondo <at> gmail.com> writes:

> > I have a potential solution for this bug, as it has impacted me as well.

> > Not sure what the best solution would be but I have included a patch that does
> > solve the problem. From what I can tell there are no tests for java
> > fortification but I have not seen any issues arising in my own java
> > projects. The issue was that in java, a “:” can mark the end of a declaration in
> > a foreach, not just a “;” or “,”.

> > === modified file 'lisp/ChangeLog'
> > *** lisp/ChangeLog	2014-09-01 15:03:45 +0000
> > --- lisp/ChangeLog	2014-09-01 19:11:46 +0000
> > ***************
> > *** 1,3 ****
> > --- 1,8 ----
> > + 2014-09-01  Jordon Biondo  <jordonbiondo <at> gmail.com>
> > + 
> > + 	* progmodes/cc-fonts.el (c-font-lock-declarators): Special
> > + 	case for declarations inside Java foreach loops (Bug#18378)
> > + 
> >   2014-09-01  Eli Zaretskii  <eliz <at> gnu.org>

> >   	* ls-lisp.el (ls-lisp-use-string-collate)

> > === modified file 'lisp/progmodes/cc-fonts.el'
> > *** lisp/progmodes/cc-fonts.el	2014-08-24 20:50:11 +0000
> > --- lisp/progmodes/cc-fonts.el	2014-09-01 19:11:59 +0000
> > *************** casts and declarations are fontified.  U
> > *** 1116,1123 ****
> >   	    ;; initializing brace lists.
> >   	    (let (found)
> >   	      (while
> > ! 		  (and (setq found (c-syntactic-re-search-forward
> > ! 			     "[;,]\\|\\s)\\|\\'\\|\\(=\\|\\s(\\)" limit t t))
> >   		       (eq (char-before) ?\[)
> >   		       (c-go-up-list-forward))
> >   		     (setq brackets-after-id t))
> > --- 1116,1128 ----
> >   	    ;; initializing brace lists.
> >   	    (let (found)
> >   	      (while
> > !                   (and (setq found (c-syntactic-re-search-forward
> > !                                     (concat "[;,]\\|\\s)\\|\\'\\|\\(=\\|"
> > !                                             (if (c-major-mode-is 'java-mode)
> > !                                                 ":\\|"
> > !                                               "")
> > !                                             "\\s(\\)")
> > !                                     limit t t))
> >   		       (eq (char-before) ?\[)
> >   		       (c-go-up-list-forward))
> >   		     (setq brackets-after-id t))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.