GNU bug report logs - #18397
24.3; [PATCH] follow-minor-mode now has an indicator in the modeline

Previous Next

Package: emacs;

Reported by: Dima Kogan <dima <at> secretsauce.net>

Date: Wed, 3 Sep 2014 18:13:02 UTC

Severity: wishlist

Tags: patch

Found in version 24.3

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18397 in the body.
You can then email your comments to 18397 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#18397; Package emacs. (Wed, 03 Sep 2014 18:13:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dima Kogan <dima <at> secretsauce.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 03 Sep 2014 18:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; [PATCH] follow-minor-mode now has an indicator in the modeline
Date: Wed, 03 Sep 2014 11:11:50 -0700
[Message part 1 (text/plain, inline)]
Hi. Here's a tiny patch to add a modeline indicator when using
follow-minor-mode

[0001-follow-minor-mode-now-has-an-indicator-in-the-modeli.patch (text/x-diff, inline)]
From fcb11c6bd6b02aa42ff4fe3c62ba5cb2add8cede Mon Sep 17 00:00:00 2001
From: Dima Kogan <dima <at> secretsauce.net>
Date: Wed, 3 Sep 2014 11:10:38 -0700
Subject: [PATCH] follow-minor-mode now has an indicator in the modeline

---
 lisp/follow.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/follow.el b/lisp/follow.el
index ddb25be..5ab8f10 100644
--- a/lisp/follow.el
+++ b/lisp/follow.el
@@ -414,6 +414,7 @@ This command runs the normal hook `follow-mode-hook'.
 Keys specific to Follow mode:
 \\{follow-mode-map}"
   :keymap follow-mode-map
+  :lighter " Follow"
   (if follow-mode
       (progn
 	(add-hook 'compilation-filter-hook 'follow-align-compilation-windows t t)
-- 
2.0.0


Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18397; Package emacs. (Tue, 23 Feb 2016 12:13:02 GMT) Full text and rfc822 format available.

Message #8 received at 18397 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 18397 <at> debbugs.gnu.org
Subject: Re: bug#18397: 24.3;
 [PATCH] follow-minor-mode now has an indicator in the modeline
Date: Tue, 23 Feb 2016 23:12:20 +1100
Dima Kogan <dima <at> secretsauce.net> writes:

> Hi. Here's a tiny patch to add a modeline indicator when using
> follow-minor-mode
>
>>From fcb11c6bd6b02aa42ff4fe3c62ba5cb2add8cede Mon Sep 17 00:00:00 2001
> From: Dima Kogan <dima <at> secretsauce.net>
> Date: Wed, 3 Sep 2014 11:10:38 -0700
> Subject: [PATCH] follow-minor-mode now has an indicator in the modeline
>
> ---
>  lisp/follow.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/follow.el b/lisp/follow.el
> index ddb25be..5ab8f10 100644
> --- a/lisp/follow.el
> +++ b/lisp/follow.el
> @@ -414,6 +414,7 @@ This command runs the normal hook `follow-mode-hook'.
>  Keys specific to Follow mode:
>  \\{follow-mode-map}"
>    :keymap follow-mode-map
> +  :lighter " Follow"

This seems like a pretty uncontroversial change, but not all minor modes
(especially the more "global" ones) create a lighter, because that would
be a lot of ... mode line stuff.

I don't use follow mode myself, so I don't know.  Opinions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18397; Package emacs. (Tue, 25 Jun 2019 21:31:01 GMT) Full text and rfc822 format available.

Message #11 received at 18397 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 18397 <at> debbugs.gnu.org
Subject: Re: bug#18397: 24.3;
 [PATCH] follow-minor-mode now has an indicator in the modeline
Date: Tue, 25 Jun 2019 23:30:21 +0200
Dima Kogan <dima <at> secretsauce.net> writes:

> @@ -414,6 +414,7 @@ This command runs the normal hook `follow-mode-hook'.
>  Keys specific to Follow mode:
>  \\{follow-mode-map}"
>    :keymap follow-mode-map
> +  :lighter " Follow"

This has been added in the meantime, and it's " Fol", apparently:

(define-minor-mode next-error-follow-minor-mode
  "Minor mode for compilation, occur and diff modes.

When turned on, cursor motion in the compilation, grep, occur or diff
buffer causes automatic display of the corresponding source code location."
  :group 'next-error :init-value nil :lighter " Fol"


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug closed, send any further explanations to 18397 <at> debbugs.gnu.org and Dima Kogan <dima <at> secretsauce.net> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 25 Jun 2019 21:31:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 24 Jul 2019 11:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 278 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.