GNU logs - #18835, boring messages

Message sent to bug-guile@HIDDEN:

Subject: bug#18835: load-from-path is inconsistent when looking for a compiled version of the source file
Resent-From: Geert Janssens <info@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sat, 25 Oct 2014 17:31:01 +0000
Resent-Message-ID: <handler.18835.B.141425821822367 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 18835 <at> debbugs.gnu.org
From: Geert Janssens <info@HIDDEN>
Date: Sat, 25 Oct 2014 19:09:09 +0200
Message-ID: <2787802.8pnN87I00l@HIDDEN>
User-Agent: KMail/4.14.1 (Linux/3.16.3-200.fc20.x86_64; KDE/4.14.1; x86_64; ; )
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart1675530.NTyNcRlumu"
Content-Transfer-Encoding: 7Bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.

--nextPart1675530.NTyNcRlumu
Content-Type: multipart/alternative; boundary="nextPart5320587.iDt9Tjd8NJ"
Content-Transfer-Encoding: 7Bit

This is a multi-part message in MIME format.

--nextPart5320587.iDt9Tjd8NJ
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

$ guile --version
guile (GNU Guile) 2.0.11

$ config.guess 
x86_64-unknown-linux-gnu

$ rpm -qa | grep guile
compat-guile18-1.8.8-7.fc20.x86_64
guile-debuginfo-2.0.11-1.fc20.x86_64
guile-2.0.11-1.fc20.x86_64
guile-devel-2.0.11-1.fc20.x86_64

These steps illustrate the issue:

1. Download the attached file and save it as $HOME/guile/test.scm
Note: this is just an example file printing one line to indicate is has
successfully been called. Any other scm file will do to illustrate this bug.

2. Run these commands:
$ mkdir -p $HOME/guile/ccache
$ cd $HOME/guile/ccache
$ guild compile -o test.go ../test.scm
$ guild compile -o test.scm.go ../test.scm

This will generate two compiled versions of the test file, each with a different extension.

Now run these commands and observe what happens:
$ cd $HOME/guile
$ GUILE_LOAD_PATH=$HOME/guile \
  GUILE_LOAD_COMPILED_PATH=$HOME/guile/ccache \
  guile -c '(load-from-path "test")'

=> This command will use the file $HOME/guile/ccache/test.go. That is, no auto-compilation 
is triggered.

$ GUILE_LOAD_PATH=$HOME/guile \
  GUILE_LOAD_COMPILED_PATH=$HOME/guile/ccache \
  guile -c '(load-from-path "test.scm")'

=> This command will *not* use either of $HOME/guile/ccache/test.go or 
$HOME/guile/ccache/test.scm.go. Instead it will autocompile test.scm into <default-cache-
dir>/test.scm.go and use that one.

So there is no way to have the second command use your self-compiled files.

From Andy Wingo's comments on irc, it is expected that the second case would have used the 
self-compiled $HOME/guile/ccache/test.scm.go. I'm fine with that although using 
$HOME/guile/ccache/test.go would have made more sense from an outsider's point of view. At 
least it should be possible to make load-from-path use a self-compiled .go file regardless of 
whether the argument ends in .scm or not.

If more information is needed, feel free to ask.

Regards,

Geert

--nextPart5320587.iDt9Tjd8NJ
Content-Transfer-Encoding: 7Bit
Content-Type: text/html; charset="us-ascii"

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">
<html><head><meta name="qrichtext" content="1" /><style type="text/css">
p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Monospace'; font-size:10pt; font-weight:400; font-style:normal;">
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ guile --version</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">guile (GNU Guile) 2.0.11</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ config.guess </p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">x86_64-unknown-linux-gnu</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ rpm -qa | grep guile</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">compat-guile18-1.8.8-7.fc20.x86_64</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">guile-debuginfo-2.0.11-1.fc20.x86_64</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">guile-2.0.11-1.fc20.x86_64</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">guile-devel-2.0.11-1.fc20.x86_64</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">These steps illustrate the issue:</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">1. Download the attached file and save it as $HOME/guile/test.scm</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Note: this is just an example file printing one line to indicate is has</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">successfully been called. Any other scm file will do to illustrate this bug.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">2. Run these commands:</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ mkdir -p $HOME/guile/ccache</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ cd $HOME/guile/ccache</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ guild compile -o test.go ../test.scm</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ guild compile -o test.scm.go ../test.scm</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">This will generate two compiled versions of the test file, each with a different extension.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Now run these commands and observe what happens:</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ cd $HOME/guile</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ GUILE_LOAD_PATH=$HOME/guile \</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">  GUILE_LOAD_COMPILED_PATH=$HOME/guile/ccache \</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">  guile -c '(load-from-path &quot;test&quot;)'</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">=&gt; This command will use the file $HOME/guile/ccache/test.go. That is, no auto-compilation is triggered.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">$ GUILE_LOAD_PATH=$HOME/guile \</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">  GUILE_LOAD_COMPILED_PATH=$HOME/guile/ccache \</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">  guile -c '(load-from-path &quot;test.scm&quot;)'</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">=&gt; This command will *not* use either of $HOME/guile/ccache/test.go or $HOME/guile/ccache/test.scm.go. Instead it will autocompile test.scm into &lt;default-cache-dir&gt;/test.scm.go and use that one.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">So there is no way to have the second command use your self-compiled files.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">From Andy Wingo's comments on irc, it is expected that the second case would have used the self-compiled $HOME/guile/ccache/test.scm.go. I'm fine with that although using $HOME/guile/ccache/test.go would have made more sense from an outsider's point of view. At least it should be possible to make load-from-path use a self-compiled .go file regardless of whether the argument ends in .scm or not.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">If more information is needed, feel free to ask.</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Regards,</p>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Geert</p></body></html>
--nextPart5320587.iDt9Tjd8NJ--

--nextPart1675530.NTyNcRlumu
Content-Disposition: attachment; filename="test.scm"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-scheme; charset="UTF-8"; name="test.scm"

(display "Testfile is read")(newline)

--nextPart1675530.NTyNcRlumu--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Geert Janssens <info@HIDDEN>
Subject: bug#18835: Acknowledgement (load-from-path is inconsistent when
 looking for a compiled version of the source file)
Message-ID: <handler.18835.B.141425821822367.ack <at> debbugs.gnu.org>
References: <2787802.8pnN87I00l@HIDDEN>
X-Gnu-PR-Message: ack 18835
X-Gnu-PR-Package: guile
Reply-To: 18835 <at> debbugs.gnu.org
Date: Sat, 25 Oct 2014 17:31:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guile@HIDDEN

If you wish to submit further information on this problem, please
send it to 18835 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
18835: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18835
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guile@HIDDEN:

Subject: bug#18835: load-from-path is inconsistent when looking for a compiled version of the source file
Resent-From: Andy Wingo <wingo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Wed, 22 Jun 2016 08:30:02 +0000
Resent-Message-ID: <handler.18835.B18835.146658414429151 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Geert Janssens <info@HIDDEN>
Cc: 18835 <at> debbugs.gnu.org
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
 :subject:references:date:in-reply-to:message-id:mime-version
 :content-type; q=dns; s=sasl; b=X1RalOu1UbA/ueXbcbJ3iNPydpa7ATCh
 /tsSA4ZpXHsMPLddUpcB8CR1t+2uh8tKJOyQH594hXviQyGLwpl4MIEczCoa4dWI
 XKpM80uch9FuwNMdCU4kjS0JQIzv1jhEAO3reXILzJaHyKGx6Uw17JMH7u+NILdI
 WZcVfysudz4=
From: Andy Wingo <wingo@HIDDEN>
References: <2787802.8pnN87I00l@HIDDEN>
Date: Wed, 22 Jun 2016 10:28:52 +0200
In-Reply-To: <2787802.8pnN87I00l@HIDDEN> (Geert Janssens's
 message of "Sat, 25 Oct 2014 19:09:09 +0200")
Message-ID: <87twgltynv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sat 25 Oct 2014 19:09, Geert Janssens <info@HIDDEN> writes:

> $ guild compile -o test.scm.go ../test.scm
>
> $ GUILE_LOAD_PATH=$HOME/guile \
>
> GUILE_LOAD_COMPILED_PATH=$HOME/guile/ccache \
>
> guile -c '(load-from-path "test.scm")'
>
> => This command will *not* use either of $HOME/guile/ccache/test.go or
> $HOME/guile/ccache/test.scm.go. Instead it will autocompile test.scm
> into <default-cache-dir>/test.scm.go and use that one.

Weird.  The logic in load.c is that we only add on .go if the file
doesn't already have an extension.  If the file has an extension and
it's not .go, then we don't grovel in the path at all.  I guess this is
the wrong thing?

I am not sure if we can change this in 2.0 or not.  I guess we can.

Andy

Message sent to bug-guile@HIDDEN:

Subject: bug#18835: load-from-path is inconsistent when looking for a compiled version of the source file
References: <2787802.8pnN87I00l@HIDDEN>
In-Reply-To: <2787802.8pnN87I00l@HIDDEN>
Resent-From: Taylan Kammer <taylan.kammer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Mon, 17 May 2021 20:26:02 +0000
Resent-Message-ID: <handler.18835.B18835.16212831619006 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 18835 <at> debbugs.gnu.org, Andy Wingo <wingo@HIDDEN>
From: Taylan Kammer <taylan.kammer@HIDDEN>
Message-ID: <9b5e0494-cbad-1187-f04b-98280b1ce07f@HIDDEN>
Date: Mon, 17 May 2021 22:25:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------D3815E581937F966DBF60D3E"
Content-Language: en-US
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is a multi-part message in MIME format.
--------------D3815E581937F966DBF60D3E
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

In 2016, Andy wrote:

> The logic in load.c is that we only add on .go if the file
> doesn't already have an extension.  If the file has an extension and
> it's not .go, then we don't grovel in the path at all.  I guess this is
> the wrong thing?
> 
> I am not sure if we can change this in 2.0 or not.  I guess we can.

Well that ship has sailed anyway. ;-)

IMO we should change the behavior to always try to add extensions, after
first trying without an extension.

It's feasible that one might choose to name one's files like foo.bar.scm
and the like, in which case trying to load foo.bar should work.  I might
name a number of files foo.v1.scm, foo.v2.scm, and so on.  Alternatively,
consider the already popular foo.upstream.scm.

Further, I don't see any possible confusion arising from adding the
extensions.  No one would name their files foo.go.scm or foo.scm.scm and
then try to load "foo.go" or "foo.scm" and expect the one with an extra
.scm to be loaded.

I thought a bit whether there might be security implications, like when
dropping files into a directory where every user can create files, and
someone could maliciously put a foo.scm.scm to take precedence over your
foo.scm, but that's already a problem as they could drop in a foo.go, so
the solution is not to try to load files from directories you can't trust,
like /tmp.

The only compatibility issue I can think of: maybe some people put both a
file foo and a file foo.scm in the same directory, and expect (load "foo")
to *not* try to load the one without an extension.

Thoughts?


Attached is a patch that would implement the suggestion of trying without
an extension first, then with an extension, without checking whether the
original filename does or doesn't have an extension.

-- 
Taylan

--------------D3815E581937F966DBF60D3E
Content-Type: text/plain; charset=UTF-8;
 name="0001-Make-load-try-to-add-an-extension-to-files-that-alre.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename*0="0001-Make-load-try-to-add-an-extension-to-files-that-alre.pa";
 filename*1="tch"

RnJvbSAyZWQ4MGY4MzEwMDY4MTVlMzczNzRhNzQyMThhZjQ1NzI3MDMyMjlmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUYXlsYW4gS2FtbWVyIDx0YXlsYW4ua2FtbWVyQGdt
YWlsLmNvbT4KRGF0ZTogTW9uLCAxNyBNYXkgMjAyMSAxOTozMTo0MCArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIE1ha2UgbG9hZCB0cnkgdG8gYWRkIGFuIGV4dGVuc2lvbiB0byBmaWxlcyB0
aGF0IGFscmVhZHkgaGF2ZQogb25lLgoKKiBsaWJndWlsZS9sb2FkLmMgKGxvYWRfdGh1bmtf
ZnJvbV9wYXRoLCBzZWFyY2hfcGF0aCk6IFJlbW92ZSB0aGUgY29kZQp0aGF0IGNoZWNrcyB3
aGV0aGVyIHRoZSBmaWxlbmFtZSBhbHJlYWR5IGhhcyBhbiBleHRlbnNpb24uICBBZGQgdGhl
CmVtcHR5IHN0cmluZyB0byB0aGUgaGVhZCBvZiB0aGUgZXh0ZW5zaW9ucyBsaXN0LgotLS0K
IGxpYmd1aWxlL2xvYWQuYyB8IDY3ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYx
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYmd1aWxlL2xvYWQuYyBiL2xpYmd1aWxl
L2xvYWQuYwppbmRleCBlOTVjMzZkYjEuLjBjMTk4ZjE2NSAxMDA2NDQKLS0tIGEvbGliZ3Vp
bGUvbG9hZC5jCisrKyBiL2xpYmd1aWxlL2xvYWQuYwpAQCAtNjQ5LDcgKzY0OSw2IEBAIGxv
YWRfdGh1bmtfZnJvbV9wYXRoIChTQ00gZmlsZW5hbWUsIFNDTSBzb3VyY2VfZmlsZV9uYW1l
LAogICBzdHJ1Y3Qgc3RyaW5nYnVmIGJ1ZjsKICAgc3RydWN0IHN0YXQgc3RhdF9idWY7CiAg
IGNoYXIgKmZpbGVuYW1lX2NoYXJzOwotICBzaXplX3QgZmlsZW5hbWVfbGVuOwogICBTQ00g
cGF0aCwgZXh0ZW5zaW9uczsKICAgU0NNIHJlc3VsdCA9IFNDTV9CT09MX0Y7CiAgIGNoYXIg
aW5pdGlhbF9idWZmZXJbMjU2XTsKQEAgLTY2Nyw3ICs2NjYsNiBAQCBsb2FkX3RodW5rX2Zy
b21fcGF0aCAoU0NNIGZpbGVuYW1lLCBTQ00gc291cmNlX2ZpbGVfbmFtZSwKICAgc2NtX2R5
bndpbmRfYmVnaW4gKDApOwogCiAgIGZpbGVuYW1lX2NoYXJzID0gc2NtX3RvX2xvY2FsZV9z
dHJpbmcgKGZpbGVuYW1lKTsKLSAgZmlsZW5hbWVfbGVuID0gc3RybGVuIChmaWxlbmFtZV9j
aGFycyk7CiAgIHNjbV9keW53aW5kX2ZyZWUgKGZpbGVuYW1lX2NoYXJzKTsKIAogICAvKiBJ
ZiBGSUxFTkFNRSBpcyBhYnNvbHV0ZSBhbmQgaXMgc3RpbGwgdmFsaWQsIHJldHVybiBpdCB1
bmNoYW5nZWQuICAqLwpAQCAtNjgwLDM0ICs2NzgsNiBAQCBsb2FkX3RodW5rX2Zyb21fcGF0
aCAoU0NNIGZpbGVuYW1lLCBTQ00gc291cmNlX2ZpbGVfbmFtZSwKICAgICAgIGdvdG8gZW5k
OwogICAgIH0KIAotICAvKiBJZiBGSUxFTkFNRSBoYXMgYW4gZXh0ZW5zaW9uLCBkb24ndCB0
cnkgdG8gYWRkIEVYVEVOU0lPTlMgdG8gaXQuICAqLwotICB7Ci0gICAgY2hhciAqZW5kcDsK
LQotICAgIGZvciAoZW5kcCA9IGZpbGVuYW1lX2NoYXJzICsgZmlsZW5hbWVfbGVuIC0gMTsK
LQkgZW5kcCA+PSBmaWxlbmFtZV9jaGFyczsKLQkgZW5kcC0tKQotICAgICAgewotCWlmICgq
ZW5kcCA9PSAnLicpCi0JICB7Ci0gICAgICAgICAgICBpZiAoIXN0cmluZ19oYXNfYW5fZXh0
IChmaWxlbmFtZSwgZXh0ZW5zaW9ucykpCi0gICAgICAgICAgICAgIHsKLSAgICAgICAgICAg
ICAgICAvKiBUaGlzIGZpbGVuYW1lIGhhcyBhbiBleHRlbnNpb24sIGJ1dCBub3Qgb25lIG9m
IHRoZSByaWdodAotICAgICAgICAgICAgICAgICAgIG9uZXMuLi4gKi8KLSAgICAgICAgICAg
ICAgICBnb3RvIGVuZDsKLSAgICAgICAgICAgICAgfQotCSAgICAvKiBUaGlzIGZpbGVuYW1l
IGFscmVhZHkgaGFzIGFuIGV4dGVuc2lvbiwgc28gY2FuY2VsIHRoZQotICAgICAgICAgICAg
ICAgbGlzdCBvZiBleHRlbnNpb25zLiAgKi8KLQkgICAgZXh0ZW5zaW9ucyA9IFNDTV9FT0w7
Ci0JICAgIGJyZWFrOwotCSAgfQotCWVsc2UgaWYgKGlzX2ZpbGVfbmFtZV9zZXBhcmF0b3Ig
KFNDTV9NQUtFX0NIQVIgKCplbmRwKSkpCi0JICAvKiBUaGlzIGZpbGVuYW1lIGhhcyBubyBl
eHRlbnNpb24sIHNvIGtlZXAgdGhlIGN1cnJlbnQgbGlzdAotICAgICAgICAgICAgIG9mIGV4
dGVuc2lvbnMuICAqLwotCSAgYnJlYWs7Ci0gICAgICB9Ci0gIH0KLQogICAvKiBUaGlzIHNp
bXBsaWZpZXMgdGhlIGxvb3AgYmVsb3cgYSBiaXQuCiAgICAqLwogICBpZiAoc2NtX2lzX251
bGwgKGV4dGVuc2lvbnMpKQpAQCAtNzM2LDYgKzcwNiw5IEBAIGxvYWRfdGh1bmtfZnJvbV9w
YXRoIChTQ00gZmlsZW5hbWUsIFNDTSBzb3VyY2VfZmlsZV9uYW1lLAogICAgICAgc3RyaW5n
YnVmX2NhdCAoJmJ1ZiwgZmlsZW5hbWVfY2hhcnMpOwogICAgICAgc2Fuc19leHRfbGVuID0g
YnVmLnB0ciAtIGJ1Zi5idWY7CiAKKyAgICAgIC8qIEFkZCB0aGUgZW1wdHkgc3RyaW5nIGFz
IHRoZSBmaXJzdCAiZXh0ZW5zaW9uLiIgKi8KKyAgICAgIGV4dGVuc2lvbnMgPSBzY21fY29u
cyAoc2NtX251bGxzdHIsIGV4dGVuc2lvbnMpOworCiAgICAgICAvKiBUcnkgZXZlcnkgZXh0
ZW5zaW9uLiAqLwogICAgICAgZm9yIChleHRzID0gZXh0ZW5zaW9uczsgc2NtX2lzX3BhaXIg
KGV4dHMpOyBleHRzID0gU0NNX0NEUiAoZXh0cykpCiAJewpAQCAtODA1LDcgKzc3OCw2IEBA
IHNlYXJjaF9wYXRoIChTQ00gcGF0aCwgU0NNIGZpbGVuYW1lLCBTQ00gZXh0ZW5zaW9ucywg
U0NNIHJlcXVpcmVfZXh0cywKIHsKICAgc3RydWN0IHN0cmluZ2J1ZiBidWY7CiAgIGNoYXIg
KmZpbGVuYW1lX2NoYXJzOwotICBzaXplX3QgZmlsZW5hbWVfbGVuOwogICBTQ00gcmVzdWx0
ID0gU0NNX0JPT0xfRjsKICAgY2hhciBpbml0aWFsX2J1ZmZlclsyNTZdOwogCkBAIC04MTks
NyArNzkxLDYgQEAgc2VhcmNoX3BhdGggKFNDTSBwYXRoLCBTQ00gZmlsZW5hbWUsIFNDTSBl
eHRlbnNpb25zLCBTQ00gcmVxdWlyZV9leHRzLAogICBzY21fZHlud2luZF9iZWdpbiAoMCk7
CiAKICAgZmlsZW5hbWVfY2hhcnMgPSBzY21fdG9fbG9jYWxlX3N0cmluZyAoZmlsZW5hbWUp
OwotICBmaWxlbmFtZV9sZW4gPSBzdHJsZW4gKGZpbGVuYW1lX2NoYXJzKTsKICAgc2NtX2R5
bndpbmRfZnJlZSAoZmlsZW5hbWVfY2hhcnMpOwogCiAgIC8qIElmIEZJTEVOQU1FIGlzIGFi
c29sdXRlIGFuZCBpcyBzdGlsbCB2YWxpZCwgcmV0dXJuIGl0IHVuY2hhbmdlZC4gICovCkBA
IC04MzMsMzUgKzgwNCw2IEBAIHNlYXJjaF9wYXRoIChTQ00gcGF0aCwgU0NNIGZpbGVuYW1l
LCBTQ00gZXh0ZW5zaW9ucywgU0NNIHJlcXVpcmVfZXh0cywKICAgICAgIGdvdG8gZW5kOwog
ICAgIH0KIAotICAvKiBJZiBGSUxFTkFNRSBoYXMgYW4gZXh0ZW5zaW9uLCBkb24ndCB0cnkg
dG8gYWRkIEVYVEVOU0lPTlMgdG8gaXQuICAqLwotICB7Ci0gICAgY2hhciAqZW5kcDsKLQot
ICAgIGZvciAoZW5kcCA9IGZpbGVuYW1lX2NoYXJzICsgZmlsZW5hbWVfbGVuIC0gMTsKLQkg
ZW5kcCA+PSBmaWxlbmFtZV9jaGFyczsKLQkgZW5kcC0tKQotICAgICAgewotCWlmICgqZW5k
cCA9PSAnLicpCi0JICB7Ci0gICAgICAgICAgICBpZiAoc2NtX2lzX3RydWUgKHJlcXVpcmVf
ZXh0cykgJiYKLSAgICAgICAgICAgICAgICAhc3RyaW5nX2hhc19hbl9leHQgKGZpbGVuYW1l
LCBleHRlbnNpb25zKSkKLSAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIC8qIFRo
aXMgZmlsZW5hbWUgaGFzIGFuIGV4dGVuc2lvbiwgYnV0IG5vdCBvbmUgb2YgdGhlIHJpZ2h0
Ci0gICAgICAgICAgICAgICAgICAgb25lcy4uLiAqLwotICAgICAgICAgICAgICAgIGdvdG8g
ZW5kOwotICAgICAgICAgICAgICB9Ci0JICAgIC8qIFRoaXMgZmlsZW5hbWUgYWxyZWFkeSBo
YXMgYW4gZXh0ZW5zaW9uLCBzbyBjYW5jZWwgdGhlCi0gICAgICAgICAgICAgICBsaXN0IG9m
IGV4dGVuc2lvbnMuICAqLwotCSAgICBleHRlbnNpb25zID0gU0NNX0VPTDsKLQkgICAgYnJl
YWs7Ci0JICB9Ci0JZWxzZSBpZiAoaXNfZmlsZV9uYW1lX3NlcGFyYXRvciAoU0NNX01BS0Vf
Q0hBUiAoKmVuZHApKSkKLQkgIC8qIFRoaXMgZmlsZW5hbWUgaGFzIG5vIGV4dGVuc2lvbiwg
c28ga2VlcCB0aGUgY3VycmVudCBsaXN0Ci0gICAgICAgICAgICAgb2YgZXh0ZW5zaW9ucy4g
ICovCi0JICBicmVhazsKLSAgICAgIH0KLSAgfQotCiAgIC8qIFRoaXMgc2ltcGxpZmllcyB0
aGUgbG9vcCBiZWxvdyBhIGJpdC4KICAgICovCiAgIGlmIChzY21faXNfbnVsbCAoZXh0ZW5z
aW9ucykpCkBAIC04OTAsNiArODMyLDkgQEAgc2VhcmNoX3BhdGggKFNDTSBwYXRoLCBTQ00g
ZmlsZW5hbWUsIFNDTSBleHRlbnNpb25zLCBTQ00gcmVxdWlyZV9leHRzLAogICAgICAgc3Ry
aW5nYnVmX2NhdCAoJmJ1ZiwgZmlsZW5hbWVfY2hhcnMpOwogICAgICAgc2Fuc19leHRfbGVu
ID0gYnVmLnB0ciAtIGJ1Zi5idWY7CiAKKyAgICAgIC8qIEFkZCB0aGUgZW1wdHkgc3RyaW5n
IGFzIHRoZSBmaXJzdCAiZXh0ZW5zaW9uLiIgKi8KKyAgICAgIGV4dGVuc2lvbnMgPSBzY21f
Y29ucyAoc2NtX251bGxzdHIsIGV4dGVuc2lvbnMpOworCiAgICAgICAvKiBUcnkgZXZlcnkg
ZXh0ZW5zaW9uLiAqLwogICAgICAgZm9yIChleHRzID0gZXh0ZW5zaW9uczsgc2NtX2lzX3Bh
aXIgKGV4dHMpOyBleHRzID0gU0NNX0NEUiAoZXh0cykpCiAJewotLSAKMi4zMC4yCgo=
--------------D3815E581937F966DBF60D3E--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 May 2021 20:26:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 17 16:26:12 2021
Received: from localhost ([127.0.0.1]:53891 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lijoa-0002M0-Aw
	for submit <at> debbugs.gnu.org; Mon, 17 May 2021 16:26:12 -0400
Received: from mail-ej1-f45.google.com ([209.85.218.45]:38471)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <taylan.kammer@HIDDEN>) id 1lijoX-0002Lk-GK
 for control <at> debbugs.gnu.org; Mon, 17 May 2021 16:26:11 -0400
Received: by mail-ej1-f45.google.com with SMTP id b25so11111326eju.5
 for <control <at> debbugs.gnu.org>; Mon, 17 May 2021 13:26:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=to:from:subject:message-id:date:user-agent:mime-version
 :content-language:content-transfer-encoding;
 bh=pTV1ZCYL0cR7gbFDeUhPw2tzRMI+qkkQxtA4db0Qd8M=;
 b=YaA4AeemnehXm2AvvPuGtnLiwpyq/NBe6bx1sCxwlP9MRNnhqJOXyEvwS2f4ZpbxtX
 kt2FyvAkGADYlLo0FEkc23pCie+ipLxothfeXuHpYeZ7xb0wE75G2Vz/EkJW/bsJ4py4
 WtCuGQSCyFBNCkQZ3heTOJMZheiyx8Cy1D1BpaRpDUyMb+LTjmbdqlOOvJO68Vmh2Ph2
 hMm+9FhyyFwBebSt96CDn/S0UitsZ3FQnhq1/0GGn6BaLxSOm3W62BQTd1Rsw+qF4AHZ
 VG7ZNJzW5FbMrr91zsUvm1PAp4IF3kWtSSStIGYAA46mawUqesImsz7dcwhH3YMpW6vJ
 kx+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:to:from:subject:message-id:date:user-agent
 :mime-version:content-language:content-transfer-encoding;
 bh=pTV1ZCYL0cR7gbFDeUhPw2tzRMI+qkkQxtA4db0Qd8M=;
 b=WMNC0KqyJF7rLDbi5xGOXz5g7y1g6ujYryYQbhjydxz+VnaXivCkl4bvUumMzKRmiL
 Wl11w1YThFlViZmq0PGW9I8uvvXtitly/rtXUhlJgn3d2Rty6StxZef1AJgH5Pybqu8Q
 bNsSuNeIaUrxv0mhUI5iBED8dNTT6Y2jmfCQDrF6s5a6JMUh+DzZMLlEdDDFveRyGhV+
 dVy6F89nMiswUjYhUqweeaqe/FgMgiXaBJEOMnTCmdqYro0JZUWgtFXcEiqOGimxVCeL
 mpuxGZlsSJf6MOlvwE9vMuGfsQrHCfjBWEWr9aLjGaWWF+pVUMwZlAWxcLs5IazLIGfp
 Yg+w==
X-Gm-Message-State: AOAM530aXN/RYd+V3MumwRIggc2LdkQvtzdZN7XjlhIdVH6qHlbU4NpC
 c2HLTQTr9maGg85bQ+2xa8LH3I7nQfjn8Q==
X-Google-Smtp-Source: ABdhPJw8nkMywQGMEKXrfikbC6tIjHo3xSiHGdeo54822BOY8KZUivunMLoyD7KbD16JCMRRxa/spQ==
X-Received: by 2002:a17:906:3c56:: with SMTP id
 i22mr1776128ejg.147.1621283163836; 
 Mon, 17 May 2021 13:26:03 -0700 (PDT)
Received: from [192.168.178.20] (b2b-109-90-125-150.unitymedia.biz.
 [109.90.125.150])
 by smtp.gmail.com with ESMTPSA id gb26sm9821422ejc.25.2021.05.17.13.26.03
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 17 May 2021 13:26:03 -0700 (PDT)
To: control <at> debbugs.gnu.org
From: Taylan Kammer <taylan.kammer@HIDDEN>
Subject: 18835 patch
Message-ID: <8bde91bf-1b2a-6185-cf83-45dd902e624d@HIDDEN>
Date: Mon, 17 May 2021 22:26:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 18835 + patch

Last modified: Mon, 17 May 2021 20:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.