GNU bug report logs - #19182
24.4; which-function-mode end of function detection (easy suggestion for improvement)

Previous Next

Package: emacs;

Reported by: Carlos Pita <carlosjosepita <at> gmail.com>

Date: Tue, 25 Nov 2014 18:40:01 UTC

Severity: wishlist

Tags: moreinfo

Found in version 24.4

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19182 in the body.
You can then email your comments to 19182 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#19182; Package emacs. (Tue, 25 Nov 2014 18:40:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Carlos Pita <carlosjosepita <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 25 Nov 2014 18:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Carlos Pita <carlosjosepita <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: alexr <at> msil.sps.mot.com
Subject: 24.4; which-function-mode end of function detection (easy suggestion
 for improvement)
Date: Tue, 25 Nov 2014 15:38:46 -0300
It's a known and documented limitation of which-function mode that it
doesn't detect the end of a function due to it's dependence on
imenu. The following quotes are taken from which-func.el:

;; Really this package shows not "function where the current point is
;; located now", but "nearest function which defined above the current

;;     1. Dependence on imenu package should be removed.  Separate
;; function determination mechanism should be used to determine the end

What do you think about the following strategy which avoids to remove
the dependence on imenu and, instead, leverages imenu and the
end-of-defun functionality already provided by many major modes (in one
way or another)?

1) Detect the beginning of function using imenu, as it's currently done.

2) Detect the end of function using the end-of-defun variant for the
current major mode. The function implementing the corresponding
functionality for the current major mode should be configured explicitly
on a per-mode basis, but an *unsafe* option (disabled by default) could
also be provided to take it automatically from the M-C-e binding.

This is not to say that a separate mechanism would be undesirable but to
improve which-function support for many major modes out of the box in
the short term and in a very easy way.

Cheers
--
Carlos




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19182; Package emacs. (Thu, 12 May 2022 02:05:01 GMT) Full text and rfc822 format available.

Message #8 received at 19182 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Carlos Pita <carlosjosepita <at> gmail.com>
Cc: 19182 <at> debbugs.gnu.org, alexr <at> msil.sps.mot.com
Subject: Re: bug#19182: 24.4; which-function-mode end of function detection
 (easy suggestion for improvement)
Date: Thu, 12 May 2022 04:04:39 +0200
Carlos Pita <carlosjosepita <at> gmail.com> writes:

> It's a known and documented limitation of which-function mode that it
> doesn't detect the end of a function due to it's dependence on
> imenu.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

Do you have a recipe to reproduce this end-function detection failure?
I tried it in a couple of modes and didn't see anything odd.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 12 May 2022 02:05:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19182; Package emacs. (Thu, 09 Jun 2022 14:10:02 GMT) Full text and rfc822 format available.

Message #13 received at 19182 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Carlos Pita <carlosjosepita <at> gmail.com>
Cc: 19182 <at> debbugs.gnu.org, alexr <at> msil.sps.mot.com
Subject: Re: bug#19182: 24.4; which-function-mode end of function detection
 (easy suggestion for improvement)
Date: Thu, 09 Jun 2022 16:09:41 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Do you have a recipe to reproduce this end-function detection failure?
> I tried it in a couple of modes and didn't see anything odd.

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug closed, send any further explanations to 19182 <at> debbugs.gnu.org and Carlos Pita <carlosjosepita <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 09 Jun 2022 14:10:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 08 Jul 2022 11:24:14 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 283 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.