GNU logs - #19614, boring messages

Message sent to bug-automake@HIDDEN:

Subject: bug#19614: make dist exits succesfully even when tar exits with error
Resent-From: Dimitrios Apostolou <jimis@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Fri, 16 Jan 2015 15:02:02 +0000
Resent-Message-ID: <handler.19614.B.142142048423422 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 19614 <at> debbugs.gnu.org
Date: Fri, 16 Jan 2015 16:01:01 +0100 (CET)
From: Dimitrios Apostolou <jimis@HIDDEN>
Message-ID: <alpine.DEB.2.10.1501161550450.5189@localhost>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

(Please keep me CC'd as I'm not subscribed.)

Hello list,

as the title says, I believe running "make dist" should fail when tar 
fails. The problem is that because there is a shell pipeline with gzip, 
the exit code of the pipeline is 0. I'm not aware of a portable way to fix 
this (named pipes maybe?), but most convenient would be bash's "set -o 
pipefail".

Relevant output from "make V=1 dist":

tardir=cfengine-3.7.0a1.5ffcc54 && tar --format=ustar -chf - "$tardir" | GZIP=--best gzip -c >cfengine-3.7.0a1.5ffcc54.tar.gz
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_password_hash_is_not_cached_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_unlock_with_password_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/10_modify_user_with_many_attributes_warn.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_with_hashed_password_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_lock_with_password_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_add_user_with_many_attributes_warn_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_with_password_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/10_newly_created_account_should_not_count_as_locked.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_modify_user_with_many_attributes_hpux_trusted.cf: link name is too long; not dumped
tar: cfengine-3.7.0a1.5ffcc54/tests/acceptance/17_users/unsafe/20_add_user_with_hashed_password_hpux_trusted.cf: link name is too long; not dumped
tar: Exiting with failure status due to previous errors


(A separate bug report will come soon about the "link failure" despite tar 
"-h" option being used.)


Thanks,
Dimitris

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dimitrios Apostolou <jimis@HIDDEN>
Subject: bug#19614: Acknowledgement (make dist exits succesfully even when
 tar exits with error)
Message-ID: <handler.19614.B.142142048423422.ack <at> debbugs.gnu.org>
References: <alpine.DEB.2.10.1501161550450.5189@localhost>
X-Gnu-PR-Message: ack 19614
X-Gnu-PR-Package: automake
Reply-To: 19614 <at> debbugs.gnu.org
Date: Fri, 16 Jan 2015 15:02:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-automake@HIDDEN

If you wish to submit further information on this problem, please
send it to 19614 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
19614: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19614
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-automake@HIDDEN:

Subject: bug#19614: make dist exits succesfully even when tar exits with error
Resent-From: Eric Blake <eblake@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Fri, 16 Jan 2015 16:49:01 +0000
Resent-Message-ID: <handler.19614.B19614.14214268822408 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Dimitrios Apostolou <jimis@HIDDEN>, 19614 <at> debbugs.gnu.org
Message-ID: <54B940B7.80002@HIDDEN>
Date: Fri, 16 Jan 2015 09:47:51 -0700
From: Eric Blake <eblake@HIDDEN>
Organization: Red Hat, Inc.
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
References: <alpine.DEB.2.10.1501161550450.5189@localhost>
In-Reply-To: <alpine.DEB.2.10.1501161550450.5189@localhost>
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/16/2015 08:01 AM, Dimitrios Apostolou wrote:
> (Please keep me CC'd as I'm not subscribed.)

In general, GNU list policy is to reply-to-all, precisely so you don't
have to leave disclaimers like that :)

>=20
> Hello list,
>=20
> as the title says, I believe running "make dist" should fail when tar
> fails. The problem is that because there is a shell pipeline with gzip,=

> the exit code of the pipeline is 0. I'm not aware of a portable way to
> fix this (named pipes maybe?), but most convenient would be bash's "set=

> -o pipefail".

Alas, pipefail is not portable.

>=20
> Relevant output from "make V=3D1 dist":
>=20
> tardir=3Dcfengine-3.7.0a1.5ffcc54 && tar --format=3Dustar -chf - "$tard=
ir" |
> GZIP=3D--best gzip -c >cfengine-3.7.0a1.5ffcc54.tar.gz

It is portable to do something hairy like:

{ tar ...; echo $? > file; } | gzip ...
inspect file

It is even possible to avoid an intermediate file with even hairier exec
operations to shuffle fds around.

It may be simpler to break things into two steps, with an intermediate
file instead of a pipeline, although I'm not sure it would be efficient.

But you definitely make a point that we should fix things to detect tar
failure.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

--BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJUuUC3AAoJEKeha0olJ0NqPTAH/1g0iC2Yb5fJ/omw3RBoeWms
qxiFUzeLSP6Kz4JVCV6e8MpJLcY9od9WnT8Z9fA2GAKnVtaXV3mXTHwO7yxvFHkD
aTTWMdDw+4cE3T88e8V5+0WnYmLODjeHxdwAuPV8Y+bIkG27fiu/u4bl+/Loi2uu
Uw+53X+tNAn7bVuwKORXHvlZBw8eljdoIMBQl/kmlUY2pHcJhaI6nBQtj9lsw7mR
Cify0OTtMuBonLVx1dmonVjfx/4PBV2kSVmXiMXuJI2O+hkB43rDSB0RTOdsN4EU
5EPAnk8yIyTxB6ZaR1V5WOxTdJIMnStCQXeNuy6P8aCtfbKtzvauDcrssmQesXk=
=Tv9E
-----END PGP SIGNATURE-----

--BtX7wL4Wl46EXoHEc2LnaqVjhB6bHHIj3--

Message sent to bug-automake@HIDDEN:

Subject: bug#19614: make dist exits succesfully even when tar exits with error
Resent-From: Dimitrios Apostolou <jimis@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Fri, 16 Jan 2015 17:16:01 +0000
Resent-Message-ID: <handler.19614.B19614.14214285216551 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eric Blake <eblake@HIDDEN>
Cc: 19614 <at> debbugs.gnu.org
Date: Fri, 16 Jan 2015 18:15:08 +0100 (CET)
From: Dimitrios Apostolou <jimis@HIDDEN>
In-Reply-To: <54B940B7.80002@HIDDEN>
Message-ID: <alpine.DEB.2.10.1501161807120.5189@localhost>
References: <alpine.DEB.2.10.1501161550450.5189@localhost>
 <54B940B7.80002@HIDDEN>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Fri, 16 Jan 2015, Eric Blake wrote:
> On 01/16/2015 08:01 AM, Dimitrios Apostolou wrote:
>> Relevant output from "make V=1 dist":
>>
>> tardir=cfengine-3.7.0a1.5ffcc54 && tar --format=ustar -chf - "$tardir" |
>> GZIP=--best gzip -c >cfengine-3.7.0a1.5ffcc54.tar.gz
>
> It is portable to do something hairy like:
>
> { tar ...; echo $? > file; } | gzip ...
> inspect file
>
> It is even possible to avoid an intermediate file with even hairier exec
> operations to shuffle fds around.
>
> It may be simpler to break things into two steps, with an intermediate
> file instead of a pipeline, although I'm not sure it would be efficient.
>
> But you definitely make a point that we should fix things to detect tar
> failure.

What if we just grep stderr for *any* output from any command in the 
pipeline?

{ tar ... | gzip ... ; } 2>&1 1>/dev/null | grep .

Nobody guarantees that it can't fail silently or it can't succeed despite 
output in stderr, but it's pretty rare.


Dimitris

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 8 Feb 2022 03:47:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 07 22:47:21 2022
Received: from localhost ([127.0.0.1]:44571 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nHHTN-0005On-6R
	for submit <at> debbugs.gnu.org; Mon, 07 Feb 2022 22:47:21 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:42894
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1nHHTL-0005Oa-Sz
 for control <at> debbugs.gnu.org; Mon, 07 Feb 2022 22:47:20 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 3F44A342D35; Tue,  8 Feb 2022 03:47:13 +0000 (UTC)
From: Mike Frysinger <vapier@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Control message
Message-Id: <20220208034713.3F44A342D35@HIDDEN>
Date: Tue,  8 Feb 2022 03:47:13 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

tag 19614 = confirmed
thankyou

Last modified: Tue, 8 Feb 2022 04:00:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.