GNU bug report logs - #19847
Print full subdirectory path in "Making ... in ..." messages

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: automake; Severity: wishlist; Reported by: Karl Wette <karl.wette@HIDDEN>; Keywords: patch; dated Thu, 12 Feb 2015 18:54:02 UTC; Maintainer for automake is bug-automake@HIDDEN.
Added tag(s) patch. Request was from Karl Wette <karl.wette@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Severity set to 'wishlist' from 'normal' Request was from Karl Wette <karl.wette@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Feb 2015 18:53:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 12 13:53:16 2015
Received: from localhost ([127.0.0.1]:40987 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YLyt1-0008Ju-B5
	for submit <at> debbugs.gnu.org; Thu, 12 Feb 2015 13:53:16 -0500
Received: from eggs.gnu.org ([208.118.235.92]:35272)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <karl.wette@HIDDEN>) id 1YLyMz-0007Ym-LK
 for submit <at> debbugs.gnu.org; Thu, 12 Feb 2015 13:20:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <karl.wette@HIDDEN>) id 1YLyMq-0007lc-7S
 for submit <at> debbugs.gnu.org; Thu, 12 Feb 2015 13:20:04 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:32792)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <karl.wette@HIDDEN>) id 1YLyMq-0007lX-4C
 for submit <at> debbugs.gnu.org; Thu, 12 Feb 2015 13:20:00 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36969)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <karl.wette@HIDDEN>) id 1YLyMk-0000Rm-0u
 for bug-automake@HIDDEN; Thu, 12 Feb 2015 13:20:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <karl.wette@HIDDEN>) id 1YLyMg-0007jr-QX
 for bug-automake@HIDDEN; Thu, 12 Feb 2015 13:19:53 -0500
Received: from umail.aei.mpg.de ([194.94.224.6]:46129)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <karl.wette@HIDDEN>) id 1YLyMg-0007jA-Hr
 for bug-automake@HIDDEN; Thu, 12 Feb 2015 13:19:50 -0500
Received: from mailgate.aei.mpg.de (mailgate.aei.mpg.de [194.94.224.5])
 by umail.aei.mpg.de (Postfix) with ESMTP id 299822007B5
 for <bug-automake@HIDDEN>; Thu, 12 Feb 2015 19:19:48 +0100 (CET)
Received: from mailgate.aei.mpg.de (localhost [127.0.0.1])
 by localhost (Postfix) with SMTP id 1A97540588B
 for <bug-automake@HIDDEN>; Thu, 12 Feb 2015 19:19:48 +0100 (CET)
Received: from intranet.aei.uni-hannover.de (ahin1.aei.uni-hannover.de
 [130.75.117.40])
 by mailgate.aei.mpg.de (Postfix) with ESMTP id D6F28406AF1
 for <bug-automake@HIDDEN>; Thu, 12 Feb 2015 19:19:47 +0100 (CET)
Received: from mail-wi0-f180.google.com ([209.85.212.180])
 by intranet.aei.uni-hannover.de (Lotus Domino Release 8.5.3FP6HF1016)
 with ESMTP id 2015021219193710-157146 ;
 Thu, 12 Feb 2015 19:19:37 +0100 
Received: by mail-wi0-f180.google.com with SMTP id h11so6520247wiw.1
 for <bug-automake@HIDDEN>; Thu, 12 Feb 2015 10:19:37 -0800 (PST)
X-Received: by 10.180.72.211 with SMTP id f19mr8854610wiv.9.1423765177339;
 Thu, 12 Feb 2015 10:19:37 -0800 (PST)
MIME-Version: 1.0
Received: by 10.217.148.71 with HTTP; Thu, 12 Feb 2015 10:18:57 -0800 (PST)
From: Karl Wette <karl.wette@HIDDEN>
Date: Thu, 12 Feb 2015 19:18:57 +0100
Message-ID: <CA+Rc+17acSLX_f_iJ4M1r7iXajQfLodLjpBPwSSUV0CZxOXCcg@HIDDEN>
Subject: Print full subdirectory path in "Making ... in ..." messages
To: bug-automake@HIDDEN
X-MIMETrack: Itemize by SMTP Server on intranet/aei-hannover(Release
 8.5.3FP6HF1016 | October 31, 2014) at 12.02.2015 19:19:37,
 Serialize by Router on intranet/aei-hannover(Release 8.5.3FP6HF1016 | October
 31, 2014) at 12.02.2015 19:19:47,
 Serialize complete at 12.02.2015 19:19:47
Content-Type: multipart/mixed; boundary=f46d043bdf8ca418da050ee829d1
X-PMX-Version: 6.0.2.2308539, Antispam-Engine: 2.7.2.2107409,
 Antispam-Data: 2015.2.12.180921
X-PerlMx-Spam: Gauge=IIIIIIII, Probability=8%, Report='
 HTML_NO_HTTP 0.1, BODYTEXTH_SIZE_10000_LESS 0, BODYTEXTP_SIZE_3000_LESS 0,
 CTYPE_MULTIPART_NO_QUOTE 0, NO_URI_FOUND 0, WEBMAIL_SOURCE 0, __CT 0,
 __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0,
 __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HIGHBITS 0, __MIME_HTML 0,
 __MIME_VERSION 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __SANE_MSGID 0,
 __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __YOUTUBE_RCVD 0'
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Thu, 12 Feb 2015 13:53:14 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

--f46d043bdf8ca418da050ee829d1
Content-Type: multipart/alternative; boundary=f46d043bdf8ca418d4050ee829cf

--f46d043bdf8ca418d4050ee829cf
Content-Type: text/plain; charset=UTF-8

I would like to suggest a small improvement to the "Making ... in ..."
messages printed by recursive Automake. Instead of printing just the name
of the directory "make" is about to recurse into, I believe that it would
be more informative to print the full path of the directory relative to the
top level of the package.

As an illustration, suppose a package has the following directory structure:

./Makefile.am
./packages/apple/include/Makefile.am
./packages/apple/Makefile.am
./packages/apple/src/Makefile.am
./packages/banana/include/Makefile.am
./packages/banana/Makefile.am
./packages/banana/src/Makefile.am
./packages/carrot/include/Makefile.am
./packages/carrot/Makefile.am
./packages/carrot/src/Makefile.am
./packages/Makefile.am

Currently running "make -s" from the top level would print something like:

Making all in packages
Making all in apple
Making all in include
  CC       something...
Making all in src
  CC       something...
Making all in banana
Making all in include
  CC       something...
Making all in src
  CC       something...
Making all in carrot
Making all in include
  CC       something...
Making all in src
  CC       something...

which make it difficult to see which directory make is currently in. A more
informative output would be something like:

Making all in packages
Making all in packages/apple
Making all in packages/apple/include
  CC       something...
Making all in packages/apple/src
  CC       something...
Making all in packages/banana
Making all in packages/banana/include
  CC       something...
Making all in packages/banana/src
  CC       something...
Making all in packages/carrot
Making all in packages/carrot/include
  CC       something...
Making all in packages/carrot/src
  CC       something...

Of course, one can always run "make" without "-s" to get make's own
"Entering/Leaving directory ..." messages, but this is generally very
verbose. If Automake is going to print out its own recursion-related
messages, it would be useful it they were slightly more informative.

Also, I believe "make" on MacOSX doesn't print "Entering/Leaving directory
..." messages unless they are explicitly enabled with "-w". So this would
make the default output from running "make" on MacOSX a little more
informative.

A proposed patch against git commit 6357a63 in the Automake git repository
is attached.

Cheers, Karl

--f46d043bdf8ca418d4050ee829cf
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

<div dir=3D"ltr"><div>I would like to suggest a small improvement to the &q=
uot;Making ... in ...&quot; messages printed by recursive Automake. Instead=
 of printing just the name of the directory &quot;make&quot; is about to re=
curse into, I believe that it would be more informative to print the full p=
ath of the directory relative to the top level of the package.<br><br></div=
>As an illustration, suppose a package has the following directory structur=
e:<br><div><br>./Makefile.am<br>./packages/apple/include/Makefile.am<br>./p=
ackages/apple/Makefile.am<br>./packages/apple/src/Makefile.am<br>./packages=
/banana/include/Makefile.am<br>./packages/banana/Makefile.am<br>./packages/=
banana/src/Makefile.am<br>./packages/carrot/include/Makefile.am<br>./packag=
es/carrot/Makefile.am<br>./packages/carrot/src/Makefile.am<br>./packages/Ma=
kefile.am<br><br></div><div>Currently running &quot;make -s&quot; from the =
top level would print something like:<br><br>Making all in packages<br>Maki=
ng all in apple<br>Making all in include<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 something...<br>Making all in src<br>=C2=A0 CC=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 something...<br>Making all in banana<br>Making all=
 in include<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something...<b=
r>Making all in src<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 someth=
ing...<br>Making all in carrot<br>Making all in include<br>=C2=A0 CC=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something...<br>Making all in src<br>=C2=A0 =
CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something...<br><br></div><div>which=
 make it difficult to see which directory make is currently in. A more info=
rmative output would be something like:<br><br>Making all in packages<br>Ma=
king all in packages/apple<br>Making all in packages/apple/include<br>=C2=
=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something...<br>Making all in pa=
ckages/apple/src<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something=
...<br>Making all in packages/banana<br>Making all in packages/banana/inclu=
de<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something...<br>Making =
all in packages/banana/src<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 something...<br>Making all in packages/carrot<br>Making all in packages/ca=
rrot/include<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 something...<=
br>Making all in packages/carrot/src<br>=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 something...<br><br></div><div>Of course, one can always run &=
quot;make&quot; without &quot;-s&quot; to get make&#39;s own &quot;Entering=
/Leaving directory ...&quot; messages, but this is generally very verbose. =
If Automake is going to print out its own recursion-related messages, it wo=
uld be useful it they were slightly more informative.<br><br>Also, I believ=
e &quot;make&quot; on MacOSX doesn&#39;t print &quot;Entering/Leaving direc=
tory ...&quot; messages unless they are explicitly enabled with &quot;-w&qu=
ot;. So this would make the default output from running &quot;make&quot; on=
 MacOSX a little more informative.<br><br></div><div>A proposed patch again=
st git commit 6357a63 in the Automake git repository is attached.<br><br></=
div><div>Cheers, Karl<br></div><div><br></div></div>

--f46d043bdf8ca418d4050ee829cf--
--f46d043bdf8ca418da050ee829d1
X-Attachment-Id: f_i62goqfl0
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-Print-full-subdirectory-path-in-Making-.-in-.-messag.patch"
Content-Disposition: attachment; 
	filename="0001-Print-full-subdirectory-path-in-Making-.-in-.-messag.patch"
Content-Transfer-Encoding: quoted-printable

From 5ed1c2fa9c949490e6126f4da31f67ed5e063084 Mon Sep 17 00:00:00 2001
From: Karl Wette <karl.wette@HIDDEN>
Date: Thu, 12 Feb 2015 18:48:29 +0100
Subject: [PATCH] Print full subdirectory path in "Making ... in ..." mess=
ages

---
 lib/am/subdirs.am | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/am/subdirs.am b/lib/am/subdirs.am
index cc00d58..50fe136 100644
--- a/lib/am/subdirs.am
+++ b/lib/am/subdirs.am
@@ -54,8 +54,13 @@ $(am__recursive_targets):
 	  distclean-* | maintainer-clean-*) list=3D'$(DIST_SUBDIRS)' ;; \
 	  *) list=3D'$(SUBDIRS)' ;; \
 	esac; \
+	if test "$(subdir)" =3D "."; then \
+	  thisdir=3D""; \
+	else \
+	  thisdir=3D"$(subdir)/"; \
+	fi; \
 	for subdir in $$list; do \
-	  echo "Making $$target in $$subdir"; \
+	  echo "Making $$target in $$thisdir$$subdir"; \
 	  if test "$$subdir" =3D "."; then \
 	    dot_seen=3Dyes; \
 	    local_target=3D"$$target-am"; \
--=20
1.9.1


--f46d043bdf8ca418da050ee829d1--




Acknowledgement sent to Karl Wette <karl.wette@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-automake@HIDDEN. Full text available.
Report forwarded to bug-automake@HIDDEN:
bug#19847; Package automake. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 20 Feb 2015 16:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.