GNU bug report logs - #19918
25.0.50; links in *Backtrace* & *Help* go to the wrong function definitions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19918 in the body.
You can then email your comments to 19918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; links in *Backtrace* & *Help* go to the wrong function
 definitions
Date: Sat, 21 Feb 2015 16:53:29 -0800 (PST)

In my setup, i.e., with Bookmark+ loaded, function `bookmark-bmenu-list'
is defined in file bookmark+-bmu.el.  In the debugger, there is a line
like this:

 * bookmark-bmenu-list(nil)

with the function name highlighted with a button.  `C-u C-x =' on the
name shows this:

 Here is a `help-function-def' button labeled `bookmark-bmenu-list'.


 There are text properties here:
   button               (t)
   category             help-function-def-button
   help-args            [Show]

Clicking [Show] shows this:

 (bookmark-bmenu-list
   "d:/Emacs-25-2014-10-20/share/emacs/25.0.50/lisp/bookmark.el")

That's wrong.  And clicking mouse-2 on that button takes me to that
wrong file.  And so does `C-h f' followed by the name and clicking on
the library, which is shown as bookmark.el.

The debugger correctly traverses the code of the version of the function
that is defined in bookmark+-bmu.el, however.

IOW, the function is defined correctly.  It is only the links in Help
and the debugger that are wrong, as well as the file name in Help.  But
the doc string in Help is correct - it is the doc string for the
Bookmark+ version of the function.

The redefinition of the function in bookmark+-bmu.el is a
straightforward defun.


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm <at> gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'

Message #8 received at 19918 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 19918 <at> debbugs.gnu.org
Subject: Re: bug#19918: 25.0.50;
 links in *Backtrace* & *Help* go to the wrong function definitions
Date: Sat, 30 Apr 2016 19:09:14 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> In my setup, i.e., with Bookmark+ loaded, function `bookmark-bmenu-list'
> is defined in file bookmark+-bmu.el.  In the debugger, there is a line
> like this:
>
>  * bookmark-bmenu-list(nil)
>
> with the function name highlighted with a button.  `C-u C-x =' on the
> name shows this:
>
>  Here is a `help-function-def' button labeled `bookmark-bmenu-list'.
>
>  There are text properties here:
>    button               (t)
>    category             help-function-def-button
>    help-args            [Show]
>
> Clicking [Show] shows this:
>
>  (bookmark-bmenu-list
>    "d:/Emacs-25-2014-10-20/share/emacs/25.0.50/lisp/bookmark.el")

Do you have a recipe not involving your own code?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 19918 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 19918 <at> debbugs.gnu.org
Subject: RE: bug#19918: 25.0.50; links in *Backtrace* & *Help* go to the wrong
 function definitions
Date: Sat, 30 Apr 2016 10:03:29 -0800 (GMT-08:00)

> Do you have a recipe not involving your own code?

The point is that the help button does not reflect the fact
that the command was redefined.

The redefining code (in bookmark+-bmu.el, at top level) is
simply this:

(defun bookmark-bmenu-list (&optional filteredp msg-p)
  "..."
  (interactive "i\np")
  ...)

The problem is with the button link - it has apparently
hard-coded the address of the original definition of
this command, in standard library bookmark.el.

That's the bug.

Message #14 received at 19918 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 19918 <at> debbugs.gnu.org
Subject: Re: bug#19918: 25.0.50; links in *Backtrace* & *Help* go to the
 wrong function definitions
Date: Sun, 01 Dec 2019 09:18:11 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

>> Do you have a recipe not involving your own code?
>
> The point is that the help button does not reflect the fact
> that the command was redefined.
>
> The redefining code (in bookmark+-bmu.el, at top level) is
> simply this:
>
> (defun bookmark-bmenu-list (&optional filteredp msg-p)
>   "..."
>   (interactive "i\np")
>   ...)
>
> The problem is with the button link - it has apparently
> hard-coded the address of the original definition of
> this command, in standard library bookmark.el.

Could you please give a recipe for how to reproduce this bug using
vanilla Emacs?

Best regards,
Stefan Kangas

Message #19 received at 19918 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 19918 <at> debbugs.gnu.org
Subject: RE: bug#19918: 25.0.50; links in *Backtrace* & *Help* go to the wrong
 function definitions
Date: Sun, 1 Dec 2019 09:44:15 -0800 (PST)

> Could you please give a recipe for how to reproduce
> this bug using vanilla Emacs?

That bug was reported 5 years ago, for Emacs 25.
It seems that it's been fixed, in Emacs 26.3 at
least.  So I guess the bug can be closed.  Thx.

Message #24 received at 19918-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 19918-done <at> debbugs.gnu.org
Subject: Re: bug#19918: 25.0.50; links in *Backtrace* & *Help* go to the
 wrong function definitions
Date: Sun, 01 Dec 2019 22:57:30 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

>> Could you please give a recipe for how to reproduce
>> this bug using vanilla Emacs?
>
> That bug was reported 5 years ago, for Emacs 25.
> It seems that it's been fixed, in Emacs 26.3 at
> least.  So I guess the bug can be closed.  Thx.

Thanks for that, and I'm therefore closing this bug.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.