GNU logs - #19961, boring messages

Message sent to bug-automake@HIDDEN:

Subject: bug#19961: check-local is kind of like check-hook
Resent-From: Shahbaz Youssefi <shabbyx@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Fri, 27 Feb 2015 16:59:02 +0000
Resent-Message-ID: <handler.19961.B.142505629328364 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 19961 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Fri, 27 Feb 2015 17:07:27 +0100
Message-ID: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
From: Shahbaz Youssefi <shabbyx@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

The -local and -hook targets are generally used like this:

X: X-local
    # stuff to do X
    $(MAKE) X-hook

That is, X-local is run first, then the automake generated rules do X
and then X-hook is called.

With check-local, the generated Makefile.in looks like this:

check-am: all-am
    $(MAKE) $(AM_MAKEFLAGS) check-TESTS check-local

Now as far as the documentation is concerned, this is valid:

> With the -local targets, there is no particular guarantee of execution order; typically, they are run early, but with parallel make, there is no way to be sure of that.

However, even with not-parallel make, check-local executes after the tests.

To align this with the other -local rules, why not generate it like this?

check-am: all-am check-local
    $(MAKE) $(AM_MAKEFLAGS) check-TESTS

The reason I actually have a problem with the current method is that
it is impossible to perform an action before the check. In my
particular case, my test scripts use test kernel modules. Of course,
automake doesn't have a target like check_KERNELMODULE for example to
automatically build the kernel module before running the tests. So
ideally what I could do is to build the kernel module in check-local.
The way the Makefile.in's are currently generated, this is impossible.

In my case, I had to use all-local to build the test kernel modules,
even if the user is not interested in make check, which is annoying in
the least.

Good day,
Shahbaz

---

P.S. I think it's all very clear, but just for good measure, here is an example:

=================================

configure.ac:

AC_PREREQ([2.68])
AC_INIT([Demo], [0.0], [demo])
AC_CONFIG_AUX_DIR([bin])
AC_CONFIG_MACRO_DIR([m4])

AM_INIT_AUTOMAKE([1.14 -Wall -Werror foreign])

AC_CONFIG_FILES([Makefile])
AC_OUTPUT

=================================

Makefile.am:

ACLOCAL_AMFLAGS = -I m4

check_SCRIPT = test_script

TESTS = $(check_SCRIPT)

check-local:
    @echo "*******************************************"
    @echo "*******************************************"
    @echo "I wanted this to be called before the check"
    @echo "*******************************************"
    @echo "*******************************************"

=================================

test_script:

#! /bin/bash

echo "Running test script"

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Shahbaz Youssefi <shabbyx@HIDDEN>
Subject: bug#19961: Acknowledgement (check-local is kind of like check-hook)
Message-ID: <handler.19961.B.142505629328364.ack <at> debbugs.gnu.org>
References: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
X-Gnu-PR-Message: ack 19961
X-Gnu-PR-Package: automake
Reply-To: 19961 <at> debbugs.gnu.org
Date: Fri, 27 Feb 2015 16:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-automake@HIDDEN

If you wish to submit further information on this problem, please
send it to 19961 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
19961: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D19961
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-automake@HIDDEN:

Subject: bug#19961: check-local is kind of like check-hook
Resent-From: Peter Johansson <trojkan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Sun, 01 Mar 2015 23:19:01 +0000
Resent-Message-ID: <handler.19961.B19961.142525191915170 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Shahbaz Youssefi <shabbyx@HIDDEN>
Cc: 19961 <at> debbugs.gnu.org
Message-ID: <54F39E41.4020504@HIDDEN>
Date: Mon, 02 Mar 2015 09:18:25 +1000
From: Peter Johansson <trojkan@HIDDEN>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.8.0
MIME-Version: 1.0
References: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
In-Reply-To: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 02/28/2015 02:07 AM, Shahbaz Youssefi wrote:
> Hi,
>
> The -local and -hook targets are generally used like this:
>
> X: X-local
>      # stuff to do X
>      $(MAKE) X-hook
>
> That is, X-local is run first, then the automake generated rules do X
> and then X-hook is called.
>
> With check-local, the generated Makefile.in looks like this:
>
> check-am: all-am
>      $(MAKE) $(AM_MAKEFLAGS) check-TESTS check-local
>
> Now as far as the documentation is concerned, this is valid:
>
>> With the -local targets, there is no particular guarantee of execution order; typically, they are run early, but with parallel make, there is no way to be sure of that.
> However, even with not-parallel make, check-local executes after the tests.
>
> To align this with the other -local rules, why not generate it like this?
>
> check-am: all-am check-local
>      $(MAKE) $(AM_MAKEFLAGS) check-TESTS

I think it would be a mistake to change this rule. Some projects might 
rely on the fact that 'check-local' depends on 'all-am' and 
'check-local' might e.g. run some of the programs built within 'all-am'.


>
> The reason I actually have a problem with the current method is that
> it is impossible to perform an action before the check. In my
> particular case, my test scripts use test kernel modules. Of course,
> automake doesn't have a target like check_KERNELMODULE for example to
> automatically build the kernel module before running the tests. So
> ideally what I could do is to build the kernel module in check-local.
> The way the Makefile.in's are currently generated, this is impossible.
>
> In my case, I had to use all-local to build the test kernel modules,
> even if the user is not interested in make check, which is annoying in
> the least.

With my Automake the rule looks like:

check-am: all-am
     $(MAKE) $(AM_MAKEFLAGS) $(check_SCRIPTS) $(check_DATA)
     $(MAKE) $(AM_MAKEFLAGS) check-TESTS check-local

so you could move your check_kernelmodule into check_DATA with something 
like (untested)

check_DATA = kernelmodule.timestamp

kernelmodule.timestamp:
     @echo "*******************************************"
     @echo "*******************************************"
     @echo "I want this to be called before the check"
     @echo "*******************************************"
     @echo "*******************************************"





Cheers,
Peter

-- 
Peter Johansson

Message sent to bug-automake@HIDDEN:

Subject: bug#19961: check-local is kind of like check-hook
Resent-From: Shahbaz Youssefi <shabbyx@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Mon, 02 Mar 2015 12:18:01 +0000
Resent-Message-ID: <handler.19961.B19961.142529864127779 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Peter Johansson <trojkan@HIDDEN>
Cc: 19961 <at> debbugs.gnu.org
MIME-Version: 1.0
In-Reply-To: <54F39E41.4020504@HIDDEN>
References: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
 <54F39E41.4020504@HIDDEN>
Date: Mon, 2 Mar 2015 13:17:12 +0100
Message-ID: <CALeOzZ9M2tyG-sK69gM4MUW6mSxyAUuJqACLHjaXoz1=Gfg3eA@HIDDEN>
From: Shahbaz Youssefi <shabbyx@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Mon, Mar 2, 2015 at 12:18 AM, Peter Johansson <trojkan@HIDDEN> wrote:
> On 02/28/2015 02:07 AM, Shahbaz Youssefi wrote:
>>
>> To align this with the other -local rules, why not generate it like this?
>>
>> check-am: all-am check-local
>>      $(MAKE) $(AM_MAKEFLAGS) check-TESTS
>
> I think it would be a mistake to change this rule. Some projects might rely
> on the fact that 'check-local' depends on 'all-am' and 'check-local' might
> e.g. run some of the programs built within 'all-am'.
>

Fair enough. Wouldn't something like this address that issue?

check-local: all-am

check-am: check-local
     $(MAKE) $(AM_MAKEFLAGS) check-TESTS

>
> With my Automake the rule looks like:
>
> check-am: all-am
>     $(MAKE) $(AM_MAKEFLAGS) $(check_SCRIPTS) $(check_DATA)
>     $(MAKE) $(AM_MAKEFLAGS) check-TESTS check-local
>
> so you could move your check_kernelmodule into check_DATA with something
> like (untested)
>
> check_DATA = kernelmodule.timestamp
>
> kernelmodule.timestamp:
>     @echo "*******************************************"
>     @echo "*******************************************"
>     @echo "I want this to be called before the check"
>     @echo "*******************************************"
>     @echo "*******************************************"
>

Ok, I haven't seen check_DATA before (is that new in Automake 1.15?).
This could be a solution of course, although a bit strange, since the
kernel module is not really "data".

I do have a related suggestion nevertheless. You see, no matter how
many scenarios you think about, there is always some use-case that's
going to be desired by someone but is unforeseen. Why not just create
a general rule? My suggestion is to have for each target X, the
following two targets:

- X-pre is guaranteed to run before X
- X-post is guaranteed to run after X

This way, regardless of the target, anyone with whatever strange,
foreseen or unforeseen scenario, can use these two to extend the
operation of the target.

Kampai,
Shahbaz

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#19961: [PATCH 1/2] automake: support check-hook target
References: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
In-Reply-To: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
Resent-From: Mike Frysinger <vapier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Mon, 21 Feb 2022 03:37:02 +0000
Resent-Message-ID: <handler.19961.B19961.164541460515730 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 19961
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: 
To: 19961 <at> debbugs.gnu.org
Received: via spool by 19961-submit <at> debbugs.gnu.org id=B19961.164541460515730
          (code B ref 19961); Mon, 21 Feb 2022 03:37:02 +0000
Received: (at 19961) by debbugs.gnu.org; 21 Feb 2022 03:36:45 +0000
Received: from localhost ([127.0.0.1]:34372 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nLzVF-00045e-7o
	for submit <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:36:45 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:33520
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1nLzVC-00045G-Sl
 for 19961 <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:36:43 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id A6E223436CD; Mon, 21 Feb 2022 03:36:36 +0000 (UTC)
From: Mike Frysinger <vapier@HIDDEN>
Date: Sun, 20 Feb 2022 22:36:31 -0500
Message-Id: <20220221033632.2672-1-vapier@HIDDEN>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

Related to automake bug https://bugs.gnu.org/19961.

Add hook support for the check target as requested by Shahbaz Youssefi.

* NEWS: Mention new check-hook.
* bin/automake.in: Run check-hook if defined.
* doc/automake.texi: Document new check-hook.
---
 NEWS              | 2 ++
 bin/automake.in   | 2 ++
 doc/automake.texi | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 665d8329d667..183825e8f2ed 100644
--- a/NEWS
+++ b/NEWS
@@ -29,6 +29,8 @@ New in 1.17:
   - Variables using escaped \# will trigger portability warnings, but be
     retained when appended.  GNU Make & BSD Makes are known to support it.
 
+  - The check target now supports user defined check-hook.
+
 * Obsolescent features:
 
   - py-compile no longer supports Python 0.x or 1.x versions.  Python 2.0,
diff --git a/bin/automake.in b/bin/automake.in
index 6d55884023cd..1a47865474f9 100644
--- a/bin/automake.in
+++ b/bin/automake.in
@@ -4670,6 +4670,8 @@ sub do_check_merge_target ()
   # Include user-defined local form of target.
   push @check_tests, 'check-local'
     if user_phony_rule 'check-local';
+  push @check_tests, 'check-hook'
+    if user_phony_rule 'check-hook';
 
   # The check target must depend on the local equivalent of
   # 'all', to ensure all the primary targets are built.  Then it
diff --git a/doc/automake.texi b/doc/automake.texi
index b6a38dc27ce5..b13f96809ce3 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -11609,7 +11609,7 @@ In contrast, some rules also have a way to run another rule, called a
 @dfn{hook}; hooks are always executed after the main rule's work is done.
 The hook is named after the principal target, with @samp{-hook} appended.
 The targets allowing hooks are @code{install-data},
-@code{install-exec}, @code{uninstall}, @code{dist}, and
+@code{install-exec}, @code{uninstall}, @code{check}, @code{dist}, and
 @code{distcheck}.
 
 For instance, here is how to create a hard link to an installed program:
-- 
2.34.1

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#19961: [PATCH 2/2] automake: allow check-local to run early
Resent-From: Mike Frysinger <vapier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Mon, 21 Feb 2022 03:37:02 +0000
Resent-Message-ID: <handler.19961.B19961.164541460815742 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 19961
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: 
To: 19961 <at> debbugs.gnu.org
Received: via spool by 19961-submit <at> debbugs.gnu.org id=B19961.164541460815742
          (code B ref 19961); Mon, 21 Feb 2022 03:37:02 +0000
Received: (at 19961) by debbugs.gnu.org; 21 Feb 2022 03:36:48 +0000
Received: from localhost ([127.0.0.1]:34374 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nLzVI-00045q-Gm
	for submit <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:36:48 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:33526
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1nLzVE-00045J-GF
 for 19961 <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:36:44 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id CC0203436EA; Mon, 21 Feb 2022 03:36:38 +0000 (UTC)
From: Mike Frysinger <vapier@HIDDEN>
Date: Sun, 20 Feb 2022 22:36:32 -0500
Message-Id: <20220221033632.2672-2-vapier@HIDDEN>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220221033632.2672-1-vapier@HIDDEN>
References: <20220221033632.2672-1-vapier@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

Fixes automake bug https://bugs.gnu.org/19961.

* NEWS: Note that check-local may run earlier that before.
* bin/automake.in: Allow check-local to run before check-am instead
of after like check-hook does.
---
 NEWS            | 5 +++++
 bin/automake.in | 7 +++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/NEWS b/NEWS
index 183825e8f2ed..a4f3d6063073 100644
--- a/NEWS
+++ b/NEWS
@@ -31,6 +31,11 @@ New in 1.17:
 
   - The check target now supports user defined check-hook.
 
+* Miscellaneous changes
+
+  - The user defined check-local target may now run earlier in the check
+    process.  Users who want to always run at the end should use check-hook.
+
 * Obsolescent features:
 
   - py-compile no longer supports Python 0.x or 1.x versions.  Python 2.0,
diff --git a/bin/automake.in b/bin/automake.in
index 1a47865474f9..5a151455019e 100644
--- a/bin/automake.in
+++ b/bin/automake.in
@@ -4668,7 +4668,7 @@ sub handle_user_recursion ()
 sub do_check_merge_target ()
 {
   # Include user-defined local form of target.
-  push @check_tests, 'check-local'
+  $output_rules .= "check-local: all-am\n"
     if user_phony_rule 'check-local';
   push @check_tests, 'check-hook'
     if user_phony_rule 'check-hook';
@@ -4676,7 +4676,10 @@ sub do_check_merge_target ()
   # The check target must depend on the local equivalent of
   # 'all', to ensure all the primary targets are built.  Then it
   # must build the local check rules.
-  $output_rules .= "check-am: all-am\n";
+  $output_rules .= "check-am: all-am";
+  $output_rules .= " check-local"
+    if user_phony_rule 'check-local';
+  $output_rules .= "\n";
   if (@check)
     {
       pretty_print_rule ("\t\$(MAKE) \$(AM_MAKEFLAGS)", "\t  ", @check);
-- 
2.34.1

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Feb 2022 03:53:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 20 22:53:31 2022
Received: from localhost ([127.0.0.1]:34391 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nLzlP-0006la-4j
	for submit <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:53:31 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:37792
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1nLzlO-0006lL-3D
 for control <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:53:26 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 218143433AA; Mon, 21 Feb 2022 03:53:20 +0000 (UTC)
From: Mike Frysinger <vapier@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Control message
Message-Id: <20220221035320.218143433AA@HIDDEN>
Date: Mon, 21 Feb 2022 03:53:20 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

clone 19961 -1
retitle -1 support X-pre & X-post like X-local & X-hook
severity -1 wishlist
tag -1 = confirmed
thankyou

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#19961: check-local is kind of like check-hook
Resent-From: Mike Frysinger <vapier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Mon, 21 Feb 2022 04:00:02 +0000
Resent-Message-ID: <handler.19961.B19961.164541599226709 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 19961
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: 
To: Shahbaz Youssefi <shabbyx@HIDDEN>
Cc: Peter Johansson <trojkan@HIDDEN>, 19961 <at> debbugs.gnu.org
Received: via spool by 19961-submit <at> debbugs.gnu.org id=B19961.164541599226709
          (code B ref 19961); Mon, 21 Feb 2022 04:00:02 +0000
Received: (at 19961) by debbugs.gnu.org; 21 Feb 2022 03:59:52 +0000
Received: from localhost ([127.0.0.1]:34406 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nLzrb-0006wj-JC
	for submit <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:59:51 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:39044
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1nLzra-0006wX-Hm
 for 19961 <at> debbugs.gnu.org; Sun, 20 Feb 2022 22:59:50 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id B4DF23433AA; Mon, 21 Feb 2022 03:59:44 +0000 (UTC)
Date: Sun, 20 Feb 2022 22:59:44 -0500
From: Mike Frysinger <vapier@HIDDEN>
Message-ID: <YhMOMPG81ZaYTebL@vapier>
Mail-Followup-To: Shahbaz Youssefi <shabbyx@HIDDEN>,
 Peter Johansson <trojkan@HIDDEN>, 19961 <at> debbugs.gnu.org
References: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
 <54F39E41.4020504@HIDDEN>
 <CALeOzZ9M2tyG-sK69gM4MUW6mSxyAUuJqACLHjaXoz1=Gfg3eA@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="AdJnJk/utEX00Cs4"
Content-Disposition: inline
In-Reply-To: <CALeOzZ9M2tyG-sK69gM4MUW6mSxyAUuJqACLHjaXoz1=Gfg3eA@HIDDEN>
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)


--AdJnJk/utEX00Cs4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 02 Mar 2015 13:17, Shahbaz Youssefi wrote:
> On Mon, Mar 2, 2015 at 12:18 AM, Peter Johansson wrote:
> > On 02/28/2015 02:07 AM, Shahbaz Youssefi wrote:
> >>
> >> To align this with the other -local rules, why not generate it like th=
is?
> >>
> >> check-am: all-am check-local
> >>      $(MAKE) $(AM_MAKEFLAGS) check-TESTS
> >
> > I think it would be a mistake to change this rule. Some projects might =
rely
> > on the fact that 'check-local' depends on 'all-am' and 'check-local' mi=
ght
> > e.g. run some of the programs built within 'all-am'.
>=20
> Fair enough. Wouldn't something like this address that issue?
>=20
> check-local: all-am
>=20
> check-am: check-local
>      $(MAKE) $(AM_MAKEFLAGS) check-TESTS

should be doable to add check-hook (to support people who want to run at the
end) and to add check-local (to support people who want to run early).

although i think the right answer for you specifically is what Peter already
suggested -- use an existing check_XXX primary instead.

> > With my Automake the rule looks like:
> >
> > check-am: all-am
> >     $(MAKE) $(AM_MAKEFLAGS) $(check_SCRIPTS) $(check_DATA)
> >     $(MAKE) $(AM_MAKEFLAGS) check-TESTS check-local
> >
> > so you could move your check_kernelmodule into check_DATA with something
> > like (untested)
> >
> > check_DATA =3D kernelmodule.timestamp
> >
> > kernelmodule.timestamp:
> >     @echo "*******************************************"
> >     @echo "*******************************************"
> >     @echo "I want this to be called before the check"
> >     @echo "*******************************************"
> >     @echo "*******************************************"
> >
>=20
> Ok, I haven't seen check_DATA before (is that new in Automake 1.15?).

no, it's been around for a very long time -- at least since Automake 1.5
=66rom Aug 2001.  i didn't dive deeper in the source beyond that.

> This could be a solution of course, although a bit strange, since the
> kernel module is not really "data".

sure, but out of all the primaries Automake understands, what would you call
it ?  a program ?  a script ?  a library ?  from userspace pov, it might as
well just be "data".  i don't think adding support for LINUXKERNELMODULE ma=
kes
that much sense since it's not portable (beyond Linux), no one has asked for
it, and the way a kernel module is built is veeeery tightly coupled with the
exact version of Linux that you're building.
-mike

--AdJnJk/utEX00Cs4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmITDjAACgkQQWM7n+g3
9YFNMQ//S+1qFfmjaJgtpRcO5JElse7YDLNFxBSyHPC+kDH4++dob3GOkP/P2/Q6
vHFB860il1i3CVBNWuathBHjOxMnTFBB1+uNYfec9hJ/8CjtJk9I9BaRIfVQj+l8
T8bx3qiy6NUFZDZH0FPdH8k9cKZewu8xITVd0MXnuYhFJwS0jHopx2orG7MCQ0k2
ElGkLGh55I0uezkcdWiAyHzwFN8UDe7afnXdBOpEJN+qxi83mig4mWe6HFFCND0V
A52wes9yMB7+HceNfS29m7g31oJhvjGLW+VToEz68bzFlJdfn785Q0E7xKe542bq
XkKF5+nncK30xXijodBg3hx/qSfsoR6VxiF+DaaszKWsf4RptwW7BZcgI8wkaUkS
iH67wBvdLmbVcFKp08DDrD27WDAqjLmb/1JBdSZ7sKtyeLkM7Cy/kZCFILimnyT9
IMRkNcCaf1o1g1ePl78DcqBOOHTe2FYX0AGgQ2KH+pYqEU87jlFRahJL6ICbcqUS
4JjkM4Htak0MOiK+s5otIYbNn539Kw4vs5PijyfjZN7G5aifgNgg+6N4/aU6d5h1
mJYIICYDOpz5vlQaVXJK0vJPoAaEh7uKu33yQmth/ggvrExXug5E5Fdq+nPi87+T
TQGrONfHmKhdDnVdF/9vzcJplBpHwip7XjV6/mN7WDPLwua6uTs=
=/6eH
-----END PGP SIGNATURE-----

--AdJnJk/utEX00Cs4--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Feb 2022 04:43:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 20 23:43:46 2022
Received: from localhost ([127.0.0.1]:34519 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nM0Y6-0004AE-1V
	for submit <at> debbugs.gnu.org; Sun, 20 Feb 2022 23:43:46 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:48604
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1nM0Y4-00049y-9y
 for control <at> debbugs.gnu.org; Sun, 20 Feb 2022 23:43:44 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 9FC8E34373D; Mon, 21 Feb 2022 04:43:38 +0000 (UTC)
From: Mike Frysinger <vapier@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Control message
Message-Id: <20220221044338.9FC8E34373D@HIDDEN>
Date: Mon, 21 Feb 2022 04:43:38 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

tag 19961 = confirmed
thankyou

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#19961: check-local is kind of like check-hook
References: <CALeOzZ_mc6PP5YiRYJzC_J=YdsbSsz+rEWE6LfTxkEW7dJgSwA@HIDDEN>
Resent-From: Karl Berry <karl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Thu, 24 Feb 2022 02:39:02 +0000
Resent-Message-ID: <handler.19961.B19961.164567033332225 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 19961
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: confirmed
To: vapier@HIDDEN, 19961 <at> debbugs.gnu.org
Received: via spool by 19961-submit <at> debbugs.gnu.org id=B19961.164567033332225
          (code B ref 19961); Thu, 24 Feb 2022 02:39:02 +0000
Received: (at 19961) by debbugs.gnu.org; 24 Feb 2022 02:38:53 +0000
Received: from localhost ([127.0.0.1]:46952 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nN41s-0008Nh-Pw
	for submit <at> debbugs.gnu.org; Wed, 23 Feb 2022 21:38:52 -0500
Received: from freefriends.org ([96.88.95.60]:51586)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <karl@HIDDEN>) id 1nN41r-0008Na-Oj
 for 19961 <at> debbugs.gnu.org; Wed, 23 Feb 2022 21:38:52 -0500
X-Envelope-From: karl@HIDDEN
Received: from freefriends.org (freefriends.org [96.88.95.60])
 by freefriends.org (8.14.7/8.14.7) with ESMTP id 21O2cob7021030
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Wed, 23 Feb 2022 19:38:51 -0700
Received: (from apache@localhost)
 by freefriends.org (8.14.7/8.14.7/Submit) id 21O2cnF0021029;
 Wed, 23 Feb 2022 19:38:49 -0700
Date: Wed, 23 Feb 2022 19:38:49 -0700
Message-Id: <202202240238.21O2cnF0021029@HIDDEN>
From: Karl Berry <karl@HIDDEN>
In-Reply-To: <YhMOMPG81ZaYTebL@vapier>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

I think it would be a mistake to change where check-local runs,
in any way. In Peter's message, it is running after any $(check_DATA).
It does not seem that is still the case after your patch, Mike?
(As usual, I didn't actually try it. Sorry.)

Although it would be nice if there were perfect consistency from the
beginning about the names and timing of -hook and -local, I strongly
believe that trying to retrofit consistency is not worth creating
incompatibilities. Not at all.

To address the original request for something that runs before check-am,
I would instead suggesting creating a new check-pre instead of changing
check-local.

However, since the original case can be addressed otherwise, and there
are no other bug reports that require this (are there?), my actual
suggestion is to do nothing.

Except possibly to sharpen the rather annoyingly vague statement in the
manual about timing that was already quoted:

  With the `-local' targets, there is no particular guarantee of
  execution order; typically, they are run early, but with parallel
  make, there is no way to be sure of that.

which gives the user essentially zero information. Maybe it has to be
that way, but if, apart from check-local, the OP's description of
Automake's output as being

X: X-local

is correct, then we could at least say that "X-local" runs before "X",
except for "check-local". That does not change with parallel makes.

I admit the whole behavior of -local and -hook is rather unclear in my mind.

As for changing the names of -local and -hook: I agree -pre and -post
would have been better, but given the long history, I do not think it
would be good to change the names, or support alternative/preferred
names, just for the sake of names. That just seems like creating
unnecessary confusion. --best, karl.

Last modified: Thu, 24 Feb 2022 02:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.