GNU bug report logs - #19965
24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined

Previous Next

Package: emacs;

Reported by: Stefan Reichör <stefan <at> xsteve.at>

Date: Fri, 27 Feb 2015 22:35:01 UTC

Severity: minor

Tags: fixed, moreinfo

Found in version 24.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 19965 in the body.
You can then email your comments to 19965 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#19965; Package emacs. (Fri, 27 Feb 2015 22:35:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Reichör <stefan <at> xsteve.at>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 27 Feb 2015 22:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; diary-face-attrs and appt-warning-time-regexp cannot be combined
Date: Fri, 27 Feb 2015 23:34:14 +0100
Hi Emacs Team,

I use two features of the diary:

a) The appointment warntime

,----
| 27/02/2015 23:45 Test ## warntime 30
`----

That way I can override the warntime for an entry


b) special text properties for the calendar view

,----
| 27/02/2015 23:45 Test [background:yellow]
`----


Now I want to combine both features.

I tried the following two variants, but they don't work:

,----
| 27/02/2015 23:45 Test ## warntime 30 [background:yellow]
`----

,----
| 27/02/2015 23:45 Test [background:yellow] ## warntime 30
`----


It would be really great to have a way to specify both features!

Thanks,
  Stefan.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19965; Package emacs. (Mon, 28 Dec 2020 01:28:01 GMT) Full text and rfc822 format available.

Message #8 received at 19965 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 19965 <at> debbugs.gnu.org
Subject: Re: bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp
 cannot be combined
Date: Mon, 28 Dec 2020 02:27:18 +0100
Stefan Reichör <stefan <at> xsteve.at> writes:

> I use two features of the diary:
>
> a) The appointment warntime
>
> ,----
> | 27/02/2015 23:45 Test ## warntime 30
> `----
>
> That way I can override the warntime for an entry
>
> b) special text properties for the calendar view
>
> ,----
> | 27/02/2015 23:45 Test [background:yellow]
> `----
>
> Now I want to combine both features.
>
> I tried the following two variants, but they don't work:
>
> ,----
> | 27/02/2015 23:45 Test ## warntime 30 [background:yellow]

(I'm going through old bug reports that unfortunately got no response at
the time.)

So you have a test case, starting from "emacs -Q", to reproduce this
bug?  That'll be helpful when trying to fix this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 28 Dec 2020 01:28:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19965; Package emacs. (Mon, 28 Dec 2020 14:35:02 GMT) Full text and rfc822 format available.

Message #13 received at 19965 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 19965 <at> debbugs.gnu.org
Subject: Re: bug#19965: 24.3;
 diary-face-attrs and appt-warning-time-regexp cannot be combined
Date: Mon, 28 Dec 2020 15:34:41 +0100
Hi Lars!

Thanks a lot for going through old bugs.

This way you can reproduce the problem using "emacs -Q":

;; Content of ~/diary-test (adjust date + time to be a few minutes in the future):
12/28/2020 15:40 Test reminder, warntime used ## warntime 32
12/28/2020 15:41 Test reminder, colored [background:red]
12/28/2020 15:42 Test reminder combined1, not colored [background:red] ## warntime 34
12/28/2020 15:43 Test reminder combined2, not colored ## warntime 36 [background:red] 
01/01/2021 New year [background:yellow]



(setq diary-file "~/diary-test")

(add-hook 'diary-display-hook 'fancy-diary-display)
(add-hook 'calendar-initial-window-hook 'diary-mark-entries)

(require 'appt)
(calendar)

;; force checking of appointments
(appt-check t)

;; appt-time-msg-list should contain the new appointment
(describe-variable 'appt-time-msg-list)


Stefan.


> Stefan Reichör <stefan <at> xsteve.at> writes:
>
>> I use two features of the diary:
>>
>> a) The appointment warntime
>>
>> ,----
>> | 27/02/2015 23:45 Test ## warntime 30
>> `----
>>
>> That way I can override the warntime for an entry
>>
>> b) special text properties for the calendar view
>>
>> ,----
>> | 27/02/2015 23:45 Test [background:yellow]
>> `----
>>
>> Now I want to combine both features.
>>
>> I tried the following two variants, but they don't work:
>>
>> ,----
>> | 27/02/2015 23:45 Test ## warntime 30 [background:yellow]
>
> (I'm going through old bug reports that unfortunately got no response at
> the time.)
>
> So you have a test case, starting from "emacs -Q", to reproduce this
> bug?  That'll be helpful when trying to fix this.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19965; Package emacs. (Tue, 29 Dec 2020 01:05:02 GMT) Full text and rfc822 format available.

Message #16 received at 19965 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 19965 <at> debbugs.gnu.org
Subject: Re: bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp
 cannot be combined
Date: Tue, 29 Dec 2020 02:04:31 +0100
Stefan Reichör <stefan <at> xsteve.at> writes:

> This way you can reproduce the problem using "emacs -Q":

Thanks for the very clear bug reproduction case.  It seems like the
diary code just assumed that the face attrs were at the end of the lines
(and weren't combined with comments), and just removing that limitation
seems to fix the test case.  Fix pushed to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 29 Dec 2020 01:06:01 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 19965 <at> debbugs.gnu.org and Stefan Reichör <stefan <at> xsteve.at> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 29 Dec 2020 01:06:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19965; Package emacs. (Tue, 29 Dec 2020 18:26:02 GMT) Full text and rfc822 format available.

Message #23 received at 19965 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 19965 <at> debbugs.gnu.org
Subject: Re: bug#19965: 24.3;
 diary-face-attrs and appt-warning-time-regexp cannot be combined
Date: Tue, 29 Dec 2020 19:25:43 +0100
Hi Lars!

> Stefan Reichör <stefan <at> xsteve.at> writes:
>
>> This way you can reproduce the problem using "emacs -Q":
>
> Thanks for the very clear bug reproduction case.  It seems like the
> diary code just assumed that the face attrs were at the end of the lines
> (and weren't combined with comments), and just removing that limitation
> seems to fix the test case.  Fix pushed to Emacs 28.

Thanks for fixing this problem.

I can confirm that it works for me now :-)


Stefan.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#19965; Package emacs. (Wed, 30 Dec 2020 03:04:01 GMT) Full text and rfc822 format available.

Message #26 received at 19965 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 19965 <at> debbugs.gnu.org
Subject: Re: bug#19965: 24.3; diary-face-attrs and appt-warning-time-regexp
 cannot be combined
Date: Wed, 30 Dec 2020 04:03:15 +0100
Stefan Reichör <stefan <at> xsteve.at> writes:

> I can confirm that it works for me now :-)

Thanks for checking.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 27 Jan 2021 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 61 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.