GNU bug report logs - #20152
24.4: bookmarks display wrong annotation (FIX INCLUDED)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Boruch Baum <boruch_baum@HIDDEN>; dated Fri, 20 Mar 2015 10:40:03 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 20152 <at> debbugs.gnu.org:


Received: (at 20152) by debbugs.gnu.org; 26 Mar 2015 01:41:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 25 21:41:42 2015
Received: from localhost ([127.0.0.1]:36756 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Yawnm-000873-5F
	for submit <at> debbugs.gnu.org; Wed, 25 Mar 2015 21:41:42 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.181]:16516)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1Yawnh-00086k-97
 for 20152 <at> debbugs.gnu.org; Wed, 25 Mar 2015 21:41:38 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCws0EhQYDSSIE6IRi3QYWAwDgz4Dg3AEqDs
X-IPAS-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCws0EhQYDSSIE6IRi3QYWAwDgz4Dg3AEqDs
X-IronPort-AV: E=Sophos;i="5.01,1,1400040000"; 
   d="scan'208";a="114595128"
Received: from 65-110-216-75.cpe.pppoe.ca (HELO pastel.home) ([65.110.216.75])
 by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA;
 25 Mar 2015 21:41:32 -0400
Received: by pastel.home (Postfix, from userid 20848)
 id DDEA82455; Wed, 25 Mar 2015 21:41:30 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
Subject: Re: bug#20152: 24.4: bookmarks display wrong annotation (FIX INCLUDED)
Message-ID: <jwvegoc5yom.fsf-monnier+emacsbugs@HIDDEN>
References: <550BF8BE.5080105@HIDDEN>
 <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN> <550C67C2.9020208@HIDDEN>
 <550C6B09.3010208@HIDDEN>
Date: Wed, 25 Mar 2015 21:41:30 -0400
In-Reply-To: <550C6B09.3010208@HIDDEN> (Boruch Baum's message of "Fri, 20 Mar
 2015 14:46:33 -0400")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 20152
Cc: 20152 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)

> In the bookmark list buffer, after viewing an annotation for a
> bookmark, navigating to another bookmark entry does not kill the
> annotation buffer display, leading to confusion about which entry
> the still-visible annotation refers.

Indeed.  How 'bout we only fix this part, not by removing the window,
but by keeping it up-to-date as long as the annotations buffer
is displayed?
Can you provide a patch which does just that?

> +(defvar bookmark-bmenu-toggle-auto-display-annotations nil

I think this is not needed: if the user wants to see the annotations,
she can hit `a' after which they'll be auto-updated as she moves in
the list.  And if she doesn't want to see the annotations, she can hit
`q' in the annotations buffer (which should call quit-window).

> +"When not `nil', function `bookmark-bmenu-show-annotation' (by
> +default, bound to `a`), toggles whether to automatically display
> +a bookmark's annotation as one navigates through the bookmark
> +list. Default is `nil'.")

We typically use "non-nil" and "nil" rather than "not `nil'" and
"`nil'".  Same for t which we don't put in `...'.  All other symbols
indeed do get `...'.

> +    (if bookmark-bmenu-auto-display-annotations
> +      (setq bookmark-bmenu-auto-display-annotations nil)
> +     (setq bookmark-bmenu-auto-display-annotations t)))

Aka (setq bookmark-bmenu-auto-display-annotations
          (not bookmark-bmenu-auto-display-annotations))

> +(defvar bookmark-bmenu-auto-display-annotations nil

I don't think we need this either, just use
(get-buffer-window "*Bookmark Annotation*" t) instead.

> +(defun bookmark-bmenu-post-command-hook-function ()
> +  (add-hook 'post-command-hook 'bookmark-bmenu-motion-hook-function t t))
> +
> +(add-hook 'bookmark-bmenu-mode-hook 'bookmark-bmenu-post-command-hook-function)

Better keep bookmark-bmenu-mode-hook nil by default.  IOW, the code
should simply be added to bookmark-bmenu-mode instead.


        Stefan




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20152; Package emacs. Full text available.

Message received at 20152 <at> debbugs.gnu.org:


Received: (at 20152) by debbugs.gnu.org; 20 Mar 2015 18:47:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 20 14:47:24 2015
Received: from localhost ([127.0.0.1]:59374 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YZ1x5-0000Il-H8
	for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 14:47:24 -0400
Received: from mout.gmx.net ([212.227.15.15]:51378)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <boruch_baum@HIDDEN>) id 1YZ1x3-0000I3-B2
 for 20152 <at> debbugs.gnu.org; Fri, 20 Mar 2015 14:47:22 -0400
Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx001)
 with ESMTPSA (Nemesis) id 0MOO6X-1Yccqb0UNB-005u06; Fri, 20 Mar 2015 19:47:12
 +0100
Message-ID: <550C6B09.3010208@HIDDEN>
Date: Fri, 20 Mar 2015 14:46:33 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#20152: 24.4: bookmarks display wrong annotation (FIX INCLUDED)
References: <550BF8BE.5080105@HIDDEN>
 <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN> <550C67C2.9020208@HIDDEN>
In-Reply-To: <550C67C2.9020208@HIDDEN>
OpenPGP: url=hkp://keys.gnupg.net
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="GXnseTG9AoM05MvG51rgBjK1p2a9220ph"
X-Provags-ID: V03:K0:hJnMpa7/R5nhHb2jf72xp2eX66y8wJ3pmnqmHVOlnSLgPWm0Gmq
 9iZSwLsPv2GYxtDoiFcX1wIJAQvyw8FliH+jjpkp/zaQYWG8aFug5LOm7WfFKnBhS/7uaiR
 N5sGJtW6eA7w7NIMLLwxzHP+G0xqKBaHXEon8Cyd09Wz5NH3WnXqTkG0aJIl/i7H/dVBD5X
 w0U3PY/S4kmjsOB68eUFg==
X-UI-Out-Filterresults: notjunk:1;
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 20152
Cc: 20152 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--GXnseTG9AoM05MvG51rgBjK1p2a9220ph
Content-Type: multipart/mixed;
 boundary="------------070406070702060505000706"

This is a multi-part message in MIME format.
--------------070406070702060505000706
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

And this, replaces `emacs_bug_20152-b.patch'.

Now I'm really signing off.


On 03/20/2015 02:32 PM, Boruch Baum wrote:
> Stefan,
>=20
> I noticed that my solution, while good, was partial, in that it didn't
> cover ALL the possible navigation commands.
>=20
> Attached is a more elegant, smaller, and more thorough fix, especially
> appropriate or a buffer such as bookmark-bmenu, as so many of the
> keystrokes within the buffer will be navigation commands.
>=20
> This patch replaces `emacs_bug_20152-a.patch'.
>=20
> Signing off for Shabbat,
>=20
> Boruch.
>=20
> On 03/20/2015 10:31 AM, Stefan Monnier wrote:
>> Same here, please resend your fix as a patch ("diff -u" or "diff -c").=
--=20
>=20
>=20
> hkp://keys.gnupg.net
> CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0
>=20


--=20
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0


--------------070406070702060505000706
Content-Type: text/x-patch;
 name="emacs_bug_20152-b2.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="emacs_bug_20152-b2.patch"

--- bookmark.el	2015-03-20 14:25:37.325230039 -0400
+++ bookmark-new.el	2015-03-20 14:40:51.425200402 -0400
@@ -1901,9 +1901,20 @@
       (bookmark-bmenu-other-window))))
=20
=20
+(defvar bookmark-bmenu-toggle-auto-display-annotations nil
+"When not `nil', function `bookmark-bmenu-show-annotation' (by
+default, bound to `a`), toggles whether to automatically display
+a bookmark's annotation as one navigates through the bookmark
+list. Default is `nil'.")
+
 (defun bookmark-bmenu-show-annotation ()
   "Show the annotation for the current bookmark in another window."
   (interactive)
+  (when (and (called-interactively-p "any")
+             bookmark-bmenu-toggle-auto-display-annotations)
+    (if bookmark-bmenu-auto-display-annotations
+      (setq bookmark-bmenu-auto-display-annotations nil)
+     (setq bookmark-bmenu-auto-display-annotations t)))
   (let ((bookmark (bookmark-bmenu-bookmark)))
     (bookmark-show-annotation bookmark)))
=20
@@ -2068,6 +2079,31 @@
     (forward-line 1))
   (forward-line 0))
=20
+(defvar bookmark-bmenu-auto-display-annotations nil
+"Whether to automatically display a bookmark's annotation as one
+navigates through the bookmark list. `t' for yes. Default is
+`nil'.")
+
+(defvar bookmark-bmenu-last-post-command-line 1
+"The line number at point, within the bookmark list buffer, after
+the last command had been run in that buffer.")
+
+(defun bookmark-bmenu-motion-hook-function ()
+"This function is added to the `post-command-hook' locally for
+bookmark list buffers, in order to update any visible annotations
+as one navigates within the buffer."
+  (let ((annotation-buffer))
+    (when (/=3D bookmark-bmenu-last-post-command-line (line-number-at-po=
s))
+      (when (setq annotation-buffer (get-buffer "*Bookmark Annotation*")=
)
+        (kill-buffer annotation-buffer))
+      (when bookmark-bmenu-auto-display-annotations
+        (bookmark-bmenu-show-annotation)))))
+
+(defun bookmark-bmenu-post-command-hook-function ()
+  (add-hook 'post-command-hook 'bookmark-bmenu-motion-hook-function t t)=
)
+
+(add-hook 'bookmark-bmenu-mode-hook 'bookmark-bmenu-post-command-hook-fu=
nction)
+
=20
 =0C
 ;;; Menu bar stuff.  Prefix is "bookmark-menu".

--------------070406070702060505000706--

--GXnseTG9AoM05MvG51rgBjK1p2a9220ph
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVDGsJAAoJEDvrUfDmCx9LvKIP/0SlQdcplSNDktJty8TH7+58
hwm7k8XDQeZ0L1CjP3k3K8ezL734ArVUOQwoCgXdKLMH+PbuwygQJFOnFjIF1w3a
jpuRi1hQ01Wf8QLBm2LeaRC52RQ5fiu+PLra7hBgmCvrCjDYFIrUsHCK9ASY8N2F
Aw/d/3Fwgg2FNysIwe8aYX7Gr6sJ8rCwibk7pTgTqDd/hsORnp2WTDyLOlsgLn3M
c2nJNe7P4yYGGLPOBYPwnJgrX0kWYHDCu52HSqAOuhCJHR9sn7TXVR6w+Gs8g07E
lcvvbMrNqNVunjwwZBo/i0fFXBZQyMeyL7ihsSROR4O8CF5tKiLsq4Eu2HPg/HJX
uZC1npvhSO6PFy3JZs2BUoURgU/o9204IHb+0nQx20XK3xq8K0ALP6wND0pR4RYN
lSn7lanPZz1T7ZstsvFbbEZ5h4cmoU9Pt3QjsCnOYWFmTOgEsgcO1pcBXUDOK7Jb
Tla653NXFmYuuYEvLqQFlTW/VXgKLCMNoGkzI4v4i5SVZxItJQxQicH3Iy15NP0L
J3g9KoH98LBjCn37ZsjGIZxxZ+lmIvRYj7WPCkaHeI3QKrJ9J14zbhP8EvV8oyFF
0a09bZ68CMc5UlJc+BCJ8BRjynl0CSe2Hzlvh3OP7wfhq5ZvL0xHD0G5n9Iev+a2
VU4GIL3ZprKqLsbT8708
=wpqi
-----END PGP SIGNATURE-----

--GXnseTG9AoM05MvG51rgBjK1p2a9220ph--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20152; Package emacs. Full text available.

Message received at 20152 <at> debbugs.gnu.org:


Received: (at 20152) by debbugs.gnu.org; 20 Mar 2015 18:33:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 20 14:33:29 2015
Received: from localhost ([127.0.0.1]:59353 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YZ1jc-0007tF-QN
	for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 14:33:29 -0400
Received: from mout.gmx.net ([212.227.15.19]:60540)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <boruch_baum@HIDDEN>) id 1YZ1ja-0007sY-6i
 for 20152 <at> debbugs.gnu.org; Fri, 20 Mar 2015 14:33:27 -0400
Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx003)
 with ESMTPSA (Nemesis) id 0MYP57-1Z40qI091F-00VBw4; Fri, 20 Mar 2015 19:33:15
 +0100
Message-ID: <550C67C2.9020208@HIDDEN>
Date: Fri, 20 Mar 2015 14:32:34 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#20152: 24.4: bookmarks display wrong annotation (FIX INCLUDED)
References: <550BF8BE.5080105@HIDDEN>
 <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN>
In-Reply-To: <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN>
OpenPGP: url=hkp://keys.gnupg.net
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="C8h7VTD4XGQnVUds9PXJU4slHwwB0Q19U"
X-Provags-ID: V03:K0:zq7sUpATmqCmRFXE4tK1eSe0+b027eF9xV0mal5lThCex9Iw2ke
 fWzInpZ+PcEuFeuJ45O0Ps7P0qPV2yjkUChWZ3N7ihkY6f0c8bvp3feYoyRbgvU51nY/yji
 dX7cxJIY4pIUv1UDG5lMjDA9gPrJjXC/g1QmcNrrJF4C4W/uL1MfOLAQsWcV1R7CdtyJv2s
 kDBH/CZOjvrzMVhGJbrKQ==
X-UI-Out-Filterresults: notjunk:1;
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 20152
Cc: 20152 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--C8h7VTD4XGQnVUds9PXJU4slHwwB0Q19U
Content-Type: multipart/mixed;
 boundary="------------090708080009050104020201"

This is a multi-part message in MIME format.
--------------090708080009050104020201
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Stefan,

I noticed that my solution, while good, was partial, in that it didn't
cover ALL the possible navigation commands.

Attached is a more elegant, smaller, and more thorough fix, especially
appropriate or a buffer such as bookmark-bmenu, as so many of the
keystrokes within the buffer will be navigation commands.

This patch replaces `emacs_bug_20152-a.patch'.

Signing off for Shabbat,

Boruch.

On 03/20/2015 10:31 AM, Stefan Monnier wrote:
> Same here, please resend your fix as a patch ("diff -u" or "diff -c").-=
-=20


hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0


--------------090708080009050104020201
Content-Type: text/x-patch;
 name="emacs_bug_20152-a2.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="emacs_bug_20152-a2.patch"

--- bookmark.el	2015-03-20 14:25:37.325230039 -0400
+++ bookmark-new.el	2015-03-20 14:22:03.981236956 -0400
@@ -2068,6 +2068,31 @@
     (forward-line 1))
   (forward-line 0))
=20
+(defvar bookmark-bmenu-auto-display-annotations nil
+"Whether to automatically display a bookmark's annotation as one
+navigates through the bookmark list. `t' for yes. Default is
+`nil'.")
+
+(defvar bookmark-bmenu-last-post-command-line 1
+"The line number at point, within the bookmark list buffer, after
+the last command had been run in that buffer.")
+
+(defun bookmark-bmenu-motion-hook-function ()
+"This function is added to the `post-command-hook' locally for
+bookmark list buffers, in order to update any visible annotations
+as one navigates within the buffer."
+  (let ((annotation-buffer))
+    (when (/=3D bookmark-bmenu-last-post-command-line (line-number-at-po=
s))
+      (when (setq annotation-buffer (get-buffer "*Bookmark Annotation*")=
)
+        (kill-buffer annotation-buffer))
+      (when bookmark-bmenu-auto-display-annotations
+        (bookmark-bmenu-show-annotation)))))
+
+(defun bookmark-bmenu-post-command-hook-function ()
+  (add-hook 'post-command-hook 'bookmark-bmenu-motion-hook-function t t)=
)
+
+(add-hook 'bookmark-bmenu-mode-hook 'bookmark-bmenu-post-command-hook-fu=
nction)
+
=20
 =0C
 ;;; Menu bar stuff.  Prefix is "bookmark-menu".

--------------090708080009050104020201--

--C8h7VTD4XGQnVUds9PXJU4slHwwB0Q19U
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVDGfCAAoJEDvrUfDmCx9L4g0P/iaoNnVA1GbCTCKSt8Af6Yp6
iYoVnMj0z306M1+umEySfXONM44Np7VlJplW8C3sF+YpZrkiVd5FLljWaNuRDZIG
VL0t7WFU5bYPVXin26BZbLq5jhE3vTa6YJWXHmawGL0sptXnBnFtKQWXlsqPCQ8k
lhSgybyLrEvgVIRKxD0mADCVVyNPl8Eu83LL+8F2H1hPntnarNC4G2tMNBcmOQUE
GCu4oUJj3BnYgdK15v78PixlIqfinLbqs+y5cSe5ae5M7SSJCXSg5f+WhpdtyhRg
pXuFXhlK/qPCvFY7NnbZL6Kmv173VDKUpcNbtQrZ6P2+fw18Cf/bN+3juBEOeIye
gn0rBTqS1ZyWBE9SyzhTXLgErmM/8nNNZ5j2r/5eIoCTocf8fbLAHBBPhC2AKRQ0
3XCw9r/0VdKz9uVbD5tDBxwje223vYH2dF3An281OElPJoP9Jl0lPXaryCBNBKWx
iLDdojHj4aRRL4FH/xS9ge/fJIQsFdU0mjeSe8acke9a5yWskfSgreJ7RhDkhiIm
hI3PQ6LV3IWHdi9zwPI1rsFXRU3Xw8FgIxs0EVgVtZ6KnyKiIy+QhCPDiq8x4W+s
WME7HKH0vMbeJmawYFGkl7BvTjqWgb1WQKEEHhZEvFsPwxcbCqSWS8o/MbR3QvO3
BKuhvHpa1OP6v3HcGC1B
=C8iX
-----END PGP SIGNATURE-----

--C8h7VTD4XGQnVUds9PXJU4slHwwB0Q19U--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20152; Package emacs. Full text available.

Message received at 20152 <at> debbugs.gnu.org:


Received: (at 20152) by debbugs.gnu.org; 20 Mar 2015 16:30:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 20 12:30:18 2015
Received: from localhost ([127.0.0.1]:59311 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YYzoO-0001rD-IU
	for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 12:30:17 -0400
Received: from mout.gmx.net ([212.227.17.21]:50559)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYzoJ-0001qu-Mn
 for 20152 <at> debbugs.gnu.org; Fri, 20 Mar 2015 12:30:14 -0400
Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx101)
 with ESMTPSA (Nemesis) id 0M8ZtH-1ZV6JF27iV-00wBi8; Fri, 20 Mar 2015 17:30:02
 +0100
Message-ID: <550C4ADD.9050607@HIDDEN>
Date: Fri, 20 Mar 2015 12:29:17 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#20152: 24.4: bookmarks display wrong annotation (FIX INCLUDED)
References: <550BF8BE.5080105@HIDDEN>
 <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN>
In-Reply-To: <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN>
OpenPGP: url=hkp://keys.gnupg.net
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="TUA6rVNmqeHOsHQXEvjM4THPaJHd1qSde"
X-Provags-ID: V03:K0:cL/gtl9+Z2U6FRd5GRrmZ2shpEsl3k7hZ/fQoeKfZ+aTrxqczAv
 +YQAXaFFJANAv1QvgiavmALp7AHGVgkCFoQqRwEoFn1pphuiOuEQwZxvjK/4tEbA9e3l+5Q
 cuHgL5wtYCVdLFv39N02LBRMWgRkTJIgpCEAMdZ6TYWpCFwTlP8BLOd6in2ze29xM2Bdgi8
 iPANsn5B5v30TaiEZA26Q==
X-UI-Out-Filterresults: notjunk:1;
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 20152
Cc: 20152 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--TUA6rVNmqeHOsHQXEvjM4THPaJHd1qSde
Content-Type: multipart/mixed;
 boundary="------------070409020804060201040507"

This is a multi-part message in MIME format.
--------------070409020804060201040507
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 03/20/2015 10:31 AM, Stefan Monnier wrote:
> Same here, please resend your fix as a patch ("diff -u" or "diff -c").
I've attached TWO versions of the patch, in order to give you the option
to easily choose whether you want the second additional feature
mentioned below.

>> "Boruch" =3D=3D Boruch Baum <boruch_baum@HIDDEN> writes:
>=20
>> In the bookmark list buffer, after viewing an annotation for a
>> bookmark, navigating to another bookmark entry does not kill the
>> annotation buffer display, leading to confusion about which entry
>> the still-visible annotation refers.
>=20
>> The atttached bugfix kills the annotation buffer on navigation,
>> and remaps navigation keys accordingly.
>=20
>> The bugfix also introduces an option to automatically display
>> annotations as one navigates within the bookmark list buffer.
This is reflected in file `emacs_bug_20152-a.patch'

>> The bugfix also introduces an option to toggle auto-display of
>> annotations.
This is reflected in file `emacs_bug_20152-b.patch'

--=20
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0


--------------070409020804060201040507
Content-Type: text/x-patch;
 name="emacs_bug_20152-a.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="emacs_bug_20152-a.patch"

--- bookmark.el	2015-03-20 12:11:20.889491239 -0400
+++ bookmark-new.el	2015-03-20 12:14:45.825484595 -0400
@@ -1487,9 +1487,11 @@
     (define-key map "\C-d" 'bookmark-bmenu-delete-backwards)
     (define-key map "x" 'bookmark-bmenu-execute-deletions)
     (define-key map "d" 'bookmark-bmenu-delete)
-    (define-key map " " 'next-line)
-    (define-key map "n" 'next-line)
-    (define-key map "p" 'previous-line)
+    (define-key map " " 'bookmark-bmenu-next-line)
+    (define-key map "n" 'bookmark-bmenu-next-line)
+    (define-key map [remap next-line] 'bookmark-bmenu-next-line)
+    (define-key map "p" 'bookmark-bmenu-previous-line)
+    (define-key map [remap previous-line] 'bookmark-bmenu-previous-line)=

     (define-key map "\177" 'bookmark-bmenu-backup-unmark)
     (define-key map "u" 'bookmark-bmenu-unmark)
     (define-key map "m" 'bookmark-bmenu-mark)
@@ -1501,6 +1503,8 @@
     (define-key map "A" 'bookmark-bmenu-show-all-annotations)
     (define-key map "e" 'bookmark-bmenu-edit-annotation)
     (define-key map "/" 'bookmark-bmenu-search)
+    (define-key map [remap backward-char] 'bookmark-bmenu-backward-char)=

+    (define-key map [remap forward-char]  'bookmark-bmenu-forward-char)
     (define-key map [mouse-2] 'bookmark-bmenu-other-window-with-mouse)
     map))
=20
@@ -2068,6 +2072,54 @@
     (forward-line 1))
   (forward-line 0))
=20
+(defvar bookmark-bmenu-auto-display-annotations nil
+"Whether to automatically display a bookmark's annotation as one
+navigates through the bookmark list. `t' for yes. Default is
+`nil'.")
+
+(defun bookmark-bmenu-next-line (&optional ARG TRY-VSCROLL)
+"Move cursor vertically down ARG lines within the bookmark list.
+Refer to function `next-line' for details."
+  (interactive "^p\np")
+  (let
+    ((annotation-buffer
+       (get-buffer "*Bookmark Annotation*")))
+    (when annotation-buffer
+      (kill-buffer annotation-buffer)))
+  (next-line ARG TRY-VSCROLL)
+  (when bookmark-bmenu-auto-display-annotations
+     (bookmark-bmenu-show-annotation)))
+
+(defun bookmark-bmenu-previous-line (&optional ARG TRY-VSCROLL)
+"Move cursor vertically up ARG lines within the bookmark list.
+Refer to function `previous-line' for details."
+  (interactive "^p\np")
+  (let
+    ((annotation-buffer
+       (get-buffer "*Bookmark Annotation*")))
+    (when annotation-buffer
+      (kill-buffer annotation-buffer)))
+  (previous-line ARG TRY-VSCROLL)
+  (when bookmark-bmenu-auto-display-annotations
+     (bookmark-bmenu-show-annotation)))
+
+(defun bookmark-bmenu-forward-char (&optional N)
+  (interactive "p")
+  (bookmark-bmenu-backward-forward-char 'forward-char N))
+
+(defun bookmark-bmenu-backward-char (&optional N)
+  (interactive "p")
+  (bookmark-bmenu-backward-forward-char 'backward-char N))
+
+(defun bookmark-bmenu-backward-forward-char (direction-function N)
+  (let (annotation-buffer
+        (initial-line (line-number-at-pos)))
+    (funcall direction-function N)
+    (when (/=3D initial-line (line-number-at-pos))
+      (when (setq annotation-buffer (get-buffer "*Bookmark Annotation*")=
)
+        (kill-buffer annotation-buffer))
+      (when bookmark-bmenu-auto-display-annotations
+        (bookmark-bmenu-show-annotation)))))
=20
 =0C
 ;;; Menu bar stuff.  Prefix is "bookmark-menu".

--------------070409020804060201040507
Content-Type: text/x-patch;
 name="emacs_bug_20152-b.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="emacs_bug_20152-b.patch"

--- bookmark.el	2015-03-20 12:16:19.485481558 -0400
+++ bookmark-new.el	2015-03-20 12:17:41.241478908 -0400
@@ -1487,9 +1487,11 @@
     (define-key map "\C-d" 'bookmark-bmenu-delete-backwards)
     (define-key map "x" 'bookmark-bmenu-execute-deletions)
     (define-key map "d" 'bookmark-bmenu-delete)
-    (define-key map " " 'next-line)
-    (define-key map "n" 'next-line)
-    (define-key map "p" 'previous-line)
+    (define-key map " " 'bookmark-bmenu-next-line)
+    (define-key map "n" 'bookmark-bmenu-next-line)
+    (define-key map [remap next-line] 'bookmark-bmenu-next-line)
+    (define-key map "p" 'bookmark-bmenu-previous-line)
+    (define-key map [remap previous-line] 'bookmark-bmenu-previous-line)=

     (define-key map "\177" 'bookmark-bmenu-backup-unmark)
     (define-key map "u" 'bookmark-bmenu-unmark)
     (define-key map "m" 'bookmark-bmenu-mark)
@@ -1501,6 +1503,8 @@
     (define-key map "A" 'bookmark-bmenu-show-all-annotations)
     (define-key map "e" 'bookmark-bmenu-edit-annotation)
     (define-key map "/" 'bookmark-bmenu-search)
+    (define-key map [remap backward-char] 'bookmark-bmenu-backward-char)=

+    (define-key map [remap forward-char]  'bookmark-bmenu-forward-char)
     (define-key map [mouse-2] 'bookmark-bmenu-other-window-with-mouse)
     map))
=20
@@ -1901,9 +1905,20 @@
       (bookmark-bmenu-other-window))))
=20
=20
+(defvar bookmark-bmenu-toggle-auto-display-annotations nil
+"When not `nil', function `bookmark-bmenu-show-annotation' (by
+default, bound to `a`), toggles whether to automatically display
+a bookmark's annotation as one navigates through the bookmark
+list. Default is `nil'.")
+
 (defun bookmark-bmenu-show-annotation ()
   "Show the annotation for the current bookmark in another window."
   (interactive)
+  (when (and (called-interactively-p "any")
+             bookmark-bmenu-toggle-auto-display-annotations)
+    (if bookmark-bmenu-auto-display-annotations
+      (setq bookmark-bmenu-auto-display-annotations nil)
+     (setq bookmark-bmenu-auto-display-annotations t)))
   (let ((bookmark (bookmark-bmenu-bookmark)))
     (bookmark-show-annotation bookmark)))
=20
@@ -2068,6 +2083,54 @@
     (forward-line 1))
   (forward-line 0))
=20
+(defvar bookmark-bmenu-auto-display-annotations nil
+"Whether to automatically display a bookmark's annotation as one
+navigates through the bookmark list. `t' for yes. Default is
+`nil'.")
+
+(defun bookmark-bmenu-next-line (&optional ARG TRY-VSCROLL)
+"Move cursor vertically down ARG lines within the bookmark list.
+Refer to function `next-line' for details."
+  (interactive "^p\np")
+  (let
+    ((annotation-buffer
+       (get-buffer "*Bookmark Annotation*")))
+    (when annotation-buffer
+      (kill-buffer annotation-buffer)))
+  (next-line ARG TRY-VSCROLL)
+  (when bookmark-bmenu-auto-display-annotations
+     (bookmark-bmenu-show-annotation)))
+
+(defun bookmark-bmenu-previous-line (&optional ARG TRY-VSCROLL)
+"Move cursor vertically up ARG lines within the bookmark list.
+Refer to function `previous-line' for details."
+  (interactive "^p\np")
+  (let
+    ((annotation-buffer
+       (get-buffer "*Bookmark Annotation*")))
+    (when annotation-buffer
+      (kill-buffer annotation-buffer)))
+  (previous-line ARG TRY-VSCROLL)
+  (when bookmark-bmenu-auto-display-annotations
+     (bookmark-bmenu-show-annotation)))
+
+(defun bookmark-bmenu-forward-char (&optional N)
+  (interactive "p")
+  (bookmark-bmenu-backward-forward-char 'forward-char N))
+
+(defun bookmark-bmenu-backward-char (&optional N)
+  (interactive "p")
+  (bookmark-bmenu-backward-forward-char 'backward-char N))
+
+(defun bookmark-bmenu-backward-forward-char (direction-function N)
+  (let (annotation-buffer
+        (initial-line (line-number-at-pos)))
+    (funcall direction-function N)
+    (when (/=3D initial-line (line-number-at-pos))
+      (when (setq annotation-buffer (get-buffer "*Bookmark Annotation*")=
)
+        (kill-buffer annotation-buffer))
+      (when bookmark-bmenu-auto-display-annotations
+        (bookmark-bmenu-show-annotation)))))
=20
 =0C
 ;;; Menu bar stuff.  Prefix is "bookmark-menu".

--------------070409020804060201040507--

--TUA6rVNmqeHOsHQXEvjM4THPaJHd1qSde
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVDErdAAoJEDvrUfDmCx9LfFQP/Rpf3jSCq/5jiLgx/JiMEzp5
rHSwRfQvRasT2J202pgQ9Nj6cxNZ+FGpVi/6dscccPwcsrbYo20SBzd57V9t5hDu
TwkDSQctxpFg6sJrCg8yuGRoe5tFduRPnGUv2sX7I/MEAIm3bH72WBdKpn0IDLfT
qOHDHf5083cdlfj6ogmoyL4HA0TBkYDfs/PpT8K26/Knxv6+P0NPR9F5nkoWq7Re
nIvM+wSf8fiSb+rbINiOFndnL20EBfvFgdLkLmVnUAaJTyg71UOho3NmWFgGoCdj
KWnJ3YjniHxk4XJ9WVwkGLqSm+7qmaFDFznECiR5eCibHw4wTvU4DmF2fZU6to81
XoxEFhhbSxEFPDrWXj2Twh4Znqdoym5v++/NtWGyqfgRMjvIsqeg4EZH7pn1tc/H
wpEqmlagtGEjaibaV7OnfW+2oZ6u3D/9afeKBe6zZ+A6ICJCTb/70lma9D1Mxt8h
lYmYg8CO5+TZaC0P3ijbDDeZs7/3AnekJM4/NxF9icbl1NKE5kMNKT/ZONskDC+M
yQF58r8yM+2BGWHwjZaTp9pQWj6HVWm7nmv7684hqfetzdwhClX/fvoUJFW3RJ2C
AzqT6S4JcHBCrHqta1g9+9dUO+ISbqdotf631HPmNhbXkTkv1tpqfdN7KiAvaFUy
jrGs6QoL3cLT7kX0KphM
=tGDb
-----END PGP SIGNATURE-----

--TUA6rVNmqeHOsHQXEvjM4THPaJHd1qSde--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20152; Package emacs. Full text available.

Message received at 20152 <at> debbugs.gnu.org:


Received: (at 20152) by debbugs.gnu.org; 20 Mar 2015 14:31:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 20 10:31:48 2015
Received: from localhost ([127.0.0.1]:59224 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YYxxg-0007R5-2H
	for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 10:31:47 -0400
Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41205)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <monnier@HIDDEN>) id 1YYxxa-0007Qt-50
 for 20152 <at> debbugs.gnu.org; Fri, 20 Mar 2015 10:31:42 -0400
Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242])
 by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2KEVbi7031729;
 Fri, 20 Mar 2015 10:31:37 -0400
Received: by pastel.home (Postfix, from userid 20848)
 id DA480F63; Fri, 20 Mar 2015 10:31:36 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Boruch Baum <boruch_baum@HIDDEN>
Subject: Re: bug#20152: 24.4: bookmarks display wrong annotation (FIX INCLUDED)
Message-ID: <jwv4mpfyc48.fsf-monnier+emacsbugs@HIDDEN>
References: <550BF8BE.5080105@HIDDEN>
Date: Fri, 20 Mar 2015 10:31:36 -0400
In-Reply-To: <550BF8BE.5080105@HIDDEN> (Boruch Baum's message of "Fri, 20 Mar
 2015 06:38:54 -0400")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-NAI-Spam-Flag: NO
X-NAI-Spam-Threshold: 5
X-NAI-Spam-Score: 0
X-NAI-Spam-Rules: 1 Rules triggered
	RV5251=0
X-NAI-Spam-Version: 2.3.0.9393 : core <5251> : inlines <2452> : streams
 <1408631> : uri <1885574>
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: 20152
Cc: 20152 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

Same here, please resend your fix as a patch ("diff -u" or "diff -c").


        Stefan


>>>>> "Boruch" == Boruch Baum <boruch_baum@HIDDEN> writes:

> In the bookmark list buffer, after viewing an annotation for a
> bookmark, navigating to another bookmark entry does not kill the
> annotation buffer display, leading to confusion about which entry
> the still-visible annotation refers.

> The atttached bugfix kills the annotation buffer on navigation,
> and remaps navigation keys accordingly.

> The bugfix also introduces an option to automatically display
> annotations as one navigates within the bookmark list buffer.

> The bugfix also introduces an option to toggle auto-display of
> annotations.

> Note that the code has two sets of key-binding definitions: Only
> the first, (defvar bookmark-bmenu-mode-map ..., is for the bugfix
> to bookmark.el. The second, (eval-after-load "bookmark" ..., or
> better, just (progn ..., is included for convenience / testing.



> ;-------------------------------------------------------------------
> ; bookmark-bmenu-next-line
> ; bookmark-bmenu-previous-line
> ; bookmark-bmenu-forward-char
> ; bookmark-bmenu-backward-char
> ;
> ; Functions to address bug in which the `*Bookmark Annotation*' buffer
> ; is not modified or updated when navigating through the
> ; bookmark-bmenu-list.
> ;
> ; Also provides option to auto-display annotations as one navigates
> ; the bmenu-list

> (defvar bookmark-bmenu-auto-display-annotations nil
> "Whether to automatically display a bookmark's annotation as one
> navigates through the bookmark list. `t' for yes. Default is
> `nil'.")

> (defun bookmark-bmenu-next-line (&optional ARG TRY-VSCROLL)
> "Move cursor vertically down ARG lines within the bookmark list.
> Refer to function `next-line' for details."
>   (interactive "^p\np")
>   (let
>     ((annotation-buffer
>        (get-buffer "*Bookmark Annotation*")))
>     (when annotation-buffer
>       (kill-buffer annotation-buffer)))
>   (next-line ARG TRY-VSCROLL)
>   (when bookmark-bmenu-auto-display-annotations
>      (bookmark-bmenu-show-annotation)))

> (defun bookmark-bmenu-previous-line (&optional ARG TRY-VSCROLL)
> "Move cursor vertically up ARG lines within the bookmark list.
> Refer to function `previous-line' for details."
>   (interactive "^p\np")
>   (let
>     ((annotation-buffer
>        (get-buffer "*Bookmark Annotation*")))
>     (when annotation-buffer
>       (kill-buffer annotation-buffer)))
>   (previous-line ARG TRY-VSCROLL)
>   (when bookmark-bmenu-auto-display-annotations
>      (bookmark-bmenu-show-annotation)))

> (defun bookmark-bmenu-forward-char (&optional N)
>   (interactive "p")
>   (bookmark-bmenu-backward-forward-char 'forward-char N))

> (defun bookmark-bmenu-backward-char (&optional N)
>   (interactive "p")
>   (bookmark-bmenu-backward-forward-char 'backward-char N))

> (defun bookmark-bmenu-backward-forward-char (direction-function N)
>   (let (annotation-buffer
>         (initial-line (line-number-at-pos)))
>     (funcall direction-function N)
>     (when (/= initial-line (line-number-at-pos))
>       (when (setq annotation-buffer (get-buffer "*Bookmark Annotation*"))
>         (kill-buffer annotation-buffer))
>       (when bookmark-bmenu-auto-display-annotations
>         (bookmark-bmenu-show-annotation)))))

> ;-------------------------------------------------------------------
> ;
> ; ONLY ONE OF THE FOLLOWING TWO OPTIONS ARE NECESSARY !
> ;
> ; Either redine the mode map, or just the individual keys
> ;
> ;-------------------------------------------------------------------
> (defvar bookmark-bmenu-mode-map
>   (let ((map (make-keymap)))
>     (set-keymap-parent map special-mode-map)
>     (define-key map "v" 'bookmark-bmenu-select)
>     (define-key map "w" 'bookmark-bmenu-locate)
>     (define-key map "2" 'bookmark-bmenu-2-window)
>     (define-key map "1" 'bookmark-bmenu-1-window)
>     (define-key map "j" 'bookmark-bmenu-this-window)
>     (define-key map "\C-c\C-c" 'bookmark-bmenu-this-window)
>     (define-key map "f" 'bookmark-bmenu-this-window)
>     (define-key map "\C-m" 'bookmark-bmenu-this-window)
>     (define-key map "o" 'bookmark-bmenu-other-window)
>     (define-key map "\C-o" 'bookmark-bmenu-switch-other-window)
>     (define-key map "s" 'bookmark-bmenu-save)
>     (define-key map "k" 'bookmark-bmenu-delete)
>     (define-key map "\C-d" 'bookmark-bmenu-delete-backwards)
>     (define-key map "x" 'bookmark-bmenu-execute-deletions)
>     (define-key map "d" 'bookmark-bmenu-delete)
>     (define-key map " " 'bookmark-bmenu-next-line)
>     (define-key map "n" 'bookmark-bmenu-next-line)
>     (define-key map [remap next-line] 'bookmark-bmenu-next-line)
>     (define-key map "p" 'bookmark-bmenu-previous-line)
>     (define-key map [remap previous-line] 'bookmark-bmenu-previous-line)
>     (define-key map "\177" 'bookmark-bmenu-backup-unmark)
>     (define-key map "u" 'bookmark-bmenu-unmark)
>     (define-key map "m" 'bookmark-bmenu-mark)
>     (define-key map "l" 'bookmark-bmenu-load)
>     (define-key map "r" 'bookmark-bmenu-rename)
>     (define-key map "R" 'bookmark-bmenu-relocate)
>     (define-key map "t" 'bookmark-bmenu-toggle-filenames)
>     (define-key map "a" 'bookmark-bmenu-show-annotation)
>     (define-key map "A" 'bookmark-bmenu-show-all-annotations)
>     (define-key map "e" 'bookmark-bmenu-edit-annotation)
>     (define-key map "/" 'bookmark-bmenu-search)
>     (define-key map [remap backward-char] 'bookmark-bmenu-backward-char)
>     (define-key map [remap forward-char]  'bookmark-bmenu-forward-char)
>     (define-key map [mouse-2] 'bookmark-bmenu-other-window-with-mouse)
>     map))


> (eval-after-load "bookmark"
>   (progn
>     (define-key bookmark-bmenu-mode-map
>       [remap next-line] 'bookmark-bmenu-next-line)
>     (define-key bookmark-bmenu-mode-map
>       [remap previous-line] 'bookmark-bmenu-previous-line)
>     (define-key bookmark-bmenu-mode-map
>       (kbd "n")   'bookmark-bmenu-next-line)
>     (define-key bookmark-bmenu-mode-map
>       (kbd "SPC") 'bookmark-bmenu-next-line)
>     (define-key bookmark-bmenu-mode-map
>       (kbd "p")   'bookmark-bmenu-previous-line)
>     (define-key bookmark-bmenu-mode-map
>       [remap backward-char] 'bookmark-bmenu-backward-char)
>     (define-key bookmark-bmenu-mode-map
>       [remap forward-char]  'bookmark-bmenu-forward-char)
>   ))
> ;-------------------------------------------------------------------


> ;-------------------------------------------------------------------
> ; Modification to function `bookmark-bmenu-show-annotation' to allow
> ; for toggling whether to autodisplay annotations as one navigates
> ; through the bookmark list.
> ;
> ; Do note that the documentation for function `called-interactively-p'
> ; discourages its use in favor of eg. '(not (or executing-kbd-macro
> ; noninteractive))'. See there for details.
> ;
> (defvar bookmark-bmenu-toggle-auto-display-annotations nil
> "When not `nil', function `bookmark-bmenu-show-annotation' (by
> default, bound to `a`), toggles whether to automatically display
> a bookmark's annotation as one navigates through the bookmark
> list. Default is `nil'.")

> (defun bookmark-bmenu-show-annotation ()
>   "Show the annotation for the current bookmark in another window."
>   (interactive)
>   (when (and (called-interactively-p "any")
>              bookmark-bmenu-toggle-auto-display-annotations)
>     (if bookmark-bmenu-auto-display-annotations
>       (setq bookmark-bmenu-auto-display-annotations nil)
>      (setq bookmark-bmenu-auto-display-annotations t)))
>   (let ((bookmark (bookmark-bmenu-bookmark)))
>     (bookmark-show-annotation bookmark)))
> ;-------------------------------------------------------------------


> -- 
> hkp://keys.gnupg.net
> CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0






Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20152; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Mar 2015 10:39:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 20 06:39:48 2015
Received: from localhost ([127.0.0.1]:58833 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YYuLC-0000Xz-KS
	for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 06:39:47 -0400
Received: from eggs.gnu.org ([208.118.235.92]:41888)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYuL9-0000Xk-B6
 for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 06:39:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYuL2-0003jk-78
 for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 06:39:38 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:39498)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYuL2-0003je-4c
 for submit <at> debbugs.gnu.org; Fri, 20 Mar 2015 06:39:36 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43604)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYuL0-00023J-47
 for bug-gnu-emacs@HIDDEN; Fri, 20 Mar 2015 06:39:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYuKv-0003ez-2W
 for bug-gnu-emacs@HIDDEN; Fri, 20 Mar 2015 06:39:34 -0400
Received: from mout.gmx.net ([212.227.17.22]:63913)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <boruch_baum@HIDDEN>) id 1YYuKu-0003ep-Lh
 for bug-gnu-emacs@HIDDEN; Fri, 20 Mar 2015 06:39:29 -0400
Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx102)
 with ESMTPSA (Nemesis) id 0Lyj4F-1ZcvYh1LF9-0167sY for
 <bug-gnu-emacs@HIDDEN>; Fri, 20 Mar 2015 11:39:24 +0100
Message-ID: <550BF8BE.5080105@HIDDEN>
Date: Fri, 20 Mar 2015 06:38:54 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: bug-gnu-emacs@HIDDEN
Subject: 24.4: bookmarks display wrong annotation (FIX INCLUDED)
OpenPGP: url=hkp://keys.gnupg.net
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="nMQRTGVhgG0BqhEiV1qiknVXbiuCraaAf"
X-Provags-ID: V03:K0:5SqdbqArEVQizNn46KB0K1GbH4mGz0PUdGNhf/q4b+qQzBYF00v
 SFeGjL9imDj+yaPCwhCp2zMMLzbMUhP9WAc7Hu6n6CcUpSGZq3w7nThO+poKFxfOhnRoFvZ
 krKOqU2WMHG1ySkkkwhuCHk12N2HvV6OsbQDMedW7ktyOxEi9TK9gwibN7W0xkE5YYbi96z
 RAguZGqeM+90nTe/R2wUA==
X-UI-Out-Filterresults: notjunk:1;
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic]
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.1 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.1 (----)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--nMQRTGVhgG0BqhEiV1qiknVXbiuCraaAf
Content-Type: multipart/mixed;
 boundary="------------050403000409070100020109"

This is a multi-part message in MIME format.
--------------050403000409070100020109
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

In the bookmark list buffer, after viewing an annotation for a
bookmark, navigating to another bookmark entry does not kill the
annotation buffer display, leading to confusion about which entry
the still-visible annotation refers.

The atttached bugfix kills the annotation buffer on navigation,
and remaps navigation keys accordingly.

The bugfix also introduces an option to automatically display
annotations as one navigates within the bookmark list buffer.

The bugfix also introduces an option to toggle auto-display of
annotations.

Note that the code has two sets of key-binding definitions: Only
the first, (defvar bookmark-bmenu-mode-map ..., is for the bugfix
to bookmark.el. The second, (eval-after-load "bookmark" ..., or
better, just (progn ..., is included for convenience / testing.



;-------------------------------------------------------------------
; bookmark-bmenu-next-line
; bookmark-bmenu-previous-line
; bookmark-bmenu-forward-char
; bookmark-bmenu-backward-char
;
; Functions to address bug in which the `*Bookmark Annotation*' buffer
; is not modified or updated when navigating through the
; bookmark-bmenu-list.
;
; Also provides option to auto-display annotations as one navigates
; the bmenu-list

(defvar bookmark-bmenu-auto-display-annotations nil
"Whether to automatically display a bookmark's annotation as one
navigates through the bookmark list. `t' for yes. Default is
`nil'.")

(defun bookmark-bmenu-next-line (&optional ARG TRY-VSCROLL)
"Move cursor vertically down ARG lines within the bookmark list.
Refer to function `next-line' for details."
  (interactive "^p\np")
  (let
    ((annotation-buffer
       (get-buffer "*Bookmark Annotation*")))
    (when annotation-buffer
      (kill-buffer annotation-buffer)))
  (next-line ARG TRY-VSCROLL)
  (when bookmark-bmenu-auto-display-annotations
     (bookmark-bmenu-show-annotation)))

(defun bookmark-bmenu-previous-line (&optional ARG TRY-VSCROLL)
"Move cursor vertically up ARG lines within the bookmark list.
Refer to function `previous-line' for details."
  (interactive "^p\np")
  (let
    ((annotation-buffer
       (get-buffer "*Bookmark Annotation*")))
    (when annotation-buffer
      (kill-buffer annotation-buffer)))
  (previous-line ARG TRY-VSCROLL)
  (when bookmark-bmenu-auto-display-annotations
     (bookmark-bmenu-show-annotation)))

(defun bookmark-bmenu-forward-char (&optional N)
  (interactive "p")
  (bookmark-bmenu-backward-forward-char 'forward-char N))

(defun bookmark-bmenu-backward-char (&optional N)
  (interactive "p")
  (bookmark-bmenu-backward-forward-char 'backward-char N))

(defun bookmark-bmenu-backward-forward-char (direction-function N)
  (let (annotation-buffer
        (initial-line (line-number-at-pos)))
    (funcall direction-function N)
    (when (/=3D initial-line (line-number-at-pos))
      (when (setq annotation-buffer (get-buffer "*Bookmark Annotation*"))=

        (kill-buffer annotation-buffer))
      (when bookmark-bmenu-auto-display-annotations
        (bookmark-bmenu-show-annotation)))))

;-------------------------------------------------------------------
;
; ONLY ONE OF THE FOLLOWING TWO OPTIONS ARE NECESSARY !
;
; Either redine the mode map, or just the individual keys
;
;-------------------------------------------------------------------
(defvar bookmark-bmenu-mode-map
  (let ((map (make-keymap)))
    (set-keymap-parent map special-mode-map)
    (define-key map "v" 'bookmark-bmenu-select)
    (define-key map "w" 'bookmark-bmenu-locate)
    (define-key map "2" 'bookmark-bmenu-2-window)
    (define-key map "1" 'bookmark-bmenu-1-window)
    (define-key map "j" 'bookmark-bmenu-this-window)
    (define-key map "\C-c\C-c" 'bookmark-bmenu-this-window)
    (define-key map "f" 'bookmark-bmenu-this-window)
    (define-key map "\C-m" 'bookmark-bmenu-this-window)
    (define-key map "o" 'bookmark-bmenu-other-window)
    (define-key map "\C-o" 'bookmark-bmenu-switch-other-window)
    (define-key map "s" 'bookmark-bmenu-save)
    (define-key map "k" 'bookmark-bmenu-delete)
    (define-key map "\C-d" 'bookmark-bmenu-delete-backwards)
    (define-key map "x" 'bookmark-bmenu-execute-deletions)
    (define-key map "d" 'bookmark-bmenu-delete)
    (define-key map " " 'bookmark-bmenu-next-line)
    (define-key map "n" 'bookmark-bmenu-next-line)
    (define-key map [remap next-line] 'bookmark-bmenu-next-line)
    (define-key map "p" 'bookmark-bmenu-previous-line)
    (define-key map [remap previous-line] 'bookmark-bmenu-previous-line)
    (define-key map "\177" 'bookmark-bmenu-backup-unmark)
    (define-key map "u" 'bookmark-bmenu-unmark)
    (define-key map "m" 'bookmark-bmenu-mark)
    (define-key map "l" 'bookmark-bmenu-load)
    (define-key map "r" 'bookmark-bmenu-rename)
    (define-key map "R" 'bookmark-bmenu-relocate)
    (define-key map "t" 'bookmark-bmenu-toggle-filenames)
    (define-key map "a" 'bookmark-bmenu-show-annotation)
    (define-key map "A" 'bookmark-bmenu-show-all-annotations)
    (define-key map "e" 'bookmark-bmenu-edit-annotation)
    (define-key map "/" 'bookmark-bmenu-search)
    (define-key map [remap backward-char] 'bookmark-bmenu-backward-char)
    (define-key map [remap forward-char]  'bookmark-bmenu-forward-char)
    (define-key map [mouse-2] 'bookmark-bmenu-other-window-with-mouse)
    map))


(eval-after-load "bookmark"
  (progn
    (define-key bookmark-bmenu-mode-map
      [remap next-line] 'bookmark-bmenu-next-line)
    (define-key bookmark-bmenu-mode-map
      [remap previous-line] 'bookmark-bmenu-previous-line)
    (define-key bookmark-bmenu-mode-map
      (kbd "n")   'bookmark-bmenu-next-line)
    (define-key bookmark-bmenu-mode-map
      (kbd "SPC") 'bookmark-bmenu-next-line)
    (define-key bookmark-bmenu-mode-map
      (kbd "p")   'bookmark-bmenu-previous-line)
    (define-key bookmark-bmenu-mode-map
      [remap backward-char] 'bookmark-bmenu-backward-char)
    (define-key bookmark-bmenu-mode-map
      [remap forward-char]  'bookmark-bmenu-forward-char)
  ))
;-------------------------------------------------------------------


;-------------------------------------------------------------------
; Modification to function `bookmark-bmenu-show-annotation' to allow
; for toggling whether to autodisplay annotations as one navigates
; through the bookmark list.
;
; Do note that the documentation for function `called-interactively-p'
; discourages its use in favor of eg. '(not (or executing-kbd-macro
; noninteractive))'. See there for details.
;
(defvar bookmark-bmenu-toggle-auto-display-annotations nil
"When not `nil', function `bookmark-bmenu-show-annotation' (by
default, bound to `a`), toggles whether to automatically display
a bookmark's annotation as one navigates through the bookmark
list. Default is `nil'.")

(defun bookmark-bmenu-show-annotation ()
  "Show the annotation for the current bookmark in another window."
  (interactive)
  (when (and (called-interactively-p "any")
             bookmark-bmenu-toggle-auto-display-annotations)
    (if bookmark-bmenu-auto-display-annotations
      (setq bookmark-bmenu-auto-display-annotations nil)
     (setq bookmark-bmenu-auto-display-annotations t)))
  (let ((bookmark (bookmark-bmenu-bookmark)))
    (bookmark-show-annotation bookmark)))
;-------------------------------------------------------------------


--=20
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0


--------------050403000409070100020109
Content-Type: text/plain; charset=UTF-8;
 name="attachment-1"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="attachment-1"

Oy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0KOyBib29rbWFyay1ibWVudS1uZXh0LWxpbmUKOyBib29rbWFyay1i
bWVudS1wcmV2aW91cy1saW5lCjsgYm9va21hcmstYm1lbnUtZm9yd2FyZC1jaGFyCjsgYm9v
a21hcmstYm1lbnUtYmFja3dhcmQtY2hhcgo7CjsgRnVuY3Rpb25zIHRvIGFkZHJlc3MgYnVn
IGluIHdoaWNoIHRoZSBgKkJvb2ttYXJrIEFubm90YXRpb24qJyBidWZmZXIKOyBpcyBub3Qg
bW9kaWZpZWQgb3IgdXBkYXRlZCB3aGVuIG5hdmlnYXRpbmcgdGhyb3VnaCB0aGUKOyBib29r
bWFyay1ibWVudS1saXN0Lgo7CjsgQWxzbyBwcm92aWRlcyBvcHRpb24gdG8gYXV0by1kaXNw
bGF5IGFubm90YXRpb25zIGFzIG9uZSBuYXZpZ2F0ZXMKOyB0aGUgYm1lbnUtbGlzdAoKKGRl
ZnZhciBib29rbWFyay1ibWVudS1hdXRvLWRpc3BsYXktYW5ub3RhdGlvbnMgbmlsCiJXaGV0
aGVyIHRvIGF1dG9tYXRpY2FsbHkgZGlzcGxheSBhIGJvb2ttYXJrJ3MgYW5ub3RhdGlvbiBh
cyBvbmUKbmF2aWdhdGVzIHRocm91Z2ggdGhlIGJvb2ttYXJrIGxpc3QuIGB0JyBmb3IgeWVz
LiBEZWZhdWx0IGlzCmBuaWwnLiIpCgooZGVmdW4gYm9va21hcmstYm1lbnUtbmV4dC1saW5l
ICgmb3B0aW9uYWwgQVJHIFRSWS1WU0NST0xMKQoiTW92ZSBjdXJzb3IgdmVydGljYWxseSBk
b3duIEFSRyBsaW5lcyB3aXRoaW4gdGhlIGJvb2ttYXJrIGxpc3QuClJlZmVyIHRvIGZ1bmN0
aW9uIGBuZXh0LWxpbmUnIGZvciBkZXRhaWxzLiIKICAoaW50ZXJhY3RpdmUgIl5wXG5wIikK
ICAobGV0CiAgICAoKGFubm90YXRpb24tYnVmZmVyCiAgICAgICAoZ2V0LWJ1ZmZlciAiKkJv
b2ttYXJrIEFubm90YXRpb24qIikpKQogICAgKHdoZW4gYW5ub3RhdGlvbi1idWZmZXIKICAg
ICAgKGtpbGwtYnVmZmVyIGFubm90YXRpb24tYnVmZmVyKSkpCiAgKG5leHQtbGluZSBBUkcg
VFJZLVZTQ1JPTEwpCiAgKHdoZW4gYm9va21hcmstYm1lbnUtYXV0by1kaXNwbGF5LWFubm90
YXRpb25zCiAgICAgKGJvb2ttYXJrLWJtZW51LXNob3ctYW5ub3RhdGlvbikpKQoKKGRlZnVu
IGJvb2ttYXJrLWJtZW51LXByZXZpb3VzLWxpbmUgKCZvcHRpb25hbCBBUkcgVFJZLVZTQ1JP
TEwpCiJNb3ZlIGN1cnNvciB2ZXJ0aWNhbGx5IHVwIEFSRyBsaW5lcyB3aXRoaW4gdGhlIGJv
b2ttYXJrIGxpc3QuClJlZmVyIHRvIGZ1bmN0aW9uIGBwcmV2aW91cy1saW5lJyBmb3IgZGV0
YWlscy4iCiAgKGludGVyYWN0aXZlICJecFxucCIpCiAgKGxldAogICAgKChhbm5vdGF0aW9u
LWJ1ZmZlcgogICAgICAgKGdldC1idWZmZXIgIipCb29rbWFyayBBbm5vdGF0aW9uKiIpKSkK
ICAgICh3aGVuIGFubm90YXRpb24tYnVmZmVyCiAgICAgIChraWxsLWJ1ZmZlciBhbm5vdGF0
aW9uLWJ1ZmZlcikpKQogIChwcmV2aW91cy1saW5lIEFSRyBUUlktVlNDUk9MTCkKICAod2hl
biBib29rbWFyay1ibWVudS1hdXRvLWRpc3BsYXktYW5ub3RhdGlvbnMKICAgICAoYm9va21h
cmstYm1lbnUtc2hvdy1hbm5vdGF0aW9uKSkpCgooZGVmdW4gYm9va21hcmstYm1lbnUtZm9y
d2FyZC1jaGFyICgmb3B0aW9uYWwgTikKICAoaW50ZXJhY3RpdmUgInAiKQogIChib29rbWFy
ay1ibWVudS1iYWNrd2FyZC1mb3J3YXJkLWNoYXIgJ2ZvcndhcmQtY2hhciBOKSkKCihkZWZ1
biBib29rbWFyay1ibWVudS1iYWNrd2FyZC1jaGFyICgmb3B0aW9uYWwgTikKICAoaW50ZXJh
Y3RpdmUgInAiKQogIChib29rbWFyay1ibWVudS1iYWNrd2FyZC1mb3J3YXJkLWNoYXIgJ2Jh
Y2t3YXJkLWNoYXIgTikpCgooZGVmdW4gYm9va21hcmstYm1lbnUtYmFja3dhcmQtZm9yd2Fy
ZC1jaGFyIChkaXJlY3Rpb24tZnVuY3Rpb24gTikKICAobGV0IChhbm5vdGF0aW9uLWJ1ZmZl
cgogICAgICAgIChpbml0aWFsLWxpbmUgKGxpbmUtbnVtYmVyLWF0LXBvcykpKQogICAgKGZ1
bmNhbGwgZGlyZWN0aW9uLWZ1bmN0aW9uIE4pCiAgICAod2hlbiAoLz0gaW5pdGlhbC1saW5l
IChsaW5lLW51bWJlci1hdC1wb3MpKQogICAgICAod2hlbiAoc2V0cSBhbm5vdGF0aW9uLWJ1
ZmZlciAoZ2V0LWJ1ZmZlciAiKkJvb2ttYXJrIEFubm90YXRpb24qIikpCiAgICAgICAgKGtp
bGwtYnVmZmVyIGFubm90YXRpb24tYnVmZmVyKSkKICAgICAgKHdoZW4gYm9va21hcmstYm1l
bnUtYXV0by1kaXNwbGF5LWFubm90YXRpb25zCiAgICAgICAgKGJvb2ttYXJrLWJtZW51LXNo
b3ctYW5ub3RhdGlvbikpKSkpCgo7LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo7CjsgT05MWSBPTkUgT0YgVEhF
IEZPTExPV0lORyBUV08gT1BUSU9OUyBBUkUgTkVDRVNTQVJZICEKOwo7IEVpdGhlciByZWRp
bmUgdGhlIG1vZGUgbWFwLCBvciBqdXN0IHRoZSBpbmRpdmlkdWFsIGtleXMKOwo7LS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLQooZGVmdmFyIGJvb2ttYXJrLWJtZW51LW1vZGUtbWFwCiAgKGxldCAoKG1hcCAo
bWFrZS1rZXltYXApKSkKICAgIChzZXQta2V5bWFwLXBhcmVudCBtYXAgc3BlY2lhbC1tb2Rl
LW1hcCkKICAgIChkZWZpbmUta2V5IG1hcCAidiIgJ2Jvb2ttYXJrLWJtZW51LXNlbGVjdCkK
ICAgIChkZWZpbmUta2V5IG1hcCAidyIgJ2Jvb2ttYXJrLWJtZW51LWxvY2F0ZSkKICAgIChk
ZWZpbmUta2V5IG1hcCAiMiIgJ2Jvb2ttYXJrLWJtZW51LTItd2luZG93KQogICAgKGRlZmlu
ZS1rZXkgbWFwICIxIiAnYm9va21hcmstYm1lbnUtMS13aW5kb3cpCiAgICAoZGVmaW5lLWtl
eSBtYXAgImoiICdib29rbWFyay1ibWVudS10aGlzLXdpbmRvdykKICAgIChkZWZpbmUta2V5
IG1hcCAiXEMtY1xDLWMiICdib29rbWFyay1ibWVudS10aGlzLXdpbmRvdykKICAgIChkZWZp
bmUta2V5IG1hcCAiZiIgJ2Jvb2ttYXJrLWJtZW51LXRoaXMtd2luZG93KQogICAgKGRlZmlu
ZS1rZXkgbWFwICJcQy1tIiAnYm9va21hcmstYm1lbnUtdGhpcy13aW5kb3cpCiAgICAoZGVm
aW5lLWtleSBtYXAgIm8iICdib29rbWFyay1ibWVudS1vdGhlci13aW5kb3cpCiAgICAoZGVm
aW5lLWtleSBtYXAgIlxDLW8iICdib29rbWFyay1ibWVudS1zd2l0Y2gtb3RoZXItd2luZG93
KQogICAgKGRlZmluZS1rZXkgbWFwICJzIiAnYm9va21hcmstYm1lbnUtc2F2ZSkKICAgIChk
ZWZpbmUta2V5IG1hcCAiayIgJ2Jvb2ttYXJrLWJtZW51LWRlbGV0ZSkKICAgIChkZWZpbmUt
a2V5IG1hcCAiXEMtZCIgJ2Jvb2ttYXJrLWJtZW51LWRlbGV0ZS1iYWNrd2FyZHMpCiAgICAo
ZGVmaW5lLWtleSBtYXAgIngiICdib29rbWFyay1ibWVudS1leGVjdXRlLWRlbGV0aW9ucykK
ICAgIChkZWZpbmUta2V5IG1hcCAiZCIgJ2Jvb2ttYXJrLWJtZW51LWRlbGV0ZSkKICAgIChk
ZWZpbmUta2V5IG1hcCAiICIgJ2Jvb2ttYXJrLWJtZW51LW5leHQtbGluZSkKICAgIChkZWZp
bmUta2V5IG1hcCAibiIgJ2Jvb2ttYXJrLWJtZW51LW5leHQtbGluZSkKICAgIChkZWZpbmUt
a2V5IG1hcCBbcmVtYXAgbmV4dC1saW5lXSAnYm9va21hcmstYm1lbnUtbmV4dC1saW5lKQog
ICAgKGRlZmluZS1rZXkgbWFwICJwIiAnYm9va21hcmstYm1lbnUtcHJldmlvdXMtbGluZSkK
ICAgIChkZWZpbmUta2V5IG1hcCBbcmVtYXAgcHJldmlvdXMtbGluZV0gJ2Jvb2ttYXJrLWJt
ZW51LXByZXZpb3VzLWxpbmUpCiAgICAoZGVmaW5lLWtleSBtYXAgIlwxNzciICdib29rbWFy
ay1ibWVudS1iYWNrdXAtdW5tYXJrKQogICAgKGRlZmluZS1rZXkgbWFwICJ1IiAnYm9va21h
cmstYm1lbnUtdW5tYXJrKQogICAgKGRlZmluZS1rZXkgbWFwICJtIiAnYm9va21hcmstYm1l
bnUtbWFyaykKICAgIChkZWZpbmUta2V5IG1hcCAibCIgJ2Jvb2ttYXJrLWJtZW51LWxvYWQp
CiAgICAoZGVmaW5lLWtleSBtYXAgInIiICdib29rbWFyay1ibWVudS1yZW5hbWUpCiAgICAo
ZGVmaW5lLWtleSBtYXAgIlIiICdib29rbWFyay1ibWVudS1yZWxvY2F0ZSkKICAgIChkZWZp
bmUta2V5IG1hcCAidCIgJ2Jvb2ttYXJrLWJtZW51LXRvZ2dsZS1maWxlbmFtZXMpCiAgICAo
ZGVmaW5lLWtleSBtYXAgImEiICdib29rbWFyay1ibWVudS1zaG93LWFubm90YXRpb24pCiAg
ICAoZGVmaW5lLWtleSBtYXAgIkEiICdib29rbWFyay1ibWVudS1zaG93LWFsbC1hbm5vdGF0
aW9ucykKICAgIChkZWZpbmUta2V5IG1hcCAiZSIgJ2Jvb2ttYXJrLWJtZW51LWVkaXQtYW5u
b3RhdGlvbikKICAgIChkZWZpbmUta2V5IG1hcCAiLyIgJ2Jvb2ttYXJrLWJtZW51LXNlYXJj
aCkKICAgIChkZWZpbmUta2V5IG1hcCBbcmVtYXAgYmFja3dhcmQtY2hhcl0gJ2Jvb2ttYXJr
LWJtZW51LWJhY2t3YXJkLWNoYXIpCiAgICAoZGVmaW5lLWtleSBtYXAgW3JlbWFwIGZvcndh
cmQtY2hhcl0gICdib29rbWFyay1ibWVudS1mb3J3YXJkLWNoYXIpCiAgICAoZGVmaW5lLWtl
eSBtYXAgW21vdXNlLTJdICdib29rbWFyay1ibWVudS1vdGhlci13aW5kb3ctd2l0aC1tb3Vz
ZSkKICAgIG1hcCkpCgoKKGV2YWwtYWZ0ZXItbG9hZCAiYm9va21hcmsiCiAgKHByb2duCiAg
ICAoZGVmaW5lLWtleSBib29rbWFyay1ibWVudS1tb2RlLW1hcAogICAgICBbcmVtYXAgbmV4
dC1saW5lXSAnYm9va21hcmstYm1lbnUtbmV4dC1saW5lKQogICAgKGRlZmluZS1rZXkgYm9v
a21hcmstYm1lbnUtbW9kZS1tYXAKICAgICAgW3JlbWFwIHByZXZpb3VzLWxpbmVdICdib29r
bWFyay1ibWVudS1wcmV2aW91cy1saW5lKQogICAgKGRlZmluZS1rZXkgYm9va21hcmstYm1l
bnUtbW9kZS1tYXAKICAgICAgKGtiZCAibiIpICAgJ2Jvb2ttYXJrLWJtZW51LW5leHQtbGlu
ZSkKICAgIChkZWZpbmUta2V5IGJvb2ttYXJrLWJtZW51LW1vZGUtbWFwCiAgICAgIChrYmQg
IlNQQyIpICdib29rbWFyay1ibWVudS1uZXh0LWxpbmUpCiAgICAoZGVmaW5lLWtleSBib29r
bWFyay1ibWVudS1tb2RlLW1hcAogICAgICAoa2JkICJwIikgICAnYm9va21hcmstYm1lbnUt
cHJldmlvdXMtbGluZSkKICAgIChkZWZpbmUta2V5IGJvb2ttYXJrLWJtZW51LW1vZGUtbWFw
CiAgICAgIFtyZW1hcCBiYWNrd2FyZC1jaGFyXSAnYm9va21hcmstYm1lbnUtYmFja3dhcmQt
Y2hhcikKICAgIChkZWZpbmUta2V5IGJvb2ttYXJrLWJtZW51LW1vZGUtbWFwCiAgICAgIFty
ZW1hcCBmb3J3YXJkLWNoYXJdICAnYm9va21hcmstYm1lbnUtZm9yd2FyZC1jaGFyKQogICkp
CjstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tCgoKOy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KOyBNb2RpZmljYXRpb24gdG8gZnVu
Y3Rpb24gYGJvb2ttYXJrLWJtZW51LXNob3ctYW5ub3RhdGlvbicgdG8gYWxsb3cKOyBmb3Ig
dG9nZ2xpbmcgd2hldGhlciB0byBhdXRvZGlzcGxheSBhbm5vdGF0aW9ucyBhcyBvbmUgbmF2
aWdhdGVzCjsgdGhyb3VnaCB0aGUgYm9va21hcmsgbGlzdC4KOwo7IERvIG5vdGUgdGhhdCB0
aGUgZG9jdW1lbnRhdGlvbiBmb3IgZnVuY3Rpb24gYGNhbGxlZC1pbnRlcmFjdGl2ZWx5LXAn
CjsgZGlzY291cmFnZXMgaXRzIHVzZSBpbiBmYXZvciBvZiBlZy4gJyhub3QgKG9yIGV4ZWN1
dGluZy1rYmQtbWFjcm8KOyBub25pbnRlcmFjdGl2ZSkpJy4gU2VlIHRoZXJlIGZvciBkZXRh
aWxzLgo7CihkZWZ2YXIgYm9va21hcmstYm1lbnUtdG9nZ2xlLWF1dG8tZGlzcGxheS1hbm5v
dGF0aW9ucyBuaWwKIldoZW4gbm90IGBuaWwnLCBmdW5jdGlvbiBgYm9va21hcmstYm1lbnUt
c2hvdy1hbm5vdGF0aW9uJyAoYnkKZGVmYXVsdCwgYm91bmQgdG8gYGFgKSwgdG9nZ2xlcyB3
aGV0aGVyIHRvIGF1dG9tYXRpY2FsbHkgZGlzcGxheQphIGJvb2ttYXJrJ3MgYW5ub3RhdGlv
biBhcyBvbmUgbmF2aWdhdGVzIHRocm91Z2ggdGhlIGJvb2ttYXJrCmxpc3QuIERlZmF1bHQg
aXMgYG5pbCcuIikKCihkZWZ1biBib29rbWFyay1ibWVudS1zaG93LWFubm90YXRpb24gKCkK
ICAiU2hvdyB0aGUgYW5ub3RhdGlvbiBmb3IgdGhlIGN1cnJlbnQgYm9va21hcmsgaW4gYW5v
dGhlciB3aW5kb3cuIgogIChpbnRlcmFjdGl2ZSkKICAod2hlbiAoYW5kIChjYWxsZWQtaW50
ZXJhY3RpdmVseS1wICJhbnkiKQogICAgICAgICAgICAgYm9va21hcmstYm1lbnUtdG9nZ2xl
LWF1dG8tZGlzcGxheS1hbm5vdGF0aW9ucykKICAgIChpZiBib29rbWFyay1ibWVudS1hdXRv
LWRpc3BsYXktYW5ub3RhdGlvbnMKICAgICAgKHNldHEgYm9va21hcmstYm1lbnUtYXV0by1k
aXNwbGF5LWFubm90YXRpb25zIG5pbCkKICAgICAoc2V0cSBib29rbWFyay1ibWVudS1hdXRv
LWRpc3BsYXktYW5ub3RhdGlvbnMgdCkpKQogIChsZXQgKChib29rbWFyayAoYm9va21hcmst
Ym1lbnUtYm9va21hcmspKSkKICAgIChib29rbWFyay1zaG93LWFubm90YXRpb24gYm9va21h
cmspKSkKOy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0K
--------------050403000409070100020109--

--nMQRTGVhgG0BqhEiV1qiknVXbiuCraaAf
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVC/i+AAoJEDvrUfDmCx9LHuUP/jmZQ7xg2rnfMJEaxYWd5rGQ
HwpCvxBlGmvcVBXlx0hnfZeZCRrgt9JwJhcDQ83bQrtDY3Z/CzH7afxSAbTbdzFf
UPxEONMxuD/sdQfUuEiA5gSXJzGbd1/6PBhrsDAnL3c254qs47zafd80pQ232260
qtdDylZNPGm2DjjA1T8yUNOPpbC0dqQfjPT6Q+tkR99pu6PdpvDEZfiq0hsTz2aI
hnY03uZp14r1WfDhlhxEnyDLIBBPEvqbpuyJ21nzQDnTbA4/JPjm0is/yZ3oocf/
JwoQcwOpV0omm3TZ7CqlkL00A5MCow/STGsCQ7DZHgOCrAoYuIL6EZ4UISKd88oT
+6bhpwZZyf1VFS99mPoy5onc50KQvJLcv+WESggCO7IBwQ5G5vDQP2ffAnvnMoYZ
IyMPG+zgLsw2LOwp0rOKcYbSTntNmHgGhoYIYy1rqe9DRnYCLzO1xHGpxzJLl4U7
eADDUZS/6WNkUiSwJF/gupYoEhC/X4yA4cebsLkP9Ym3TIOGgusUpUWaLTOkhkNr
7KBZOD4L5bOo7IRdc3PpgkQ56hbl54FvKX5EbnzWxRFD8L5nMPG0+DxH4jS2pG6o
Brd1DBxudycBZYDZ/PVHgZUeWKURTDEuEFXWodeqKdG7y9W4BO4V1Xg6v4F6yiu3
J2uRcsu1DGkqKwPfeGp0
=PnO2
-----END PGP SIGNATURE-----

--nMQRTGVhgG0BqhEiV1qiknVXbiuCraaAf--




Acknowledgement sent to Boruch Baum <boruch_baum@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#20152; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.