GNU bug report logs - #20157
25.0.50; `describe-key-briefly' shows byte-code for <mouse-movement>

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20157 in the body.
You can then email your comments to 20157 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; `describe-key-briefly' shows byte-code for <mouse-movement>
Date: Sat, 21 Mar 2015 11:43:21 -0700 (PDT)

I cannot easily give a recipe to repro this.  But using
`describe-key-briefly' with non-nil INSERT arg and clicking mouse-1
in some contexts gives me this:

<down-mouse-1> at that spot runs the command mouse-drag-region
<mouse-movement> runs the command #[257 "..." [(down-mouse-1
(#<window 26 on throw-show-key.el> 5007 (577 . 198) 152173811 nil
5007 (82 . 16) nil (3 . 6) (0 . 12))) (5007)
#<window 26 on throw-show-key.el> 0 44 0 nil event-end posn-point
mouse-movement integer-or-marker-p mouse--drag-set-mark-and-point
mouse-position mouse-scroll-subr nil auto-hscroll-mode] 9 "

(fn EVENT)" "e"]

where the "..." after the #[257 is really byte-code.

So far, I have not seen byte code for other key descriptions.

I say in some contexts because if I just put this in a buffer and use
C-x C-e on it, it just inserts "<mouse-movement> runs the command
ignore":

  (describe-key-briefly [mouse-movement] t)

So far, I have not seen byte-code for other key descriptions.

I tried using the debugger on this, but was unable to repro the problem
then.  Apparently, sometimes clicking mouse-1 causes the normal text
"runs the command ignore" to be used.  Sometimes it shows the byte code.

The preceding command, when it does this, seems always to be
`mouse-drag-region', from a <down-mouse-1> event.

Message #14 received at 20157 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: michael_heerdegen <at> web.de, 13841 <at> debbugs.gnu.org, 20157 <at> debbugs.gnu.org,
 drew.adams <at> oracle.com
Subject: Re: bug#13841: 24.3.50; Regression - unreadable `C-h k' help
Date: Wed, 09 Oct 2019 05:28:17 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> > No, I think we should forbid using a lambda as a user-visible key
>> > binding.
>> 
>> I think we should avoid doing so in the code in Emacs
>
> That's what I meant, yes.

I have now fixed this in menu-bar.el for the original reported case (and
the ones in nearby menus).  There may be more lurking other places, but
we can fix those if somebody reports them, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 20157 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 20157 <at> debbugs.gnu.org, 13841 <at> debbugs.gnu.org,
 drew.adams <at> oracle.com
Subject: Re: bug#13841: 24.3.50; Regression - unreadable `C-h k' help
Date: Wed, 09 Oct 2019 12:57:32 +0200

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I have now fixed this in menu-bar.el for the original reported case (and
> the ones in nearby menus).  There may be more lurking other places, but
> we can fix those if somebody reports them, I guess.

Thanks.

I don't recall: did we want to fix only compiled lambdas, or any
anonymous functions (including quoted lambdas)?

Attached a quick rough search for candidates (search for "-->") - is any
of them problematic?


Regards,

Michael.

[menu-bar-lambdas.el (application/emacs-lisp, attachment)]

Message #24 received at 20157 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 20157 <at> debbugs.gnu.org, 13841 <at> debbugs.gnu.org,
 drew.adams <at> oracle.com
Subject: Re: bug#13841: 24.3.50; Regression - unreadable `C-h k' help
Date: Wed, 09 Oct 2019 20:57:30 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> I don't recall: did we want to fix only compiled lambdas, or any
> anonymous functions (including quoted lambdas)?

All key bindings (including menu ones) should be to named functions, I
think.  That allows inspection via `C-h k' and the user can jump to the
function definition to see what it does.

> Attached a quick rough search for candidates (search for "-->") - is any
> of them problematic?

All of them should be changed, I think, although the
tab-bar-make-keymap-1 looks a bit difficult to deal with.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.