GNU bug report logs - #20177
24.4: bookmark.el: show all annotations does not display in proper order (FIX INCLUDED)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20177 in the body.
You can then email your comments to 20177 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4: bookmark.el: show all annotations does not display in proper
 order (FIX INCLUDED)
Date: Mon, 23 Mar 2015 06:21:49 -0400

[Message part 1 (text/plain, inline)]

When `bookmark-sort-flag' is set, the bmenu list displays in sorted
order, but the function `bookmark-show-all-annotations' (keybinding
`A'), does not.

The first attached patch file, `simple.patch', is just that.

The second attached patch file, `fancy.patch', adds an option to display
the list of all annotations as a pre-formatted org-mode buffer, based
upon the setting of a new variable,
`bookmark-show-all-annotations-in-org-mode'.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

[simple.patch (text/x-patch, attachment)]

[fancy.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 20177 <at> debbugs.gnu.org
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Wed, 25 Mar 2015 21:56:08 -0400

> When `bookmark-sort-flag' is set, the bmenu list displays in sorted
> order, but the function `bookmark-show-all-annotations' (keybinding
> `A'), does not.

> The first attached patch file, `simple.patch', is just that.

Thanks, attached.

> The second attached patch file, `fancy.patch', adds an option to display
> the list of all annotations as a pre-formatted org-mode buffer, based
> upon the setting of a new variable,
> `bookmark-show-all-annotations-in-org-mode'.

I'd tend to think that this buffer should be read-only and using a major
mode that derives from special-mode, which seems incompatible with
org-mode.  It could still use the Org syntax, of course, maybe with an
outline-minor-mode.

> +(defvar bookmark-show-all-annotations-in-org-mode nil
> +"When not `nil', the command `bookmark-show-all-annotations' will
> +format its display as an org-mode buffer")

I think we can just change the format without introducing an option to
recover the old format.


        Stefan

Message #11 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 20177 <at> debbugs.gnu.org, Boruch Baum <boruch_baum <at> gmx.com>
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Tue, 25 Jun 2019 19:35:33 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> The second attached patch file, `fancy.patch', adds an option to display
>> the list of all annotations as a pre-formatted org-mode buffer, based
>> upon the setting of a new variable,
>> `bookmark-show-all-annotations-in-org-mode'.
>
> I'd tend to think that this buffer should be read-only and using a major
> mode that derives from special-mode, which seems incompatible with
> org-mode.  It could still use the Org syntax, of course, maybe with an
> outline-minor-mode.
>
>> +(defvar bookmark-show-all-annotations-in-org-mode nil
>> +"When not `nil', the command `bookmark-show-all-annotations' will
>> +format its display as an org-mode buffer")
>
> I think we can just change the format without introducing an option to
> recover the old format.

I think so too.  Boruch, did you do any further work on this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 20177 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Tue, 25 Jun 2019 15:43:45 -0400

On 2019-06-25 19:35, Lars Ingebrigtsen wrote:
> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
> >> The second attached patch file, `fancy.patch', adds an option to display
> >> the list of all annotations as a pre-formatted org-mode buffer, based
> >> upon the setting of a new variable,
> >> `bookmark-show-all-annotations-in-org-mode'.
> >
> > I'd tend to think that this buffer should be read-only and using a major
> > mode that derives from special-mode, which seems incompatible with
> > org-mode.  It could still use the Org syntax, of course, maybe with an
> > outline-minor-mode.
> >
> >> +(defvar bookmark-show-all-annotations-in-org-mode nil
> >> +"When not `nil', the command `bookmark-show-all-annotations' will
> >> +format its display as an org-mode buffer")
> >
> > I think we can just change the format without introducing an option to
> > recover the old format.
>
> I think so too.  Boruch, did you do any further work on this?

No. ( ... year 2015 ... Thanks for the memories ... )

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Message #17 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 20177 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Wed, 26 Jun 2019 15:55:07 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

>> I think so too.  Boruch, did you do any further work on this?
>
> No. ( ... year 2015 ... Thanks for the memories ... )

In that case it seems unlikely that we'd be able to proceed with this
bug report and I'm closing it.  Please reopen if further progress can be
made.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 20177 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Wed, 26 Jun 2019 16:47:04 +0200

Boruch Baum <boruch_baum <at> gmx.com> writes:

> On 2019-06-26 15:55, Lars Ingebrigtsen wrote:
>> Boruch Baum <boruch_baum <at> gmx.com> writes:
>>
>> >> I think so too.  Boruch, did you do any further work on this?
>> >
>> > No. ( ... year 2015 ... Thanks for the memories ... )
>>
>> In that case it seems unlikely that we'd be able to proceed with this
>> bug report and I'm closing it.  Please reopen if further progress can be
>> made.
>
> I submitted two versions of patch, so if the objections are to the
> 'fancy' one, which added features that aren't good enough,
> why not accept the 'simple' patch that addresses the reported bug?

Stefan did apply that one at the time...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Boruch Baum <boruch_baum <at> gmx.com>
Cc: 20177 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Wed, 26 Jun 2019 16:50:09 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Boruch Baum <boruch_baum <at> gmx.com> writes:
>
>> On 2019-06-26 15:55, Lars Ingebrigtsen wrote:
>>> Boruch Baum <boruch_baum <at> gmx.com> writes:
>>>
>>> >> I think so too.  Boruch, did you do any further work on this?
>>> >
>>> > No. ( ... year 2015 ... Thanks for the memories ... )
>>>
>>> In that case it seems unlikely that we'd be able to proceed with this
>>> bug report and I'm closing it.  Please reopen if further progress can be
>>> made.
>>
>> I submitted two versions of patch, so if the objections are to the
>> 'fancy' one, which added features that aren't good enough,
>> why not accept the 'simple' patch that addresses the reported bug?
>
> Stefan did apply that one at the time...

(But he said "Thanks, attached" instead of "applied", which may explain
the confustion.  :-))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 20177 <at> debbugs.gnu.org (full text, mbox):

From: Boruch Baum <boruch_baum <at> gmx.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 20177 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#20177: 24.4: bookmark.el: show all annotations does not
 display in proper order (FIX INCLUDED)
Date: Wed, 26 Jun 2019 10:45:01 -0400

On 2019-06-26 15:55, Lars Ingebrigtsen wrote:
> Boruch Baum <boruch_baum <at> gmx.com> writes:
>
> >> I think so too.  Boruch, did you do any further work on this?
> >
> > No. ( ... year 2015 ... Thanks for the memories ... )
>
> In that case it seems unlikely that we'd be able to proceed with this
> bug report and I'm closing it.  Please reopen if further progress can be
> made.

I submitted two versions of patch, so if the objections are to the
'fancy' one, which added features that aren't good enough,
why not accept the 'simple' patch that addresses the reported bug?

--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.