GNU bug report logs - #20461
25.0.50; `use-hard-newlines'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Wed, 29 Apr 2015 17:27:01 UTC

Severity: wishlist

Tags: fixed

Found in version 25.0.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20461 in the body.
You can then email your comments to 20461 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Wed, 29 Apr 2015 17:27:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 29 Apr 2015 17:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; `use-hard-newlines'
Date: Wed, 29 Apr 2015 10:26:44 -0700 (PDT)
Why is this minor mode not named `use-hard-newlines-mode', to respect
the naming convention?

Reading the doc for this function doesn't even offer a clue that this is
a minor mode and that it is not global.

See, for instance, this user's question, which shows that s?he expected
the function to act globally.
http://stackoverflow.com/q/29949975/729907


In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2015-04-05 on LEG570
Bzr revision: 16eec6fc55dcc05d1d819f18998e84a9580b2521
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --host=i686-pc-mingw32 --enable-checking=yes,glyphs'




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Sat, 30 Apr 2016 19:01:02 GMT) Full text and rfc822 format available.

Message #8 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 20461 <at> debbugs.gnu.org
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Sat, 30 Apr 2016 21:00:40 +0200
Drew Adams <drew.adams <at> oracle.com> writes:

> Why is this minor mode not named `use-hard-newlines-mode', to respect
> the naming convention?
>
> Reading the doc for this function doesn't even offer a clue that this is
> a minor mode and that it is not global.
>
> See, for instance, this user's question, which shows that s?he expected
> the function to act globally.
> http://stackoverflow.com/q/29949975/729907

I agree.  An objections to renaming to -mode and marking the old name as
an obsolete alias?  (And fixing the doc string.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 05:00:02 GMT) Full text and rfc822 format available.

Message #11 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 20461 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 05:58:54 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Drew Adams <drew.adams <at> oracle.com> writes:
>
>> Why is this minor mode not named `use-hard-newlines-mode', to respect
>> the naming convention?
>>
>> Reading the doc for this function doesn't even offer a clue that this is
>> a minor mode and that it is not global.
>>
>> See, for instance, this user's question, which shows that s?he expected
>> the function to act globally.
>> http://stackoverflow.com/q/29949975/729907
>
> I agree.  An objections to renaming to -mode and marking the old name as
> an obsolete alias?  (And fixing the doc string.)

I agree as well.  No protests within 4+ years could be taken as a sign
that no one minds the change.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 12:28:01 GMT) Full text and rfc822 format available.

Message #14 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 20461 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 13:27:24 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

>> I agree.  An objections to renaming to -mode and marking the old name as
>> an obsolete alias?  (And fixing the doc string.)
>
> I agree as well.  No protests within 4+ years could be taken as a sign
> that no one minds the change.

I had another peek at this, and use-hard-newlines is slightly unusual
in that many functions bind the use-hard-newlines (and use it), like:

(defun fill-flowed-encode (&optional buffer)
[...]
    (when use-hard-newlines

So we'd presumably need to rename the variable, too, and then it just
seems like it's not worth it, really.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 12:57:01 GMT) Full text and rfc822 format available.

Message #17 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 20461 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 13:55:50 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> So we'd presumably need to rename the variable, too, and then it just
> seems like it's not worth it, really.

I see, yes then it might be better to just leave it alone.

I guess the doc string still need fixing to say it only affects the
current buffer though.  That is perhaps important enough to go on the
first line, but I couldn't come up with a way to do that which doesn't
go over the 67 character limit.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 13:01:02 GMT) Full text and rfc822 format available.

Message #20 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 20461 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 14:00:19 +0100
Stefan Kangas <stefan <at> marxist.se> writes:

> I guess the doc string still need fixing to say it only affects the
> current buffer though.  That is perhaps important enough to go on the
> first line, but I couldn't come up with a way to do that which doesn't
> go over the 67 character limit.

I changed it to "Toggle between hard and soft newlines in the current
buffer".  :-)  So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 23 Jan 2020 13:01:03 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 20461 <at> debbugs.gnu.org and Drew Adams <drew.adams <at> oracle.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 23 Jan 2020 13:01:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 14:52:01 GMT) Full text and rfc822 format available.

Message #27 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: larsi <at> gnus.org, 20461 <at> debbugs.gnu.org
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 16:51:23 +0200
> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 23 Jan 2020 13:55:50 +0100
> Cc: 20461 <at> debbugs.gnu.org
> 
> I guess the doc string still need fixing to say it only affects the
> current buffer though.  That is perhaps important enough to go on the
> first line, but I couldn't come up with a way to do that which doesn't
> go over the 67 character limit.

67-character limit is not a hard limit.  If you can do it in less than
79, go for it.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 14:59:02 GMT) Full text and rfc822 format available.

Message #30 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 20461 <at> debbugs.gnu.org
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 15:58:35 +0100
On Thu, 23 Jan 2020 13:55:50 +0100 Stefan Kangas <stefan <at> marxist.se> wrote:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> So we'd presumably need to rename the variable, too, and then it just
>> seems like it's not worth it, really.
>
> I see, yes then it might be better to just leave it alone.
>
> I guess the doc string still need fixing to say it only affects the
> current buffer though.  That is perhaps important enough to go on the
> first line, but I couldn't come up with a way to do that which doesn't
> go over the 67 character limit.

How about this:

Toggle between using hard and soft newlines in the current buffer.

Steve Berman




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 16:55:01 GMT) Full text and rfc822 format available.

Message #33 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Stefan Kangas <stefan <at> marxist.se>
Cc: 20461 <at> debbugs.gnu.org
Subject: RE: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 08:54:43 -0800 (PST)
> I had another peek at this, and use-hard-newlines is slightly unusual
> in that many functions bind the use-hard-newlines (and use it), like:
> 
> (defun fill-flowed-encode (&optional buffer) [...]
>   (when use-hard-newlines
> 
> So we'd presumably need to rename the variable, too,

Yes, of course.  That's true of any minor mode.  Often
people do not use the variable, but they certainly can,
in general.

> and then it just seems like it's not worth it, really.

Why?  No reason given.  The right thing to do, to
respect Emacs convention and not mislead users further,
is to fix this.  And yes, of course, that means also
renaming the variable.  This is trivial to fix.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20461; Package emacs. (Thu, 23 Jan 2020 18:27:02 GMT) Full text and rfc822 format available.

Message #36 received at 20461 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: larsi <at> gnus.org, stefan <at> marxist.se, 20461 <at> debbugs.gnu.org
Subject: Re: bug#20461: 25.0.50; `use-hard-newlines'
Date: Thu, 23 Jan 2020 20:26:47 +0200
> From: Stephen Berman <stephen.berman <at> gmx.net>
> Date: Thu, 23 Jan 2020 15:58:35 +0100
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 20461 <at> debbugs.gnu.org
> 
> Toggle between using hard and soft newlines in the current buffer.

I'd drop "the" for a good measure.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 21 Feb 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 37 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.