GNU bug report logs -
#2048
Flymake Enhancement
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2048 in the body.
You can then email your comments to 2048 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>
:
bug#2048
; Package
emacs
.
(Sun, 25 Jan 2009 17:20:03 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Joseph Donaldson <donaldsonjw <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
Emacs Bugs <bug-gnu-emacs <at> gnu.org>
.
(Sun, 25 Jan 2009 17:20:04 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello,
I hope this is the right forum for submitting this patch for flymake. If
it is not, please, direct me to the correct one. While working to get
flymake to work with the bigloo scheme compiler I discovered that when
it examines the compiler output it does so line-by-line. This prevents
flymake in the case of bigloo from being able to show complete
error/warning messages -- bigloo's error/warning messages span multiple
lines. To remedy this, I introduced a buffer-local variable named
flymake-split-output-pattern and modified the function
flymake-split-output to use it when splitting the output into individual
error/warning messages. The default value of
flymake-split-output-pattern is "[\n\r]+"; this matches the value
previously hard-coded in flymake-split-output. For bigloo, I added in
my .emacs file a hook to bee-mode-hook to set the value
flymake-split-ouput-pattern to "^[\r\n][\r\n]". This enabled flymake to
display the full error/warning messages provided bigloo. The patch for
this modification is attached. If there are any questions and or
comments, I would appreciate hearing them.
Thank You,
Joseph Donaldson
[flymake.patch (text/x-patch, attachment)]
Information forwarded
to
bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>
:
bug#2048
; Package
emacs
.
(Mon, 26 Jan 2009 02:15:03 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Stefan Monnier <monnier <at> iro.umontreal.ca>
:
Extra info received and forwarded to list. Copy sent to
Emacs Bugs <bug-gnu-emacs <at> gnu.org>
.
(Mon, 26 Jan 2009 02:15:03 GMT)
Full text and
rfc822 format available.
Message #10 received at 2048 <at> emacsbugs.donarmstrong.com (full text, mbox):
severity 2048 wishlist
thanks
> lines. To remedy this, I introduced a buffer-local variable named
> flymake-split-output-pattern and modified the function
> flymake-split-output to use it when splitting the output into individual
> error/warning messages. The default value of
> flymake-split-output-pattern is "[\n\r]+"; this matches the value
> previously hard-coded in flymake-split-output. For bigloo, I added in
> my .emacs file a hook to bee-mode-hook to set the value
> flymake-split-ouput-pattern to "^[\r\n][\r\n]". This enabled flymake to
> display the full error/warning messages provided bigloo. The patch for
> this modification is attached. If there are any questions and or
> comments, I would appreciate hearing them.
I'd hope that flymake.el can be improved to match multi-line regexps
without having to tell it how to cut the output into chunks.
In any case, this change is too late for Emacs-23.1 which is in feature
freeze, but otherwise the goal is right. I remember someone else
needing/implementing support for multiline error messages in flymake.el
a while back.
Stefan
Severity set to `wishlist' from `normal'
Request was from
Stefan Monnier <monnier <at> iro.umontreal.ca>
to
control <at> emacsbugs.donarmstrong.com
.
(Mon, 26 Jan 2009 02:15:04 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#2048
; Package
emacs
.
(Sat, 19 Sep 2020 21:58:02 GMT)
Full text and
rfc822 format available.
Message #15 received at 2048 <at> debbugs.gnu.org (full text, mbox):
Joseph Donaldson <donaldsonjw <at> gmail.com> writes:
> I hope this is the right forum for submitting this patch for flymake. If
> it is not, please, direct me to the correct one. While working to get
> flymake to work with the bigloo scheme compiler I discovered that when
> it examines the compiler output it does so line-by-line.
This was 11 years ago, and the bug report unfortunately didn't get a lot
of attention at the time. However, I think the underlying problem was
fixed by João a few years back, so I'm closing this bug report. If the
problem still persists in newer versions of Emacs, please respond to the
debbugs address and we'll reopen.
commit 6954270e87e3a9f829cd6e8c89febc2c0bc48845
Author: João Távora <joaotavora <at> gmail.com>
AuthorDate: Wed Aug 23 02:23:41 2017 +0100
Completely rewrite Flymake's subprocess output processing
Instead of parsing and matching regexps line-by-line, insert
subprocess output in a separate buffer and parse using
`search-forward-regexp'. This eventually enables multi-line error
patterns and simplifies code all around. Store per-check information
in the subprocess using `process-get' and `process-put'. Treat error
messages, warnings, etc. more generically as "diagnostics". Create
these objects as soon as possible, reusing existing `flymake-ler'
structure. Fix some whitespace.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug closed, send any further explanations to
2048 <at> debbugs.gnu.org and Joseph Donaldson <donaldsonjw <at> gmail.com>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Sat, 19 Sep 2020 21:58:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 18 Oct 2020 11:24:09 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 191 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.