GNU bug report logs - #2048
Flymake Enhancement

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Joseph Donaldson <donaldsonjw@HIDDEN>; dated Sun, 25 Jan 2009 17:20:03 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Severity set to `wishlist' from `normal' Request was from Stefan Monnier <monnier@HIDDEN> to control@HIDDEN. Full text available.

Message received at 2048@HIDDEN:


Received: (at 2048) by emacsbugs.donarmstrong.com; 26 Jan 2009 02:06:07 +0000
From monnier@HIDDEN Sun Jan 25 18:06:07 2009
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=-2.5 required=4.0 tests=HAS_BUG_NUMBER,
	MURPHY_DRUGS_REL8,VALID_BTS_CONTROL,XIRONPORT autolearn=ham
	version=3.2.5-bugs.debian.org_2005_01_02
Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0Q25xS3029815;
	Sun, 25 Jan 2009 18:06:00 -0800
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AtYFAJypfEnO+LLC/2dsb2JhbACBbccJhUuCIg
X-IronPort-AV: E=Sophos;i="4.37,323,1231131600"; 
   d="scan'208";a="32812355"
Received: from 206-248-178-194.dsl.teksavvy.com (HELO pastel.home) ([206.248.178.194])
  by ironport2-out.teksavvy.com with ESMTP; 25 Jan 2009 21:05:53 -0500
Received: by pastel.home (Postfix, from userid 20848)
	id BAAC98040; Sun, 25 Jan 2009 21:05:53 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Joseph Donaldson <donaldsonjw@HIDDEN>
Cc: 2048 <at> debbugs.gnu.org
Subject: Re: bug#2048: Flymake Enhancement
Message-ID: <jwveiyqsu2a.fsf-monnier+emacsbugreports@HIDDEN>
References: <1232903607.19724.17.camel@tadpole>
Date: Sun, 25 Jan 2009 21:05:53 -0500
In-Reply-To: <1232903607.19724.17.camel@tadpole> (Joseph Donaldson's message
	of "Sun, 25 Jan 2009 12:13:27 -0500")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

severity 2048 wishlist
thanks

> lines. To remedy this, I introduced a buffer-local variable named
> flymake-split-output-pattern and modified the function
> flymake-split-output to use it when splitting the output into individual
> error/warning messages. The default value of
> flymake-split-output-pattern is "[\n\r]+"; this matches the value
> previously hard-coded in flymake-split-output. For bigloo, I added in
> my .emacs file a hook to bee-mode-hook to set the value
> flymake-split-ouput-pattern to "^[\r\n][\r\n]". This enabled flymake to
> display the full error/warning messages provided bigloo. The patch for
> this modification is attached. If there are any questions and or
> comments, I would appreciate hearing them.

I'd hope that flymake.el can be improved to match multi-line regexps
without having to tell it how to cut the output into chunks.
In any case, this change is too late for Emacs-23.1 which is in feature
freeze, but otherwise the goal is right.  I remember someone else
needing/implementing support for multiline error messages in flymake.el
a while back.


        Stefan




Acknowledgement sent to Stefan Monnier <monnier@HIDDEN>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs@HIDDEN>. Full text available.
Information forwarded to bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>:
bug#2048; Package emacs. Full text available.

Message received at submit@HIDDEN:


Received: (at submit) by emacsbugs.donarmstrong.com; 25 Jan 2009 17:13:43 +0000
From donaldsonjw@HIDDEN Sun Jan 25 09:13:42 2009
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: ***
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=3.0 required=4.0 tests=CAPINIT,MURPHY_DRUGS_REL8
	autolearn=no version=3.2.5-bugs.debian.org_2005_01_02
Received: from lists.gnu.org (lists.gnu.org [199.232.76.165])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0PHDd7O022920
	for <submit@HIDDEN>; Sun, 25 Jan 2009 09:13:40 -0800
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LR8YE-00080y-Ms
	for bug-gnu-emacs@HIDDEN; Sun, 25 Jan 2009 12:13:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LR8YB-0007y4-VC
	for bug-gnu-emacs@HIDDEN; Sun, 25 Jan 2009 12:13:38 -0500
Received: from [199.232.76.173] (port=49205 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1LR8YB-0007xj-IW
	for bug-gnu-emacs@HIDDEN; Sun, 25 Jan 2009 12:13:35 -0500
Received: from rn-out-0910.google.com ([64.233.170.185]:36924)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <donaldsonjw@HIDDEN>)
	id 1LR8YB-0001Qa-BO
	for bug-gnu-emacs@HIDDEN; Sun, 25 Jan 2009 12:13:35 -0500
Received: by rn-out-0910.google.com with SMTP id k50so1607492rnd.7
        for <bug-gnu-emacs@HIDDEN>; Sun, 25 Jan 2009 09:13:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:subject:from:to:content-type
         :date:message-id:mime-version:x-mailer;
        bh=aU7rwttG1KTID0m7Cq2oyn8UR9ijRtEIO8rHsZxVPqg=;
        b=i7JDO4BcraMcT4o/U5XuGlGn7JDB2tSy5FR+yFLZ0h1afFMcnBfvOnnf5JeTh5nzOn
         ChGZQLod99NCyg55WGKJj90cf23cL8CbtBCtFsiwxEFZP3mGhU09wjaffrNF15/Ivsoq
         T9rqtGYpQzLZeHaNMpGjTUaol5Y6hEICYeNas=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:content-type:date:message-id:mime-version:x-mailer;
        b=nTIM8Dk8VtDxIT/EJvOJQxGfbgfff4cYKwpEtlT258vhoAY75oYJDoTqrsJJnorXud
         SydO2bjqofur3/YfpUFgztUj1UbciNep+yZkVqWWT1L9UoFLbo26v/QYDlkZ42+xzboY
         tKEHHdTO9gWmwhL69gPc04a/A496MJ2Jdjne8=
Received: by 10.100.191.9 with SMTP id o9mr3299520anf.63.1232903613854;
        Sun, 25 Jan 2009 09:13:33 -0800 (PST)
Received: from ?192.168.2.3? (cpe-76-190-210-243.neo.res.rr.com [76.190.210.243])
        by mx.google.com with ESMTPS id d21sm20253570and.46.2009.01.25.09.13.32
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Sun, 25 Jan 2009 09:13:33 -0800 (PST)
Subject: Flymake Enhancement
From: Joseph Donaldson <donaldsonjw@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="=-ItEAY3Nq2y9DYRrucCxP"
Date: Sun, 25 Jan 2009 12:13:27 -0500
Message-Id: <1232903607.19724.17.camel@tadpole>
Mime-Version: 1.0
X-Mailer: Evolution 2.24.3 
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2)


--=-ItEAY3Nq2y9DYRrucCxP
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hello,

I hope this is the right forum for submitting this patch for flymake. If
it is not, please, direct me to the correct one. While working to get
flymake to work with the bigloo scheme compiler I discovered that when
it examines the compiler output it does so line-by-line. This prevents
flymake in the case of bigloo from being able to show complete
error/warning messages -- bigloo's error/warning messages span multiple
lines. To remedy this, I introduced a buffer-local variable named
flymake-split-output-pattern and modified the function
flymake-split-output to use it when splitting the output into individual
error/warning messages. The default value of
flymake-split-output-pattern is "[\n\r]+"; this matches the value
previously hard-coded in flymake-split-output. For bigloo, I added in
my .emacs file a hook to bee-mode-hook to set the value
flymake-split-ouput-pattern to "^[\r\n][\r\n]". This enabled flymake to
display the full error/warning messages provided bigloo. The patch for
this modification is attached. If there are any questions and or
comments, I would appreciate hearing them.

Thank You,
Joseph Donaldson

  

--=-ItEAY3Nq2y9DYRrucCxP
Content-Disposition: attachment; filename="flymake.patch"
Content-Type: text/x-patch; name="flymake.patch"; charset="UTF-8"
Content-Transfer-Encoding: 7bit

*** flymake.el	2009-01-25 11:38:32.000000000 -0500
--- flymake_mod.el	2009-01-25 11:44:06.000000000 -0500
***************
*** 67,72 ****
--- 67,76 ----
    "Same as `flymake-err-info', effective when a syntax check is in progress.")
  (make-variable-buffer-local 'flymake-new-err-info)
  
+ (defvar  flymake-split-output-pattern "[\n\r]+"
+   "Regular expression used to split the output into individual error/warning messages")
+ (make-variable-buffer-local 'flymake-split-output-pattern)
+ 
  ;;;; [[ cross-emacs compatibility routines
  (defsubst flymake-makehash (&optional test)
    (if (fboundp 'make-hash-table)
***************
*** 863,869 ****
  Return last one as residual if it does not end with newline char.
  Returns ((LINES) RESIDUAL)."
    (when (and output (> (length output) 0))
!     (let* ((lines (flymake-split-string output "[\n\r]+"))
  	   (complete (equal "\n" (char-to-string (aref output (1- (length output))))))
  	   (residual nil))
        (when (not complete)
--- 867,873 ----
  Return last one as residual if it does not end with newline char.
  Returns ((LINES) RESIDUAL)."
    (when (and output (> (length output) 0))
!     (let* ((lines (flymake-split-string output  flymake-split-output-pattern))
  	   (complete (equal "\n" (char-to-string (aref output (1- (length output))))))
  	   (residual nil))
        (when (not complete)

--=-ItEAY3Nq2y9DYRrucCxP--






Acknowledgement sent to Joseph Donaldson <donaldsonjw@HIDDEN>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs@HIDDEN>. Full text available.
Report forwarded to bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>:
bug#2048; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 31 Oct 2014 17:00:04 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.