GNU logs - #20481, boring messages


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; Newlines in message-box output don't work on Windows
Resent-From: Adam Connor <adamc55@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 01 May 2015 03:19:02 +0000
Resent-Message-ID: <handler.20481.B.14304503307237 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 20481 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.14304503307237
          (code B ref -1); Fri, 01 May 2015 03:19:02 +0000
Received: (at submit) by debbugs.gnu.org; 1 May 2015 03:18:50 +0000
Received: from localhost ([127.0.0.1]:57996 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Yo1TV-0001se-8d
	for submit <at> debbugs.gnu.org; Thu, 30 Apr 2015 23:18:50 -0400
Received: from eggs.gnu.org ([208.118.235.92]:54610)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <adamc55@HIDDEN>) id 1Yo1TR-0001sJ-9K
 for submit <at> debbugs.gnu.org; Thu, 30 Apr 2015 23:18:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <adamc55@HIDDEN>) id 1Yo1TK-0005Vj-4R
 for submit <at> debbugs.gnu.org; Thu, 30 Apr 2015 23:18:39 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50,
 FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,T_DKIM_INVALID
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:48225)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <adamc55@HIDDEN>) id 1Yo1TK-0005Vf-11
 for submit <at> debbugs.gnu.org; Thu, 30 Apr 2015 23:18:38 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39882)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <adamc55@HIDDEN>) id 1Yo1TI-0007YQ-70
 for bug-gnu-emacs@HIDDEN; Thu, 30 Apr 2015 23:18:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <adamc55@HIDDEN>) id 1Yo1TG-0005VH-J6
 for bug-gnu-emacs@HIDDEN; Thu, 30 Apr 2015 23:18:36 -0400
Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:36824)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <adamc55@HIDDEN>) id 1Yo1TG-0005VB-Bw
 for bug-gnu-emacs@HIDDEN; Thu, 30 Apr 2015 23:18:34 -0400
Received: by obbkp3 with SMTP id kp3so3616683obb.3
 for <bug-gnu-emacs@HIDDEN>; Thu, 30 Apr 2015 20:18:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:from:date:message-id:subject:to:content-type;
 bh=KI7MPP92WVt2pQZCw4ao2jryBKd+ZURwogGqxI5+7UU=;
 b=H1mj5nQP6Vhm8a9eDF8Lh8hVRLxDLGG4Jd6tLcYJXwkwMHg7RTsOBYD1bvY0gOIe/+
 b8kmrqEIV5R7tsLPe9yYeNNTod/BsYJJaF1Ua8GHIpF1EA39i0R0BYUUIWfBg3DmQp5X
 esE96KdkifGFcO+hnY9t3TYI6omP+E+D6jUR1m/1P62HVMsjePkLXb81i4xcCkBKxAKw
 2EJ7gFzjmaHq4PJCd1qahfNqk/2b/L16i8yf8gg2Q3wfQ33ZfA0wsmRZsAXxXzHdCCxZ
 ODi27A4abOg1mMtsgEVZugks+lP8MyikkbHdyNPIm0WCh2f86ZIrOLVs7VwHAmjSI7JK
 rpkQ==
X-Received: by 10.202.206.144 with SMTP id e138mr5899302oig.132.1430450313342; 
 Thu, 30 Apr 2015 20:18:33 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.202.63.9 with HTTP; Thu, 30 Apr 2015 20:18:13 -0700 (PDT)
From: Adam Connor <adamc55@HIDDEN>
Date: Thu, 30 Apr 2015 22:18:13 -0500
Message-ID: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
Content-Type: multipart/alternative; boundary=001a113ad9f0cbb5a40514fcaaf2
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -3.8 (---)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.8 (---)

--001a113ad9f0cbb5a40514fcaaf2
Content-Type: text/plain; charset=UTF-8

If I display a message using message-box, newlines seem to be ignored.
For example
    (message-box "secret\nmessage")

will show the message "secretmessage". I have also tried \r\n with the
same result.

Not a huge problem but annoying...



In GNU Emacs 24.5.1 (x86_64-w64-mingw32)
 of 2015-04-11 on KAEL
Windowing system distributor `Microsoft Corp.', version 6.3.9600
Configured using:
 `configure --prefix=/z/emacs --host=x86_64-w64-mingw32
 --target=x86_64-w64-mingw32 --build=x86_64-w64-mingw32 --with-wide-int
 --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2
 --with-gnutls --with-sound=yes --with-file-notification=yes
 --without-dbus --without-imagemagick 'CFLAGS=-Ofast
 -fomit-frame-pointer -funroll-loops -g0 -pipe' 'LDFLAGS=-static-libgcc
 -static-libstdc++ -static -s -Wl,-s''

Important settings:
  value of $LANG: ENU
  locale-coding-system: utf-8

Major mode: Emacs-Lisp

Minor modes in effect:
  my-keys-minor-mode: t
  tabbar-mwheel-mode: t
  tabbar-mode: t
  global-nlinum-mode: t
  nlinum-mode: t
  diff-auto-refine-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  recentf-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Auto-saving...
Quit
Saving file c:/Users/Adam/.emacs.d/elisp/file-utils.el...
Wrote c:/Users/Adam/.emacs.d/elisp/file-utils.el
file-older-than
Quit
Saving file c:/Users/Adam/.emacs.d/elisp/file-utils.el...
Wrote c:/Users/Adam/.emacs.d/elisp/file-utils.el
file-older-than
Wrote c:/Users/Adam/.emacs.d/packages-updated.txt
nil

Load-path shadows:
~/.emacs.d/lib/tabbar-master/revive hides ~/.emacs.d/lib/revive
c:/Users/Adam/.emacs.d/elpa/dash-2.10.0/dash hides ~/.emacs.d/lib/dash
~/.emacs.d/lib/indent hides
c:/dev/emacs-w64-24.5/share/emacs/24.5/lisp/indent

Features:
(shadow sort mail-extr emacsbug sendmail debug eieio-opt speedbar
sb-image ezimage dframe find-func geiser-mode geiser-xref geiser-chicken
geiser-racket geiser-guile geiser-repl geiser-image geiser-compile
geiser-debug geiser-company geiser-doc geiser-menu geiser-autodoc eldoc
info-look geiser geiser-edit etags geiser-completion geiser-eval
geiser-connection tq geiser-syntax rx geiser-log geiser-popup view
geiser-impl geiser-custom geiser-base tar-mode thingatpt cmuscheme
scheme tabify autoload misearch multi-isearch lisp-mnt help-mode
mule-util gnutls mm-archive network-stream starttls url-cache
url-handlers finder-inf vc-git tabbar revbufs fill-column-indicator
nlinum linum virtualenvwrapper dash vc-svn psvn derived log-edit message
format-spec rfc822 mml mml-sec mailabbrev mail-utils gmm-utils
mailheader pcvs-util add-log diff-mode pp elp ediff-merg ediff-wind
ediff-diff ediff-mult ediff-help ediff-init ediff-util dired rdp-utils
web-mode flymake compile python json comint ring ansi-color util
undo-tree soap-client mm-decode mm-bodies mm-encode url-http tls
url-auth mail-parse rfc2231 rfc2047 rfc2045 ietf-drums url-gw url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source eieio byte-opt bytecomp
byte-compile cl-extra cconv eieio-core gnus-util mm-util mail-prsvr
password-cache url-vars mailcap warnings xml easy-mmode virtualenv-utils
env-utils proj-utils cl-macs s cl gv ido edmacro kmacro ibuffer
framemove advice help-fns ehelp editorconfig file-utils recentf
tree-widget wid-edit desktop frameset cl-loaddefs cl-lib info easymenu
package epg-config misterioso-theme library-utils time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32
ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
w32notify w32 multi-tty emacs)

Memory information:
((conses 16 699525 109272)
 (symbols 56 35736 0)
 (miscs 48 3413 2679)
 (strings 32 87577 14382)
 (string-bytes 1 2273331)
 (vectors 16 37061)
 (vector-slots 8 1409654 155048)
 (floats 8 159 939)
 (intervals 56 66830 766)
 (buffers 960 23))

--001a113ad9f0cbb5a40514fcaaf2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">If I display a message using message-box, newlines seem to=
 be ignored.<br>For example<br>=C2=A0=C2=A0=C2=A0 (message-box &quot;secret=
\nmessage&quot;)<br><br>will show the message &quot;secretmessage&quot;. I =
have also tried \r\n with the<br>same result.<br><br>Not a huge problem but=
 annoying...<br><br><br><br>In GNU Emacs 24.5.1 (x86_64-w64-mingw32)<br>=C2=
=A0of 2015-04-11 on KAEL<br>Windowing system distributor `Microsoft Corp.&#=
39;, version 6.3.9600<br>Configured using:<br>=C2=A0`configure --prefix=3D/=
z/emacs --host=3Dx86_64-w64-mingw32<br>=C2=A0--target=3Dx86_64-w64-mingw32 =
--build=3Dx86_64-w64-mingw32 --with-wide-int<br>=C2=A0--with-jpeg --with-xp=
m --with-png --with-tiff --with-rsvg --with-xml2<br>=C2=A0--with-gnutls --w=
ith-sound=3Dyes --with-file-notification=3Dyes<br>=C2=A0--without-dbus --wi=
thout-imagemagick &#39;CFLAGS=3D-Ofast<br>=C2=A0-fomit-frame-pointer -funro=
ll-loops -g0 -pipe&#39; &#39;LDFLAGS=3D-static-libgcc<br>=C2=A0-static-libs=
tdc++ -static -s -Wl,-s&#39;&#39;<br><br>Important settings:<br>=C2=A0 valu=
e of $LANG: ENU<br>=C2=A0 locale-coding-system: utf-8<br><br>Major mode: Em=
acs-Lisp<br><br>Minor modes in effect:<br>=C2=A0 my-keys-minor-mode: t<br>=
=C2=A0 tabbar-mwheel-mode: t<br>=C2=A0 tabbar-mode: t<br>=C2=A0 global-nlin=
um-mode: t<br>=C2=A0 nlinum-mode: t<br>=C2=A0 diff-auto-refine-mode: t<br>=
=C2=A0 global-undo-tree-mode: t<br>=C2=A0 undo-tree-mode: t<br>=C2=A0 recen=
tf-mode: t<br>=C2=A0 desktop-save-mode: t<br>=C2=A0 tooltip-mode: t<br>=C2=
=A0 electric-indent-mode: t<br>=C2=A0 mouse-wheel-mode: t<br>=C2=A0 menu-ba=
r-mode: t<br>=C2=A0 file-name-shadow-mode: t<br>=C2=A0 global-font-lock-mod=
e: t<br>=C2=A0 font-lock-mode: t<br>=C2=A0 blink-cursor-mode: t<br>=C2=A0 a=
uto-composition-mode: t<br>=C2=A0 auto-encryption-mode: t<br>=C2=A0 auto-co=
mpression-mode: t<br>=C2=A0 line-number-mode: t<br>=C2=A0 transient-mark-mo=
de: t<br><br>Recent messages:<br>Auto-saving...<br>Quit<br>Saving file c:/U=
sers/Adam/.emacs.d/elisp/file-utils.el...<br>Wrote c:/Users/Adam/.emacs.d/e=
lisp/file-utils.el<br>file-older-than<br>Quit<br>Saving file c:/Users/Adam/=
.emacs.d/elisp/file-utils.el...<br>Wrote c:/Users/Adam/.emacs.d/elisp/file-=
utils.el<br>file-older-than<br>Wrote c:/Users/Adam/.emacs.d/packages-update=
d.txt<br>nil<br><br>Load-path shadows:<br>~/.emacs.d/lib/tabbar-master/revi=
ve hides ~/.emacs.d/lib/revive<br>c:/Users/Adam/.emacs.d/elpa/dash-2.10.0/d=
ash hides ~/.emacs.d/lib/dash<br>~/.emacs.d/lib/indent hides c:/dev/emacs-w=
64-24.5/share/emacs/24.5/lisp/indent<br><br>Features:<br>(shadow sort mail-=
extr emacsbug sendmail debug eieio-opt speedbar<br>sb-image ezimage dframe =
find-func geiser-mode geiser-xref geiser-chicken<br>geiser-racket geiser-gu=
ile geiser-repl geiser-image geiser-compile<br>geiser-debug geiser-company =
geiser-doc geiser-menu geiser-autodoc eldoc<br>info-look geiser geiser-edit=
 etags geiser-completion geiser-eval<br>geiser-connection tq geiser-syntax =
rx geiser-log geiser-popup view<br>geiser-impl geiser-custom geiser-base ta=
r-mode thingatpt cmuscheme<br>scheme tabify autoload misearch multi-isearch=
 lisp-mnt help-mode<br>mule-util gnutls mm-archive network-stream starttls =
url-cache<br>url-handlers finder-inf vc-git tabbar revbufs fill-column-indi=
cator<br>nlinum linum virtualenvwrapper dash vc-svn psvn derived log-edit m=
essage<br>format-spec rfc822 mml mml-sec mailabbrev mail-utils gmm-utils<br=
>mailheader pcvs-util add-log diff-mode pp elp ediff-merg ediff-wind<br>edi=
ff-diff ediff-mult ediff-help ediff-init ediff-util dired rdp-utils<br>web-=
mode flymake compile python json comint ring ansi-color util<br>undo-tree s=
oap-client mm-decode mm-bodies mm-encode url-http tls<br>url-auth mail-pars=
e rfc2231 rfc2047 rfc2045 ietf-drums url-gw url<br>url-proxy url-privacy ur=
l-expand url-methods url-history url-cookie<br>url-domsuf url-util url-pars=
e auth-source eieio byte-opt bytecomp<br>byte-compile cl-extra cconv eieio-=
core gnus-util mm-util mail-prsvr<br>password-cache url-vars mailcap warnin=
gs xml easy-mmode virtualenv-utils<br>env-utils proj-utils cl-macs s cl gv =
ido edmacro kmacro ibuffer<br>framemove advice help-fns ehelp editorconfig =
file-utils recentf<br>tree-widget wid-edit desktop frameset cl-loaddefs cl-=
lib info easymenu<br>package epg-config misterioso-theme library-utils time=
-date tooltip<br>electric uniquify ediff-hook vc-hooks lisp-float-type mwhe=
el dos-w32<br>ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar d=
nd fontset<br>image regexp-opt fringe tabulated-list newcomment lisp-mode p=
rog-mode<br>register page menu-bar rfn-eshadow timer select scroll-bar mous=
e<br>jit-lock font-lock syntax facemenu font-core frame cham georgian<br>ut=
f-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean<br>japanese =
hebrew greek romanian slovak czech european ethiopic indian<br>cyrillic chi=
nese case-table epa-hook jka-cmpr-hook help simple abbrev<br>minibuffer nad=
vice loaddefs button faces cus-face macroexp files<br>text-properties overl=
ay sha1 md5 base64 format env code-pages mule<br>custom widget hashtable-pr=
int-readable backquote make-network-process<br>w32notify w32 multi-tty emac=
s)<br><br>Memory information:<br>((conses 16 699525 109272)<br>=C2=A0(symbo=
ls 56 35736 0)<br>=C2=A0(miscs 48 3413 2679)<br>=C2=A0(strings 32 87577 143=
82)<br>=C2=A0(string-bytes 1 2273331)<br>=C2=A0(vectors 16 37061)<br>=C2=A0=
(vector-slots 8 1409654 155048)<br>=C2=A0(floats 8 159 939)<br>=C2=A0(inter=
vals 56 66830 766)<br>=C2=A0(buffers 960 23))<br><br></div>

--001a113ad9f0cbb5a40514fcaaf2--




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Adam Connor <adamc55@HIDDEN>
Subject: bug#20481: Acknowledgement (24.5; Newlines in message-box output
 don't work on Windows)
Message-ID: <handler.20481.B.14304503307237.ack <at> debbugs.gnu.org>
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
X-Gnu-PR-Message: ack 20481
X-Gnu-PR-Package: emacs
Reply-To: 20481 <at> debbugs.gnu.org
Date: Fri, 01 May 2015 03:19:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 20481 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
20481: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20481
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 01 May 2015 07:20:04 +0000
Resent-Message-ID: <handler.20481.B20481.143046475530450 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Adam Connor <adamc55@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.143046475530450
          (code B ref 20481); Fri, 01 May 2015 07:20:04 +0000
Received: (at 20481) by debbugs.gnu.org; 1 May 2015 07:19:15 +0000
Received: from localhost ([127.0.0.1]:58069 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Yo5EA-0007v2-KP
	for submit <at> debbugs.gnu.org; Fri, 01 May 2015 03:19:15 -0400
Received: from mtaout23.012.net.il ([80.179.55.175]:49401)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <eliz@HIDDEN>) id 1Yo5E7-0007um-Gh
 for 20481 <at> debbugs.gnu.org; Fri, 01 May 2015 03:19:12 -0400
Received: from conversion-daemon.a-mtaout23.012.net.il by
 a-mtaout23.012.net.il (HyperSendmail v2007.08) id
 <0NNN00900TDG1900@HIDDEN> for 20481 <at> debbugs.gnu.org;
 Fri, 01 May 2015 10:19:05 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il
 (HyperSendmail v2007.08) with ESMTPA id
 <0NNN008F4TNSYX50@HIDDEN>;
 Fri, 01 May 2015 10:19:05 +0300 (IDT)
Date: Fri, 01 May 2015 10:19:05 +0300
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
X-012-Sender: halo1@HIDDEN
Message-id: <83ioccsr2u.fsf@HIDDEN>
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

> From: Adam Connor <adamc55@HIDDEN>
> Date: Thu, 30 Apr 2015 22:18:13 -0500
> 
> If I display a message using message-box, newlines seem to be ignored.
> For example
> (message-box "secret\nmessage")
> 
> will show the message "secretmessage". I have also tried \r\n with the
> same result.
> 
> Not a huge problem but annoying...

Emacs on Windows doesn't really support message boxes (a.k.a. "dialog
boxes"), except for simple Yes/No questions popped up by yes-or-no-p.
For other messages, such as this one, Emacs on Windows emulates dialog
boxes by menus, and in a menu an item cannot contain a newline.

In this case, we faithfully pass the original string with a newline to
the MS-Windows menu API, and I believe it is dropped by Windows when
it displays the menu.

IOW, this is a missing feature: dialog boxes are not fully supported
on MS-Windows.




Message received at control <at> debbugs.gnu.org:


Received: (at control) by debbugs.gnu.org; 1 May 2015 07:20:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 01 03:20:42 2015
Received: from localhost ([127.0.0.1]:58073 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1Yo5Fa-0007xO-KL
	for submit <at> debbugs.gnu.org; Fri, 01 May 2015 03:20:42 -0400
Received: from mtaout23.012.net.il ([80.179.55.175]:49460)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <eliz@HIDDEN>) id 1Yo5FX-0007x8-M8
 for control <at> debbugs.gnu.org; Fri, 01 May 2015 03:20:40 -0400
Received: from conversion-daemon.a-mtaout23.012.net.il by
 a-mtaout23.012.net.il (HyperSendmail v2007.08) id
 <0NNN00900TDG1900@HIDDEN> for control <at> debbugs.gnu.org;
 Fri, 01 May 2015 10:20:34 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il
 (HyperSendmail v2007.08) with ESMTPA id
 <0NNN008MWTQ9YX50@HIDDEN> for control <at> debbugs.gnu.org;
 Fri, 01 May 2015 10:20:34 +0300 (IDT)
Date: Fri, 01 May 2015 10:20:34 +0300
From: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#20481: 24.5;
 Newlines in message-box output don't work on Windows
In-reply-to: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
X-012-Sender: halo1@HIDDEN
To: control <at> debbugs.gnu.org
Message-id: <83h9rwsr0d.fsf@HIDDEN>
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: Eli Zaretskii <eliz@HIDDEN>
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

severity 20481 wishlist
thanks




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 02 May 2015 06:34:02 +0000
Resent-Message-ID: <handler.20481.B20481.14305484223944 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Adam Connor <adamc55@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.14305484223944
          (code B ref 20481); Sat, 02 May 2015 06:34:02 +0000
Received: (at 20481) by debbugs.gnu.org; 2 May 2015 06:33:42 +0000
Received: from localhost ([127.0.0.1]:59068 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YoQze-00011X-7C
	for submit <at> debbugs.gnu.org; Sat, 02 May 2015 02:33:42 -0400
Received: from mtaout22.012.net.il ([80.179.55.172]:43575)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <eliz@HIDDEN>) id 1YoQza-00011D-SO
 for 20481 <at> debbugs.gnu.org; Sat, 02 May 2015 02:33:40 -0400
Received: from conversion-daemon.a-mtaout22.012.net.il by
 a-mtaout22.012.net.il (HyperSendmail v2007.08) id
 <0NNP00I00M4TDC00@HIDDEN> for 20481 <at> debbugs.gnu.org;
 Sat, 02 May 2015 09:33:32 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il
 (HyperSendmail v2007.08) with ESMTPA id
 <0NNP00IVHM7V6G40@HIDDEN>;
 Sat, 02 May 2015 09:33:32 +0300 (IDT)
Date: Sat, 02 May 2015 09:33:15 +0300
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAC_vAoGvLFr--qNihU+MDpyZPhZEysz02hCOOWVE4otubmRJWg@HIDDEN>
X-012-Sender: halo1@HIDDEN
Message-id: <83a8xnqyj8.fsf@HIDDEN>
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <83ioccsr2u.fsf@HIDDEN>
 <CAC_vAoGvLFr--qNihU+MDpyZPhZEysz02hCOOWVE4otubmRJWg@HIDDEN>
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

> From: Adam Connor <adamc55@HIDDEN>
> Date: Fri, 1 May 2015 15:22:29 -0500
> 
> Thanks for explaining. That's unfortunate.

Patches to have Emacs on Windows support dialog boxes are welcome.
There's already code there, currently ifdef'ed away, which is
incomplete and "needs work".




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5;, Newlines in message-box output don't work on Windows
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
In-Reply-To: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 19 Aug 2024 16:15:02 +0000
Resent-Message-ID: <handler.20481.B20481.17240840633076 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 20481 <at> debbugs.gnu.org
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.17240840633076
          (code B ref 20481); Mon, 19 Aug 2024 16:15:02 +0000
Received: (at 20481) by debbugs.gnu.org; 19 Aug 2024 16:14:23 +0000
Received: from localhost ([127.0.0.1]:58990 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sg51T-0000nX-7q
	for submit <at> debbugs.gnu.org; Mon, 19 Aug 2024 12:14:23 -0400
Received: from mail.imayhem.com ([82.223.54.191]:54349
 helo=zealous-pike.82-223-54-191.plesk.page)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpardo@HIDDEN>) id 1sg51R-0000nC-3V
 for 20481 <at> debbugs.gnu.org; Mon, 19 Aug 2024 12:14:22 -0400
Received: from [192.168.68.105] (111.red-88-21-7.staticip.rima-tde.net
 [88.21.7.111])
 by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 161F180250
 for <20481 <at> debbugs.gnu.org>; Mon, 19 Aug 2024 16:13:32 +0000 (UTC)
Authentication-Results: zealous-pike.82-223-54-191.plesk.page;
 spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@HIDDEN
 smtp.helo=[192.168.68.105]
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Content-Type: multipart/mixed; boundary="------------iNkfdT9n6OLn00m1a0F9ROO0"
Message-ID: <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
Date: Mon, 19 Aug 2024 18:13:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: es-ES
From: Cecilio Pardo <cpardo@HIDDEN>
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------iNkfdT9n6OLn00m1a0F9ROO0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

This patch adds support on Windows Vista an later for dialog boxes using 
TaskDialog.



--------------iNkfdT9n6OLn00m1a0F9ROO0
Content-Type: text/plain; charset=UTF-8; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy93MzJtZW51LmMgYi9zcmMvdzMybWVudS5jCmluZGV4IGNlYTRm
NDg5MmE0Li4wMjllNGJiZjgwNSAxMDA2NDQKLS0tIGEvc3JjL3czMm1lbnUuYworKysgYi9z
cmMvdzMybWVudS5jCkBAIC01Miw2ICs1Miw5IEBACiAKICNpbmNsdWRlICJ3MzJjb21tb24u
aCIJLyogZm9yIG9zaW5mb19jYWNoZSAqLwogCisjaW5jbHVkZSAiY29tbWN0cmwuaCIKKwor
LyogVGhpcyBvbmx5IGFwcGxpZXMgdG8gT1MgdmVyc2lvbnMgcHJpb3IgdG8gVmlzdGEuICov
CiAjdW5kZWYgSEFWRV9ESUFMT0dTIC8qIFRPRE86IEltcGxlbWVudCBuYXRpdmUgZGlhbG9n
cy4gICovCiAKICNpZm5kZWYgVFJVRQpAQCAtMTAxLDE0ICsxMDQsMTQ4IEBAICNkZWZpbmUg
RkFMU0UgMAogCiB2b2lkIHczMl9mcmVlX21lbnVfc3RyaW5ncyAoSFdORCk7CiAKKworI2Rl
ZmluZSBUQVNLX0RJQUxPR19NQVhfQlVUVE9OUyA9IDEwOworCitzdGF0aWMgSFJFU1VMVAor
dGFza19kaWFsb2dfY2FsbGJhY2soSFdORCBod25kLCBVSU5UIG1zZywgV1BBUkFNIHdQYXJh
bSwKKwkJICAgICBMUEFSQU0gbFBhcmFtLCBMT05HX1BUUiBjYWxsYmFja19kYXRhKQorewor
ICBzd2l0Y2ggKG1zZykKKyAgICB7CisgICAgY2FzZSBURE5fQ1JFQVRFRDoKKyAgICAgIC8q
IERpc2FibGUgYWxsIGJ1dHRvbnMgd2l0aCBJRCA+PSAyMDAwICovCisgICAgICBmb3IgKGlu
dCBpID0gMDsgaSA8IFRBU0tfRElBTE9HX01BWF9CVVRUT05TOyBpKyspCisJU2VuZE1lc3Nh
Z2UoIGh3bmQsIFRETV9FTkFCTEVfQlVUVE9OLCAyMDAwICsgaSwgRkFMU0UgKTsKKyAgICAg
IGJyZWFrOworICAgIH0KKyAgcmV0dXJuIFNfT0s7Cit9CisKIExpc3BfT2JqZWN0CiB3MzJf
cG9wdXBfZGlhbG9nIChzdHJ1Y3QgZnJhbWUgKmYsIExpc3BfT2JqZWN0IGhlYWRlciwgTGlz
cF9PYmplY3QgY29udGVudHMpCiB7Ci0KICAgY2hlY2tfd2luZG93X3N5c3RlbSAoZik7CiAK
LSNpZm5kZWYgSEFWRV9ESUFMT0dTCisgIHZvaWQgKnRhc2tfZGlhbG9nX2luZGlyZWN0ID0K
KyAgICBnZXRfcHJvY19hZGRyIChHZXRNb2R1bGVIYW5kbGUgKCJjb21jdGwzMi5kbGwiKSwg
IlRhc2tEaWFsb2dJbmRpcmVjdCIpOworCisgIGlmICh0YXNrX2RpYWxvZ19pbmRpcmVjdCkK
KyAgICB7CisgICAgICAvKiBHZXQgdGhlIHRpdGxlIGFzIGEgVVRGLTE2IHN0cmluZy4gKi8K
KyAgICAgIENIRUNLX1NUUklORyAoWENBUiAoY29udGVudHMpKTsKKyAgICAgIGNoYXIgKnRp
dGxlID0gIFNTREFUQSAoWENBUiAoY29udGVudHMpKTsKKyAgICAgIGludCB3aWRlX2xlbmd0
aCA9IHNpemVvZihXQ0hBUikgKgorCXBNdWx0aUJ5dGVUb1dpZGVDaGFyIChDUF9VVEY4LCAw
LCB0aXRsZSwgLTEsIE5VTEwsIDApOworICAgICAgV0NIQVIgKnRpdGxlX3RleHRfd2lkZSA9
IGFsbG9jYSAod2lkZV9sZW5ndGgpOworICAgICAgcE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQ
X1VURjgsIDAsIHRpdGxlLCAtMSwKKwkJCSAgICB0aXRsZV90ZXh0X3dpZGUsIHdpZGVfbGVu
Z3RoKTsKKworICAgICAgLyogUHJlcGFyZSB0aGUgc3RydWN0IHdpdGggdGhlIGRpYWxvZydz
IGJ1dHRvbnMuICovCisgICAgICBUQVNLRElBTE9HX0JVVFRPTiBidXR0b25zW1RBU0tfRElB
TE9HX01BWF9CVVRUT05TXTsKKyAgICAgIExpc3BfT2JqZWN0IGJ1dHRvbl92YWx1ZXNbVEFT
S19ESUFMT0dfTUFYX0JVVFRPTlNdOworICAgICAgaW50IGJ1dHRvbl9jb3VudCA9IDA7Cisg
ICAgICBMaXNwX09iamVjdCBiID0gWENEUiAoY29udGVudHMpOworCisgICAgICB3aGlsZSAo
ICFOSUxQIChiKSApIHsKKwlpZiAoIGJ1dHRvbl9jb3VudCA+PSBUQVNLX0RJQUxPR19NQVhf
QlVUVE9OUyApCisJICB7CisJICAgIC8qIFdlIGhhdmUgdG9vIG1hbnkgYnV0dG9ucy4gV2Ug
aWdub3JlIHRoZSByZXN0LiAqLworCSAgICBicmVhazsKKwkgIH0KKworCUxpc3BfT2JqZWN0
IGl0ZW0gPSBYQ0FSKGIpOworCisJaWYgKEZjb25zcCAoaXRlbSkpCisJICB7CisJICAgIC8q
IEEgbm9ybWFsIGl0ZW0gKHRleHQgLiB2YWx1ZSkgKi8KKwkgICAgTGlzcF9PYmplY3QgaXRl
bV9uYW1lID0gWENBUiAoaXRlbSk7CisJICAgIExpc3BfT2JqZWN0IGl0ZW1fdmFsdWUgPSBY
Q0RSIChpdGVtKTsKKworCSAgICBDSEVDS19TVFJJTkcgKGl0ZW1fbmFtZSk7CisKKwkgICAg
aW50IHdpZGVfbGVuZ3RoID0gc2l6ZW9mKFdDSEFSKSAqCisJICAgICAgcE11bHRpQnl0ZVRv
V2lkZUNoYXIgKENQX1VURjgsIDAsIFNTREFUQSAoaXRlbV9uYW1lKSwgLTEsCisJCQkJICAg
IE5VTEwsIDApOworCSAgICBidXR0b25zW2J1dHRvbl9jb3VudF0ucHN6QnV0dG9uVGV4dCA9
IGFsbG9jYSAod2lkZV9sZW5ndGgpOworCSAgICBwTXVsdGlCeXRlVG9XaWRlQ2hhciAoQ1Bf
VVRGOCwgMCwgU1NEQVRBIChpdGVtX25hbWUpLCAtMSwKKwkJCQkgIChMUFdTVFIpCisJCQkJ
ICBidXR0b25zW2J1dHRvbl9jb3VudF0ucHN6QnV0dG9uVGV4dCwKKwkJCQkgIHdpZGVfbGVu
Z3RoKTsKKwkgICAgYnV0dG9uc1tidXR0b25fY291bnRdLm5CdXR0b25JRCA9IDEwMDAgKyBi
dXR0b25fY291bnQ7CisJICAgIGJ1dHRvbl92YWx1ZXNbYnV0dG9uX2NvdW50KytdID0gaXRl
bV92YWx1ZTsKKwkgIH0KKwllbHNlIGlmIChOSUxQIChpdGVtKSkKKwkgIHsKKwkgICAgLyog
QSBuaWwgaXRlbSBtZWFucyB0byBwdXQgYWxsIGZvbGxvd2luZyBpdGVtcyBvbiB0aGUKKwkg
ICAgICAgcmlnaHQuIFdlIGlnbm9yZSB0aGlzLiAqLworCSAgfQorCWVsc2UgaWYgKFNUUklO
R1AoaXRlbSkpCisJICB7CisJICAgIC8qIEEgc3RyaW5nIGl0ZW0gbWVhbnMgYW4gdW5zZWxl
Y3RhYmxlIGJ1dHRvbi4gV2UgYWRkIGEKKwkgICAgICAgYnV0dG9uLCBhbiB0aGVuIG5lZWQg
dG8gZGlzYWJsZSBpdCBvbiB0aGUgY2FsbGJhY2suCisJICAgICAgIFdlIHVzZSBpZHMgYmFz
ZWQgb24gMjAwMCB0byBtYXJrIHRoZXNlIGJ1dHRvbnMgKi8KKwkgICAgaW50IHdpZGVfbGVu
Z3RoID0gc2l6ZW9mKFdDSEFSKSAqCisJICAgICAgcE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQ
X1VURjgsIDAsIFNTREFUQSAoaXRlbSksIC0xLCBOVUxMLCAwKTsKKwkgICAgYnV0dG9uc1ti
dXR0b25fY291bnRdLnBzekJ1dHRvblRleHQgPSBhbGxvY2EgKHdpZGVfbGVuZ3RoKTsKKwkg
ICAgcE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAsIFNTREFUQSAoaXRlbSksIC0x
LAorCQkJCSAgKExQV1NUUikKKwkJCQkgIGJ1dHRvbnNbYnV0dG9uX2NvdW50XS5wc3pCdXR0
b25UZXh0LAorCQkJCSAgd2lkZV9sZW5ndGgpOworCSAgICBidXR0b25zW2J1dHRvbl9jb3Vu
dF0ubkJ1dHRvbklEID0gMjAwMCArIGJ1dHRvbl9jb3VudDsKKwkgICAgYnV0dG9uX3ZhbHVl
c1tidXR0b25fY291bnQrK10gPSBRbmlsOworCSAgfQorCisJYiA9IFhDRFIgKGIpOworICAg
ICAgfQorCisgICAgICBpbnQgcHJlc3NlZF9idXR0b24gPSAwOworCisgICAgICBUQVNLRElB
TE9HQ09ORklHIGNvbmZpZyA9IHsgfTsKKyAgICAgIGNvbmZpZy5od25kUGFyZW50ID0gRlJB
TUVfVzMyX1dJTkRPVyAoZik7CisgICAgICBjb25maWcuY2JTaXplID0gc2l6ZW9mKGNvbmZp
Zyk7CisgICAgICBjb25maWcuaEluc3RhbmNlID0gaGluc3Q7CisgICAgICBjb25maWcuZHdG
bGFncyA9IFRERl9BTExPV19ESUFMT0dfQ0FOQ0VMTEFUSU9OOworICAgICAgY29uZmlnLnBm
Q2FsbGJhY2sgPSB0YXNrX2RpYWxvZ19jYWxsYmFjazsKKworICAgICAgY29uZmlnLnBzeldp
bmRvd1RpdGxlID0gTCJRdWVzdGlvbiI7CisgICAgICBpZiAoIU5JTFAgKGhlYWRlcikpCisJ
eworCSAgY29uZmlnLnBzeldpbmRvd1RpdGxlID0gTCJJbmZvcm1hdGlvbiI7CisJICBjb25m
aWcucHN6TWFpbkljb24gPSBURF9JTkZPUk1BVElPTl9JQ09OOworCX0KIAorICAgICAgY29u
ZmlnLnBzek1haW5JbnN0cnVjdGlvbiA9IHRpdGxlX3RleHRfd2lkZTsKKyAgICAgIGNvbmZp
Zy5wQnV0dG9ucyA9IGJ1dHRvbnM7CisgICAgICBjb25maWcuY0J1dHRvbnMgPSBidXR0b25f
Y291bnQ7CisKKyAgICAgIGlmICghU1VDQ0VFREVEIChUYXNrRGlhbG9nSW5kaXJlY3QgKCZj
b25maWcsICZwcmVzc2VkX2J1dHRvbiwKKwkJCQkJICBOVUxMLCBOVUxMKSkpCisJcmV0dXJu
IHF1aXQgKCk7CisKKworICAgICAgc3dpdGNoIChwcmVzc2VkX2J1dHRvbikKKwl7CisJY2Fz
ZSBJRE9LOgorCSAgLyogVGhpcyBjYW4gb25seSBoYXBwZW4gaWYgbm8gYnV0dG9ucyB3aGVy
ZQorCSAgICAgcHJvdmlkZWQuIEFuIE9LIGJ1dHRvbiBpcyBhdXRvbWF0aWNhbGx5IGFkZGVk
LiAqLworCSAgcmV0dXJuIFF0OworCWNhc2UgSURDQU5DRUw6CisJICAvKiBUaGUgdXNlciBj
bG9zZWQgdGhlIGRpYWxvZyB3aXRob3V0IHVzaW5nIHRoZSBidXR0b25zICovCisJICByZXR1
cm4gcXVpdCgpOworCWRlZmF1bHQ6CisJICAvKiBPbmUgb2YgdGhlIHNwZWNpZmllZCBidXR0
b25zLiAqLworCSAgaW50IGJ1dHRvbl9pbmRleCA9IHByZXNzZWRfYnV0dG9uIC0gMTAwMDsK
KwkgIGlmICggYnV0dG9uX2luZGV4ID49IDAgJiYgYnV0dG9uX2luZGV4IDwgYnV0dG9uX2Nv
dW50ICkKKwkgICAgcmV0dXJuIGJ1dHRvbl92YWx1ZXNbYnV0dG9uX2luZGV4XTsKKwkgIHJl
dHVybiBxdWl0KCk7CisJfQorICAgIH0KKworICAvKiBJZiB3ZSBnZXQgaGVyZSwgVGFza0Rp
YWxvZyBpcyBub3Qgc3VwcG9ydGVkLiBVc2UgTWVzc2FnZUJveC9NZW51LiAqLworCisKKyNp
Zm5kZWYgSEFWRV9ESUFMT0dTCiAgIC8qIEhhbmRsZSBzaW1wbGUgWWVzL05vIGNob2ljZXMg
YXMgTWVzc2FnZUJveCBwb3B1cHMuICAqLwogICBpZiAoaXNfc2ltcGxlX2RpYWxvZyAoY29u
dGVudHMpKQogICAgIHJldHVybiBzaW1wbGVfZGlhbG9nX3Nob3cgKGYsIGNvbnRlbnRzLCBo
ZWFkZXIpOwo=

--------------iNkfdT9n6OLn00m1a0F9ROO0--




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 19 Aug 2024 17:46:01 +0000
Resent-Message-ID: <handler.20481.B20481.172408955313264 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.172408955313264
          (code B ref 20481); Mon, 19 Aug 2024 17:46:01 +0000
Received: (at 20481) by debbugs.gnu.org; 19 Aug 2024 17:45:53 +0000
Received: from localhost ([127.0.0.1]:59147 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sg6S1-0003Rs-2R
	for submit <at> debbugs.gnu.org; Mon, 19 Aug 2024 13:45:53 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37966)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sg6Rz-0003RY-28
 for 20481 <at> debbugs.gnu.org; Mon, 19 Aug 2024 13:45:51 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sg6RD-00037b-7S; Mon, 19 Aug 2024 13:45:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=84B9nx5ZcESbu6/Q6J3l4Caqk/HiR5yCrDu7/wKoPsg=; b=buQpI794YJpJ
 QyAQqfJVft0NJY+rlLEefQNe3v8uffcY0VslAjhyqZmaKf70VQuCEerzwL64Y252doHWd2slWKE70
 Loutaahox3EXMWifXmxoDhfIexvE3N8TnD9+2vC8QSacK5lxPlCyx6Vv2+1sHmuX7puGLkr2G00tW
 JfDBuIYqnLd1lJb35lLKO8qavDSXr7Wv6IxNL8VuY4xJNjXDVbh8nCXbLr3b+9aYHTU3q14UugFn6
 u0DP0QIvfz5Qedc2VF3jA8HR9y9Z4qzN96tILlhTSkyRT8IG6aPtJC7qltNlzESklKt9CcDTgfgkv
 kk9gefXLMpsV5etLzx3+Sw==;
Date: Mon, 19 Aug 2024 20:44:50 +0300
Message-Id: <86v7zwwgod.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN> (message from
 Cecilio Pardo on Mon, 19 Aug 2024 18:13:31 +0200)
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Mon, 19 Aug 2024 18:13:31 +0200
> From: Cecilio Pardo <cpardo@HIDDEN>
> 
> This patch adds support on Windows Vista an later for dialog boxes using 
> TaskDialog.

Thanks.

First, to accept a contribution of this size we'll need a
copyright-assignment paperwork from you.  Should I send you the form
to fill with instructions to go with it, so you could start the
paperwork rolling?

A few comments about the patch:

> +  void *task_dialog_indirect =
> +    get_proc_addr (GetModuleHandle ("comctl32.dll"), "TaskDialogIndirect");
> +
> +  if (task_dialog_indirect)

A minor optimization is to call get_proc_addr only once and save the
result in a static variable.  We use this technique in many places in
Emacs, and I see no reason not to do that here.

> +      /* Get the title as a UTF-16 string. */
> +      CHECK_STRING (XCAR (contents));
> +      char *title =  SSDATA (XCAR (contents));
> +      int wide_length = sizeof(WCHAR) *
> +	pMultiByteToWideChar (CP_UTF8, 0, title, -1, NULL, 0);
> +      WCHAR *title_text_wide = alloca (wide_length);
> +      pMultiByteToWideChar (CP_UTF8, 0, title, -1,
> +			    title_text_wide, wide_length);

The text of Lisp strings is stored by Emacs in a super-set of UTF-8,
so it cannot be safely passed to MultiByteToWideChar.  You need to
encode it in UTF-8 first (use ENCODE_UTF_8).

> +	    CHECK_STRING (item_name);
> +
> +	    int wide_length = sizeof(WCHAR) *
> +	      pMultiByteToWideChar (CP_UTF8, 0, SSDATA (item_name), -1,
> +				    NULL, 0);
> +	    buttons[button_count].pszButtonText = alloca (wide_length);
> +	    pMultiByteToWideChar (CP_UTF8, 0, SSDATA (item_name), -1,
> +				  (LPWSTR)
> +				  buttons[button_count].pszButtonText,
> +				  wide_length);

Same here.

> +	else if (NILP (item))
> +	  {
> +	    /* A nil item means to put all following items on the
> +	       right. We ignore this. */
                    ^^              ^^
Our convention is to leave two spaces between sentences in
documentation, comments, and strings.  We also leave two spaces at the
end of C comments, before the closing "*/" (here and elsewhere in the
patch).

> +	else if (STRINGP(item))
                       ^^
Another stylistic nit: please leave one space between the name of a
function/macro and the opening parenthesis that follows it (here and
elsewhere in the patch).

> +	    /* A string item means an unselectable button. We add a
> +	       button, an then need to disable it on the callback.
> +	       We use ids based on 2000 to mark these buttons */
> +	    int wide_length = sizeof(WCHAR) *
> +	      pMultiByteToWideChar (CP_UTF8, 0, SSDATA (item), -1, NULL, 0);
> +	    buttons[button_count].pszButtonText = alloca (wide_length);
> +	    pMultiByteToWideChar (CP_UTF8, 0, SSDATA (item), -1,
> +				  (LPWSTR)
> +				  buttons[button_count].pszButtonText,
> +				  wide_length);

UTF-8 encoding again.




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 19 Aug 2024 19:22:02 +0000
Resent-Message-ID: <handler.20481.B20481.172409528823352 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.172409528823352
          (code B ref 20481); Mon, 19 Aug 2024 19:22:02 +0000
Received: (at 20481) by debbugs.gnu.org; 19 Aug 2024 19:21:28 +0000
Received: from localhost ([127.0.0.1]:59265 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sg7wW-00064a-BA
	for submit <at> debbugs.gnu.org; Mon, 19 Aug 2024 15:21:28 -0400
Received: from mail.imayhem.com ([82.223.54.191]:54015
 helo=zealous-pike.82-223-54-191.plesk.page)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpardo@HIDDEN>) id 1sg7wU-00064I-UU
 for 20481 <at> debbugs.gnu.org; Mon, 19 Aug 2024 15:21:27 -0400
Received: from [192.168.68.105] (111.red-88-21-7.staticip.rima-tde.net
 [88.21.7.111])
 by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id D606D80250; 
 Mon, 19 Aug 2024 19:20:37 +0000 (UTC)
Authentication-Results: zealous-pike.82-223-54-191.plesk.page;
 spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@HIDDEN
 smtp.helo=[192.168.68.105]
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Message-ID: <6a6428f0-cf5a-4387-9cf1-bdde61cc0c52@HIDDEN>
Date: Mon, 19 Aug 2024 21:20:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN> <86v7zwwgod.fsf@HIDDEN>
Content-Language: es-ES
From: Cecilio Pardo <cpardo@HIDDEN>
In-Reply-To: <86v7zwwgod.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 19/08/2024 19:44, Eli Zaretskii wrote:
>> Date: Mon, 19 Aug 2024 18:13:31 +0200
>> From: Cecilio Pardo <cpardo@HIDDEN>
>>
>> This patch adds support on Windows Vista an later for dialog boxes using
>> TaskDialog.
> Thanks.
>
> First, to accept a contribution of this size we'll need a
> copyright-assignment paperwork from you.  Should I send you the form
> to fill with instructions to go with it, so you could start the
> paperwork rolling?

Yes, please.

Thanks for your comments.





Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 11 Sep 2024 13:45:01 +0000
Resent-Message-ID: <handler.20481.B20481.172606229611255 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.172606229611255
          (code B ref 20481); Wed, 11 Sep 2024 13:45:01 +0000
Received: (at 20481) by debbugs.gnu.org; 11 Sep 2024 13:44:56 +0000
Received: from localhost ([127.0.0.1]:37958 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1soNeR-0002vR-Qz
	for submit <at> debbugs.gnu.org; Wed, 11 Sep 2024 09:44:56 -0400
Received: from mail.imayhem.com ([82.223.54.191]:41911
 helo=zealous-pike.82-223-54-191.plesk.page)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpardo@HIDDEN>) id 1soNeK-0002v6-8r
 for 20481 <at> debbugs.gnu.org; Wed, 11 Sep 2024 09:44:52 -0400
Received: from [192.168.68.105] (111.red-88-21-7.staticip.rima-tde.net
 [88.21.7.111])
 by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 4973580107; 
 Wed, 11 Sep 2024 13:44:31 +0000 (UTC)
Authentication-Results: zealous-pike.82-223-54-191.plesk.page;
 spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@HIDDEN
 smtp.helo=[192.168.68.105]
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Content-Type: multipart/mixed; boundary="------------K6TYVOmsouvKDGssGtulmc91"
Message-ID: <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN>
Date: Wed, 11 Sep 2024 15:44:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN> <86v7zwwgod.fsf@HIDDEN>
Content-Language: es-ES
From: Cecilio Pardo <cpardo@HIDDEN>
In-Reply-To: <86v7zwwgod.fsf@HIDDEN>
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------K6TYVOmsouvKDGssGtulmc91
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 19/08/2024 19:44, Eli Zaretskii wrote:
>> Date: Mon, 19 Aug 2024 18:13:31 +0200
>> From: Cecilio Pardo <cpardo@HIDDEN>
>>
>> This patch adds support on Windows Vista an later for dialog boxes using
>> TaskDialog.
> Thanks.
>
> First, to accept a contribution of this size we'll need a
> copyright-assignment paperwork from you.  Should I send you the form
> to fill with instructions to go with it, so you could start the
> paperwork rolling?
>
> A few comments about the patch:

Hello,

The copyright assignment is ready. Here is the patch with your

comments addressed. I also attach a couple of manual tests.


--

Cecilio Pardo




--------------K6TYVOmsouvKDGssGtulmc91
Content-Type: text/plain; charset=UTF-8; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9tZW51LmMgYi9zcmMvbWVudS5jCmluZGV4IGRlNGQwOTY0ZTlj
Li42YjRhYWVmMTcxNSAxMDA2NDQKLS0tIGEvc3JjL21lbnUuYworKysgYi9zcmMvbWVudS5j
CkBAIC0xNTk0LDkgKzE1OTQsMTAgQEAgREVGVU4gKCJ4LXBvcHVwLWRpYWxvZyIsIEZ4X3Bv
cHVwX2RpYWxvZywgU3hfcG9wdXBfZGlhbG9nLCAyLCAzLCAwLAogICAgICAgTGlzcF9PYmpl
Y3Qgc2VsZWN0aW9uCiAJPSBGUkFNRV9URVJNSU5BTCAoZiktPnBvcHVwX2RpYWxvZ19ob29r
IChmLCBoZWFkZXIsIGNvbnRlbnRzKTsKICNpZmRlZiBIQVZFX05UR1VJCi0gICAgICAvKiBO
VEdVSSBzdXBwb3J0cyBvbmx5IHNpbXBsZSBkaWFsb2dzIHdpdGggWWVzL05vIGNob2ljZXMu
ICBGb3IKLQkgb3RoZXIgZGlhbG9ncywgaXQgcmV0dXJucyB0aGUgc3ltYm9sICd1bnN1cHBv
cnRlZC0tdzMyLWRpYWxvZycsCi0JIGFzIGEgc2lnbmFsIGZvciB0aGUgY2FsbGVyIHRvIGZh
bGwgYmFjayB0byB0aGUgZW11bGF0aW9uIGNvZGUuICAqLworICAgICAgLyogTlRHVUkgb24g
V2luZG93cyB2ZXJzaW9ucyBiZWZvcmUgVmlzdGEgc3VwcG9ydHMgb25seSBzaW1wbGUKKwkg
ZGlhbG9ncyB3aXRoIFllcy9ObyBjaG9pY2VzLiAgRm9yIG90aGVyIGRpYWxvZ3MsIGl0IHJl
dHVybnMgdGhlCisJIHN5bWJvbCAndW5zdXBwb3J0ZWQtLXczMi1kaWFsb2cnLCBhcyBhIHNp
Z25hbCBmb3IgdGhlIGNhbGxlciB0bworCSBmYWxsIGJhY2sgdG8gdGhlIGVtdWxhdGlvbiBj
b2RlLiAgKi8KICAgICAgIGlmICghRVEgKHNlbGVjdGlvbiwgUXVuc3VwcG9ydGVkX193MzJf
ZGlhbG9nKSkKICNlbmRpZgogCXJldHVybiBzZWxlY3Rpb247CmRpZmYgLS1naXQgYS9zcmMv
dzMybWVudS5jIGIvc3JjL3czMm1lbnUuYwppbmRleCBjZWE0ZjQ4OTJhNC4uM2M3ZWJmNjRh
YmUgMTAwNjQ0Ci0tLSBhL3NyYy93MzJtZW51LmMKKysrIGIvc3JjL3czMm1lbnUuYwpAQCAt
NTIsNiArNTIsOSBAQAogCiAjaW5jbHVkZSAidzMyY29tbW9uLmgiCS8qIGZvciBvc2luZm9f
Y2FjaGUgKi8KIAorI2luY2x1ZGUgImNvbW1jdHJsLmgiCisKKy8qIFRoaXMgb25seSBhcHBs
aWVzIHRvIE9TIHZlcnNpb25zIHByaW9yIHRvIFZpc3RhLiAgKi8KICN1bmRlZiBIQVZFX0RJ
QUxPR1MgLyogVE9ETzogSW1wbGVtZW50IG5hdGl2ZSBkaWFsb2dzLiAgKi8KIAogI2lmbmRl
ZiBUUlVFCkBAIC03Niw2ICs3OSwxMSBAQCAjZGVmaW5lIEZBTFNFIDAKICAgICBJTiBjb25z
dCBXQ0hBUiAqdGV4dCwKICAgICBJTiBjb25zdCBXQ0hBUiAqY2FwdGlvbiwKICAgICBJTiBV
SU5UIHR5cGUpOwordHlwZWRlZiBIUkVTVUxUIChXSU5BUEkgKlRhc2tEaWFsb2dJbmRpcmVj
dF9Qcm9jKSAoCisgICAgSU4gY29uc3QgVEFTS0RJQUxPR0NPTkZJRyAqcFRhc2tDb25maWcs
CisgICAgT1VUIGludCAqcG5CdXR0b24sCisgICAgT1VUIGludCAqcG5SYWRpb0J1dHRvbiwK
KyAgICBPVVQgQk9PTCAqcGZWZXJpZmljYXRpb25GbGFnQ2hlY2tlZCk7CiAKICNpZmRlZiBO
VEdVSV9VTklDT0RFCiBHZXRNZW51SXRlbUluZm9BX1Byb2MgZ2V0X21lbnVfaXRlbV9pbmZv
ID0gR2V0TWVudUl0ZW1JbmZvQTsKQEAgLTg5LDYgKzk3LDggQEAgI2RlZmluZSBGQUxTRSAw
CiBNZXNzYWdlQm94V19Qcm9jIHVuaWNvZGVfbWVzc2FnZV9ib3ggPSBOVUxMOwogI2VuZGlm
IC8qIE5UR1VJX1VOSUNPREUgKi8KIAorVGFza0RpYWxvZ0luZGlyZWN0X1Byb2MgdGFza19k
aWFsb2dfaW5kaXJlY3Q7CisKICNpZmRlZiBIQVZFX0RJQUxPR1MKIHN0YXRpYyBMaXNwX09i
amVjdCB3MzJfZGlhbG9nX3Nob3cgKHN0cnVjdCBmcmFtZSAqLCBMaXNwX09iamVjdCwgTGlz
cF9PYmplY3QsIGNoYXIgKiopOwogI2Vsc2UKQEAgLTEwMSwxNCArMTExLDE1NSBAQCAjZGVm
aW5lIEZBTFNFIDAKIAogdm9pZCB3MzJfZnJlZV9tZW51X3N0cmluZ3MgKEhXTkQpOwogCisj
ZGVmaW5lIFRBU0tfRElBTE9HX01BWF9CVVRUT05TIDEwCisKK3N0YXRpYyBIUkVTVUxUCit0
YXNrX2RpYWxvZ19jYWxsYmFjayAoSFdORCBod25kLCBVSU5UIG1zZywgV1BBUkFNIHdQYXJh
bSwKKwkJICAgICAgTFBBUkFNIGxQYXJhbSwgTE9OR19QVFIgY2FsbGJhY2tfZGF0YSkKK3sK
KyAgc3dpdGNoIChtc2cpCisgICAgeworICAgIGNhc2UgVEROX0NSRUFURUQ6CisgICAgICAv
KiBEaXNhYmxlIGFsbCBidXR0b25zIHdpdGggSUQgPj0gMjAwMCAgKi8KKyAgICAgIGZvciAo
aW50IGkgPSAwOyBpIDwgVEFTS19ESUFMT0dfTUFYX0JVVFRPTlM7IGkrKykKKyAgICAgICAg
U2VuZE1lc3NhZ2UgKGh3bmQsIFRETV9FTkFCTEVfQlVUVE9OLCAyMDAwICsgaSwgRkFMU0Up
OworICAgICAgYnJlYWs7CisgICAgfQorICByZXR1cm4gU19PSzsKK30KKwogTGlzcF9PYmpl
Y3QKIHczMl9wb3B1cF9kaWFsb2cgKHN0cnVjdCBmcmFtZSAqZiwgTGlzcF9PYmplY3QgaGVh
ZGVyLCBMaXNwX09iamVjdCBjb250ZW50cykKIHsKLQogICBjaGVja193aW5kb3dfc3lzdGVt
IChmKTsKIAotI2lmbmRlZiBIQVZFX0RJQUxPR1MKKyAgaWYgKHRhc2tfZGlhbG9nX2luZGly
ZWN0KQorICAgIHsKKyAgICAgIGludCB3aWRlX2xlbjsKKworICAgICAgQ0hFQ0tfQ09OUyAo
Y29udGVudHMpOwogCisgICAgICAvKiBHZXQgdGhlIHRpdGxlIGFzIGFuIFVURi0xNiBzdHJp
bmcuICAqLworICAgICAgY2hhciAqdGl0bGUgPSBTU0RBVEEgKEVOQ09ERV9VVEZfOCAoWENB
UiAoY29udGVudHMpKSk7CisgICAgICB3aWRlX2xlbiA9IHNpemVvZiAoV0NIQVIpICoKKwlw
TXVsdGlCeXRlVG9XaWRlQ2hhciAoQ1BfVVRGOCwgMCwgdGl0bGUsIC0xLCBOVUxMLCAwKTsK
KyAgICAgIFdDSEFSICp0aXRsZV93ID0gYWxsb2NhICh3aWRlX2xlbik7CisgICAgICBwTXVs
dGlCeXRlVG9XaWRlQ2hhciAoQ1BfVVRGOCwgMCwgdGl0bGUsIC0xLCB0aXRsZV93LCB3aWRl
X2xlbik7CisKKyAgICAgIC8qIFByZXBhcmUgdGhlIGFycmF5cyB3aXRoIHRoZSBkaWFsb2cn
cyBidXR0b25zIGFuZCByZXR1cm4gdmFsdWVzLiAgKi8KKyAgICAgIFRBU0tESUFMT0dfQlVU
VE9OIGJ1dHRvbnNbVEFTS19ESUFMT0dfTUFYX0JVVFRPTlNdOworICAgICAgTGlzcF9PYmpl
Y3QgYnV0dG9uX3ZhbHVlc1tUQVNLX0RJQUxPR19NQVhfQlVUVE9OU107CisgICAgICBpbnQg
YnV0dG9uX2NvdW50ID0gMDsKKyAgICAgIExpc3BfT2JqZWN0IGIgPSBYQ0RSIChjb250ZW50
cyk7CisKKyAgICAgIHdoaWxlICghTklMUCAoYikpIHsKKwlpZiAoYnV0dG9uX2NvdW50ID49
IFRBU0tfRElBTE9HX01BWF9CVVRUT05TKQorCSAgeworCSAgICAvKiBXZSBoYXZlIHRvbyBt
YW55IGJ1dHRvbnMuIFdlIGlnbm9yZSB0aGUgcmVzdC4gICovCisJICAgIGJyZWFrOworCSAg
fQorCisJTGlzcF9PYmplY3QgaXRlbSA9IFhDQVIgKGIpOworCisJaWYgKEZjb25zcCAoaXRl
bSkpCisJICB7CisJICAgIC8qIEEgbm9ybWFsIGl0ZW0gKHRleHQgLiB2YWx1ZSkgICovCisJ
ICAgIExpc3BfT2JqZWN0IGl0ZW1fbmFtZSA9IFhDQVIgKGl0ZW0pOworCSAgICBMaXNwX09i
amVjdCBpdGVtX3ZhbHVlID0gWENEUiAoaXRlbSk7CisKKwkgICAgQ0hFQ0tfU1RSSU5HIChp
dGVtX25hbWUpOworCisJICAgIGl0ZW1fbmFtZSA9IEVOQ09ERV9VVEZfOCAoaXRlbV9uYW1l
KTsKKwkgICAgd2lkZV9sZW4gPSBzaXplb2YgKFdDSEFSKSAqCisJICAgICAgcE11bHRpQnl0
ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAsIFNTREFUQSAoaXRlbV9uYW1lKSwKKwkJCQkgICAg
LTEsIE5VTEwsIDApOworCSAgICBidXR0b25zW2J1dHRvbl9jb3VudF0ucHN6QnV0dG9uVGV4
dCA9IGFsbG9jYSAod2lkZV9sZW4pOworCSAgICBwTXVsdGlCeXRlVG9XaWRlQ2hhciAoQ1Bf
VVRGOCwgMCwgU1NEQVRBIChpdGVtX25hbWUpLCAtMSwKKwkJCQkgIChMUFdTVFIpCisJCQkJ
ICBidXR0b25zW2J1dHRvbl9jb3VudF0ucHN6QnV0dG9uVGV4dCwKKwkJCQkgIHdpZGVfbGVu
KTsKKwkgICAgYnV0dG9uc1tidXR0b25fY291bnRdLm5CdXR0b25JRCA9IDEwMDAgKyBidXR0
b25fY291bnQ7CisJICAgIGJ1dHRvbl92YWx1ZXNbYnV0dG9uX2NvdW50KytdID0gaXRlbV92
YWx1ZTsKKwkgIH0KKwllbHNlIGlmIChOSUxQIChpdGVtKSkKKwkgIHsKKwkgICAgLyogQSBu
aWwgaXRlbSBtZWFucyB0byBwdXQgYWxsIGZvbGxvd2luZyBpdGVtcyBvbiB0aGUKKwkgICAg
ICAgcmlnaHQuIFdlIGlnbm9yZSB0aGlzLiAgKi8KKwkgIH0KKwllbHNlIGlmIChTVFJJTkdQ
IChpdGVtKSkKKwkgIHsKKwkgICAgLyogQSBzdHJpbmcgaXRlbSBtZWFucyBhbiB1bnNlbGVj
dGFibGUgYnV0dG9uLiBXZSBhZGQgYQorCSAgICAgICBidXR0b24sIGFuIHRoZW4gbmVlZCB0
byBkaXNhYmxlIGl0IG9uIHRoZSBjYWxsYmFjay4KKwkgICAgICAgV2UgdXNlIGlkcyBiYXNl
ZCBvbiAyMDAwIHRvIG1hcmsgdGhlc2UgYnV0dG9ucy4gICovCisJICAgIExpc3BfT2JqZWN0
IGl0ZW1fbmFtZSA9IEVOQ09ERV9VVEZfOCAoaXRlbSk7CisJICAgIHdpZGVfbGVuID0gc2l6
ZW9mIChXQ0hBUikgKgorCSAgICAgIHBNdWx0aUJ5dGVUb1dpZGVDaGFyIChDUF9VVEY4LCAw
LCBTU0RBVEEgKGl0ZW1fbmFtZSksCisJCQkJICAgIC0xLCBOVUxMLCAwKTsKKwkgICAgYnV0
dG9uc1tidXR0b25fY291bnRdLnBzekJ1dHRvblRleHQgPSBhbGxvY2EgKHdpZGVfbGVuKTsK
KwkgICAgcE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAsIFNTREFUQSAoaXRlbV9u
YW1lKSwgLTEsCisJCQkJICAoTFBXU1RSKQorCQkJCSAgYnV0dG9uc1tidXR0b25fY291bnRd
LnBzekJ1dHRvblRleHQsCisJCQkJICB3aWRlX2xlbik7CisJICAgIGJ1dHRvbnNbYnV0dG9u
X2NvdW50XS5uQnV0dG9uSUQgPSAyMDAwICsgYnV0dG9uX2NvdW50OworCSAgICBidXR0b25f
dmFsdWVzW2J1dHRvbl9jb3VudCsrXSA9IFFuaWw7CisJICB9CisJZWxzZQorCSAgeworCSAg
ICBlcnJvciAoIkluY29ycmVjdCBkaWFsb2cgYnV0dG9uIHNwZWNpZmljYXRpb24iKTsKKwkg
ICAgcmV0dXJuIFFuaWw7CisJICB9CisKKwliID0gWENEUiAoYik7CisgICAgICB9CisKKyAg
ICAgIGludCBwcmVzc2VkX2J1dHRvbiA9IDA7CisKKyAgICAgIFRBU0tESUFMT0dDT05GSUcg
Y29uZmlnID0geyB9OworICAgICAgY29uZmlnLmh3bmRQYXJlbnQgPSBGUkFNRV9XMzJfV0lO
RE9XIChmKTsKKyAgICAgIGNvbmZpZy5jYlNpemUgPSBzaXplb2YgKGNvbmZpZyk7CisgICAg
ICBjb25maWcuaEluc3RhbmNlID0gaGluc3Q7CisgICAgICBjb25maWcuZHdGbGFncyA9IFRE
Rl9BTExPV19ESUFMT0dfQ0FOQ0VMTEFUSU9OOworICAgICAgY29uZmlnLnBmQ2FsbGJhY2sg
PSB0YXNrX2RpYWxvZ19jYWxsYmFjazsKKworICAgICAgY29uZmlnLnBzeldpbmRvd1RpdGxl
ID0gTCJRdWVzdGlvbiI7CisgICAgICBpZiAoIU5JTFAgKGhlYWRlcikpCisJeworCSAgY29u
ZmlnLnBzeldpbmRvd1RpdGxlID0gTCJJbmZvcm1hdGlvbiI7CisJICBjb25maWcucHN6TWFp
bkljb24gPSBURF9JTkZPUk1BVElPTl9JQ09OOworCX0KKworICAgICAgY29uZmlnLnBzek1h
aW5JbnN0cnVjdGlvbiA9IHRpdGxlX3c7CisgICAgICBjb25maWcucEJ1dHRvbnMgPSBidXR0
b25zOworICAgICAgY29uZmlnLmNCdXR0b25zID0gYnV0dG9uX2NvdW50OworCisgICAgICBp
ZiAoIVNVQ0NFRURFRCAodGFza19kaWFsb2dfaW5kaXJlY3QgKCZjb25maWcsICZwcmVzc2Vk
X2J1dHRvbiwKKwkJCQkJICAgIE5VTEwsIE5VTEwpKSkKKwlyZXR1cm4gcXVpdCAoKTsKKwor
CisgICAgICBzd2l0Y2ggKHByZXNzZWRfYnV0dG9uKQorCXsKKwljYXNlIElET0s6CisJICAv
KiBUaGlzIGNhbiBvbmx5IGhhcHBlbiBpZiBubyBidXR0b25zIHdlcmUgcHJvdmlkZWQuIEFu
IE9LCisJICAgICBidXR0b24gaXMgYXV0b21hdGljYWxseSBhZGRlZCBieSBUYXNrRGlhbG9n
SW5kaXJlY3QgaW4gdGhhdAorCSAgICAgY2FzZS4gICovCisJICByZXR1cm4gUXQ7CisJY2Fz
ZSBJRENBTkNFTDoKKwkgIC8qIFRoZSB1c2VyIGNsb3NlZCB0aGUgZGlhbG9nIHdpdGhvdXQg
dXNpbmcgdGhlIGJ1dHRvbnMuICAqLworCSAgcmV0dXJuIHF1aXQgKCk7CisJZGVmYXVsdDoK
KwkgIC8qIE9uZSBvZiB0aGUgc3BlY2lmaWVkIGJ1dHRvbnMuICAqLworCSAgaW50IGJ1dHRv
bl9pbmRleCA9IHByZXNzZWRfYnV0dG9uIC0gMTAwMDsKKwkgIGlmIChidXR0b25faW5kZXgg
Pj0gMCAmJiBidXR0b25faW5kZXggPCBidXR0b25fY291bnQpCisJICAgIHJldHVybiBidXR0
b25fdmFsdWVzW2J1dHRvbl9pbmRleF07CisJICByZXR1cm4gcXVpdCAoKTsKKwl9CisgICAg
fQorCisgIC8qIElmIHdlIGdldCBoZXJlLCBUYXNrRGlhbG9nIGlzIG5vdCBzdXBwb3J0ZWQu
IFVzZSBNZXNzYWdlQm94L01lbnUuICAqLworCisKKyNpZm5kZWYgSEFWRV9ESUFMT0dTCiAg
IC8qIEhhbmRsZSBzaW1wbGUgWWVzL05vIGNob2ljZXMgYXMgTWVzc2FnZUJveCBwb3B1cHMu
ICAqLwogICBpZiAoaXNfc2ltcGxlX2RpYWxvZyAoY29udGVudHMpKQogICAgIHJldHVybiBz
aW1wbGVfZGlhbG9nX3Nob3cgKGYsIGNvbnRlbnRzLCBoZWFkZXIpOwpAQCAtMTYxOCw2ICsx
NzY5LDEwIEBAIHN5bXNfb2ZfdzMybWVudSAodm9pZCkKIHZvaWQKIGdsb2JhbHNfb2ZfdzMy
bWVudSAodm9pZCkKIHsKKyAgSE1PRFVMRSBjb21jdHJsMzIgPSBHZXRNb2R1bGVIYW5kbGUg
KCJjb21jdGwzMi5kbGwiKTsKKyAgdGFza19kaWFsb2dfaW5kaXJlY3QgPSAoVGFza0RpYWxv
Z0luZGlyZWN0X1Byb2MpCisgICAgZ2V0X3Byb2NfYWRkciAoY29tY3RybDMyLCAiVGFza0Rp
YWxvZ0luZGlyZWN0Iik7CisKICNpZm5kZWYgTlRHVUlfVU5JQ09ERQogICAvKiBTZWUgaWYg
R2V0L1NldE1lbnVJdGVtSW5mbyBmdW5jdGlvbnMgYXJlIGF2YWlsYWJsZS4gICovCiAgIEhN
T0RVTEUgdXNlcjMyID0gR2V0TW9kdWxlSGFuZGxlICgidXNlcjMyLmRsbCIpOwo=
--------------K6TYVOmsouvKDGssGtulmc91
Content-Type: text/plain; charset=UTF-8; name="test.el"
Content-Disposition: attachment; filename="test.el"
Content-Transfer-Encoding: base64

KHByb2duDQogIChwcmludCAobWVzc2FnZS1ib3ggIlRoaXMgaXMgYSBtZXNzYWdlIGJveCIp
KQ0KICAocHJpbnQgKHgtcG9wdXAtZGlhbG9nIHQgJygiVGhpcyBpcyBhbHNvIGEgbWVzc2Fn
ZWJveCIpKSkNCiAgKHByaW50ICAoeC1wb3B1cC1kaWFsb2cgdCAnKCJXaXRoIHNvbWUgYnV0
dG9ucyINCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgiT0siIDEpDQoJCSAgICAg
ICAgICAgICAgICAgICAgICAoIkNBTkNFTCIgMikNCgkJICAgICAgICAgICAgICAgICAgICAg
ICgiTkVFRCBNT1JFIElORk8iIDMpDQoJCSAgICAgICAgICAgICAgICAgICAgICAoIkRPTlQg
UkVBTExZIENBUkUiIDQpKSkgKQ0KDQogIChwcmludCAoeC1wb3B1cC1kaWFsb2cgdCAnKCJX
aXRoIGEgbG90IG90IGJ1dHRvbnMiDQoJCSAgICAgICAgICAgICAgICAgICAgICgiT0siIDEp
DQoJCSAgICAgICAgICAgICAgICAgICAgICgiQ0FOQ0VMIiAyKQ0KCQkgICAgICAgICAgICAg
ICAgICAgICAoIk5FRUQgTU9SRSBJTkZPIiAzKQ0KCQkgICAgICAgICAgICAgICAgICAgICAo
IkRPTlQgUkVBTExZIENBUkUiIDQpDQoJCSAgICAgICAgICAgICAgICAgICAgICgiMSBtb3Jl
IiA0KQ0KCQkgICAgICAgICAgICAgICAgICAgICAoIjIgbW9yZSIgNCkNCgkJICAgICAgICAg
ICAgICAgICAgICAgKCIzIG1vcmUiIDQpDQoJCSAgICAgICAgICAgICAgICAgICAgICgiNCBt
b3JlIiA0KQ0KCQkgICAgICAgICAgICAgICAgICAgICAoIjUgbW9yZSIgNCkNCgkJICAgICAg
ICAgICAgICAgICAgICAgKCI2IG1vcmUiIDQpDQoJCSAgICAgICAgICAgICAgICAgICAgICgi
NyBtb3JlIiA0KQ0KCQkgICAgICAgICAgICAgICAgICAgICAoIjggbW9yZSIgNCkNCgkJICAg
ICAgICAgICAgICAgICAgICAgKCI5IG1vcmUiIDQpDQoJCSAgICAgICAgICAgICAgICAgICAg
ICgiMTAgbW9yZSIgNCkpKSkNCiAgDQogIChwcmludCAoeC1wb3B1cC1kaWFsb2cgdCAnKCJX
aXRoIGEgbmlsIGJ1dHRvbiAod2UgZG8gbm90aGluZyB3aXRoIHRoYXQpIg0KCQkgICAgICAg
ICAgICAgICAgICAgICAoIk9LIiAxKQ0KCQkgICAgICAgICAgICAgICAgICAgICAoIkNBTkNF
TCIgMikNCgkJICAgICAgICAgICAgICAgICAgICAgbmlsDQoJCSAgICAgICAgICAgICAgICAg
ICAgICgiTkVFRCBNT1JFIElORk8iIDMpDQoJCSAgICAgICAgICAgICAgICAgICAgICgiRE9O
VCBSRUFMTFkgQ0FSRSIgNCkpKSkNCiAgDQogIChwcmludCAoeC1wb3B1cC1kaWFsb2cgdCAn
KCJXaXRoIHNvbWUgZGlzYWJsZWQgYnV0dG9ucyINCgkJICAgICAgICAgICAgICAoIk9LIiAx
KQ0KCQkgICAgICAgICAgICAgICgiQ0FOQ0VMIiAyKQ0KCQkgICAgICAgICAgICAgICJEaXNh
YmxlZCINCgkJICAgICAgICAgICAgICAoIk5FRUQgTU9SRSBJTkZPIiAzKQ0KCQkgICAgICAg
ICAgICAgICJBbHNvIGRpc2FibGVkIg0KCQkgICAgICAgICAgICAgICgiRE9OVCBSRUFMTFkg
Q0FSRSIgNCkpKSkNCiAgKQ0K

--------------K6TYVOmsouvKDGssGtulmc91--




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Po Lu <luangruo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 12 Sep 2024 02:51:02 +0000
Resent-Message-ID: <handler.20481.B20481.17261094227417 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.17261094227417
          (code B ref 20481); Thu, 12 Sep 2024 02:51:02 +0000
Received: (at 20481) by debbugs.gnu.org; 12 Sep 2024 02:50:22 +0000
Received: from localhost ([127.0.0.1]:39840 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1soZuX-0001vZ-L7
	for submit <at> debbugs.gnu.org; Wed, 11 Sep 2024 22:50:21 -0400
Received: from sonic303-20.consmr.mail.ne1.yahoo.com ([66.163.188.146]:40230)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1soZuV-0001pU-Ew
 for 20481 <at> debbugs.gnu.org; Wed, 11 Sep 2024 22:50:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1726109406; bh=Laj/N+RvPjKssbSEsQpIVk2oh7ATcaoxhkTtATMvulY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To;
 b=UQWZcJDCtcxl3CWvs8K+CQ+GKHSfP4LEGV6Ceviaux6JyQFnQQ0JHDWV5dXpiJzAAq5XZiABdnkYMXVEuSnE9cQVPKAViFml/ekGhD6Cxfhbdue9h60h8nnfQuqZrhqrqDFo0h5Jrb+OPuT4u3GSpZFdCRPOAQffBb8D9QpxWt8qcvJ4XFF6ogmSCZyy5Z+RbS/g9X7qt33kw0PbOl+ZqxE1BLBPC298AGKWS7NTDWTJpLc0RVI9sV9mCdguBZIsAFgy7z/aorwMOZdo7DJOEu88LVg7L7hCiYpE1ShWrua6BT0UmNoJvVfeAQjX2XHMUYnqT/PoWtBdQ+Qn/hiDfQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1726109406; bh=WwKwXXL51IJ/u9Du0CsbSVFx5buLguERPTD7YqOYHqw=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=VJeeFbpDAnbcu3EpfGxniEzwQ56Id8VPfmw2WZrc56ALiA9Ds0BVYap65lhGXIyM5qWUPeCdXEkJ9sCI5PaDExWQS15vTQ73EzlK6SX+8P04oZbOTAc2E7t/5vzUOd3b7fHdhbr9n/sJQH+R7s6OQLO4Q5HK6ULun4Sw6pDKdO/gR2CLkFPtjUJgt1jesdxlNnQ/pBEn2Ezpg8HaDjugl4xQnIFpc33R4gpUd0TPWCSN7Qji75AO2kWj8Dzn7tEd7OxnBLmB2oWzk1nPorsn9jhs2NGEE/J7mRQe6plABxGZhG78QcBVFYluB9fv+o3OyAjAlXNT1fufb7foqZjkmg==
X-YMail-OSG: nat1ihUVM1l6c7uPI1UDK_xmE35v7DXdK5CGzuS_qqqcuKAtmN3u_06XFRL9Pbs
 F5p9eC36absYj1WVb1eeolZg65aoawwvFM9eBWMniBNZDaZVSehBNUAVqz8Gr3tjJBlG0zbRSbaW
 fvMDhW4_T0DMuvOSUvmieejTAMZMqjWIKW0X82ayqFBu9Ic8k1RXM1X_C9giIgYGy7MxqOxftzTG
 Ux1U1HS.uBHviZ8nsMmoavaZ8mZFzQOWwJP5quBWu7ZiQbJa0wXJsFcK20RpoaoCpp6Ak2PoH2PF
 _oD8Wzsi_J8PjYYBH0uyfVMFdA03CEhdAmfwNH8rG2AOQfN4o2vZMSYQbqNjO8tJrMCK15nHlM7S
 OuIFB7w7ldX.Z6RhyksxFeTtMrW6oVefQwHkgKiP2kByqTin89gmcmJ8GDDzTgO0D_VKhFxGC91H
 WsJBHKSy4LKiL9FlnkmAAvNb0pGUgG16aD57y17flFI25vze8KxjR5WlT1Kq75sRO1U.E_aOhgB2
 A41PMSWBCaiOyMp3Hjk1BikNN7FqA03v_LUNhxDs24Rea1eeBCC7iX0NiGXDl_YNKLKqDDZ7yWC7
 TvGrhyvw9wr7Gmy5lu21PDF0M92P_95i2oJVIUcmUWDcJOLhPAkJvWxaHFiGLn9kmU.v9URdYLqL
 O8GuovgORGruwPmFhFjTquxEV9lfgfhOcsyx450NfEfYjb2qX8_q7XI8cwsarfSIz0FfHde.xEff
 JeB5O9pw43UbGPSNHuose1cPt9KxSsnIMN1wiVLxSP4YHAinSGHSUd3LYp3T9RIfPO4SlEdzcIeB
 iUTDxG.m0bRKFAsH68wsGumbjn3vnsb4PWwBNFp1_E1kPLzkflgvUUahDFzhuHsyl.J4yAre._fW
 QOyVuje_.Dt1L_lKK6YLYWkcZU_mfNt7nAmtmtakqOIEn35KxuzSKM7tsJctBaYlXzJxyYNbn2M0
 KmAPv1swHwI.DrHjSwQ.Obw9ZUJ_wXEEcf3wqdtpW2gvAcCpyH0tzCjfsqJLJ7JxQoi1UZ3h3bUR
 dlUBL_Ahd9ra_WeDDYlillY.gxT0V9AehAzUEm06Uu9ZnArfHr4V5TjAzePcsLP4zc_ssh7J5kCZ
 ml_XuFX2E2B55vNphEX.IsT61N0m7K3o8DxfZWdi.bg8VgH5qtY.jVLKK4OMof_IQlrnNFY6DsaT
 MTLyBAgML47dAputj_ilN9Rias351R1XwS4BSrUS1PWWxsU3kbVuKX7oRMeZydGBVkfoOZ.12ni4
 9jAUtq0gpu3W634ILaS3.rd9NwA4yb4gGB9_bQmGL0zQpNBoIPcPKigT51263nixlAjYo3cL462K
 kbMcIPuWkuqYk2Yd5gFMKaQq4epT6JzqOLt4QUaryfM1HaGIal27QdORWEPeoiyLumPJBttnQlUk
 XKTpbPDfYI7viT1GMaHy_jWr5F9ivC3PWbp3Q0zGiEXrYspqdcvF8WdJbN5ZPHOx0_7a1gse_0Mx
 hZdzFHBCk0B.n95baKj.fFnw3zzbTw7XX1J2Y0P4Spr7xbsRPpOk0gek7UhrhQJ7zqvhWccdlv3i
 JgiRBkogtBrEtlS.jWpwa9LUF20S1Z7v7NWVWtXyWkdG5KxwMg_STaVQhjhG690Kd444PWhhl3V5
 ABJAWbdFBuG3zz2ywoAgqtO8oYy.bV6Ix17kIuBfFP8OXjizHKfEYnsnHrnmHRigpomuNB_DCcn6
 UBa7K7Vw7EN3j_wm.XLw4HTA.KOdFa9yOIxWJTAe27xqjTOP7TQ2Slyok3K5trZYCb2x0613sCt9
 3XrTKs.xIkk2J.YTdZB0x16ENzUTirzpisZS84HjUyQs9t_0WJDEIIFPGdiIUuIPOlfp_xEkkeCc
 QQ32FD01K610UE1b4dDU5SLyQwHnRfJfow7.thIgSNa_4ZBlP9F0X2XdHCWy_eJIMwEoHAoSS547
 3uO6s9OxiV67wEV.o32SNt.j9qUxmE1VAhDny6YCL3MB.7rDY.MGBOBFpz8Zjw461zjN8z2lWQqf
 mToA_EDFMvtdbjCx.dkys_irC94w4dQmHrQycSqhQNHwwD_9j75Q3LV1PNEYB7DPhFXznDaOZD.t
 Y9cH2TVNBemFNK1TTtzACbivMj25QonsdC.u4uE907sj7rCJmKVJa1IbEWf87y2oHdn.szkF1Nfn
 63y5pOURic0Kga8QtpnxiRG8vXf4m0.6jgSIf8wRkjBq1eznkXSTSc6r4XlxAkb1DyNyLHOcXgf8
 sbz.DwRIg.aZJBB2G1etJAg8JZIOQAjHLPI1pjXc_ESTaf9u7XWl.F6YAaC_j27ocYA--
X-Sonic-MF: <luangruo@HIDDEN>
X-Sonic-ID: 5588cc4c-56fa-47d6-8e0a-474039abe6b9
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic303.consmr.mail.ne1.yahoo.com with HTTP; Thu, 12 Sep 2024 02:50:06 +0000
Received: by hermes--production-sg3-fc85cddf6-qj99b (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 0cad2d1f2b913d6689eaaf6be7e4b53b; 
 Thu, 12 Sep 2024 02:50:01 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
In-Reply-To: <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN> (Cecilio
 Pardo's message of "Wed, 11 Sep 2024 15:44:28 +0200")
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
 <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN>
Date: Thu, 12 Sep 2024 10:49:48 +0800
Message-ID: <87r09ppovn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.22645
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 2391
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Cecilio Pardo <cpardo@HIDDEN> writes:

> On 19/08/2024 19:44, Eli Zaretskii wrote:
>>> Date: Mon, 19 Aug 2024 18:13:31 +0200
>>> From: Cecilio Pardo <cpardo@HIDDEN>
>>>
>>> This patch adds support on Windows Vista an later for dialog boxes using
>>> TaskDialog.
>> Thanks.
>>
>> First, to accept a contribution of this size we'll need a
>> copyright-assignment paperwork from you.  Should I send you the form
>> to fill with instructions to go with it, so you could start the
>> paperwork rolling?
>>
>> A few comments about the patch:
>
> Hello,
>
> The copyright assignment is ready. Here is the patch with your
>
> comments addressed. I also attach a couple of manual tests.
>

Thanks.  Following are a number of minor stylistic comments.

> +      while (!NILP (b)) {

Please insert a newline before this opening brace and indent the same by
one column.

> +	if (Fconsp (item))

  "if (CONSP (item))"

> +	    wide_len = sizeof (WCHAR) *
> +	      pMultiByteToWideChar (CP_UTF8, 0, SSDATA (item_name),
> +				    -1, NULL, 0);

Please enclose this expression in parens and break it before the
operator, thus:

  (sizeof (WCHAR)
   * pMultiByteToWideChar (CP_UTF8, 0, SSDATA (...), ...))

> +	  {
> +	    /* A nil item means to put all following items on the
> +	       right. We ignore this.  */
> +	  }

[...]

> +	else if (STRINGP (item))
> +	  {
> +	    /* A string item means an unselectable button. We add a
> +	       button, an then need to disable it on the callback.
> +	       We use ids based on 2000 to mark these buttons.  */

Please insert two spaces after sentence stops.

> +	    Lisp_Object item_name = ENCODE_UTF_8 (item);
> +	    wide_len = sizeof (WCHAR) *
> +	      pMultiByteToWideChar (CP_UTF8, 0, SSDATA (item_name),
> +				    -1, NULL, 0);

What I said about wrapping long expressions also applies here.

> +      TASKDIALOGCONFIG config = { };

  TASKDIALOGCONFIG config = { 0 };

> +      if (!SUCCEEDED (task_dialog_indirect (&config, &pressed_button,
> +					    NULL, NULL)))
> +	return quit ();

This return statement is redundant.

Lastly, I observe that you have implemented a bespoke dialog parser for
Windows, the likes of which have been a source of difficulties in the
past.  Is there any particular reason that you decided against
implementing the w32_dialog_show function called in the "#ifdef
HAVE_DIALOGS" version of w32_popup_dialog?




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 12 Sep 2024 13:34:02 +0000
Resent-Message-ID: <handler.20481.B20481.17261480237505 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Po Lu <luangruo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.17261480237505
          (code B ref 20481); Thu, 12 Sep 2024 13:34:02 +0000
Received: (at 20481) by debbugs.gnu.org; 12 Sep 2024 13:33:43 +0000
Received: from localhost ([127.0.0.1]:40426 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sojx8-0001wy-QG
	for submit <at> debbugs.gnu.org; Thu, 12 Sep 2024 09:33:43 -0400
Received: from mail.imayhem.com ([82.223.54.191]:32885
 helo=zealous-pike.82-223-54-191.plesk.page)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpardo@HIDDEN>) id 1sojx6-0001wg-5G
 for 20481 <at> debbugs.gnu.org; Thu, 12 Sep 2024 09:33:40 -0400
Received: from [192.168.68.105] (111.red-88-21-7.staticip.rima-tde.net
 [88.21.7.111])
 by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 6EE3880176; 
 Thu, 12 Sep 2024 13:33:25 +0000 (UTC)
Authentication-Results: zealous-pike.82-223-54-191.plesk.page;
 spf=pass (sender IP is 88.21.7.111) smtp.mailfrom=cpardo@HIDDEN
 smtp.helo=[192.168.68.105]
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Content-Type: multipart/mixed; boundary="------------MIr0cuSwS8ZuF0ZZ0Kh6tekB"
Message-ID: <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN>
Date: Thu, 12 Sep 2024 15:33:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Cecilio Pardo <cpardo@HIDDEN>
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN> <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN> <87r09ppovn.fsf@HIDDEN>
Content-Language: es-ES
In-Reply-To: <87r09ppovn.fsf@HIDDEN>
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------MIr0cuSwS8ZuF0ZZ0Kh6tekB
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 12/09/2024 4:49, Po Lu wrote:
> Thanks.  Following are a number of minor stylistic comments.

Sorry I missed those. They are corrected in the attached patch.

> Lastly, I observe that you have implemented a bespoke dialog parser for
> Windows, the likes of which have been a source of difficulties in the
> past.  Is there any particular reason that you decided against
> implementing the w32_dialog_show function called in the "#ifdef
> HAVE_DIALOGS" version of w32_popup_dialog?

I left w32_dialog_show as it was in case an implementation for

older versions of windows became available. I can rewrite it

if you think is better that way.


--------------MIr0cuSwS8ZuF0ZZ0Kh6tekB
Content-Type: text/plain; charset=UTF-8; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9tZW51LmMgYi9zcmMvbWVudS5jCmluZGV4IGRlNGQwOTY0ZTlj
Li42YjRhYWVmMTcxNSAxMDA2NDQKLS0tIGEvc3JjL21lbnUuYworKysgYi9zcmMvbWVudS5j
CkBAIC0xNTk0LDkgKzE1OTQsMTAgQEAgREVGVU4gKCJ4LXBvcHVwLWRpYWxvZyIsIEZ4X3Bv
cHVwX2RpYWxvZywgU3hfcG9wdXBfZGlhbG9nLCAyLCAzLCAwLAogICAgICAgTGlzcF9PYmpl
Y3Qgc2VsZWN0aW9uCiAJPSBGUkFNRV9URVJNSU5BTCAoZiktPnBvcHVwX2RpYWxvZ19ob29r
IChmLCBoZWFkZXIsIGNvbnRlbnRzKTsKICNpZmRlZiBIQVZFX05UR1VJCi0gICAgICAvKiBO
VEdVSSBzdXBwb3J0cyBvbmx5IHNpbXBsZSBkaWFsb2dzIHdpdGggWWVzL05vIGNob2ljZXMu
ICBGb3IKLQkgb3RoZXIgZGlhbG9ncywgaXQgcmV0dXJucyB0aGUgc3ltYm9sICd1bnN1cHBv
cnRlZC0tdzMyLWRpYWxvZycsCi0JIGFzIGEgc2lnbmFsIGZvciB0aGUgY2FsbGVyIHRvIGZh
bGwgYmFjayB0byB0aGUgZW11bGF0aW9uIGNvZGUuICAqLworICAgICAgLyogTlRHVUkgb24g
V2luZG93cyB2ZXJzaW9ucyBiZWZvcmUgVmlzdGEgc3VwcG9ydHMgb25seSBzaW1wbGUKKwkg
ZGlhbG9ncyB3aXRoIFllcy9ObyBjaG9pY2VzLiAgRm9yIG90aGVyIGRpYWxvZ3MsIGl0IHJl
dHVybnMgdGhlCisJIHN5bWJvbCAndW5zdXBwb3J0ZWQtLXczMi1kaWFsb2cnLCBhcyBhIHNp
Z25hbCBmb3IgdGhlIGNhbGxlciB0bworCSBmYWxsIGJhY2sgdG8gdGhlIGVtdWxhdGlvbiBj
b2RlLiAgKi8KICAgICAgIGlmICghRVEgKHNlbGVjdGlvbiwgUXVuc3VwcG9ydGVkX193MzJf
ZGlhbG9nKSkKICNlbmRpZgogCXJldHVybiBzZWxlY3Rpb247CmRpZmYgLS1naXQgYS9zcmMv
dzMybWVudS5jIGIvc3JjL3czMm1lbnUuYwppbmRleCBjZWE0ZjQ4OTJhNC4uOGVjZjdlOGU4
YTcgMTAwNjQ0Ci0tLSBhL3NyYy93MzJtZW51LmMKKysrIGIvc3JjL3czMm1lbnUuYwpAQCAt
NTIsNiArNTIsOSBAQAogCiAjaW5jbHVkZSAidzMyY29tbW9uLmgiCS8qIGZvciBvc2luZm9f
Y2FjaGUgKi8KIAorI2luY2x1ZGUgImNvbW1jdHJsLmgiCisKKy8qIFRoaXMgb25seSBhcHBs
aWVzIHRvIE9TIHZlcnNpb25zIHByaW9yIHRvIFZpc3RhLiAgKi8KICN1bmRlZiBIQVZFX0RJ
QUxPR1MgLyogVE9ETzogSW1wbGVtZW50IG5hdGl2ZSBkaWFsb2dzLiAgKi8KIAogI2lmbmRl
ZiBUUlVFCkBAIC03Niw2ICs3OSwxMSBAQCAjZGVmaW5lIEZBTFNFIDAKICAgICBJTiBjb25z
dCBXQ0hBUiAqdGV4dCwKICAgICBJTiBjb25zdCBXQ0hBUiAqY2FwdGlvbiwKICAgICBJTiBV
SU5UIHR5cGUpOwordHlwZWRlZiBIUkVTVUxUIChXSU5BUEkgKlRhc2tEaWFsb2dJbmRpcmVj
dF9Qcm9jKSAoCisgICAgSU4gY29uc3QgVEFTS0RJQUxPR0NPTkZJRyAqcFRhc2tDb25maWcs
CisgICAgT1VUIGludCAqcG5CdXR0b24sCisgICAgT1VUIGludCAqcG5SYWRpb0J1dHRvbiwK
KyAgICBPVVQgQk9PTCAqcGZWZXJpZmljYXRpb25GbGFnQ2hlY2tlZCk7CiAKICNpZmRlZiBO
VEdVSV9VTklDT0RFCiBHZXRNZW51SXRlbUluZm9BX1Byb2MgZ2V0X21lbnVfaXRlbV9pbmZv
ID0gR2V0TWVudUl0ZW1JbmZvQTsKQEAgLTg5LDYgKzk3LDggQEAgI2RlZmluZSBGQUxTRSAw
CiBNZXNzYWdlQm94V19Qcm9jIHVuaWNvZGVfbWVzc2FnZV9ib3ggPSBOVUxMOwogI2VuZGlm
IC8qIE5UR1VJX1VOSUNPREUgKi8KIAorVGFza0RpYWxvZ0luZGlyZWN0X1Byb2MgdGFza19k
aWFsb2dfaW5kaXJlY3Q7CisKICNpZmRlZiBIQVZFX0RJQUxPR1MKIHN0YXRpYyBMaXNwX09i
amVjdCB3MzJfZGlhbG9nX3Nob3cgKHN0cnVjdCBmcmFtZSAqLCBMaXNwX09iamVjdCwgTGlz
cF9PYmplY3QsIGNoYXIgKiopOwogI2Vsc2UKQEAgLTEwMSwxNCArMTExLDE1NyBAQCAjZGVm
aW5lIEZBTFNFIDAKIAogdm9pZCB3MzJfZnJlZV9tZW51X3N0cmluZ3MgKEhXTkQpOwogCisj
ZGVmaW5lIFRBU0tfRElBTE9HX01BWF9CVVRUT05TIDEwCisKK3N0YXRpYyBIUkVTVUxUCit0
YXNrX2RpYWxvZ19jYWxsYmFjayAoSFdORCBod25kLCBVSU5UIG1zZywgV1BBUkFNIHdQYXJh
bSwKKwkJICAgICAgTFBBUkFNIGxQYXJhbSwgTE9OR19QVFIgY2FsbGJhY2tfZGF0YSkKK3sK
KyAgc3dpdGNoIChtc2cpCisgICAgeworICAgIGNhc2UgVEROX0NSRUFURUQ6CisgICAgICAv
KiBEaXNhYmxlIGFsbCBidXR0b25zIHdpdGggSUQgPj0gMjAwMCAgKi8KKyAgICAgIGZvciAo
aW50IGkgPSAwOyBpIDwgVEFTS19ESUFMT0dfTUFYX0JVVFRPTlM7IGkrKykKKyAgICAgICAg
U2VuZE1lc3NhZ2UgKGh3bmQsIFRETV9FTkFCTEVfQlVUVE9OLCAyMDAwICsgaSwgRkFMU0Up
OworICAgICAgYnJlYWs7CisgICAgfQorICByZXR1cm4gU19PSzsKK30KKwogTGlzcF9PYmpl
Y3QKIHczMl9wb3B1cF9kaWFsb2cgKHN0cnVjdCBmcmFtZSAqZiwgTGlzcF9PYmplY3QgaGVh
ZGVyLCBMaXNwX09iamVjdCBjb250ZW50cykKIHsKLQogICBjaGVja193aW5kb3dfc3lzdGVt
IChmKTsKIAotI2lmbmRlZiBIQVZFX0RJQUxPR1MKKyAgaWYgKHRhc2tfZGlhbG9nX2luZGly
ZWN0KQorICAgIHsKKyAgICAgIGludCB3aWRlX2xlbjsKKworICAgICAgQ0hFQ0tfQ09OUyAo
Y29udGVudHMpOworCisgICAgICAvKiBHZXQgdGhlIHRpdGxlIGFzIGFuIFVURi0xNiBzdHJp
bmcuICAqLworICAgICAgY2hhciAqdGl0bGUgPSBTU0RBVEEgKEVOQ09ERV9VVEZfOCAoWENB
UiAoY29udGVudHMpKSk7CisgICAgICB3aWRlX2xlbiA9IChzaXplb2YgKFdDSEFSKQorCQkg
ICogcE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAsIHRpdGxlLCAtMSwgTlVMTCwg
MCkpOworICAgICAgV0NIQVIgKnRpdGxlX3cgPSBhbGxvY2EgKHdpZGVfbGVuKTsKKyAgICAg
IHBNdWx0aUJ5dGVUb1dpZGVDaGFyIChDUF9VVEY4LCAwLCB0aXRsZSwgLTEsIHRpdGxlX3cs
IHdpZGVfbGVuKTsKIAorICAgICAgLyogUHJlcGFyZSB0aGUgYXJyYXlzIHdpdGggdGhlIGRp
YWxvZydzIGJ1dHRvbnMgYW5kIHJldHVybiB2YWx1ZXMuICAqLworICAgICAgVEFTS0RJQUxP
R19CVVRUT04gYnV0dG9uc1tUQVNLX0RJQUxPR19NQVhfQlVUVE9OU107CisgICAgICBMaXNw
X09iamVjdCBidXR0b25fdmFsdWVzW1RBU0tfRElBTE9HX01BWF9CVVRUT05TXTsKKyAgICAg
IGludCBidXR0b25fY291bnQgPSAwOworICAgICAgTGlzcF9PYmplY3QgYiA9IFhDRFIgKGNv
bnRlbnRzKTsKKworICAgICAgd2hpbGUgKCFOSUxQIChiKSkKKwl7CisJICBpZiAoYnV0dG9u
X2NvdW50ID49IFRBU0tfRElBTE9HX01BWF9CVVRUT05TKQorCSAgICB7CisJICAgICAgLyog
V2UgaGF2ZSB0b28gbWFueSBidXR0b25zLiBXZSBpZ25vcmUgdGhlIHJlc3QuICAqLworCSAg
ICAgIGJyZWFrOworCSAgICB9CisJICAKKwkgIExpc3BfT2JqZWN0IGl0ZW0gPSBYQ0FSIChi
KTsKKwkgIAorCSAgaWYgKENPTlNQIChpdGVtKSkKKwkgICAgeworCSAgICAgIC8qIEEgbm9y
bWFsIGl0ZW0gKHRleHQgLiB2YWx1ZSkgICovCisJICAgICAgTGlzcF9PYmplY3QgaXRlbV9u
YW1lID0gWENBUiAoaXRlbSk7CisJICAgICAgTGlzcF9PYmplY3QgaXRlbV92YWx1ZSA9IFhD
RFIgKGl0ZW0pOworCSAgICAgIAorCSAgICAgIENIRUNLX1NUUklORyAoaXRlbV9uYW1lKTsK
KwkgICAgICAKKwkgICAgICBpdGVtX25hbWUgPSBFTkNPREVfVVRGXzggKGl0ZW1fbmFtZSk7
CisJICAgICAgd2lkZV9sZW4gPSAoc2l6ZW9mIChXQ0hBUikKKwkJCSAgKiBwTXVsdGlCeXRl
VG9XaWRlQ2hhciAoQ1BfVVRGOCwgMCwgU1NEQVRBIChpdGVtX25hbWUpLAorCQkJCQkJICAt
MSwgTlVMTCwgMCkpOworCSAgICAgIGJ1dHRvbnNbYnV0dG9uX2NvdW50XS5wc3pCdXR0b25U
ZXh0ID0gYWxsb2NhICh3aWRlX2xlbik7CisJICAgICAgcE11bHRpQnl0ZVRvV2lkZUNoYXIg
KENQX1VURjgsIDAsIFNTREFUQSAoaXRlbV9uYW1lKSwgLTEsCisJCQkJICAgIChMUFdTVFIp
CisJCQkJICAgIGJ1dHRvbnNbYnV0dG9uX2NvdW50XS5wc3pCdXR0b25UZXh0LAorCQkJCSAg
ICB3aWRlX2xlbik7CisJICAgICAgYnV0dG9uc1tidXR0b25fY291bnRdLm5CdXR0b25JRCA9
IDEwMDAgKyBidXR0b25fY291bnQ7CisJICAgICAgYnV0dG9uX3ZhbHVlc1tidXR0b25fY291
bnQrK10gPSBpdGVtX3ZhbHVlOworCSAgICB9CisJICBlbHNlIGlmIChOSUxQIChpdGVtKSkK
KwkgICAgeworCSAgICAgIC8qIEEgbmlsIGl0ZW0gbWVhbnMgdG8gcHV0IGFsbCBmb2xsb3dp
bmcgaXRlbXMgb24gdGhlCisJCSByaWdodC4gIFdlIGlnbm9yZSB0aGlzLiAgKi8KKwkgICAg
fQorCSAgZWxzZSBpZiAoU1RSSU5HUCAoaXRlbSkpCisJICAgIHsKKwkgICAgICAvKiBBIHN0
cmluZyBpdGVtIG1lYW5zIGFuIHVuc2VsZWN0YWJsZSBidXR0b24uICBXZSBhZGQgYQorCSAg
ICAgICBidXR0b24sIGFuIHRoZW4gbmVlZCB0byBkaXNhYmxlIGl0IG9uIHRoZSBjYWxsYmFj
ay4gIFdlCisJICAgICAgIHVzZSBpZHMgYmFzZWQgb24gMjAwMCB0byBtYXJrIHRoZXNlIGJ1
dHRvbnMuICAqLworCSAgICAgIExpc3BfT2JqZWN0IGl0ZW1fbmFtZSA9IEVOQ09ERV9VVEZf
OCAoaXRlbSk7CisJICAgICAgd2lkZV9sZW4gPSAoc2l6ZW9mIChXQ0hBUikKKwkJCSAgKiBw
TXVsdGlCeXRlVG9XaWRlQ2hhciAoQ1BfVVRGOCwgMCwKKwkJCQkJCSAgU1NEQVRBIChpdGVt
X25hbWUpLAorCQkJCQkJICAtMSwgTlVMTCwgMCkpOworCSAgICAgIGJ1dHRvbnNbYnV0dG9u
X2NvdW50XS5wc3pCdXR0b25UZXh0ID0gYWxsb2NhICh3aWRlX2xlbik7CisJICAgICAgcE11
bHRpQnl0ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAsIFNTREFUQSAoaXRlbV9uYW1lKSwgLTEs
CisJCQkJICAgIChMUFdTVFIpCisJCQkJICAgIGJ1dHRvbnNbYnV0dG9uX2NvdW50XS5wc3pC
dXR0b25UZXh0LAorCQkJCSAgICB3aWRlX2xlbik7CisJICAgICAgYnV0dG9uc1tidXR0b25f
Y291bnRdLm5CdXR0b25JRCA9IDIwMDAgKyBidXR0b25fY291bnQ7CisJICAgICAgYnV0dG9u
X3ZhbHVlc1tidXR0b25fY291bnQrK10gPSBRbmlsOworCSAgICB9CisJICBlbHNlCisJICAg
IHsKKwkgICAgICBlcnJvciAoIkluY29ycmVjdCBkaWFsb2cgYnV0dG9uIHNwZWNpZmljYXRp
b24iKTsKKwkgICAgICByZXR1cm4gUW5pbDsKKwkgICAgfQorCSAgCisJICBiID0gWENEUiAo
Yik7CisJfQorICAgICAgCisgICAgICBpbnQgcHJlc3NlZF9idXR0b24gPSAwOworICAgICAg
CisgICAgICBUQVNLRElBTE9HQ09ORklHIGNvbmZpZyA9IHsgMCB9OworICAgICAgY29uZmln
Lmh3bmRQYXJlbnQgPSBGUkFNRV9XMzJfV0lORE9XIChmKTsKKyAgICAgIGNvbmZpZy5jYlNp
emUgPSBzaXplb2YgKGNvbmZpZyk7CisgICAgICBjb25maWcuaEluc3RhbmNlID0gaGluc3Q7
CisgICAgICBjb25maWcuZHdGbGFncyA9IFRERl9BTExPV19ESUFMT0dfQ0FOQ0VMTEFUSU9O
OworICAgICAgY29uZmlnLnBmQ2FsbGJhY2sgPSB0YXNrX2RpYWxvZ19jYWxsYmFjazsKKyAg
ICAgIAorICAgICAgY29uZmlnLnBzeldpbmRvd1RpdGxlID0gTCJRdWVzdGlvbiI7CisgICAg
ICBpZiAoIU5JTFAgKGhlYWRlcikpCisJeworCSAgY29uZmlnLnBzeldpbmRvd1RpdGxlID0g
TCJJbmZvcm1hdGlvbiI7CisJICBjb25maWcucHN6TWFpbkljb24gPSBURF9JTkZPUk1BVElP
Tl9JQ09OOworCX0KKworICAgICAgY29uZmlnLnBzek1haW5JbnN0cnVjdGlvbiA9IHRpdGxl
X3c7CisgICAgICBjb25maWcucEJ1dHRvbnMgPSBidXR0b25zOworICAgICAgY29uZmlnLmNC
dXR0b25zID0gYnV0dG9uX2NvdW50OworICAgICAgCisgICAgICBpZiAoIVNVQ0NFRURFRCAo
dGFza19kaWFsb2dfaW5kaXJlY3QgKCZjb25maWcsICZwcmVzc2VkX2J1dHRvbiwKKwkJCQkJ
ICAgIE5VTEwsIE5VTEwpKSkKKwlxdWl0ICgpOworICAgICAgCisKKyAgICAgIHN3aXRjaCAo
cHJlc3NlZF9idXR0b24pCisJeworCWNhc2UgSURPSzoKKwkgIC8qIFRoaXMgY2FuIG9ubHkg
aGFwcGVuIGlmIG5vIGJ1dHRvbnMgd2VyZSBwcm92aWRlZC4gQW4gT0sKKwkgICAgIGJ1dHRv
biBpcyBhdXRvbWF0aWNhbGx5IGFkZGVkIGJ5IFRhc2tEaWFsb2dJbmRpcmVjdCBpbiB0aGF0
CisJICAgICBjYXNlLiAgKi8KKwkgIHJldHVybiBRdDsKKwljYXNlIElEQ0FOQ0VMOgorCSAg
LyogVGhlIHVzZXIgY2xvc2VkIHRoZSBkaWFsb2cgd2l0aG91dCB1c2luZyB0aGUgYnV0dG9u
cy4gICovCisJICByZXR1cm4gcXVpdCAoKTsKKwlkZWZhdWx0OgorCSAgLyogT25lIG9mIHRo
ZSBzcGVjaWZpZWQgYnV0dG9ucy4gICovCisJICBpbnQgYnV0dG9uX2luZGV4ID0gcHJlc3Nl
ZF9idXR0b24gLSAxMDAwOworCSAgaWYgKGJ1dHRvbl9pbmRleCA+PSAwICYmIGJ1dHRvbl9p
bmRleCA8IGJ1dHRvbl9jb3VudCkKKwkgICAgcmV0dXJuIGJ1dHRvbl92YWx1ZXNbYnV0dG9u
X2luZGV4XTsKKwkgIHJldHVybiBxdWl0ICgpOworCX0KKyAgICB9CisKKyAgLyogSWYgd2Ug
Z2V0IGhlcmUsIFRhc2tEaWFsb2cgaXMgbm90IHN1cHBvcnRlZC4gVXNlIE1lc3NhZ2VCb3gv
TWVudS4gICovCisKKworI2lmbmRlZiBIQVZFX0RJQUxPR1MKICAgLyogSGFuZGxlIHNpbXBs
ZSBZZXMvTm8gY2hvaWNlcyBhcyBNZXNzYWdlQm94IHBvcHVwcy4gICovCiAgIGlmIChpc19z
aW1wbGVfZGlhbG9nIChjb250ZW50cykpCiAgICAgcmV0dXJuIHNpbXBsZV9kaWFsb2dfc2hv
dyAoZiwgY29udGVudHMsIGhlYWRlcik7CkBAIC0xNjE4LDYgKzE3NzEsMTAgQEAgc3ltc19v
Zl93MzJtZW51ICh2b2lkKQogdm9pZAogZ2xvYmFsc19vZl93MzJtZW51ICh2b2lkKQogewor
ICBITU9EVUxFIGNvbWN0cmwzMiA9IEdldE1vZHVsZUhhbmRsZSAoImNvbWN0bDMyLmRsbCIp
OworICB0YXNrX2RpYWxvZ19pbmRpcmVjdCA9IChUYXNrRGlhbG9nSW5kaXJlY3RfUHJvYykK
KyAgICBnZXRfcHJvY19hZGRyIChjb21jdHJsMzIsICJUYXNrRGlhbG9nSW5kaXJlY3QiKTsK
KwogI2lmbmRlZiBOVEdVSV9VTklDT0RFCiAgIC8qIFNlZSBpZiBHZXQvU2V0TWVudUl0ZW1J
bmZvIGZ1bmN0aW9ucyBhcmUgYXZhaWxhYmxlLiAgKi8KICAgSE1PRFVMRSB1c2VyMzIgPSBH
ZXRNb2R1bGVIYW5kbGUgKCJ1c2VyMzIuZGxsIik7Cg==

--------------MIr0cuSwS8ZuF0ZZ0Kh6tekB--




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Sep 2024 11:02:02 +0000
Resent-Message-ID: <handler.20481.B20481.172631167123152 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: luangruo@HIDDEN, 20481 <at> debbugs.gnu.org
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.172631167123152
          (code B ref 20481); Sat, 14 Sep 2024 11:02:02 +0000
Received: (at 20481) by debbugs.gnu.org; 14 Sep 2024 11:01:11 +0000
Received: from localhost ([127.0.0.1]:44923 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spQWc-00061K-Cl
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 07:01:10 -0400
Received: from eggs.gnu.org ([209.51.188.92]:32824)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1spQWY-00060p-Gf
 for 20481 <at> debbugs.gnu.org; Sat, 14 Sep 2024 07:01:08 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1spQWI-0001LN-4t; Sat, 14 Sep 2024 07:00:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=fD0vbelRsCxXtK6zo2pdJElbH6IaetzGv1hI0kw7M7Q=; b=dSQ0JuvZh7Nn
 01LNCNT6Q5MQQpgs3ecklFzbUAXUDVrliBGSlLMWipmhvZCrbXIwHB0h4Ub9wxbw45shRkRR3XISR
 fRLsLV4yIgAl7wfC7C14xKZNG0jkFmHyv18KnxP5HbJcaDM8XpA+gfuuc/44MBrhLfTLerSUvJATV
 ktczmdVVzQpLz0yLVKaWx2gtJZJfbvifJG7PEuFpTWNMcV+rIJsYjysV/1rUkwR6R+ag5PuP16tUW
 glRDR5dN8Hm6nj5v7G+kOHG0PfhS8RFk1m7ZjrpwpStv9JyvipJT1OoP0o74AS4OM43LMXMHDNAeQ
 0nDHKiGIwJsChx3okI1+YA==;
Date: Sat, 14 Sep 2024 14:00:46 +0300
Message-Id: <86bk0qh541.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN> (message from
 Cecilio Pardo on Thu, 12 Sep 2024 15:33:23 +0200)
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN> <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN> <87r09ppovn.fsf@HIDDEN>
 <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN>
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 12 Sep 2024 15:33:23 +0200
> From: Cecilio Pardo <cpardo@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>, 20481 <at> debbugs.gnu.org
> 
> On 12/09/2024 4:49, Po Lu wrote:
> > Thanks.  Following are a number of minor stylistic comments.
> 
> Sorry I missed those. They are corrected in the attached patch.

Thanks, now installed on the master branch (which will become Emacs 31).

FTR, I needed some additions because mingw.org's MinGW lacks some
stuff in its headers that the code used.  Please see that the result
still compiles with MinGW64.




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Po Lu <luangruo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Sep 2024 12:06:02 +0000
Resent-Message-ID: <handler.20481.B20481.17263155314988 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.17263155314988
          (code B ref 20481); Sat, 14 Sep 2024 12:06:02 +0000
Received: (at 20481) by debbugs.gnu.org; 14 Sep 2024 12:05:31 +0000
Received: from localhost ([127.0.0.1]:44981 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spRWt-0001IO-8L
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 08:05:31 -0400
Received: from sonic314-20.consmr.mail.ne1.yahoo.com ([66.163.189.146]:40073)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1spRWs-0001I3-1t
 for 20481 <at> debbugs.gnu.org; Sat, 14 Sep 2024 08:05:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1726315514; bh=v5nCHDXLTmA6eIJtxTEMzpGxtrQIO5nw2iC4f538MOk=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To;
 b=Q9nltanQeeUb7aejiar8f0ngECXGhdfKsmiz7VJbLrmD9STamKEKmZeUe4VLC0u5HVNGp7TbwwRZnD8GgELDsv2Lnv08NKSJUo+gVwRQawd6IZPPm4cSDObnmaEnFqOAXDJ9xxu7vHzaeVIh21J1zKEi6+L/wL8wYx93t26clnrPZD2hR2fMQrNhjmrsilvbyu0vckWk1VYgiD2wMFj0tyh12QOd2Lh6xD9Q9HsaFwCEvirKStMDUex6Y5FipecApHt5IDGhZoAyUUz7amTskARn+gtGOKKituZMLRypi1aIB+9DxWNnh8mUY4IHn5qRHmObOAHKdIH4QLn5nkv7fg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1726315514; bh=OO0A4Uns1izYujXF97GA3VqzVwTipnBczT+ZjbqPQFc=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=fxeR8a2mwYqUPjZ/cSNGrsFDwCGW2uHm1nj8iQ8yorObPsy/03tQUdq1auVJeNMKgDSk0LQFti7fYkcjqrEc3+4vE1cccjE6+6ZLaatAENjKXE9gYMwtMTB6mk3ZTBsK4W/RL2XYIJqR3jVoEdO+9Za86aCo190eUetfOB8ak7l/qztAD3Y+57pg7QI8UGxIIOsaxPzkBoWOmFApsZW1S+CnDpzv89NqqCf+anceFL3v9E+zUyGoBc76l/DvekG2Rf0QDV5Wh1p6zDtfRvmpeBa+WC31B75FTJ19tyyxA4YoebOrj3mjIqcF9USFz43EI/2pD5NDKpBZSnP3DHnlTg==
X-YMail-OSG: ERkFq94VM1mARn7h3s6m76AxW506FolIBvu1OGW6BmDTU.wHhquN.HFTbi6R3dT
 VL_sMlkbD88It2ymHfIsZw5JSlkaCcfzy7kh.o7Pt3OtMabCMNE0xIj8EdjD4a8rANByxAFFEct7
 UCNY4qWyqdTC8gopb76QihdK_pQNuk30kUdS10CxeQxjSDDBB9BSVO8sPWoftwIGyylPan4w1oUI
 6lzCow9v8kGfBb2hGxKYSlS29aPIVuwGifBCFkebPgI_GrfOnFhz6YN5gz4WIqfWQxPpgI.Kh.7h
 MLCrAY5zq7tJrkRDt9mZaAPqWeSRSSs3h6BMRm6Uutux7fX9g_JIVA6QQzhnaDYvkFQrha3HSMtm
 pyXH1HBY1YmeO4XnbZ4Mh2S5C5Hnnow1D9Q_bXFy75OprHQ6_s38dt3833rZHKDC9.__64iob7ej
 g5XpGm_1.8ITTI2BKJbiQTNDJ.7ctNdUSDj2jVHEEy9LXdx41EvtrQSeA3JQwCLKbLd9B485gIAe
 ba525KBoPDa8VYGU9Zvf_NtfvVJADI8i9nl3RfG_9z3lPahi8R5kLlTB5vxVvS4ai646mLWBIINn
 eHzl.OWI4sgy_JrjxoCYuoEwxctjDS27cIjuFko9VTiTJ.pan0KCqHoBcNNlJBk5BwX0ItG.uXp8
 nbnn7WO9xPexP_xjJmu8DGAx.r14RQjSTAqcW0Ah2NIh.pqLojKkpwyPNlsH13kUyfPrmLfcZJhP
 pDAVyK.Tamr4.FL9EPWEHSbz2IVWcsTz5LIMj3P.lowe1C.D1Oc6UEZztVl8kQr4cezvUQGJQuhe
 5B0C8rEucDgLpPhdsR9_at_O.Adnc0lKcm_9hRDIXd.R5z3GGOHxEuyr95tM8wZAQUAHe8i.DyKF
 FeWohuNFRtMIxpP6P9UEWJFPLQwU.NyZPWPMLH4MX_rYR_CfwcaCoNwPGJhsasE2iqKT7GFlT2CD
 WxNB4jXrk2zKT8cWp4tIDw5q6QZs90z3QxLHN7Ux5pCcx57_lWeX6dXuhHZGKRavYYv7UWW..LaS
 mmDQUQG5V_eFe0253DI_F0184L2780fsp9FRBGeKC5zhT1RY8wzk9Q3Mxjn9rqendeXk52v7VL2t
 KVP3iZaLGsOj09_Q3Y1sDT5SbuR1vdr0b1KeU6XDzEaYzt9WaIHE36Q.zwGTP93GClmlKyshG9z3
 sRV.RfduyRknh5cfJLynAI0f2qz5k0IPag42Qom.PhTGoP_sZLQnEjAscaaEewrTNh1XDd9HimJ9
 zP7IyuSRqkamdukf9PcikbEq6kjdCspgPQp_xY2esX5FbXFVLT3PS2XveMW.DMZIRL0uwQ6uG9xw
 9YgiaXgh_TlDPIYTGkYBNOsvMMlOUm9ipIhdaTxmaKNLF0GbGjpd4G5qXMkSlkAQmwlvT1VZo_mA
 C4M8Hxe0rEsmI9SnsTOdU_D1F8Wxk9Zn43HakYJqCezfhY1ZVh3RUxsxnrkrSkd4ACxeSTjWvha9
 bb_1OrpoTuse5vXpLdymPf7Di6g_R616Sbfckd.EQ8N5wvYRbcAi3p6dsz1oGfNsnCOf3BP8D4yi
 ubEHtBGSWTltKEz4UakvqDeOn5KgVffCJawMng1UVej5A7d8enH6BQxIuji8JBXekMRQd_mEV9lc
 5YC8ZiWfR5gxhzBpJPQAErXDc4nfHoG53f3H64v1weSh4h4QHVqAd67WkJX7.HFd6B7oYGa9ER5V
 1nNh4KPylWGRBER.tZ3ebyfLQQ8JI7_POMeW60gOMqXd6oCmsQd4lctPD_sDvd7tcIzjH_T2Tye5
 52BbLQgycy3RufiTG5txqN4sBYpXrDtFzb5.CXu23If7u2fcZlP0HvejuP57koJSIEiCxLRG0j.s
 ka9Rbv5qkroZwHcgc4pDWPKKszYydobUi_YyyarlFqTEwJ4zOhmMfMDrFwGnJqx5tpYIam8sClJL
 aFRJrmmsDoHS1Nu9pueRGty5qA7pfoWTvUKSeqPEQTYmMjTHue2FcrsrEnr0UEUeGNZnuaEx38Du
 6IbEjYbL.WjXlwezNZQxssPItL_aAKnPm5OyOCssQVmOq4aQOuQn20xT4fcRC0yHx0pzfCTkIXPo
 d3MmJhNvQu8zrGUu6Unq5V1ExMKvBiIz1r1l_c4cpvzRr1uiZylFRyF5kajLJYNTpG9gbUSef6CF
 KLEsVi1mn2CdOmXO2V.r3b16.65L46JJMCeOq1s.zC08n4aes6E9ZXa.Ex9D.oorfUqSHrFsL19e
 z5d4ELWHgA2pLvPcZnRzAAWLnGyRpNzzaUkoco9A3jxVxuEcTIlfmCGqCKjzBr70dPQ0A
X-Sonic-MF: <luangruo@HIDDEN>
X-Sonic-ID: 29e82f38-2adc-47ac-bc7d-2c97a8d0a604
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sat, 14 Sep 2024 12:05:14 +0000
Received: by hermes--production-sg3-fc85cddf6-pbnn7 (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 6a9c2f6fef92e3011441cfb09d26be65; 
 Sat, 14 Sep 2024 12:05:09 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
In-Reply-To: <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN> (Cecilio
 Pardo's message of "Thu, 12 Sep 2024 15:33:23 +0200")
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
 <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN>
 <87r09ppovn.fsf@HIDDEN>
 <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Sat, 14 Sep 2024 20:05:03 +0800
Message-ID: <87h6aiphjk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Mailer: WebService/1.1.22645
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 366
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Cecilio Pardo <cpardo@HIDDEN> writes:

> I left w32_dialog_show as it was in case an implementation for
> older versions of windows became available. I can rewrite=C2=A0it
> if you think is better that way.

I don't think the improvised menu-dialogs and w32_dialog_show are
mutually exclusive.  The latter could easily be enabled only on Windows
Vista systems.




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Sep 2024 12:18:01 +0000
Resent-Message-ID: <handler.20481.B20481.17263162757479 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Po Lu <luangruo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org, cpardo@HIDDEN
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.17263162757479
          (code B ref 20481); Sat, 14 Sep 2024 12:18:01 +0000
Received: (at 20481) by debbugs.gnu.org; 14 Sep 2024 12:17:55 +0000
Received: from localhost ([127.0.0.1]:45038 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spRis-0001wZ-QK
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 08:17:55 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48594)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1spRiq-0001wJ-NT
 for 20481 <at> debbugs.gnu.org; Sat, 14 Sep 2024 08:17:53 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1spRia-0002B8-R1; Sat, 14 Sep 2024 08:17:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=j1oeOARsguQ0JxKVKW2xu70nSopT30XhQQL2TfXZt5w=; b=WHhOkNto6/4Ta/A3Oprm
 rN1T464pvofJe5YGGS/A/yfMyPhEoTFIPn8wxpsyuNMWMa8ptXlWEGo5I0b06Vz3rFhEG8MuvCBY3
 Iw5qoBDW3OBctzw9Zch0TCq6IbOBqOwYwaYnbWK5UYYu2/p/AIvu+ML5mRTssFtW3gPC/vWhKeF/o
 osiW2qjORzzmHoxwL6CbUJ5s8UPM782P81cLSImgDTBGsVkpi1ExW4YlU43Rgu5JQK59Eo6LPH3zc
 QQYwE8drqQVa3ZcYLZjYTeYyYZZ0XTyB+Jh5TWBVfRZp+Y1DPyu9kqXcq8g2y4CaCHGAnRBV6zTAO
 4gQr3QG+4KywWw==;
Date: Sat, 14 Sep 2024 15:17:33 +0300
Message-Id: <861q1mh1k2.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87h6aiphjk.fsf@HIDDEN> (message from Po Lu on Sat, 14 Sep
 2024 20:05:03 +0800)
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
 <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN>
 <87r09ppovn.fsf@HIDDEN>
 <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN>
 <87h6aiphjk.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Po Lu <luangruo@HIDDEN>
> Cc: 20481 <at> debbugs.gnu.org,  Eli Zaretskii <eliz@HIDDEN>
> Date: Sat, 14 Sep 2024 20:05:03 +0800
> 
> Cecilio Pardo <cpardo@HIDDEN> writes:
> 
> > I left w32_dialog_show as it was in case an implementation for
> > older versions of windows became available. I can rewrite it
> > if you think is better that way.
> 
> I don't think the improvised menu-dialogs and w32_dialog_show are
> mutually exclusive.  The latter could easily be enabled only on Windows
> Vista systems.

It already is, since on older systems we will be unable to find
TaskDialogIndirect in comctl32.dll, and will fall back to the
menu-dialog implementation.  Or what am I missing?




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Po Lu <luangruo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Sep 2024 14:03:02 +0000
Resent-Message-ID: <handler.20481.B20481.1726322575896 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org, cpardo@HIDDEN
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.1726322575896
          (code B ref 20481); Sat, 14 Sep 2024 14:03:02 +0000
Received: (at 20481) by debbugs.gnu.org; 14 Sep 2024 14:02:55 +0000
Received: from localhost ([127.0.0.1]:47412 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spTMV-0000EK-2E
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 10:02:55 -0400
Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:36797)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <luangruo@HIDDEN>) id 1spTMS-0000E2-9s
 for 20481 <at> debbugs.gnu.org; Sat, 14 Sep 2024 10:02:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1726322556; bh=ndNWzLoDELE03Ru3fB9KdjXFgSZmYZq2hIrydCKVVLU=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To;
 b=ZVlFuXnBP65bRsFavdC2RLm2ZK9NCIp8WWkKABIwdJhnfeuK4S8GrR9YjnKZs+dw1G89vcj+InmToBQ/MEzLMplodhbABX+O64gfKovkkkT6QYa8rS/vYWdzEv7xbFK2bVK6oq2HTLUw0owxu8GNZCCB0HvBTeg7JrMXFHwPHpyiHryf+U+LoiUeTklkxTc2nDAIEIs7ngVlbKTVFRklLczP7O8+6LX8t20XNrTH+n+D8I7CIm+6AtQJvXPnaVaoIN2TSKc8NUpPTjOyhcja40E2jhFUfwgzmBOdXWq7z1vrMTEhFet1LqoTfTrhZJCouXOihR1huNur1eJA7rFt1g==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
 t=1726322556; bh=oo+6EtczZcdt1Gp6UcMNgILFnDr4GImgly8UUIF8zmc=;
 h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
 b=Dv0UXvSVYyabXOiEvIMFv3cbbUF+C3dKQNcgPkZ0NkSSTwydg6rtWwlQO1ypLg/o7ZCQew8BoaJo1J2YEmQtBkrOAmtLlKCr43eO67Cc67s8dY8VxkHxHqv6tiVuZ9MYqtBSCbxJtJACnxRNTSTYz8GYGkSYucRp65KQz8kB4lQ9hRa7r8x/x05e7riD3pdD3/4OWzt6pQf89fWtFKXMcqmfl+j92ntqWQwMwF5YPlmn/UN6LcH6s6Kthj0N4Rh8dsO7xFQPXvjQ4lYZrtH3I/LYfZFNRA98RWWhEBZDn4J37bNHumhhPZQ2kUrX8YX9DyWJ7GxuPItWSj/JFpsmBw==
X-YMail-OSG: 8iwbBw8VM1n5oP5RufNaq99.ofRDalFnk4YceB5M7EcmqPVQkNm6heh99tUNYTH
 t9Zw_TtAnTcBsO4kZUUonZK9DEydZnkOnkZmKx.1BMjgwRB5lmOiQIN4FoYQ77dE5xPjOjfn1sqQ
 cRZDkLt4jZHAAQ79aTVy.uEqNYKvD_CHOIojdg5dEhNMacuqdDvkE6DNfKQixHeMi98C7_dcI9ay
 HpR723Z8_91_vETO3s2DRtI2WwXtD2uDV1RavS707NGooGM1piA1cHCzb3t6sDKFJUMUCsyU36Gk
 yhpvK8j8VbM4YgRKqUfaIeCXtwkkMk20Ne5zZ9Rcqk6hW39BjNmGcbEk3UTyoCg9e0veXmXXDOg8
 qEn7EY4nOtG5T74gboOYpCeqOHzm_u6am_BEEBIozw1BQDg5ErHIHP8SRp0B1W2nLQ_YWryiZ6DO
 VHE32Mvci9rfgtUGd_TnjBmkpDyI_zm4wCxuR4IFleXxXvpYtPc3xdHvAjybld0siRxVZ8rIphjA
 a3nFbwL4MFefLAP7fhcNKRXOw1OaZHLFjBqfS9f_YMZmN4OMwYedns_616xNE9NFmVTH4eOeAjw1
 exZkiBNGEtDM4DjmIujyMyXHohJdqpBiUnlL1rBhe8C0b0u.7pEPQXP0X2oL4tePq9TDsj1dD8AY
 7V9iHkub1bMBznraycpQg4CEUcyfY3nIb9UVWoNcqEhtDTsRHUsSStGUBvTDc8b_RcD.Tf.GVgIL
 ST8sHFCNzFAd..daM7bdrW34n2QgWOX5uVyZrIyQrAyPX4KWZUShdERc_3k6etsvUlcdHWeMpJj0
 9WMhdatq8LmrvPAfIMEwSxc7EbBk7f.khL_fu4.F2i7UTAMo0Du2FlirVFhVTBODjHI8yxiLDWkY
 l1asnJH_sJhoo23iYWy0BEOfvyZFmGFWCqpUSdzF4WbfM1lSJshldFTz5.rQjfZ0C054QsbJXXwM
 9Sk5x9cQVwfLYoxliamg7CNF2WPvRCYCP515Atf1jAt6cXopEJWPjoiQrlW4Ve.frPohdpBcTtYw
 1yVvofwt9VE0O4IrrmFdf2kbjf7NwRUBSEsQfQ3EmNTL_aAJGTsXMMZI1aNnVE6xBtZzVxWLuQiR
 hjdEMOBGAeUxQxPzbwc1b3QqLXs93.qtrLz53LoW57XhQ5dXaA.z9Pg4SZS58P06NQIG_pmufN1w
 06_1_lOg3KtKuQ6Ev4LqaeC8K6.7foRxGyim4kYH8I.7Du84KLVS5zY_pJ0vB3rIoJEMFsvQPLCd
 xnr_Ym61xWCojTFas0FuvVLBk7pRcGzTpaHIP.azDFf.A4g2qGk9IAKQmr2UdxLWPbL1tSyOlEwd
 A1sfUQe5rw9eV63qRInYZxuSWvLAUlveaEC7M3AxxOiMeyAlk1mLTquF0.3ojQ6dJyHU8e.4v5NY
 WKIN7sFF2_UAHEztomBgAyIFUyzwS1H2IFimMfvyeIHFNAzATo7wxLkIuEyDM2EQVZlzahBNw7qf
 nfjGKPFWnDHpl7r01iKZr1AVtSeFZTb499QnBGhhOUA26a.OFSo8MVI_l9PUmX8jAIeIr7pZiaNr
 DdgadR30QvuZQCijk_xFs8sue44WbulE8NrklgpTRIXQdg5yjSKL2bGdftVZPUYfibrP7oBtajgW
 Jny4tiDZk8iOIEq3qb_3TXO7NVJdd9Bt0F89SsYCcbM5QvQV0s3.EV0C1Oi1gdWN.HV61mdJNVvk
 7_NyI7xu8txjRMGo_1JnnLgfF1cdx1xeDiQxc2Uxh7wbcQEeEfCwqixpXRAI34OeeJ1urQFkGqbh
 tXfAaKJx3MD7tVSWkNSGcuQR8rMKa63bhJqIERi1SztRbVJPFibNg0L3YXbWv1xct2Q8gOf85dit
 AvCbLGvcJuxRtgo.Zrizkhmj_owS3Lb27m0wadkFDSAun7Xflh_yLW5MdSHooWSig3y1PLrNFz6N
 nOwQAwqvjcqrNl4Pk7adWLgmTRLvL.H0etAgDP71h2z7xN7ehupWu6GyRFV5DrLzORiztW6FvCtd
 1G.nNmaUrmQ_7q7Ga8Vuq6dzld_.SccYoouUf9EPoUAcVIuR4Lhw5ujI1EbWRilDp4IRwju85x1T
 AZSa6fuMcfObDM1.Nh9g8COxN5emrzlGLHqKEUx2Y5ieGeXqwrKL9j5JIfbCESJ89Rrmr_iEJuXZ
 eIPR3Qdfzo9i3mc5bq2bvq.EIdURpp5XlVvsfmXQ5WxIkx3xcDqP0C1EgPQXw6ozsp5Pfr0jmJsC
 uPWH8RrxsrzS6cRGI5REhBk1fwcFcLX1ag6jCtnog7C5wscn2CiC.rXshSScjFwkJd34aKPE-
X-Sonic-MF: <luangruo@HIDDEN>
X-Sonic-ID: 0c4c0531-ae5b-454c-8650-606659118ad9
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sat, 14 Sep 2024 14:02:36 +0000
Received: by hermes--production-sg3-fc85cddf6-kzxtv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 715571f9c758dfd5e8fac903e2c68a64; 
 Sat, 14 Sep 2024 14:02:30 +0000 (UTC)
From: Po Lu <luangruo@HIDDEN>
In-Reply-To: <861q1mh1k2.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 14 Sep
 2024 15:17:33 +0300")
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
 <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN>
 <87r09ppovn.fsf@HIDDEN>
 <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN>
 <87h6aiphjk.fsf@HIDDEN> <861q1mh1k2.fsf@HIDDEN>
Date: Sat, 14 Sep 2024 22:02:25 +0800
Message-ID: <87zfoanxji.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Mailer: WebService/1.1.22645
 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo
Content-Length: 478
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> It already is, since on older systems we will be unable to find
> TaskDialogIndirect in comctl32.dll, and will fall back to the
> menu-dialog implementation.  Or what am I missing?

I'm asking for an implementation of w32_popup_dialog that delegates
parsing the menu to `list_of_panes', rather than to a custom parser such
as the function currently implements, so that the dialog parser may be
one and the same across all window systems.




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Sep 2024 14:16:02 +0000
Resent-Message-ID: <handler.20481.B20481.17263233133956 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Po Lu <luangruo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org, cpardo@HIDDEN
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.17263233133956
          (code B ref 20481); Sat, 14 Sep 2024 14:16:02 +0000
Received: (at 20481) by debbugs.gnu.org; 14 Sep 2024 14:15:13 +0000
Received: from localhost ([127.0.0.1]:47489 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spTYP-00011V-35
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 10:15:13 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1spTYN-00011F-BE
 for 20481 <at> debbugs.gnu.org; Sat, 14 Sep 2024 10:15:11 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1spTY7-0001iP-Ce; Sat, 14 Sep 2024 10:14:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=NyvQmvbKV+h760IN2988kAl2zh0wBD4VafM5ryFVpUs=; b=ROm4XFI2A4BV
 rlgwLYQD2jZTXgZfwAjj5owG6zr6E8+/G1s5VzyVspr3ADsRl137gyxLMwULdB2+3/LTjO6xPQpZN
 EnBrUhEldfD3knPdnxQluUtk7uBNnqFBv7KfBA1uBpyqbI6IW4FYrSsovMwhd9C5hGYH69J9x1PXe
 aoGWFTFgE2sxIgK4oDOsrSGw1s9kbLu8x7Zg8rwcP7MEnHrqcAFNKQh+bfotsn+FM56vhOshEl4Wm
 5NIMxii6g/R9NGCvm6XX8ZEbM8Wlwunlo3xII0i2PpBjpxE6imB2MhmB0IV1+9BOqwiD6VyyHJQ7U
 6EWXNsLgJKtj5OudYC1gfA==;
Date: Sat, 14 Sep 2024 17:14:53 +0300
Message-Id: <86o74qfhk2.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87zfoanxji.fsf@HIDDEN> (message from Po Lu on Sat, 14 Sep
 2024 22:02:25 +0800)
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN>
 <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN>
 <87r09ppovn.fsf@HIDDEN>
 <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN>
 <87h6aiphjk.fsf@HIDDEN> <861q1mh1k2.fsf@HIDDEN> <87zfoanxji.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Po Lu <luangruo@HIDDEN>
> Cc: cpardo@HIDDEN,  20481 <at> debbugs.gnu.org
> Date: Sat, 14 Sep 2024 22:02:25 +0800
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > It already is, since on older systems we will be unable to find
> > TaskDialogIndirect in comctl32.dll, and will fall back to the
> > menu-dialog implementation.  Or what am I missing?
> 
> I'm asking for an implementation of w32_popup_dialog that delegates
> parsing the menu to `list_of_panes', rather than to a custom parser such
> as the function currently implements, so that the dialog parser may be
> one and the same across all window systems.

Ah, okay.  But then this cannot be a job led by a w32-only developer,
it must be a cross-platform job led by someone who knows enough about
the other GUI systems to make the right abstractions.




Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#20481: 24.5; , Newlines in message-box output don't work on Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Sep 2024 15:21:02 +0000
Resent-Message-ID: <handler.20481.B20481.172632722319336 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 20481
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: 20481 <at> debbugs.gnu.org
Received: via spool by 20481-submit <at> debbugs.gnu.org id=B20481.172632722319336
          (code B ref 20481); Sat, 14 Sep 2024 15:21:02 +0000
Received: (at 20481) by debbugs.gnu.org; 14 Sep 2024 15:20:23 +0000
Received: from localhost ([127.0.0.1]:47643 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1spUZS-00051o-V0
	for submit <at> debbugs.gnu.org; Sat, 14 Sep 2024 11:20:23 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60840)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1spUZQ-0004w6-Lj
 for 20481 <at> debbugs.gnu.org; Sat, 14 Sep 2024 11:20:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1spUZA-0001yQ-22; Sat, 14 Sep 2024 11:20:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=+VpaXyRpwwbe7QsrrOHP3AP+PQqlSkUatMTEkRAoQ5A=; b=lmVp9l6nbCNk
 r0ELmY+4lQlOUqaWJzBugG6naQH//xnGQ4WaHEtlUNtVUjmiIbfjvcYaUtlQ3EUGFdRnHYHpT7I3k
 nusRmaNK6UTc0UaHBUia6P0p/vUnnkT5ilusktJ7iPbrEkw/qOb9mL3LpmM855rgh7MbEpBg/d5qO
 tYzsjtivbmkG+zMauWkqNdX/15McfDzJyI1tUPkjXCQxX/jZsr2qtWZye5csZExzS3ei2x3qTgTqN
 olJCFhPR1zYtyl476GWutq4n4JxbOrTwNfMqeB6e5VRzLZ/pYhVbkvUqgNaiiryOPgKFTqaZMXlXV
 ZvSI4JXt5VWRINJVMD9xhw==;
Date: Sat, 14 Sep 2024 18:19:58 +0300
Message-Id: <86cyl6fejl.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <28906c5b-0ff1-49a7-990b-50ad95235be2@HIDDEN> (message from
 Cecilio Pardo on Sat, 14 Sep 2024 17:04:49 +0200)
References: <CAC_vAoFYY7d7Ro3QPsgkQHzDzytPxEvg2Yqy08symS9-jPDbTw@HIDDEN>
 <e90b2cad-ce0c-49e4-9481-2be4fbfe5e2f@HIDDEN> <86v7zwwgod.fsf@HIDDEN>
 <ff145b01-fc86-45fa-88e8-ac9e93c245c2@HIDDEN> <87r09ppovn.fsf@HIDDEN>
 <9256c296-a719-4147-b994-f6b6427e8671@HIDDEN> <86bk0qh541.fsf@HIDDEN>
 <28906c5b-0ff1-49a7-990b-50ad95235be2@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sat, 14 Sep 2024 17:04:49 +0200
> From: Cecilio Pardo <cpardo@HIDDEN>
> 
> On 14/09/2024 13:00, Eli Zaretskii wrote:
> > Thanks, now installed on the master branch (which will become Emacs 31).
> >
> > FTR, I needed some additions because mingw.org's MinGW lacks some
> > stuff in its headers that the code used.  Please see that the result
> > still compiles with MinGW64.
> It does.

Great, thanks.





Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.