GNU bug report logs - #20486
24.4; ispell.el new LocalWords together with existing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20486 in the body.
You can then email your comments to 20486 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42_kevin <at> yahoo.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4; ispell.el new LocalWords together with existing
Date: Sat, 02 May 2015 16:46:43 +1000

[Message part 1 (text/plain, inline)]

When ispell.el "A" adds a new LocalWords line it always puts it at the
end of the file.  It'd be good to put it with existing such lines if
there are some.

This helps if LocalWords are deliberately not at the very end of file,
eg. before a special footer.  foo.el below shows this in an elisp file

    M-x find-file  foo.el
    M-x eval-buffer
    =>
    alas new LocalWords line after the ";;; foo.el ends here" footer

I hoped LocalWords with the existing ones would avoid upsetting the
footer bit.

I get some joy from the diff below.  The existing (open-line) and
(newline) are unchanged for the case no existing LocalWords so add at
end of file.  I'm fairly confident of my (insert "\n") when adding after
an existing LocalWords line, since since don't want `newline' to
auto-fill or otherwise mangle that line.  (But I'm ready to be persuaded
if there's some left indent or similar to apply which I don't know.)

2015-05-02  Kevin Ryde  <user42_kevin <at> yahoo.com.au>

	* textmodes/ispell.el (ispell-add-per-file-word-list): Add new
	LocalWords line just after existing such lines.  Good to keep words
	together or if deliberately placed somewhere special.

[foo.el (application/emacs-lisp, attachment)]

[ispell.el.diff (text/x-diff, attachment)]

[Message part 4 (text/plain, inline)]

In GNU Emacs 24.4.1 (i586-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2015-03-08 on binet, modified by Debian
Configured using:
 `configure --build i586-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp
 --build i586-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp
 --with-x=yes --with-x-toolkit=lucid --with-toolkit-scroll-bars
 --without-gconf --without-gsettings 'CFLAGS=-g -O2
 -fstack-protector-strong -Wformat -Werror=format-security -Wall'
 CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro'

Message #8 received at 20486 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kevin Ryde <user42_kevin <at> yahoo.com.au>
Cc: 20486 <at> debbugs.gnu.org
Subject: Re: bug#20486: 24.4; ispell.el new LocalWords together with existing
Date: Fri, 21 Aug 2020 14:18:40 +0200

Kevin Ryde <user42_kevin <at> yahoo.com.au> writes:

> 	* textmodes/ispell.el (ispell-add-per-file-word-list): Add new
> 	LocalWords line just after existing such lines.  Good to keep words
> 	together or if deliberately placed somewhere special.

Looks good to me.  I tested with the test file, and without any
localwords, and it seems to work for me, so I've applied your patch to
Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.